aboutsummaryrefslogtreecommitdiff
path: root/drivers/scsi/iscsi_tcp.c
AgeCommit message (Collapse)AuthorFilesLines
2006-01-14[SCSI] iscsi: seperate iscsi interface from setup functionsMike Christie1-48/+70
This is the second version of the patch to address Christoph's comments. Instead of doing the lib, I just kept everything in scsi_trnapsort_iscsi.c like the FC and SPI class. This was becuase the driver model and sysfs class is tied to the session and connection setup so separating did not buy very much at this time. The reason for this patch was becuase HW iscsi LLDs like qla4xxx cannot use the iscsi class becuase the scsi_host was tied to the interface and class code. This patch just seperates the session from scsi host so that LLDs that allocate the host per some resource like pci device can still use the class. This is also fixes a couple refcount bugs that can be triggered when users have a sysfs file open, close the session, then read or write to the file. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2006-01-14[SCSI] iscsi: add high mem supportMike Christie1-54/+30
From Mike Christie <[email protected]> and FUJITA Tomonori <[email protected]>: We cannot use page_address becuase some pages could be highmem. Instead, we can use sock_no_sendpage which does kmap for us. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2006-01-14[SCSI] iscsi: data digest page cache usage fixFUJITA Tomonori1-7/+9
Users can write to a page while we are sending it and making digest calculations. This ends up causing us to retry the command when a digest error is later reported. By using sock_no_sendpage when data digests are calculated we can avoid a lot of (not all but it helps) the retries becuase sock_no_sendpage is not zero copy. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2006-01-14[SCSI] iscsi: host locking fix[email protected]1-3/+4
We should be taking the host_lock instead of the conn lock when checking host_busy. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2006-01-14[SCSI] iscsi: data under/over flow fix[email protected]1-4/+2
We need to check the ISCSI_FLAG_DATA_* flags. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2006-01-14[SCSI] iscsi: whitespace cleanupFUJITA Tomonori1-11/+11
Remove extra whitespaces. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2006-01-12[SCSI] turn most scsi semaphores into mutexesArjan van de Ven1-18/+19
the scsi layer is using semaphores in a mutex way, this patch converts these into using mutexes instead Signed-off-by: Arjan van de Ven <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-12-15Merge by hand (conflicts in scsi_lib.c)James Bottomley1-1/+1
This merge is pretty extensive. The conflict is over the new req->retries parameter, so I had to change the prototype to scsi_setup_blk_pc_cmnd() and the usage in sd, sr and st. Signed-off-by: James Bottomley <[email protected]>
2005-12-15[PATCH] iscsi gfp_t annotationsAl Viro1-1/+1
Signed-off-by: Al Viro <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
2005-12-13[SCSI] iscsi: check header digests for mgmt tasksMike Christie1-12/+12
From Wang Zhenyu: check header digest for cmd and mgmt tasks Signed-off-by: Wang Zhenyu <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-12-13[SCSI] iscsi: update versionMike Christie1-1/+1
Signed-off-by: Mike Christie <[email protected]> Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-12-13[SCSI] iscsi: lower queue depthMike Christie1-5/+15
From Wang Zhenyu: High queue depth was a problem for some targets so make queue_depth adjustable From Mike Christie Make default queue_depth a little lower Signed-off-by: Mike Christie <[email protected]> Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-12-13[SCSI] iscsi: data digest calculation fixMike Christie1-25/+40
From Wang Zhenyu: data digest fix (the bug caused data corruption w/Wasabi StorageBuilder target) Signed-off-by: Mike Christie <[email protected]> Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-12-13[SCSI] iscsi: iscsi response fixMike Christie1-5/+2
from Wang Zhenyu: Must check SCSI CMD and R2T response according to the spec Signed-off-by: Mike Christie <[email protected]> Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-12-13[SCSI] iscsi: redirect fixMike Christie1-2/+3
From [email protected]: There is one more issue about Equallogic systems. They send re-direction info with FIN. I think that the kernel module needs to let iscsid to read data from the socket before killing it. Signed-off-by: Mike Christie <[email protected]> Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-12-13[SCSI] iscsi: opcode check fixMike Christie1-1/+1
Must check only valid opcode bits. Signed-off-by: Mike Christie <[email protected]> Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-09-20[SCSI] iscsi: add module versionMike Christie1-1/+1
From: [email protected] I have a bad memory. I cannot remember what versions are which, so add a module version to help. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-09-20[SCSI] iscsi: fix nop-in handlingMike Christie1-35/+47
From: [email protected] This add check to NOOP_IN's ttt, when it's ~0UL we should not send NOOP_OUT by spec (plus some cleanup). Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-09-20[SCSI] iscsi: fix ahs lenMike Christie1-1/+1
From: [email protected] Fix AHS Length Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-09-20[SCSI] iscsi: update some iscsi proto defsMike Christie1-1/+1
From: [email protected] Cleanup some iscsi_proto defs, add some missing values, and fix some defs. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-09-20[SCSI] iscsi: handle nonlinear skbsMike Christie1-2/+1
From: [email protected] Fix oops from nonlinear skb usage. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-09-20[SCSI] iscsi: preemt fix and cleanupMike Christie1-24/+28
From: [email protected] Delay the head digest update until xmit time, like data digest update. [To make things cleaner and avoid prempt bug] Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-09-20[SCSI] iscsi: nodelay fixMike Christie1-1/+1
From: [email protected] I'm not sure about this. I don't think that NODELAY option hurts performance. However, open-iscsi does not use MSG_MORE properly with sendpage, so NODELAY option hurts the open-iscsi performance. I've attached a patch to fix NODELAY and MSG_MORE problems and the write performance results with disktest. I use Opteron boxes connected directly, Chelsio NICs, 1500-byte MTU, 64 KB I/O size, and the iSCSI parameters on open-iscsi web site. With only NODELAY fix, the performance drops, as you said. On the other hand, NODELAY and MSG_MORE fixes improve the performance overall. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2005-08-06[SCSI] open-iscsi/linux-iscsi-5 Initiator: Initiator codeAlex Aizman1-0/+3627
drivers/scsi/iscsi_tcp.c, iscsi data path. Signed-off-by: Alex Aizman <[email protected]> Signed-off-by: Dmitry Yusupov <[email protected]> Signed-off-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>