aboutsummaryrefslogtreecommitdiff
path: root/drivers/platform
AgeCommit message (Collapse)AuthorFilesLines
2018-09-27platform/x86: intel_pmc: Sort headers alphabeticallyAndy Shevchenko1-12/+11
Sort headers alphabetically for better maintenance. No functional change. While here, remove unneeded linux/init.h inclusion. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_oaktrail: Convert to use SPDX identifierAndy Shevchenko1-16/+2
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_oaktrail: Sort headers alphabeticallyAndy Shevchenko1-7/+7
Sort headers alphabetically for better maintenance. No functional change. While here, remove unneeded linux/init.h inclusion. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_mid_thermal: Convert to use SPDX identifierAndy Shevchenko1-18/+3
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. While here, correct MODULE_LICENSE() string to be aligned with license text. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_mid_thermal: Sort headers alphabeticallyAndy Shevchenko1-5/+4
Sort headers alphabetically for better maintenance. No functional change. While here, remove unneeded linux/init.h inclusion. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_mid_powerbtn: Convert to use SPDX identifierAndy Shevchenko1-9/+1
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_mid_powerbtn: Remove unnecessary init.h inclusionAndy Shevchenko1-1/+0
No need to include linux/init.h when linux/module.h is. No functional change intended. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_menlow: Convert to use SPDX identifierAndy Shevchenko1-18/+3
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. While here, correct MODULE_LICENSE() string to be aligned with license text. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_menlow: Sort headers alphabeticallyAndy Shevchenko1-4/+3
Sort headers alphabetically for better maintenance. No functional change. While here, remove unneeded linux/init.h inclusion. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel-ips: Convert to use SPDX identifierAndy Shevchenko2-25/+3
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. While here, correct MODULE_LICENSE() string to be aligned with license text. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_int0002_vgpio: Convert to use SPDX identifierAndy Shevchenko1-5/+2
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. While here, correct MODULE_LICENSE() string to be aligned with license text. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel-hid: Convert to use SPDX identifierAndy Shevchenko1-11/+1
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_chtdc_ti_pwrbtn: Add SPDX identifierAndy Shevchenko1-0/+1
Driver misses the licence text or identifier, thus, append it here. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_cht_int33fe: Convert to use SPDX identifierAndy Shevchenko1-5/+2
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. While here, correct MODULE_LICENSE() string to be aligned with license text. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_bxtwc_tmu: Convert to use SPDX identifierAndy Shevchenko1-11/+2
Reduce size of duplicated comments by switching to use SPDX identifier. No functional change. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27firmware: dcdbas: Move dcdbas to drivers/platform/x86Stuart Hayes5-1/+896
Move dcdbas to the more appropriate directory drivers/platform/x86. Signed-off-by: Stuart Hayes <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27firmware: dell_rbu: Move dell_rbu to drivers/platform/x86Stuart Hayes3-0/+766
Move dell_rbu to the more appropriate directory drivers/platform/x86. Signed-off-by: Stuart Hayes <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: acerhdf: restructure to allow large BIOS table be __initconstPaul Gortmaker1-13/+28
There is a table of Vendor/Model/Version {control data} in this driver, but outside of the initial probe, the V/M/V is never used again, and neither are any of the entries for platforms other than the one which matches the running target. By simply storing the {control data} for the matched platform, we can mark the large table __initconst, which reduces the loaded driver size by 20 percent. Before: root@gw:~/git/linux-head# lsmod Module Size Used by acerhdf 20480 0 root@gw:~/git/linux-head# After: root@gw:~/git/linux-head# lsmod Module Size Used by acerhdf 16384 0 root@gw:~/git/linux-head# Cc: Peter Feuerer <[email protected]> Cc: Darren Hart <[email protected]> Cc: Andy Shevchenko <[email protected]> Signed-off-by: Paul Gortmaker <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Reviewed-by: Peter Feuerer <[email protected]>
2018-09-27platform/x86: acerhdf: mark appropriate content with __init prefixPaul Gortmaker1-3/+3
These three functions are only called from the probe code which is already marked __init and hence these can be __init as well. Cc: Peter Feuerer <[email protected]> Cc: Darren Hart <[email protected]> Cc: Andy Shevchenko <[email protected]> Signed-off-by: Paul Gortmaker <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Reviewed-by: Peter Feuerer <[email protected]>
2018-09-27platform/x86: acerhdf: Add BIOS entry for Gateway LT31 v1.3307Paul Gortmaker1-0/+1
To fix: acerhdf: unknown (unsupported) BIOS version Gateway /LT31 /v1.3307 , please report, aborting! As can be seen in the context, the BIOS registers haven't changed in the previous versions, so the assumption is they won't have changed in this last update for this somewhat older platform either. Cc: Peter Feuerer <[email protected]> Cc: Darren Hart <[email protected]> Cc: Andy Shevchenko <[email protected]> Signed-off-by: Paul Gortmaker <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Reviewed-by: Peter Feuerer <[email protected]>
2018-09-27platform/x86: acerhdf: Remove cut-and-paste trap from instructionsPaul Gortmaker2-2/+5
Just like we avoid specifying actual block devices like sda for fdisk and dd examples, we should not specify specific thermal zones here. On the platform I was testing on, zone0 was acpitz, and zone1 was for this acerhdf driver. Make the printk such that it won't work with a blind cut-and-paste, and force the user to determine which zone is correct for this driver. Cc: Peter Feuerer <[email protected]> Cc: Darren Hart <[email protected]> Cc: Andy Shevchenko <[email protected]> Signed-off-by: Paul Gortmaker <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Reviewed-by: Peter Feuerer <[email protected]>
2018-09-27platform/x86: acerhdf: Enable ability to list supported systemsPaul Gortmaker1-0/+14
This driver has two module parameters that allow an override of the checks for matching model and BIOS version. However, both parameters expect you to choose an entry from the existing list of supported systems, encoded within the driver itself. Without the source, such as in a binary distribution, the end user does not have access to this information, thus rendering the two module parameters essentially useless. Add a module parameter that allows the end user to dump the list of make/model/versions so that they can then pick one that most closely matches their own system. Cc: Peter Feuerer <[email protected]> Cc: Darren Hart <[email protected]> Cc: Andy Shevchenko <[email protected]> Signed-off-by: Paul Gortmaker <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Reviewed-by: Peter Feuerer <[email protected]>
2018-09-27platform/x86: acerhdf: clarify modinfo messages for BIOS overridePaul Gortmaker1-2/+2
Normally, a module parameter for a BIOS check override implies "pretend you support this version" (and the user will enter their local version). However, this driver uses the model/BIOS module parameters in a way that is "pretend my system is the supported model XYZ with BIOS version ABC." which is less common. Since the help strings don't make such a distinction, one gets this somewhat frustrating scenario, where the user sees the error, enters *their* BIOS version and then gets the same error: root@gw:~# modprobe acerhdf acerhdf: Acer Aspire One Fan driver, v.0.7.0 acerhdf: unknown (unsupported) BIOS version Gateway /LT31 /v1.3307 , please report, aborting! modprobe: ERROR: could not insert 'acerhdf': Invalid argument root@gw:~# modprobe acerhdf force_bios=v1.3307 acerhdf: Acer Aspire One Fan driver, v.0.7.0 acerhdf: forcing BIOS version: v1.3307 acerhdf: unknown (unsupported) BIOS version Gateway /LT31 /v1.3307 , please report, aborting! modprobe: ERROR: could not insert 'acerhdf': Invalid argument Clarify the module param help text to make it clear that the driver expects a choice from existing supported models/versions. Cc: Peter Feuerer <[email protected]> Cc: Darren Hart <[email protected]> Cc: Andy Shevchenko <[email protected]> Signed-off-by: Paul Gortmaker <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Reviewed-by: Peter Feuerer <[email protected]>
2018-09-27platform/x86: intel_mid_powerbtn: Get rid of custom ICPU() macroAndy Shevchenko1-5/+2
Replace custom grown macro with generic INTEL_CPU_FAM6() one. No functional change intended. Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_int0002_vgpio: Implement irq_set_wakeHans de Goede1-0/+16
We were relying on the interrupt being shared with the ACPI SCI and the ACPI core calling irq_set_wake. But that does not always happen on Bay Trail devices, so we should do it ourselves. This fixes wake from USB not working on various Bay Trail devices. Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: intel_int0002_vgpio: Enable the driver on Bay Trail platformsHans de Goede1-5/+1
The intel_int0002_vgpio driver was added to avoid an IRQ 9 storm on Cherry Trail platforms. When originally merged the CPU ID for Bay Trail SoCs was commented out of the list of valid CPU IDs because we did not have any reports of the IRQ storm on Bay Trail platforms. We now have a report of the IRQ 9 storm on the Bay Trail based Thinkpad Tablet 10 which is fixed by enabling this driver, so lets enable it on Bay Trail too. I've tested various other Bay Trail device with this driver enabled without adverse side-effects. BugLink: https://www.dpin.de/nf/finally-s0i3-is-there-thinkpad-tablet-10-sleeps-deeply-with-linux-kernel-4-15rc/#comments Reported-and-tested-by: Nicole Faerber <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-27platform/x86: ideapad-laptop: Use __func__ instead of read_ec_cmd in pr_errZhang Xianwei1-1/+1
Refer to the commit f1395edbcec8 ("platform/x86: ideapad-laptop: Use __func__ instead of write_ec_cmd in pr_err"), prefer using '"%s...", __func__' to using 'read_ec_cmd' in read_ec_data. Signed-off-by: Zhang Xianwei <[email protected]> Acked-by: Ike Panhc <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]>
2018-09-25platform: goldfish: pipe: Make symbol 'goldfish_pipe_dev' staticWei Yongjun1-1/+1
Fixes the following sparse warning: drivers/platform/goldfish/goldfish_pipe.c:214:26: warning: symbol 'goldfish_pipe_dev' was not declared. Should it be static? Signed-off-by: Wei Yongjun <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-25platform: goldfish: pipe: Remove redundant header includeRoman Kiryanov1-1/+0
No symbols were used from this header. Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-25platform: goldfish: pipe: Remove redundant struct declarationsRoman Kiryanov1-2/+0
goldfish_pipe_command is defines just after declaration and nothing refers to goldfish_pipe before it is defined. Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-25platform: goldfish: pipe: Remove a redundant blank lineRoman Kiryanov1-1/+0
The blank line is not required there. Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-25platform: goldfish: pipe: Prevent memory corruption from several threads ↵Roman Kiryanov1-10/+14
writing to the same variable Move the "pages" buffer into "struct goldfish_pipe". Since we are locking the mutex on the pipe in transfer_max_buffers, other threads willnot be able to write into it, but other pipe instances could be served because they have its own buffer. Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-25platform: goldfish: pipe: Remove license boilerplateRoman Kiryanov1-14/+0
The boilerplate license is not necessary when the SPDX line is present. Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-20platform: x86: intel_cht_int33fe: Remove the old connections for the muxesHeikki Krogerus1-14/+4
USB Type-C class driver now expects the muxes to be always assigned to the ports and not controllers, so the connections for the mux and fusb302 can be removed. Acked-by: Andy Shevchenko <[email protected]> Acked-by: Hans de Goede <[email protected]> Tested-by: Hans de Goede <[email protected]> Signed-off-by: Heikki Krogerus <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-20platform: x86: intel_cht_int33fe: Add connections for the USB Type-C portHeikki Krogerus1-1/+11
Assigning the mux to the USB Type-C port on top of fusb302. That will prepare this driver for the change in the USB Type-C class code, where the class driver will assume the muxes to be always assigned to the ports and not the controllers. Once the USB Type-C class driver has been updated, the connections between the mux and fusb302 can be dropped. Acked-by: Andy Shevchenko <[email protected]> Acked-by: Hans de Goede <[email protected]> Tested-by: Hans de Goede <[email protected]> Signed-off-by: Heikki Krogerus <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-20platform: x86: intel_cht_int33fe: Add connection for the DP alt modeHeikki Krogerus1-3/+6
Adding a connection for the DisplayPort alternate mode. PI3USB30532 is used for muxing the port to DisplayPort on CHT platforms. The connection allows the alternate mode device to get handle to the mux, and therefore make it possible to use the USB Type-C connector as DisplayPort. Acked-by: Andy Shevchenko <[email protected]> Acked-by: Hans de Goede <[email protected]> Tested-by: Hans de Goede <[email protected]> Signed-off-by: Heikki Krogerus <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-20platform: x86: intel_cht_int33fe: Register all connections at onceHeikki Krogerus1-10/+4
We can register all device connection descriptors with a single call to device_connections_add(). Acked-by: Andy Shevchenko <[email protected]> Acked-by: Hans de Goede <[email protected]> Tested-by: Hans de Goede <[email protected]> Signed-off-by: Heikki Krogerus <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-20platform: x86: intel_cht_int33fe: Add dependency on muxesHeikki Krogerus1-0/+2
The connections create clear dependency on the muxes. fusb302 fails to probe unless we have the mux drivers available. Acked-by: Andy Shevchenko <[email protected]> Acked-by: Hans de Goede <[email protected]> Tested-by: Hans de Goede <[email protected]> Signed-off-by: Heikki Krogerus <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-18PCI: hotplug: Embed hotplug_slotLukas Wunner2-35/+21
When the PCI hotplug core and its first user, cpqphp, were introduced in February 2002 with historic commit a8a2069f432c, cpqphp allocated a slot struct for its internal use plus a hotplug_slot struct to be registered with the hotplug core and linked the two with pointers: https://git.kernel.org/tglx/history/c/a8a2069f432c Nowadays, the predominant pattern in the tree is to embed ("subclass") such structures in one another and cast to the containing struct with container_of(). But it wasn't until July 2002 that container_of() was introduced with historic commit ec4f214232cf: https://git.kernel.org/tglx/history/c/ec4f214232cf pnv_php, introduced in 2016, did the right thing and embedded struct hotplug_slot in its internal struct pnv_php_slot, but all other drivers cargo-culted cpqphp's design and linked separate structs with pointers. Embedding structs is preferrable to linking them with pointers because it requires fewer allocations, thereby reducing overhead and simplifying error paths. Casting an embedded struct to the containing struct becomes a cheap subtraction rather than a dereference. And having fewer pointers reduces the risk of them pointing nowhere either accidentally or due to an attack. Convert all drivers to embed struct hotplug_slot in their internal slot struct. The "private" pointer in struct hotplug_slot thereby becomes unused, so drop it. Signed-off-by: Lukas Wunner <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Reviewed-by: Rafael J. Wysocki <[email protected]> Acked-by: Tyrel Datwyler <[email protected]> # drivers/pci/hotplug/rpa* Acked-by: Sebastian Ott <[email protected]> # drivers/pci/hotplug/s390* Acked-by: Andy Shevchenko <[email protected]> # drivers/platform/x86 Cc: Len Brown <[email protected]> Cc: Scott Murray <[email protected]> Cc: Benjamin Herrenschmidt <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Michael Ellerman <[email protected]> Cc: Oliver OHalloran <[email protected]> Cc: Gavin Shan <[email protected]> Cc: Gerald Schaefer <[email protected]> Cc: Corentin Chary <[email protected]> Cc: Darren Hart <[email protected]>
2018-09-18PCI: hotplug: Drop hotplug_slot_infoLukas Wunner2-20/+0
Ever since the PCI hotplug core was introduced in 2002, drivers had to allocate and register a struct hotplug_slot_info for every slot: https://git.kernel.org/tglx/history/c/a8a2069f432c Apparently the idea was that drivers furnish the hotplug core with an up-to-date card presence status, power status, latch status and attention indicator status as well as notify the hotplug core of changes thereof. However only 4 out of 12 hotplug drivers bother to notify the hotplug core with pci_hp_change_slot_info() and the hotplug core never made any use of the information: There is just a single macro in pci_hotplug_core.c, GET_STATUS(), which uses the hotplug_slot_info if the driver lacks the corresponding callback in hotplug_slot_ops. The macro is called when the user reads the attribute via sysfs. Now, if the callback isn't defined, the attribute isn't exposed in sysfs in the first place (see e.g. has_power_file()). There are only two situations when the hotplug_slot_info would actually be accessed: * If the driver defines ->enable_slot or ->disable_slot but not ->get_power_status. * If the driver defines ->set_attention_status but not ->get_attention_status. There is no driver doing the former and just a single driver doing the latter, namely pnv_php.c. Amend it with a ->get_attention_status callback. With that, the hotplug_slot_info becomes completely unused by the PCI hotplug core. But a few drivers use it internally as a cache: cpcihp uses it to cache the latch_status and adapter_status. cpqhp uses it to cache the adapter_status. pnv_php and rpaphp use it to cache the attention_status. shpchp uses it to cache all four values. Amend these drivers to cache the information in their private slot struct. shpchp's slot struct already contains members to cache the power_status and adapter_status, so additional members are only needed for the other two values. In the case of cpqphp, the cached value is only accessed in a single place, so instead of caching it, read the current value from the hardware. Caution: acpiphp, cpci, cpqhp, shpchp, asus-wmi and eeepc-laptop populate the hotplug_slot_info with initial values on probe. That code is herewith removed. There is a theoretical chance that the code has side effects without which the driver fails to function, e.g. if the ACPI method to read the adapter status needs to be executed at least once on probe. That seems unlikely to me, still maintainers should review the changes carefully for this possibility. Rafael adds: "I'm not aware of any case in which it will break anything, [...] but if that happens, it may be necessary to add the execution of the control methods in question directly to the initialization part." Signed-off-by: Lukas Wunner <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Reviewed-by: Rafael J. Wysocki <[email protected]> Acked-by: Tyrel Datwyler <[email protected]> # drivers/pci/hotplug/rpa* Acked-by: Sebastian Ott <[email protected]> # drivers/pci/hotplug/s390* Acked-by: Andy Shevchenko <[email protected]> # drivers/platform/x86 Cc: Len Brown <[email protected]> Cc: Scott Murray <[email protected]> Cc: Benjamin Herrenschmidt <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Michael Ellerman <[email protected]> Cc: Oliver OHalloran <[email protected]> Cc: Gavin Shan <[email protected]> Cc: Gerald Schaefer <[email protected]> Cc: Corentin Chary <[email protected]> Cc: Darren Hart <[email protected]>
2018-09-18PCI: hotplug: Constify hotplug_slot_opsLukas Wunner2-4/+2
Hotplug drivers cannot declare their hotplug_slot_ops const, making them attractive targets for attackers, because upon registration of a hotplug slot, __pci_hp_initialize() writes to the "owner" and "mod_name" members in that struct. Fix by moving these members to struct hotplug_slot and constify every driver's hotplug_slot_ops except for pciehp. pciehp constructs its hotplug_slot_ops at runtime based on the PCIe port's capabilities, hence cannot declare them const. It can be converted to __write_rarely once that's mainlined: http://www.openwall.com/lists/kernel-hardening/2016/11/16/3 Signed-off-by: Lukas Wunner <[email protected]> Signed-off-by: Bjorn Helgaas <[email protected]> Reviewed-by: Rafael J. Wysocki <[email protected]> Acked-by: Tyrel Datwyler <[email protected]> # drivers/pci/hotplug/rpa* Acked-by: Andy Shevchenko <[email protected]> # drivers/platform/x86 Cc: Len Brown <[email protected]> Cc: Scott Murray <[email protected]> Cc: Benjamin Herrenschmidt <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Michael Ellerman <[email protected]> Cc: Oliver OHalloran <[email protected]> Cc: Gavin Shan <[email protected]> Cc: Sebastian Ott <[email protected]> Cc: Gerald Schaefer <[email protected]> Cc: Corentin Chary <[email protected]> Cc: Darren Hart <[email protected]>
2018-09-14platform: goldfish: pipe: Replace "x==NULL" to "!x"Roman Kiryanov1-5/+5
checkpatch: Comparison to NULL could be written "!x" Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-14platform: goldfish: pipe: Move logical ops to the end of the prev lineRoman Kiryanov1-2/+2
checkpatch: Logical continuations should be on the previous line Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-14platform: goldfish: pipe: Fix alignment to match parenthesisRoman Kiryanov1-35/+48
checkpatch: Alignment should match open parenthesis. Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-14platform: goldfish: pipe: Fix lines to not end an opening bracketRoman Kiryanov1-4/+3
checkpatch: Lines should not end with a '(' or '[' Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-14platform: goldfish: pipe: Rename goldfish_x to goldfish_pipe_xRoman Kiryanov1-8/+9
Add "pipe" to the pipe related function names. Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-14platform: goldfish: pipe: Remove reduntant casting to (void)Roman Kiryanov1-2/+2
Casting to (void) is no-op. Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-14platform: goldfish: pipe: Rename 'wakeBit' to 'wake_bit'Roman Kiryanov1-4/+4
checkpatch: Avoid CamelCase Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-14platform: goldfish: pipe: Remove a blank line before '}'Roman Kiryanov1-1/+1
checkpatch: Blank lines aren't necessary before a close brace '}' Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-09-14platform: goldfish: pipe: Remove reduntant castingRoman Kiryanov1-1/+1
Casting to u32 is not required here. Signed-off-by: Roman Kiryanov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.