Age | Commit message (Collapse) | Author | Files | Lines |
|
The return is not needed, remove it.
Signed-off-by: Chen Zhou <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
|
|
Use __func__ to print the function name instead of hard coded string.
Signed-off-by: Chen Zhou <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
|
|
Add the missing endianness conversions to a debug statement printing
the USB device-descriptor idVendor and idProduct fields during probe.
Signed-off-by: Johan Hovold <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
|
|
We need to ensure there is enough headroom to push extra header,
but we also need to check if we are allowed to change headers.
skb_cow_head() is the proper helper to deal with this.
Fixes: 4a476bd6d1d9 ("usbnet: New driver for QinHeng CH9200 devices")
Signed-off-by: Eric Dumazet <[email protected]>
Cc: James Hughes <[email protected]>
Cc: Matthew Garrett <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
|
|
Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.
Signed-off-by: Muhammad Falak R Wani <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
|
|
Converts the ch9200 driver to use the module_usb_driver() macro which
makes the code smaller and a bit simpler.
Signed-off-by: Tobias Klauser <[email protected]>
Acked-by: Matthew Garrett <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
|
|
There's a bunch of cheap USB 10/100 devices based on QinHeng chipsets. The
vendor driver supports the CH9100 and CH9200 devices, but the majority of
the code is of the if (ch9100) {} else {} form, with the most significant
difference being that CH9200 provides a real MII interface but CH9100 fakes
one with a bunch of global variables and magic commands. I don't have a
CH9100, so it's probably better if someone who does provides an independent
driver for it. In any case, this is a lightly cleaned up version of the
vendor driver with all the CH9100 code dropped.
Signed-off-by: Matthew Garrett <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
|