aboutsummaryrefslogtreecommitdiff
path: root/drivers/gpu/drm/i915/intel_sideband.c
AgeCommit message (Collapse)AuthorFilesLines
2013-09-04drm/i915: add more VLV IOSF sideband ports accessorsJani Nikula1-0/+56
For GPIO NC, CCK, CCU, and GPS CORE. Signed-off-by: Jani Nikula <[email protected]> Signed-off-by: Shobhit Kumar <[email protected]> Reviewed-by: Ville Syrjälä <[email protected]> Signed-off-by: Daniel Vetter <[email protected]>
2013-05-23drm/i915: change VLV IOSF sideband accessors to not return error codeJani Nikula1-17/+13
We never check the return values, and there's not much we could do on errors anyway. Just simplify the signatures. No functional changes. Signed-off-by: Jani Nikula <[email protected]> Reviewed-by: Jesse Barnes <[email protected]> Signed-off-by: Daniel Vetter <[email protected]>
2013-05-23drm/i915: rename VLV IOSF sideband functions logicallyJani Nikula1-5/+5
Rename all VLV IOSF sideband register accessor functions to vlv_<port>_{read,write}. No functional changes. Signed-off-by: Jani Nikula <[email protected]> Reviewed-by: Jesse Barnes <[email protected]> Signed-off-by: Daniel Vetter <[email protected]>
2013-05-23drm/i915: refactor VLV IOSF sideband accessors to use one helperJani Nikula1-52/+50
Both the intel_dpio_{read,write} and valleyview_{punit,nc}_{read,write} use the IOSF sideband interface. They access the same registers and do mostly the same stuff, but no shared code. There are even duplicate register defines for the same registers. Both have locking, but the former use dpio_lock and the latter rps.hw_lock. It's racy. This patch refactors the sideband access to a single function that expects dpio_lock to be held. The dpio_lock is only used for sideband stuff, so it's a better match than rps.hw_lock for the purpose. The rps stuff still needs rps.hw_lock, since it's used to protect more than just the register access, so rps code will need to hold both locks. Based on the work by Shobhit Kumar <[email protected]> and Yogesh Mohan Marimuthu <[email protected]>. Signed-off-by: Jani Nikula <[email protected]> Acked-by: Jesse Barnes <[email protected]> Signed-off-by: Daniel Vetter <[email protected]>
2013-05-23drm/i915: group sideband register accessors to a new fileJani Nikula1-0/+183
Group both the HSW/LPT SBI interface and VLV IOSF sideband register accessor functions into a new file. No functional changes. v2: also move intel_sbi_{read,write} (Daniel) Signed-off-by: Jani Nikula <[email protected]> Reviewed-by: Jesse Barnes <[email protected]> Signed-off-by: Daniel Vetter <[email protected]>