Age | Commit message (Collapse) | Author | Files | Lines |
|
Remove unnecessary space after cast.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove unnecessary semicolon.This issue is detected by coccinelle script.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Add parentheses to complex macro.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Do not initialise statics to 0.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use !x instead of x == NULL.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Add parentheses to complex macro.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
No space is necessary after cast.This problem is found by checkpatch.pl script.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
No space is necessary after cast.This patch is found by checkpatch.pl script.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
No space is necessary after cast.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The following patch fixes the following checkpatch.pl warning:
CHECK: Alignment should match open parenthesis
Signed-off-by: Heena Sirwani <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Add space around operator.This patch is found by checkpatch.pl script.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Add space around operator '-'. Problem found using checkpatch.pl
CHECK: spaces preferred around that '-' (ctx:VxV)
Signed-off-by: Dilek Uzulmez <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Replace 'int32_t' with 'int'.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Add space around '+'.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove unnecessary blank lines.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fix alignment to match open parenthesis.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Add space around operator '+'. Problem found using checkpatch.pl
CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Dilek Uzulmez <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use the inline instead of direct code to improve readability
and shorten the code a little.
Done with perl:
$ perl -p -i -e 's/\((\w+) \>\> (\d+)\) \| \(\1 \<\< \(64 \- \2\)\)/ror64(\1, \2)/g' drivers/staging/skein/threefish_block.c
Signed-off-by: Joe Perches <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes the checkpatch.pl message:
CHECK: spaces preferred around that '|' (ctx:VxV)
+ writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),
^ ^
As per the guidelines for coding style in the kernel, I have updated the
digi international driver to include spaces around the OR'd flags; not only
is this formatting issue caught by `checkpatch.pl`, in the next `if` block
the correct formatting is used, leading to both incorrect and inconsistent
code formatting.
This patch puts the line in question at 82 characters---while this is over
the recommended limit, there are no clear locations to break the line and it
barely breaks the cutoff.
Signed-off-by: Sam Horlbeck Olsen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use !x instead of x == NULL.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use !x instead of x == NULL.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use x instead of x != NULL.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use x instead of x != NULL.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove unnecessary return statement from last line of void function call
Signed-off-by: Nicholas Sim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This fixes the issue reported by checkpatch.pl:
"Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF
has changed addresses in the past, and may do so again. Linux
already includes a copy of the GPL."
in all files for the rtl8188eu driver.
Signed-off-by: Kyle Kuffermann <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Patch to rtl8188e_rxdesc.c to remove an unnecessary cast on a void
pointer.
Signed-off-by: Ben Marsh <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes multiple "comparison to NULL"
checkpatch.pl issues:
CHECK: Comparison to NULL could be written "!pcmd"
+ if (pcmd == NULL)
Signed-off-by: Juliana Rodrigues <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes several warnings caused by
malformed comments on hal_init.c and found by
checkpatch.pl.
Signed-off-by: Juliana Rodrigues <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch corrects checks generated by checkpatch.pl by
replacing comparison to null statements with equivalent
statements in the form "x" or "!x"
Signed-off-by: Roger H. Newell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch corrects warnings generated by checkpatch.pl by
removing braces from single block statements.
Signed-ff-by: Roger H. Newell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Semaphore sem_test_key_block is used to signal completion of its
host interface message. Since the thread locking this semaphore will
have to wait, completions are the preferred mechanism and will offer
a performance improvement.
Signed-off-by: Alison Schofield <[email protected]>
Reviewed-by: Arnd Bergmann <[email protected]>
Tested-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Semaphore sem_test_disconn_block is used to signal completion of its
host interface message. Since the thread locking this semaphore will
have to wait, completions are the preferred mechanism and will offer
a performance improvement.
Signed-off-by: Alison Schofield <[email protected]>
Reviewed-by: Arnd Bergmann <[email protected]>
Tested-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Semaphore sem_get_rssi is used to signal completion of its host
interface message. Since the thread locking this semaphore will have
to wait, completions are the preferred mechanism and will offer a
performance improvement.
Signed-off-by: Alison Schofield <[email protected]>
Reviewed-by: Arnd Bergmann <[email protected]>
Tested-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Semaphore sem_inactive_time is used to signal completion of its host
interface message. Since the thread locking this semaphore will have
to wait, completions are the preferred mechanism and will offer a
performance improvement.
Signed-off-by: Alison Schofield <[email protected]>
Reviewed-by: Arnd Bergmann <[email protected]>
Tested-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Break lines so that they do not exceed 80
characters. Problem found using checkpatch.
Signed-off-by: Anchal Jain <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove else after a break. Because else is
generally not useful after a break or return.
Signed-off-by: Anchal Jain <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
hif_sema_wait_response
This patch replaces struct semaphore hif_sema_wait_response with struct
completion hif_wait_response. In case of struct hif_sema_wait_response,
it better to use completion than semaphore.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes an unnecessary if-condition.
Regardless of an if-condition is performed unconditionally '_end_' statement.
Signed-off-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes goto definitions from wilc_wlan_firmware_download function.
Goto '_fail_1' feature is error return.
It returns error type directly without result variable replacement as well.
Signed-off-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patches changes an ambiguous debug messages.
The device types are both SDIO or SPI.
Signed-off-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patches removes duplicate wilc variable setting.
This value has already been set to wl variable previously.
Replace wilc with wl as well.
Signed-off-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patches removes duplicate vif variable setting.
This value has already been set previously.
Signed-off-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patches removes unnecessary debug print logs.
Signed-off-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes function 'init_tcp_tracking()'.
The function is an unnecessary return.
Signed-off-by: Leo Kim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove an unnecessary cast on a void pointer in nvec_power.c
Signed-off-by: Ben Marsh <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Replace the use of comparison to NULL, use !<expression> instead. Checkpatch detected these issues.
Signed-off-by: Laura Garcia Liebana <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
No space is required after a cast. Checkpatch detected this issue.
Signed-off-by: Laura Garcia Liebana <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Alignment should match open parenthesis. Checkpatch detected these
issues.
Signed-off-by: Laura Garcia Liebana <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Prefer the use of type int instead of int32_t. Checkpatch detected these
issues.
Signed-off-by: Laura Garcia Liebana <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Currently, DMA mapping failure is not detected, causing the hardware
to attempt a DMA from an invalid address.
This patch adds the corresponding error check for pci_map_single i.e.
pci_dma_mapping_error.
Problem found using the following Coccinelle semantic patch:
// <smpl>
@@
expression e1;
identifier x;
@@
x=
(
*dma_map_single(...)
|
*dma_map_page(...)
)
... when != dma_mapping_error(e1,x)
@@
expression e1;
identifier x;
@@
x =
(
*pci_map_single(...)
|
*pci_map_page(...)
)
... when != pci_dma_mapping_error(e1,x)
// </smpl>
Signed-off-by: Amitoj Kaur Chawla <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|