| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
It was just a wrapper to initialize a variable. Initialize it
directly instead.
Signed-off-by: Raphaël Beamonte <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Raphaël Beamonte <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
It is added and fixed error check when kmalloc is failed.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The kmalloc is used to handle host interface message within kernel thread.
The manipulation of host interface message is not called on IRQ context
and I could not find any spinlock inside function.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes unused codes of gps8ConfigPacket declared by global variable.
It is allocated and freed memory within CoreConfiguratorInit and CoreConfiguratorDeInit.
There is no used anywhere except within two functions.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes unnecessary void pointer cast of WILC_MALLOC.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes WILC_NEW and WILC_NEW_EX defines that are not used anywhere.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
WILC_NEW is replaced by kmallo with GFP_ATOMIC.
This kmalloc is inside a spin_lock_irqsave region.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch enables setting the module's debug options WARN and INFO in the
debugfs file 'wilc_debug_level'. This functionality allows the user to
enable logging of warnings and other information. Before this change,
writes to this debugfs file set only one option - DEBUG. Another option
that is enabled by default is ERR.
As a side effect, this patch removes the 'sparse' warning -
'warning: incorrect type in argument 2 (different address spaces)'.
Signed-off-by: Chandra S Gorentla <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
No one uses it, so remove it and all of the NULL parameters being used
to pass it into the msg code.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This .h file isn't needed at all, so delete it, and the one line that
added it to the build.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The macros are not used in the driver at all, except in one commented
out line, so just remove the .h file so that no one thinks it is a good
idea to add any code to use them in the future.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
It is no longer needed at all, so remove this header file.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
It was a wrapper around mod_timer() so replace it with the real timer
call and remove wilc_timer.c as it's now empty.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
It was just a wrapper around setup_timer() and could never fail, so just
call the real function, and fix up the function arguments of the
callbacks to be proper timer callback functions.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
It was just a wrapper around del_timer_sync() so call that instead.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
It was just a wrapper around del_timer() so call that instead.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
It was not used for anything, so remove it, and the variables in
wilc_timer.c that were being passed of its type.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use the proper structure (struct timer_list) instead, which makes things
much more readable.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
It was just a wrapper around usleep_range() so call that directly
instead and remove the now-empty file.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
It's not being called, so delete these lines.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Replace with struct vnt_tx_desc with all members the same.
volatile is removed from pointers as this generates warning
message.
Only the first four members of vnt_tx_desc need to be volatile.
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Create struct vnt_td_info with members
mic_hdr
skb
buf
buf_dma
dwReqCount -> req_count
byFlags -> flags
In struct tagSTxDesc volatile is removed because it will generate a warning
(in any case this member is not) and renaming td_info.
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
dwHeaderLength is assigned a value but that is never used.
Remove variable.
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
dwReqCount is no bigger than u16
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Create struct vnt_tdes1 that replaces members
wReqCount -> req_count
byTCR -> tcr
byReserved -> reserved
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
create struct vnt_tdes0 replacing used members
byTSR0 -> tsr0
byTSR1 -> tsr1
f1Owner -> owner
Narrowing endian differences to inside structure.
Signed-off-by: Malcolm Priestley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The .h file isn't needed at all, so just remove it.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
It's no longer needed, so remove the empty wrapper function.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Just use kfree, as that's all it resolves itself to.
Cc: Johnny Kim <[email protected]>
Cc: Rachel Kim <[email protected]>
Cc: Dean Lee <[email protected]>
Cc: Chris Park <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fix "foo* bar" should be "foo *bar" errors as detected by
checkpatch.pl
Signed-off-by: Yash Shah <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
dm_odm was being checked for NULL after dereferencing it. Lets check for
NULL first before derefenrencing it.
Signed-off-by: Sudip Mukherjee <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch replaces the void pointer type in the host interface
functions which process the message from host thread by the real data
type, tstrWILC_WFIDrv because the void pointer type as the arguments
is not clear and concise. In addition, typecasting to the void pointer
type is removed becasue it is not necessary.
Signed-off-by: Johnny Kim <[email protected]>
Signed-off-by: Tony Cho <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch changes the void pointer member of the tstrHostIFmsg to the
real data type because the void pointer type is ambiguous and not
readable.
Signed-off-by: Johnny Kim <[email protected]>
Signed-off-by: Tony Cho <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The structure, WILC_WFIDrvHandle is used to save the pointer address
for the driver handler which is used throughout the driver but it's
not easy to understand what it means. In addition, it doesn't support
the 64 bit machine and also causes the warnings for the 64 bit build.
This patch replaces the WILC_WFIDrvHandle by the tstrWILC_WFIDrv
because the tstrWILC_WFIDrv is real structure to represent the driver
handler and reduces the 64 bit compile warnings. Also, typecasting to
WILC_WFIDrvHandle is not needed by using tstrWILC_WFIDrv as is.
Signed-off-by: Johnny Kim <[email protected]>
Signed-off-by: Tony Cho <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove WILC_FREE that is replaced by kfree.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use kfree instead of WILC_FREE.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch remove unused memory functions because some macros with this
memory function are deleted.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove unused define macro that is never used.
Signed-off-by: Chaehyun Lim <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fix a macro with complex value coding style error.
Signed-off-by: Raphaël Beamonte <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes issue generated by commit ca93dcba3a92
("staging: rtl8192e: Remove assert() macro")
One negation was missed in conversion, therefore
asserted message was always printed.
For 1MB file downloaded via http, ~500 messages
were generated.
Signed-off-by: Mateusz Kulikowski <[email protected]>
Cc: stable <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This is a patch to the vme_pio2_core.c that adds spaces around '-'.
Signed-off-by: Junsu Shin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This is a patch to vme_pio2_core.c that fixes up the NULL comparison style.
Signed-off-by: Junsu Shin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This is a patch to the vme_pio2_core.c that removes blank line after open brace '{'.
Signed-off-by: Junsu Shin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This is a patch to vm2_pio2_core.c that removes multiple blanks lines.
Signed-off-by: Junsu Shin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
visorbus_dev_groups is not referenced outside visorbus_main.c, so it can
be declared static.
Found using sparse.
Signed-off-by: Michał Kępień <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
lines to visornic
This patch adds an module alias and a MODULE_DEVICE_TABLE to autoload the
visornic driver when an appropriate device is created by the visorbus.
Note, the correct way of fixing this is adding functionality to
scripts/mod/file2alias.c for the visorbus bus type.
Signed-off-by: Prarit Bhargava <[email protected]>
Signed-off-by: Benjamin Romer <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignments
Signed-off-by: Joe Perches <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Using 'extern' is not necessary for function prototypes.
Signed-off-by: Joe Perches <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|