aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-09-22staging: xgifb: Remove unused variable and if statementRehas Sachdeva1-5/+1
Setting the variable 'refresh_rate = 60;' has no use to the rest of the function. Hence the if statement setting it and the variable itself can be removed. This was detected using the following Coccinelle semantic patch: @@ type T; identifier i; constant C; @@ ( extern T i; | - T i; <+... when != i - i = C; ...+> ) Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: speakup: Remove unnecessary parenthesesKatie Dunne1-2/+2
Issue found by checkpatch. Signed-off-by: Katie Dunne <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: add maintainer for uart and log protocol driversDavid Lin1-0/+6
Add myself as greybus uart and log protocol driver maintainer. Signed-off-by: David Lin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: uart.c: fix alignment to match open parenthesisChaehyun Lim1-14/+14
Fixes checkpatch.pl warning: CHECK: Alignment should match open parenthesis Signed-off-by: Chaehyun Lim <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: uart.c: change 'unsigned' to 'unsigned int'Chaehyun Lim1-1/+1
Fixes checkpatch.pl warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Chaehyun Lim <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: audio_codec.c: code indent should use tabs where possibleRichard Groux1-1/+1
Minor error spotted by checkpatch.pl in greybus code indent should use tabs where possible Signed-off-by: Richard Groux <[email protected]> Reviewed-by: Alex Elder <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: audio_codec.c: space required before the open braceRichard Groux1-1/+1
Minor error spotted by checkpatch.pl in greybus space required before the open brace '{' Signed-off-by: Richard Groux <[email protected]> Reviewed-by: Alex Elder <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: arche-platform: compress return logic into one lineEva Rachel Retuya1-2/+1
Modify return statement to use the value being returned directly instead of assigning it first to 'ret' and returning this variable. Coccinelle semantic patch used: @@ expression e; local idexpression ret; @@ -ret = +return e; -return ret; Signed-off-by: Eva Rachel Retuya <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: audio: delete unnecessary parenthesesEva Rachel Retuya1-1/+1
Eliminate unneeded parentheses around the right hand side of an assignment. Coccinelle semantic patch used: @@ expression e1, e2; identifier v; @@ ( v = (e1 == e2) | v = (e1 != e2) | v = (e1 <= e2) | v = (e1 >= e2) | v = - ( e1 - ) ) Signed-off-by: Eva Rachel Retuya <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: camera: simplify NULL testEva Rachel Retuya1-1/+1
Replace direct comparisons to NULL i.e. 'x == NULL' with '!x' for consistency. Coccinelle semantic patch used: @@ identifier func; expression x; statement Z; @@ x = func(...); if ( ( + ! x - == NULL | + ! - NULL == x ) ) Z Signed-off-by: Eva Rachel Retuya <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: most: replace MOST_CH_ISOC_AVP with MOST_CH_ISOCAndrey Shvetsov5-11/+11
This patch replaces the enum value MOST_CH_ISOC_AVP with the more appropriate MOST_CH_ISOC. Signed-off-by: Andrey Shvetsov <[email protected]> Signed-off-by: Christian Gromm <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: most: clean up configuration stringsChristian Gromm2-8/+15
This patch adds the strings 'rx', 'tx' and 'isoc' to the list of accepted identifiers when setting up a channel configuration. To keep consistency it removes the prefix "dir_" from strings returned by the attributes set_direction and available_directions and it removes the suffix "_avp" from the string "isoc_avp" returned by the attributes set_datatype and available_datatypes. Signed-off-by: Christian Gromm <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: most: core: remove trailing zero from text propertyAndrey Shvetsov1-2/+2
This patch removes trailing zeros from the strings returned by the attributes available_datatypes and available_directions. Signed-off-by: Andrey Shvetsov <[email protected]> Signed-off-by: Christian Gromm <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: most: make function most_submit_mbo return voidChristian Gromm4-17/+7
Function most_submit_mbo() causes an exception only if either the pointer mbo or mbo->context equals NULL. From the underlying architecture's point of view both cases must _not_ come true and would happen only, if something has tampered with the pointers. This would render runtime code unable to recover anyway. So, instead trying to hide that things are already critically out of control we're better off with a WARN_ON() assertion. This patch replaces the return type of the function most_submit_mbo() with 'void' and adds a WARN_ONCE() assertion. Additionally, code calling the function is adapted accordingly. Signed-off-by: Christian Gromm <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: wlan-ng: fixed block comment formattingJuliana Rodrigues1-1/+2
This patch fixes a checkpatch warning in a block comment by adapting it to the community preferred coding style. Signed-off-by: Juliana Rodrigues <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: wlan-ng: fixed alignment not matchingJuliana Rodrigues1-1/+1
This patch fixes a checkpatch warning by moving arguments to the right and aligning them to their open parenthesis. Signed-off-by: Juliana Rodrigues <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: wlan-ng: fixed parenthesis alignmentJuliana Rodrigues1-1/+1
This patch fixes a checkpatch warning by moving arguments to the right and aligning them to the open parenthesis above. Signed-off-by: Juliana Rodrigues <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: wlan-ng: fixed block comment trailingJuliana Rodrigues1-1/+2
Moved trailing */ to a new line and added * to subsequent lines on a block comment. Signed-off-by: Juliana Rodrigues <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: greybus: add maintainer for greybus platform driversVaibhav Hiremath1-0/+7
Add Vaibhav Hiremath as a Maintainer of Greybus platform drivers. Signed-off-by: Vaibhav Hiremath <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: greybus: fix up camera Kconfig dependanciesGreg Kroah-Hartman1-1/+1
CONFIG_MEDIA is not a thing, but CONFIG_MEDIA_SUPPORT is, so use that. Reported-by: Valentin Rothberg <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: include: remove unused ULTRA_CHANNELCLI_STRINGDavid Kershner1-22/+0
The inline ULTRA_CHANNELCLI_STRING is not being used so remove it. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: include: remove unused spar_channel_client_release_osDavid Kershner1-22/+0
The function spar_channel_client_release_os is not being used so remove it. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: include: remove unused spar_channel_client_acquire_osDavid Kershner1-104/+0
The function spar_channel_client_acquire_os is not being used so remove it. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: include: remove unused function pathname_last_n_nodesDavid Kershner1-32/+0
The function pathname_last_n_nodes is not used, get rid of it. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: visorhba: remove prototypes for visorhba_main.cDavid Kershner1-29/+21
Remove not needed prototypes in visorhba. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: visornic: remove poll_for_irq prototypeDavid Kershner1-2/+0
Remove poll_for_irq prototype not needed. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: visornic: remove visornic_poll prototypeDavid Kershner1-1/+0
Remove visornic_poll prototype, because it is not needed. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: visornic: remove visornic debugfs protoyptesDavid Kershner1-14/+9
Remove visornic debugfs prototypes, they are not needed. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: visornic: remove prototypesDavid Kershner1-24/+17
Remove unneeded prototypes from visornic_main.c Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: greybus: add maintainer for greybus audio protocol driverVaibhav Agarwal1-0/+7
Add Vaibhav as maintainer of some Greybus Audio protocol drivers. Signed-off-by: Vaibhav Agarwal <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: lustre: ptlrpc: re-export lustre_swab_lov_mds_mdJames Simmons1-0/+1
Being over zealous in removing unused EXPORT_SYMBOLs the function lustre_swab_lov_mds_md exports were removed. They need to be exported so this patch restores those EXPORT_SYMBOLS. Same mistake was done when porting to the upstream client. Signed-off-by: James Simmons <[email protected]> Reviewed-on: http://review.whamcloud.com/14545 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6486 Reviewed-by: Dmitry Eremin <[email protected]> Reviewed-by: John L. Hammond <[email protected]> Reviewed-by: Oleg Drokin <[email protected]> Signed-off-by: James Simmons <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: greybus: add Viresh as maintainer of few greybus protocol driversViresh Kumar1-0/+17
Add Viresh Kumar as Maintainer of some of the Greybus protocol drivers. Signed-off-by: Viresh Kumar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rts5208: Remove space after castRehas Sachdeva2-3/+3
Removes unnecessary space after a cast. Issue found by checkpatch. Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rts5208: Use BIT(x) macroRehas Sachdeva1-15/+15
Replaces left shift operation (1 << x) by BIT(x). Issue found by checkpatch. Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rts5208: Put constant on right side of comparisonRehas Sachdeva1-3/+3
Replaces position of constant from left to right side of a comparison. Additionally, modifies logical continuations to be on the previous line and fixes alignment to match open parenthesis. Issues found by checkpatch. Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rts5208: Fix indentationRehas Sachdeva1-4/+4
Fixes indentation by removing unnecessary TAB. Issue found by checkpatch. Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rts5208: Add spaces around operatorsRehas Sachdeva1-4/+4
Adds spaces on either side of arithmetic and relational operators like '-', '<' and '*'. Issue found by checkpatch. Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rts5208: Remove unnecessary parenthesesRehas Sachdeva1-10/+10
Removes unnecessary parentheses from an expression of the form &(x). Issue found by checkpatch. Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: comedi: Use vma_pages function on vma object instead of explicit ↵sayli karnik1-1/+1
computation This patch uses vma_pages function on vma object instead of explicit computation. Signed-off-by: sayli karnik <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: vt6655: baseband: Remove unnecessary space after a castSandhya Bankar1-1/+1
No space is necessary after a cast. This issue was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: vt6655: card: Remove unnecessary space after a castSandhya Bankar1-2/+2
No space is necessary after a cast. This issue was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: sm750fb: Add spaces around '|'Rehas Sachdeva1-22/+22
Adds spaces on either side of a '|'. Issue found by checkpatch. Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: wlan-ng: Remove unnecessary variable usageRehas Sachdeva1-3/+1
Instead of storing the return value into a variable and then returning it, we can club the two into a single return statement. This change was made using the following semantic patch by Coccinelle: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: most: hdm-usb: convert pr_warn() to dev_warn()Eva Rachel Retuya1-2/+2
Replace pr_warn() call with its respective dev_warn() counterpart. Semantic patch used to detect and apply the transformation: @a@ identifier dev; expression E; @@ struct device *dev = E; <+... when != dev == NULL - pr_warn( + dev_warn(dev, ...); ...+> Signed-off-by: Eva Rachel Retuya <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: media: cxd2099: replace printk with dev_infoEva Rachel Retuya1-1/+1
Use dev_info() instead of printk(). Majority of the conversion was done previously on this commit: 011b2aa [media] staging/media: Use dev_ printks in cxd2099/cxd2099.[ch] Signed-off-by: Eva Rachel Retuya <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: media: bcm2048: Merge assignment with returnRehas Sachdeva1-10/+4
Instead of storing the return value into a variable and then returning it, we can club the two into a single return statement. This change was made using the following semantic patch by Coccinelle: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: media: davinci_vpfe: Merge assignment with returnRehas Sachdeva1-5/+3
Instead of storing the return value into a variable and then returning it, we can club the two into a single return statement. This change was made using the following semantic patch by Coccinelle: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: rts5208: Add space around operator.Sandhya Bankar1-4/+4
Add space around operator. This patch was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: rts5208: rtsx: Use x instead of x != NULL.Sandhya Bankar1-1/+1
Use x instead of x != NULL. This patch was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: rts5208: ms: Use x instead of x != NULL.Sandhya Bankar1-1/+1
Use x instead of x != NULL. This patch was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>