aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-08-02iwlagn: sysfs couldn't find the priv pointerEmmanuel Grumbach1-9/+9
This bug has been introduced by: d593411084a56124aa9d80aafa15db8463b2d8f7 Author: Emmanuel Grumbach <[email protected]> Date: Mon Jul 11 10:48:51 2011 +0300 iwlagn: simplify the bus architecture Revert part of the buggy patch: dev_get_drvdata will now return iwl_priv as it did before the patch. Signed-off-by: Emmanuel Grumbach <[email protected]> Tested-by: Daniel Halperin <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-08-01rt2x00: rt2800: fix zeroing skb structureStanislaw Gruszka1-2/+1
We should clear skb->data not skb itself. Bug was introduced by: commit 0b8004aa12d13ec750d102ba4082a95f0107c649 "rt2x00: Properly reserve room for descriptors in skbs". Cc: [email protected] # 2.6.36+ Signed-off-by: Stanislaw Gruszka <[email protected]> Acked-by: Gertjan van Wingerde <[email protected]> Acked-by: Ivo van Doorn <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-08-01rtlwifi: Fix kernel oops on ARM SOCLarry Finger1-9/+11
This driver uses information from the self member of the pci_bus struct to get information regarding the bridge to which the PCIe device is attached. Unfortunately, this member is not established on all architectures, which leads to a kernel oops. Skipping the entire block that uses the self member to determine the bridge vendor will only affect RTL8192DE devices as that driver sets the ASPM support flag differently when the bridge vendor is Intel. If the self member is available, there is no functional change. This patch fixes Bugzilla No. 40212. Reported-by: Hubert Liao <[email protected]> Signed-off-by: Larry Finger <[email protected]> Cc: Stable <[email protected]> [back to 2.6.38] Signed-off-by: John W. Linville <[email protected]>
2011-08-01ath9k: skip ->config_pci_powersave() if PCIe port has ASPM disabledStanislaw Gruszka5-13/+40
We receive many bug reports about system hang during suspend/resume when ath9k driver is in use. Adrian Chadd remarked that this problem happens on systems that have ASPM disabled. To do not hit the bug, skip doing ->config_pci_powersave magic if PCIe downstream port device, which ath9k device is connected to, has ASPM disabled. Bug was introduced by: commit 53bc7aa08b48e5cd745f986731cc7dc24eef2a9f Author: Vivek Natarajan <[email protected]> Date: Mon Apr 5 14:48:04 2010 +0530 ath9k: Add support for newer AR9285 chipsets. Patch should address: https://bugzilla.kernel.org/show_bug.cgi?id=37462 https://bugzilla.kernel.org/show_bug.cgi?id=37082 https://bugzilla.redhat.com/show_bug.cgi?id=697157 however I did not receive confirmation about that, except from Camilo Mesias, whose system stops hang regularly with this patch (but still hangs from time to time, but this is probably some other bug). Tested-by: Camilo Mesias <[email protected]> Cc: [email protected] # 2.6.35+ Signed-off-by: Stanislaw Gruszka <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-08-01cfg80211: off by one in nl80211_trigger_scan()Dan Carpenter1-1/+1
The test is off by one so we'd read past the end of the wiphy->bands[] array on the next line. Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-08-01iwlegacy: set tx power after rxon_assocStanislaw Gruszka2-3/+11
If settings of tx power was deferred during scan or changing channel we have to setup them during commit rxon. Fix problem on 3945 (4965 already has this fix). Optimize code to apply tx settings only when tx power was actually changed. Cc: [email protected] # 2.6.39+ Signed-off-by: Stanislaw Gruszka <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-08-01ath9k: initialize tx chainmask before testing channel tx power valuesFelix Fietkau1-0/+2
With an uninitialized chainmask, the per-channel power will only contain the power limits for a single chain instead of the combined tx power. Signed-off-by: Felix Fietkau <[email protected]> Cc: [email protected] Signed-off-by: John W. Linville <[email protected]>
2011-07-26wireless: fix a typo in ignore_reg_updateMihai Moldovan1-1/+1
Just a typo fix changing regulaotry to regulatory. Signed-off-by: Mihai Moldovan <[email protected]> CC: John W. Linville <[email protected]> CC: Mohammed Shafi <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-26b43: fix invalid memory access in b43_ssb_remove()Pavel Roskin1-2/+3
wldev is freed in b43_one_core_detach() and should not be accessed after that call. Keep wldev->dev in a local variable. Signed-off-by: Pavel Roskin <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-26b43: bcma: drop BROKENRafał Miłecki1-1/+1
We've fixed the last issue with BCMA support which caused memory corruption on loading and unloading b43. Support for BCMA in b43 was tested with 14e4:4353, 14e4:4357, 14e4:4727 and 14e4:4331. First two cards (BCM43224 and BCM43225) are supported. Signed-off-by: Rafał Miłecki <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-26b43: bus: fix memory corruption when setting driver's dataRafał Miłecki1-0/+2
Fixes bug described in: https://bugzilla.kernel.org/show_bug.cgi?id=39172 Signed-off-by: Rafał Miłecki <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-26cfg80211: really ignore the regulatory requestSven Neumann1-2/+3
At the beginning of wiphy_update_regulatory() a check is performed whether the request is to be ignored. Then the request is sent to the driver nevertheless. This happens even if last_request points to NULL, leading to a crash in the driver: [<bf01d864>] (lbs_set_11d_domain_info+0x28/0x1e4 [libertas]) from [<c03b714c>] (wiphy_update_regulatory+0x4d0/0x4f4) [<c03b714c>] (wiphy_update_regulatory+0x4d0/0x4f4) from [<c03b4008>] (wiphy_register+0x354/0x420) [<c03b4008>] (wiphy_register+0x354/0x420) from [<bf01b17c>] (lbs_cfg_register+0x80/0x164 [libertas]) [<bf01b17c>] (lbs_cfg_register+0x80/0x164 [libertas]) from [<bf020e64>] (lbs_start_card+0x20/0x88 [libertas]) [<bf020e64>] (lbs_start_card+0x20/0x88 [libertas]) from [<bf02cbd8>] (if_sdio_probe+0x898/0x9c0 [libertas_sdio]) Fix this by returning early. Also remove the out: label as it is not any longer needed. Signed-off-by: Sven Neumann <[email protected]> Cc: [email protected] Cc: Johannes Berg <[email protected]> Cc: Daniel Mack <[email protected]> Cc: [email protected] Signed-off-by: John W. Linville <[email protected]>
2011-07-26NFC: pn533: use after free in pn533_disconnect()Dan Carpenter1-1/+1
We freed "dev" on the line before. Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-22bcma: fix 'SSB_PCICORE_BFL_NOPCI' undeclared build breakageJohn W. Linville1-0/+2
linux-next-20110722/drivers/bcma/driver_pci.c:175: error: 'SSB_PCICORE_BFL_NOPCI' undeclared (first use in this function) Reported-by: Randy Dunlap <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-22b43legacy: dma: cache translation (routing bits)Rafał Miłecki2-3/+6
Signed-off-by: Rafał Miłecki <[email protected]> Tested-by: Larry Finger <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-22ath5k: use get_unaligned_le32() in ath5k_write_pwr_to_pdadc_table()Pavel Roskin1-6/+3
Signed-off-by: Pavel Roskin <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-22ath5k: remove ath5k_hw_get_capability(), don't use VEOL on AR5210Pavel Roskin3-81/+5
There are only two capabilities we need, and both are trivial to find. ath5k_hw_hasbssidmask() is true on AR5212, but not on AR5210 or AR5211. ath5k_hw_hasveol() is true on AR5211 and AR5212, but not on AR5210, according to the HAL source. Signed-off-by: Pavel Roskin <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-22ath5k: merge ath5k_{init, deinit}_hw() with their thin wrappersPavel Roskin3-22/+6
Signed-off-by: Pavel Roskin <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-22b43: (un)initialize driver on the BCMA busRafał Miłecki1-4/+44
Signed-off-by: Rafał Miłecki <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-22b43: bcma: get DMA translation bitsRafał Miłecki1-0/+5
Signed-off-by: Rafał Miłecki <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-22bcma: inform drivers about translation bits needed for the coreRafał Miłecki2-0/+21
When using DMA, drivers need to pass special translation info to the hardware. Signed-off-by: Rafał Miłecki <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-22ssb: return correct translation bit for 64-bit DMARafał Miłecki2-4/+7
Remove b43's workarounds at the same time. Other users of ssb_dma_translation do not support any 64-bit DMA devices, so they are not affected. Signed-off-by: Rafał Miłecki <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-22b43: disable parity check on BCMA devicesRafał Miłecki3-0/+21
Analyze of MMIO dumps from BCM43224, BCM43225, BCM4313 and BCM4331 has shown that wl disables parity check for all that cards. This is required for receiving any packets from the hardware. Signed-off-by: Rafał Miłecki <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-21rtlwifi: Convert printks to pr_<level>Joe Perches11-71/+72
Use the current logging styles. Add pr_fmt where appropriate. Remove now unnecessary prefixes from printks. Convert hard coded prefix to __func__. Add a missing "\n" to a format. Signed-off-by: Joe Perches <[email protected]> Acked-by: Larry Finger <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-21ath9k_hw: validate and fix broken eeprom chainmask settingsFelix Fietkau1-0/+22
Some devices (e.g. Ubiquiti AirRouter) ship with broken EEPROM chainmask data, which breaks the initial calibration after a hardware reset. To fix this, mask the eeprom chainmask with the chainmask of the chip, and use the chip chainmask if the result is zero. Signed-off-by: Felix Fietkau <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-21mwifiex: disable auto deep sleep before unloading the driverAmitkumar Karwar4-0/+19
Since the auto deep sleep mode has been enabled at driver init time we should disable it at driver unloading to shutdown the function gracefully. Signed-off-by: Amitkumar Karwar <[email protected]> Signed-off-by: Bing Zhao <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-21mwifiex: check SDIO multi-port aggregation buffer room correctlyAmitkumar Karwar1-1/+1
We should consider current packet length also while checking Tx aggregation buffer room. Signed-off-by: Amitkumar Karwar <[email protected]> Signed-off-by: Yogesh Ashok Powar <[email protected]> Signed-off-by: Bing Zhao <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-21mwifiex: put multicast/broadcast packets to the same RAAmitkumar Karwar1-0/+2
For ad-hoc mode, RA is created for each peer connected. In case of multicast traffic new RA will be created for each multicast address. While processing Tx packets we have to go through this RA list. We can avoid some RA nodes by sharing same RA for both multicast and broadcast packets. Therefore "memset(0xff)" is used to treat multicast packet as broadcast one while choosing RA. Signed-off-by: Amitkumar Karwar <[email protected]> Signed-off-by: Yogesh Ashok Powar <[email protected]> Signed-off-by: Bing Zhao <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2011-07-21iwlagn: probe would crash with DEBUG_SHIRQEmmanuel Grumbach2-11/+11
This is since my patch: iwlagn: introduce transport layer and implement rx_init The IRQ is requested before the locks are initialized, hence the crash. Initialize the tasklet before we request the IRQ on the way. Reported-by: Johannes Berg <[email protected]> Tested-by: Johannes Berg <[email protected]> Signed-off-by: Emmanuel Grumbach <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: remove "disable otp refresh" W/AWey-Yi Guy2-7/+1
Remove the "disable otp refresh" work-around, not needed anymore. Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: rename iwlagn_set_dynamic_keyJohannes Berg1-10/+11
We now have iwlagn_set_dynamic_key() and iwl_set_dynamic_key() which is confusing, rename the former to iwlagn_send_sta_key() to better reflect what it does -- it only sends a command and doesn't change driver state. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: track beacon interval sent to deviceJohannes Berg3-6/+9
Sometimes, when mac80211 changes the beacon interval or when it isn't yet set in mac80211 before association, the uCode will sysassert because we send it confusing RXON timing vs. PAN parameters. To fix this, track the last beacon interval sent to the device and use that in PAN parameter calculations. This fixes a bug during P2P group formation as a client (and possibly association to a regular AP) while connected to another AP. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: write iq invert register for 105/135 deviceWey-Yi Guy1-2/+4
For 105/135 series of devices, we need to do I/Q invert just like 2000 series devices. Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: implement WoWLANJohannes Berg11-14/+705
Implement WoWLAN support in iwlagn. The device supports a number of wakeup triggers and can do GTK rekeying when asleep (if HW crypto is used). Unfortunately, we need to disconnect from the AP after resume since we can't yet get all the info out of the wowlan uCode to stay connected safely. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: rewrite HW cryptoJohannes Berg6-224/+200
As I just discovered while doing WoWLAN, HW crypto is done wrong for GTKs: they should be programmed for the AP station ID (in the managed mode case) and the HW can actually deal with multiple group keys per station as well (which is useful in IBSS RSN but that I've chosen not to use this). To fix all this, modify the way keys are sent to the device and key offsets are allocated. After these changes, key offsets are stored into the hw_key_idx which we can then track for the key lifetime, not relying on our sta_cmd array. WEP default keys get special treatment, of course. Additionally, since I had the API for it, we can now pre-fill TKIP phase 1 keys for RX now that we can obtain the P1K from mac80211, a capability I had added for WoWLAN initially. Finally, some keys simply don't need to be added into the device's key cache -- a key that won't be used for RX is only needed in the TX header, so "pretend" to have accepted any key without adding it into the device -- no need to use up key space there for it. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: remove forgotten debugfs functionJohannes Berg1-2/+0
It seems that due to merge issues between different trees or so this function prototype wasn't removed when it should have been, do it now. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: remove un-necessary "_agn"Wey-Yi Guy10-256/+254
After driver split, extra _agn in priv structure is no needed, remove it. Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: remove keyinfo cacheJohannes Berg2-30/+0
iwlagn keeps a copy of key stuff internally but never actually uses it, so remove it. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: testmode fixed rate available for testmode onlyWey-Yi Guy3-3/+9
Move tm_fixed_rate inside CONFIG_IWLWIFI_DEVICE_SVTOOL and only available when the option is enable. Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: add comment to warn about WoWLAN in resume / suspend flowsEmmanuel Grumbach1-0/+10
WoWLAN may need the NIC even after suspend. One should not do anything to the NIC in the bus level, since one cannot check whether WoWLAN is enabled or not. Same for resume. Add a simple comment to the code to warn about this. Signed-off-by: Emmanuel Grumbach <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: iwl_bus holds drv_data as void * instead of iwl_privEmmanuel Grumbach5-27/+26
The price to pay is the access to the log system. Therefore logs from bus layer are sent by dev_printk instead of IWL_XXXX. Rename bus->priv to bus->drv_data to make the separation even clearer. Signed-off-by: Emmanuel Grumbach <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: simplify the bus architectureEmmanuel Grumbach14-140/+161
Call iwl_probe with a ready iwl_bus struct. This means that the bus layer assigns the irq, dev and iwl_bus_ops pointers to iwl_bus before giving it to iwl_probe. The device specific struct is allocated together with the common iwl_bus struct by the bus specific layer. The pointer to the aggregate struct is passed to the upper layer that holds a pointer to iwl_bus instead of an embedded iw_bus. The private data given to the PCI subsystem is now iwl_bus and not iwl_priv. Provide bus_* inliners on the way in order to simplify the syntax. Rename iwl-pci.h -> iwl-bus.h since it is bus agnostic and represent the external of the bus layer. Signed-off-by: Emmanuel Grumbach <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: transport layer receives struct iwl_trans*Emmanuel Grumbach18-154/+168
It still holds a pointer to iwl_priv. But hopefully this will disappear at some point. Also add the multiple inclusion protection to iwl-trans.h that was forgotten. Move iwl-trans structures to iwl-trans.h Signed-off-by: Emmanuel Grumbach <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: move iwl_prepare_card_hw to the transport layerEmmanuel Grumbach5-7/+14
This function is really related to the transport layer - move it. Signed-off-by: Emmanuel Grumbach <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: move more functions from the start flow to the transport layerEmmanuel Grumbach8-193/+178
Basically all the nic_init flow should be in the transport layer. iwl_prepare_card_hw will move to the transport too in a separate patch. Signed-off-by: Emmanuel Grumbach <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: SCD configuration for AMPDU moves to transport layerEmmanuel Grumbach8-239/+274
All the configurations of the HW for AMPDU are now in the transport layer. Signed-off-by: Emmanuel Grumbach <[email protected]> Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: radio sensor offset in le16 formatWey-Yi Guy2-5/+5
For temperature offset calibration, send radio sensor offset in le16 format Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: define valid init calibration maskWey-Yi Guy1-3/+13
Use the valid calibration mask for init calibration Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: remove legacy calibration commandWey-Yi Guy1-10/+0
IWL_PHY_CALIBRATE_DIFF_GAIN_CMD is for legacy device, remove it Signed-off-by: Wey-Yi Guy <[email protected]>
2011-07-21iwlagn: set correct calibration flagWey-Yi Guy2-2/+4
Set calibration config flag for complete notification Signed-off-by: Wey-Yi Guy <[email protected]>