aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-11-24MIPS: mm: Only build one microassembler that is suitableMaciej W. Rozycki1-3/+7
The microMIPS microassembler is only suitable for configurations where the kernel itself is built to microMIPS machine code and not where only user microMIPS software is supported. The former is controlled with the CPU_MICROMIPS configuration setting, whereas SYS_SUPPORTS_MICROMIPS is used for the latter. Not only that, but with a given microMIPS vs standard MIPS kernel configuration only one microassembler is needed, that matches the ISA selected -- CP0.Config3.ISAOnExc is mandatory on microMIPS processors, so there is never a need to mix microMIPS and standard MIPS code. Consequently build only the microassembler that matches the ISA selected for the kernel. Signed-off-by: Maciej W. Rozycki <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8479/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: Kconfig: Enable microMIPS support for MaltaMaciej W. Rozycki1-0/+1
Add missing microMIPS support to Malta. Currently the kernel only enables support for the instruction set for the SEAD-3 board despite the fact processor features have nothing to do with the board a processor is installed in. In this case there is no way to run microMIPS software in a fully supported way under Linux on QEMU. QEMU supports the emulation of a Malta board, but does not emulate SEAD-3. Linux supports running microMIPS code on a SEAD-3 board, but hardcodes such support to off on an emulated Malta board even if the processor selected has the microMIPS instruction set implemented. Adding support for the SEAD-3 to QEMU is a major project. Flipping a bit in the kernel that shouldn't have been cleared in the first place is a trivial effort. Thus the answer is plain... Signed-off-by: Maciej W. Rozycki <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8478/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: loongson: common: rtc: make loongson_rtc_resources staticAaro Koskinen1-1/+1
Make loongson_rtc_resources static to eliminate the following sparse warning: warning: symbol 'loongson_rtc_resources' was not declared. Should it be static? Signed-off-by: Aaro Koskinen <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8529/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: loongson: common: init: Add a missing includeAaro Koskinen1-0/+1
Add a missing include to eliminate the following sparse warnings: warning: symbol 'prom_init' was not declared. Should it be static? warning: symbol 'prom_free_prom_memory' was not declared. Should it be static? Signed-off-by: Aaro Koskinen <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8531/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: loongson: lemote-2f: reset: make ml2f_reboot staticAaro Koskinen1-1/+1
Make ml2f_reboot static to elimite the following sparse warning: warning: symbol 'ml2f_reboot' was not declared. Should it be static? Signed-off-by: Aaro Koskinen <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8528/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: loongson: lemote-2f: irq: Make internal data staticAaro Koskinen1-2/+2
Make internal static to eliminate the following sparse warnings: warning: symbol 'ip6_irqaction' was not declared. Should it be static? warning: symbol 'cascade_irqaction' was not declared. Should it be static? Signed-off-by: Aaro Koskinen <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8527/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: loongson: common: Setup: add a missing includeAaro Koskinen1-0/+1
Add a missing include to get rid of the following sparse warning: warning: symbol 'plat_mem_setup' was not declared. Should it be static? Signed-off-by: Aaro Koskinen <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8530/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: Loongson: cs5536_pci: Add a missing includeAaro Koskinen1-0/+1
Add a missing include to get rid of the following sparse warnings: warning: symbol 'cs5536_pci_conf_write4' was not declared. Should it be static? warning: symbol 'cs5536_pci_conf_read4' was not declared. Should it be static? Signed-off-by: Aaro Koskinen <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8526/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: Loongson: common: Fix array initializer syntax.Aaro Koskinen3-32/+32
Fix array initializer syntax to get rid of the following sparse warnings: "obsolete array initializer, use C99 syntax". Signed-off-by: Aaro Koskinen <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8525/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: uaccess.h: Fix strnlen_user comment.Ralf Baechle1-4/+2
Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: IP22/IP32: Add line to arch/mips/Makefile archhelp about vmlinux.32Joshua Kinard1-0/+1
Building a 64bit kernel for the SGI O2 (IP32) and the SGI Indy (IP22) uses the 'vmlinux.32' target, which converts the output 64-bit 'vmlinux' image into a 32-bit wrapped image. This is needed for certain revisions of the IP22 and IP32 ARCS PROMs to boot correctly, but this target is missing from the 'archhelp' info that is emitted by 'make help'. Signed-off-by: Joshua Kinard <[email protected]> Cc: Linux MIPS List <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/7991/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: lib: mips-atomic.c: Remove obsolete ifdeferyMarkos Chandras1-20/+0
Having #ifdefs just to guard comments is not really helpful so drop them. Moreover, the code wasn't really reached anyway since there is a #ifndef CONFIG_CPU_MIPSR2 on the top of the file. Signed-off-by: Markos Chandras <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8513/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: Octeon: Mark octeon_model_get_string() with __initAaro Koskinen3-7/+5
Mark octeon_model_get_string() with __init and make internal functions static. Signed-off-by: Aaro Koskinen <[email protected]> Cc: David Daney <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/7668/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: Octeon: Move code to avoid forward declarationAaro Koskinen1-19/+19
Move code to avoid forward declarations. Signed-off-by: Aaro Koskinen <[email protected]> Cc: David Daney <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/7667/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: Octeon: Delete potentially dangerous feature checksAaro Koskinen2-95/+0
We should not need to read fuses during normal operation, also the current code has issues with that (not safe for concurrent access). Since there are no in-kernel users for these, just delete them. Drivers should not need such OCTEON_HAS_FEATURE mechanism in any case, instead the information should be passed via device tree. Signed-off-by: Aaro Koskinen <[email protected]> Cc: David Daney <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/7665/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: Octeon: Move cvmx_fuse_read_byte()Aaro Koskinen2-19/+21
Move cvmx_fuse_read_byte() into a .c file. Signed-off-by: Aaro Koskinen <[email protected]> Cc: David Daney <[email protected]> Cc: [email protected] Cc: Aaro Koskinen <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/7666/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: oprofile: Backtrace: don't fail on leaf functionsAaro Koskinen1-2/+3
Continue the backtrace if we cannot find SP adjustment and RA save. In that case, just assume the current RA. This allows us to get samples of frequent callers of e.g. GLIBC memset(). Signed-off-by: Aaro Koskinen <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8109/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: oprofile: Enable backtrace on timer-based profilingAaro Koskinen1-1/+6
Allow unsupported CPU types to use backtrace with timer-based profiling. Some CPUs (notably OCTEON) lack architecture-specific oprofile driver. In such case oprofile can fallback to timer-based mode, and arch code can still provide the backtrace functionality. So just set up the backtrace hook always. Signed-off-by: Aaro Koskinen <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8108/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: traps: Dump the PageGrain and Wired registers on MCMarkos Chandras1-0/+2
They can be useful to determine how the MMU is configured on a MC exception. Signed-off-by: Markos Chandras <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8401/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: traps: Dump the HTW registers on a MC exceptionMarkos Chandras1-0/+5
The HTW registers can be useful to debug a MC exception. Signed-off-by: Markos Chandras <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8400/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: traps: Replace printk with pr_err for MC exceptionsMarkos Chandras1-6/+6
printk should not be used without a KERN_ facility level Signed-off-by: Markos Chandras <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8399/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24clocksource: mips-gic: Add device-tree supportAndrew Bresticker2-7/+35
Parse the GIC timer frequency and interrupt from the device-tree. Signed-off-by: Andrew Bresticker <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Cc: Rob Herring <[email protected]> Cc: Pawel Moll <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Ian Campbell <[email protected]> Cc: Kumar Gala <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Jason Cooper <[email protected]> Cc: Daniel Lezcano <[email protected]> Cc: John Crispin <[email protected]> Cc: David Daney <[email protected]> Cc: Qais Yousef <[email protected]> Cc: James Hogan <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8421/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24irqchip: mips-gic: Add device-tree supportAndrew Bresticker1-5/+87
Add device-tree support for the MIPS GIC. Update the GIC irqdomain's xlate() callback to handle the three-cell specifier described in the MIPS GIC binding document. Signed-off-by: Andrew Bresticker <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Acked-by: Jason Cooper <[email protected]> Cc: Rob Herring <[email protected]> Cc: Pawel Moll <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Ian Campbell <[email protected]> Cc: Kumar Gala <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Daniel Lezcano <[email protected]> Cc: John Crispin <[email protected]> Cc: David Daney <[email protected]> Cc: Qais Yousef <[email protected]> Cc: James Hogan <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8422/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24of: Add binding document for MIPS GICAndrew Bresticker2-0/+64
The Global Interrupt Controller (GIC) present on certain MIPS systems can be used to route external interrupts to individual VPEs and CPU interrupt vectors. It also supports a timer and software-generated interrupts. Signed-off-by: Andrew Bresticker <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Cc: Rob Herring <[email protected]> Cc: Pawel Moll <[email protected]> Cc: Mark Rutland <[email protected]> Cc: Ian Campbell <[email protected]> Cc: Kumar Gala <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Jason Cooper <[email protected]> Cc: Daniel Lezcano <[email protected]> Cc: John Crispin <[email protected]> Cc: David Daney <[email protected]> Cc: Qais Yousef <[email protected]> Cc: James Hogan <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8420/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath79: Read the initrd address from the firmware environmentAlban Bedel1-0/+8
Allow loading an initrd passed by the firmware. Signed-off-by: Alban Bedel <[email protected]> Cc: [email protected] Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8354/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath79: Use the firmware lib to parse the kernel command lineAlban Bedel1-28/+2
No need to duplicate code that is available in the firmware library. It also give us access to the firmware environment which is needed to read the initrd address and size. Signed-off-by: Alban Bedel <[email protected]> Cc: [email protected] Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8353/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: add Wireless device supportSergey Ryazanov4-0/+79
Atheros AR5312 and AR2315 both have a builtin wireless device, this patch add helper code and register platform device for all supported WiSoCs. Signed-off-by: Sergey Ryazanov <[email protected]> Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8249/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24ath5k: update dependenciesSergey Ryazanov5-11/+11
- Use config symbol defined in the driver instead of arch specific one for conditional compilation. - Rename the ATHEROS_AR231X config symbol to ATH25. - Fix include (ar231x_platform.h -> ath25_platform.h). - Some of AR231x SoCs (e.g. AR2315) have PCI bus support, so remove !PCI dependency, which block AHB support build. Signed-off-by: Sergey Ryazanov <[email protected]> Acked-by: John W. Linville <[email protected]> Cc: Jiri Slaby <[email protected]> Cc: Nick Kossifidis <[email protected]> Cc: "Luis R. Rodriguez" <[email protected]> Cc: [email protected] Cc: [email protected] Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8248/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24ath5k: revert AHB bus support removingSergey Ryazanov6-3/+294
This reverts commit 093ec3c5337434f40d77c1af06c139da3e5ba6dc. AHB bus code has been removed, since we did not have support Atheros AR231x SoC, required for building the AHB version of ath5k. Now that support WiSoC chips added we can restore functionality back. Signed-off-by: Sergey Ryazanov <[email protected]> Acked-by: John W. Linville <[email protected]> Cc: Jiri Slaby <[email protected]> Cc: Nick Kossifidis <[email protected]> Cc: "Luis R. Rodriguez" <[email protected]> Cc: [email protected] Cc: [email protected] Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8247/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: add AR2315 PCI host controller driverSergey Ryazanov5-3/+597
Add PCI host controller driver and DMA address calculation hook. Signed-off-by: Sergey Ryazanov <[email protected]> Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8246/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: register AR5312 flash controllerSergey Ryazanov1-2/+36
AR5312 SoC flash controller maps the flash content to memory and translates the memory access operations to the flash access operations. Such controller is fully supported by the physmap-flash driver. Signed-off-by: Sergey Ryazanov <[email protected]>R5312 SoC flash Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8245/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: add SoC type detectionSergey Ryazanov4-1/+77
Detect SoC type based on device ID and board configuration data. Signed-off-by: Sergey Ryazanov <[email protected]> Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8244/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: add board configuration detectionSergey Ryazanov8-0/+300
All boards based on AR5312/AR2315 SoC have a special structure located at the end of flash. This structure contains board-specific data such as Ethernet and Wireless MAC addresses. The flash is mapped to the memmory at predefined location. Signed-off-by: Sergey Ryazanov <[email protected]> Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8243/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: add UART supportSergey Ryazanov6-0/+53
Signed-off-by: Sergey Ryazanov <[email protected]> Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8242/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: add early printk supportSergey Ryazanov3-0/+47
Signed-off-by: Sergey Ryazanov <[email protected]> Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8241/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: add interrupts handling routinesSergey Ryazanov9-0/+290
Add interrupts initialization and handling routines, also add AHB bus error interrupt handlers for both SoCs families. Signed-off-by: Sergey Ryazanov <[email protected]> Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8240/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: Add basic AR2315 SoC supportSergey Ryazanov7-1/+578
Add basic support for Atheros AR2315+ SoCs: registers definition file and initial setup code. Signed-off-by: Sergey Ryazanov <[email protected]> Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8239/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: add basic AR5312 SoC supportSergey Ryazanov7-0/+387
Add basic support for Atheros AR5312/AR2312 SoCs: registers definition file and initial setup code. Signed-off-by: Sergey Ryazanov <[email protected]> Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8238/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ath25: add common partsSergey Ryazanov12-0/+296
Add common code for Atheros AR5312 and Atheros AR2315 SoCs families. Signed-off-by: Sergey Ryazanov <[email protected]> Cc: Linux MIPS <[email protected]> Patchwork: https://patchwork.linux-mips.org/patch/8237 Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: FW: Use kstrtoul() to parse unsigned long from the fw environmentAlban Bedel1-3/+3
Fix some value corruptions with values that can't be represented in a signed long. Signed-off-by: Alban Bedel <[email protected]> Cc: [email protected] Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8358/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: FW: Fix parsing u-boot environmentAlban Bedel1-1/+1
When reading u-boot's key=value pairs it should skip the '=' and not use the next argument. Signed-off-by: Alban Bedel <[email protected]> Cc: [email protected] Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/8357/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24TC: Error handling clean-upsMaciej W. Rozycki1-17/+19
Rewrite TURBOchannel error handling to use a common failure path, making sure put_device is called for devices that failed initialization. While at it update printk calls to use pr_err rather than KERN_ERR. Signed-off-by: Maciej W. Rozycki <[email protected]> Cc: [email protected] Patchwork: https://patchwork.linux-mips.org/patch/6701/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ralink: add rt2880 pci driverJohn Crispin3-0/+287
Signed-off-by: John Crispin <[email protected]> Patchwork: http://patchwork.linux-mips.org/patch/8034/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ralink: allow loading irq registers from the devicetreeJohn Crispin1-10/+25
Signed-off-by: John Crispin <[email protected]> Patchwork: http://patchwork.linux-mips.org/patch/8029/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ralink: add mt7628an supportJohn Crispin3-46/+243
Signed-off-by: John Crispin <[email protected]> Patchwork: http://patchwork.linux-mips.org/patch/8031/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ralink: add support for MT7620nJohn Crispin2-12/+15
This is the small version of MT7620a. Signed-off-by: John Crispin <[email protected]> Patchwork: http://patchwork.linux-mips.org/patch/8030/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ralink: cleanup early_printkJohn Crispin1-15/+30
Add support for the new MT7621/8 SoC and kill ifdefs. Cleanup some whitespace error while we are at it. Signed-off-by: John Crispin <[email protected]> Patchwork: http://patchwork.linux-mips.org/patch/8028/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ralink: cleanup the soc specific pinmux dataJohn Crispin10-420/+294
Before we had a pinctrl driver we used a custom OF api. This patch converts the soc specific pinmux data to a new set of structs. We also add some new pinmux setings. Signed-off-by: John Crispin <[email protected]> Patchwork: http://patchwork.linux-mips.org/patch/8009/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ralink: copy the commandline from the devicetreeJohn Crispin1-0/+2
This is a regression caused by: commit afb46f7996e91aeb36e07bc92cf96e8045bec00e Author: Rob Herring <[email protected]> Date: Wed Apr 2 19:07:24 2014 -0500 mips: ralink: convert to use unflatten_and_copy_device_tree Make the of init code reuse the cmdline defined inside the dts. Signed-off-by: John Crispin <[email protected]> Patchwork: http://patchwork.linux-mips.org/patch/8008/ Signed-off-by: Ralf Baechle <[email protected]>
2014-11-24MIPS: ralink: add a bootrom dumper moduleJohn Crispin2-0/+50
This patch adds a trivial driver that allows userland to extract the bootrom of a SoC via debugfs. Signed-off-by: John Crispin <[email protected]> Patchwork: http://patchwork.linux-mips.org/patch/8002/ Signed-off-by: Ralf Baechle <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.