aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-10-30vfs: hide file range comparison functionDarrick J. Wong2-99/+91
There are no callers of vfs_dedupe_file_range_compare, so we might as well make it a static helper and remove the export. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: enable remap callers that can handle short operationsDarrick J. Wong4-15/+33
Plumb in a remap flag that enables the filesystem remap handler to shorten remapping requests for callers that can handle it. Now copy_file_range can report partial success (in case we run up against alignment problems, resource limits, etc.). We also enable CAN_SHORTEN for fideduperange to maintain existing userspace-visible behavior where xfs/btrfs shorten the dedupe range to avoid stale post-eof data exposure. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: plumb remap flags through the vfs dedupe functionsDarrick J. Wong3-5/+9
Plumb a remap_flags argument through the vfs_dedupe_file_range_one functions so that dedupe can take advantage of it. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: plumb remap flags through the vfs clone functionsDarrick J. Wong6-12/+17
Plumb a remap_flags argument through the {do,vfs}_clone_file_range functions so that clone can take advantage of it. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: make remap_file_range functions take and return bytes completedDarrick J. Wong18-82/+108
Change the remap_file_range functions to take a number of bytes to operate upon and return the number of bytes they operated on. This is a requirement for allowing fs implementations to return short clone/dedupe results to the user, which will enable us to obey resource limits in a graceful manner. A subsequent patch will enable copy_file_range to signal to the ->clone_file_range implementation that it can handle a short length, which will be returned in the function's return value. For now the short return is not implemented anywhere so the behavior won't change -- either copy_file_range manages to clone the entire range or it tries an alternative. Neither clone ioctl can take advantage of this, alas. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: remap helper should update destination inode metadataDarrick J. Wong2-23/+19
Extend generic_remap_file_range_prep to handle inode metadata updates when remapping into a file. If the operation can possibly alter the file contents, we must update the ctime and mtime and remove security privileges, just like we do for regular file writes. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: pass remap flags to generic_remap_checksDarrick J. Wong3-4/+4
Pass the same remap flags to generic_remap_checks for consistency. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: pass remap flags to generic_remap_file_range_prepDarrick J. Wong8-24/+26
Plumb the remap flags through the filesystem from the vfs function dispatcher all the way to the prep function to prepare for behavior changes in subsequent patches. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: combine the clone and dedupe into a single remap_file_rangeDarrick J. Wong12-106/+127
Combine the clone_file_range and dedupe_file_range operations into a single remap_file_range file operation dispatch since they're fundamentally the same operation. The differences between the two can be made in the prep functions. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: rename clone_verify_area to remap_verify_areaDarrick J. Wong1-5/+5
Since we use clone_verify_area for both clone and dedupe range checks, rename the function to make it clear that it's for both. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: rename vfs_clone_file_prep to be more descriptiveDarrick J. Wong4-9/+9
The vfs_clone_file_prep is a generic function to be called by filesystem implementations only. Rename the prefix to generic_ and make it more clear that it applies to remap operations, not just clones. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: skip zero-length dedupe requestsDarrick J. Wong1-0/+5
Don't bother calling the filesystem for a zero-length dedupe request; we can return zero and exit. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: avoid problematic remapping requests into partial EOF blockDarrick J. Wong1-0/+33
A deduplication data corruption is exposed in XFS and btrfs. It is caused by extending the block match range to include the partial EOF block, but then allowing unknown data beyond EOF to be considered a "match" to data in the destination file because the comparison is only made to the end of the source file. This corrupts the destination file when the source extent is shared with it. The VFS remapping prep functions only support whole block dedupe, but we still need to appear to support whole file dedupe correctly. Hence if the dedupe request includes the last block of the souce file, don't include it in the actual dedupe operation. If the rest of the range dedupes successfully, then reject the entire request. A subsequent patch will enable us to shorten dedupe requests correctly. When reflinking sub-file ranges, a data corruption can occur when the source file range includes a partial EOF block. This shares the unknown data beyond EOF into the second file at a position inside EOF, exposing stale data in the second file. If the reflink request includes the last block of the souce file, only proceed with the reflink operation if it lands at or past the destination file's current EOF. If it lands within the destination file EOF, reject the entire request with -EINVAL and make the caller go the hard way. A subsequent patch will enable us to shorten reflink requests correctly. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: strengthen checking of file range inputs to generic_remap_checksDarrick J. Wong1-32/+52
File range remapping, if allowed to run past the destination file's EOF, is an optimization on a regular file write. Regular file writes that extend the file length are subject to various constraints which are not checked by range cloning. This is a correctness problem because we're never allowed to touch ranges that the page cache can't support (s_maxbytes); we're not supposed to deal with large offsets (MAX_NON_LFS) if O_LARGEFILE isn't set; and we must obey resource limits (RLIMIT_FSIZE). Therefore, add these checks to the new generic_remap_checks function so that we curtail unexpected behavior. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: exit early from zero length remap operationsDarrick J. Wong1-0/+2
If a remap caller asks us to remap to the source file's EOF and the source file length leaves us with a zero byte request, exit early. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: check file ranges before cloning filesDarrick J. Wong5-47/+90
Move the file range checks from vfs_clone_file_prep into a separate generic_remap_checks function so that all the checks are collected in a central location. This forms the basis for adding more checks from generic_write_checks that will make cloning's input checking more consistent with write input checking. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-30vfs: vfs_clone_file_prep_inodes should return EINVAL for a clone from beyond EOFDarrick J. Wong1-3/+0
vfs_clone_file_prep_inodes cannot return 0 if it is asked to remap from a zero byte file because that's what btrfs does. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Dave Chinner <[email protected]>
2018-10-22Linux 4.19Greg Kroah-Hartman1-2/+2
2018-10-22MAINTAINERS: Add an entry for the code of conductGreg Kroah-Hartman1-0/+6
As I introduced these files, I'm willing to be the maintainer of them as well. Acked-by: Chris Mason <[email protected]> Acked-by: Olof Johansson <[email protected]> Acked-by: Steven Rostedt (VMware) <[email protected]> Acked-by: Theodore Ts'o <[email protected]> Acked-by: Thomas Gleixner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-10-22Code of Conduct: Change the contact email addressGreg Kroah-Hartman1-6/+7
The contact point for the kernel's Code of Conduct should now be the Code of Conduct Committee, not the full TAB. Change the email address in the file to properly reflect this. Acked-by: Chris Mason <[email protected]> Acked-by: Olof Johansson <[email protected]> Acked-by: Theodore Ts'o <[email protected]> Acked-by: Thomas Gleixner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-10-22Code of Conduct Interpretation: Put in the proper URL for the committeeGreg Kroah-Hartman1-2/+3
There was a blank <URL> reference for how to find the Code of Conduct Committee. Fix that up by pointing it to the correct kernel.org website page location. Acked-by: Chris Mason <[email protected]> Acked-by: Olof Johansson <[email protected]> Acked-by: Theodore Ts'o <[email protected]> Acked-by: Thomas Gleixner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-10-22Code of Conduct: Provide links between the two documentsGreg Kroah-Hartman2-1/+11
Create a link between the Code of Conduct and the Code of Conduct Interpretation so that people can see that they are related. Acked-by: Chris Mason <[email protected]> Acked-by: Olof Johansson <[email protected]> Acked-by: Theodore Ts'o <[email protected]> Acked-by: Thomas Gleixner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-10-22Code of Conduct Interpretation: Properly reference the TAB correctlyGreg Kroah-Hartman1-8/+8
We use the term "TAB" before defining it later in the document. Fix that up by defining it at the first location. Reported-by: Kuninori Morimoto <[email protected]> Acked-by: Chris Mason <[email protected]> Acked-by: Olof Johansson <[email protected]> Acked-by: Theodore Ts'o <[email protected]> Acked-by: Thomas Gleixner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-10-22Code of Conduct Interpretation: Add document explaining how the Code of ↵Greg Kroah-Hartman2-0/+154
Conduct is to be interpreted The Contributor Covenant Code of Conduct is a general document meant to provide a set of rules for almost any open source community. Every open-source community is unique and the Linux kernel is no exception. Because of this, this document describes how we in the Linux kernel community will interpret it. We also do not expect this interpretation to be static over time, and will adjust it as needed. This document was created with the input and feedback of the TAB as well as many current kernel maintainers. Co-Developed-by: Thomas Gleixner <[email protected]> Co-Developed-by: Olof Johansson <[email protected]> Acked-by: Alex Deucher <[email protected]> Acked-by: Alexei Starovoitov <[email protected]> Acked-by: Amir Goldstein <[email protected]> Acked-by: Andrew Morton <[email protected]> Acked-by: Andy Lutomirski <[email protected]> Acked-by: Anna-Maria Gleixner <[email protected]> Acked-by: Ard Biesheuvel <[email protected]> Acked-by: Benjamin Herrenschmidt <[email protected]> Acked-by: Boris Brezillon <[email protected]> Acked-by: Borislav Petkov <[email protected]> Acked-by: Chris Mason <[email protected]> Acked-by: Christian Lütke-Stetzkamp <[email protected]> Acked-by: Colin Ian King <[email protected]> Acked-by: Dan Carpenter <[email protected]> Acked-by: Dan Williams <[email protected]> Acked-by: Daniel Borkmann <[email protected]> Acked-by: Daniel Vetter <[email protected]> Acked-by: Dave Airlie <[email protected]> Acked-by: Dave Hansen <[email protected]> Acked-by: David Ahern <[email protected]> Acked-by: David Sterba <[email protected]> Acked-by: Dmitry Torokhov <[email protected]> Acked-by: Dominik Brodowski <[email protected]> Acked-by: Eric Dumazet <[email protected]> Acked-by: Felipe Balbi <[email protected]> Acked-by: Felix Kuehling <[email protected]> Acked-by: Florian Fainelli <[email protected]> Acked-by: Geert Uytterhoeven <[email protected]> Acked-by: Grant Likely <[email protected]> Acked-by: Gregory CLEMENT <[email protected]> Acked-by: Guenter Roeck <[email protected]> Acked-by: Gustavo A. R. Silva <[email protected]> Acked-by: Hans Verkuil <[email protected]> Acked-by: Hans de Goede <[email protected]> Acked-by: Harry Wentland <[email protected]> Acked-by: Heiko Stuebner <[email protected]> Acked-by: Ingo Molnar <[email protected]> Acked-by: Jaegeuk Kim <[email protected]> Acked-by: James Smart <[email protected]> Acked-by: James Smart <[email protected]> Acked-by: Jan Kara <[email protected]> Acked-by: Jani Nikula <[email protected]> Acked-by: Jason A. Donenfeld <[email protected]> Acked-by: Jeff Kirsher <[email protected]> Acked-by: Jens Axboe <[email protected]> Acked-by: Jessica Yu <[email protected]> Acked-by: Jia-Ju Bai <[email protected]> Acked-by: Jiri Kosina <[email protected]> Acked-by: Jiri Olsa <[email protected]> Acked-by: Joerg Roedel <[email protected]> Acked-by: Johan Hovold <[email protected]> Acked-by: Johannes Thumshirn <[email protected]> Acked-by: Jonathan Corbet <[email protected]> Acked-by: Julia Lawall <[email protected]> Acked-by: Kees Cook <[email protected]> Acked-by: Kirill Tkhai <[email protected]> Acked-by: Kuninori Morimoto <[email protected]> Acked-by: Laurent Pinchart <[email protected]> Acked-by: Lina Iyer <[email protected]> Acked-by: Linus Torvalds <[email protected]> Acked-by: Linus Walleij <[email protected]> Acked-by: Mark Brown <[email protected]> Acked-by: Masahiro Yamada <[email protected]> Acked-by: Masami Hiramatsu <[email protected]> Acked-by: Mathieu Desnoyers <[email protected]> Acked-by: Matias Bjørling <[email protected]> Acked-by: Mauro Carvalho Chehab <[email protected]> Acked-by: Maxime Ripard <[email protected]> Acked-by: Michael Ellerman <[email protected]> Acked-by: Mike Rapoport <[email protected]> Acked-by: Mimi Zohar <[email protected]> Acked-by: Miquel Raynal <[email protected]> Acked-by: Mishi Choudhary <[email protected]> Acked-by: Nikolay Borisov <[email protected]> Acked-by: Oded Gabbay <[email protected]> Acked-by: Palmer Dabbelt <[email protected]> Acked-by: Paul E. McKenney <[email protected]> Acked-by: Peter Zijlstra <[email protected]> Acked-by: Rafael J. Wysocki <[email protected]> Acked-by: Richard Weinberger <[email protected]> Acked-by: Rik van Riel <[email protected]> Acked-by: Rob Clark <[email protected]> Acked-by: Rob Herring <[email protected]> Acked-by: Rodrigo Vivi <[email protected]> Acked-by: Sean Paul <[email protected]> Acked-by: Sebastian Andrzej Siewior <[email protected]> Acked-by: Sebastian Reichel <[email protected]> Acked-by: Sergio Paracuellos <[email protected]> Acked-by: Shawn Guo <[email protected]> Acked-by: Shuah Khan <[email protected]> Acked-by: Simon Horman <[email protected]> Acked-by: Srinivas Kandagatla <[email protected]> Acked-by: Stephen Hemminger <[email protected]> Acked-by: Takashi Iwai <[email protected]> Acked-by: Tejun Heo <[email protected]> Acked-by: Theodore Ts'o <[email protected]> Acked-by: Thierry Reding <[email protected]> Acked-by: Todd Poynor <[email protected]> Acked-by: Viresh Kumar <[email protected]> Acked-by: Wei Yongjun <[email protected]> Acked-by: YueHaibing <[email protected]> Reviewed-by: Steven Rostedt <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Signed-off-by: Olof Johansson <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-10-22Code of conduct: Fix wording around maintainers enforcing the code of conductChris Mason1-4/+0
As it was originally worded, this paragraph requires maintainers to enforce the code of conduct, or face potential repercussions. It sends the wrong message, when really we just want maintainers to be part of the solution and not violate the code of conduct themselves. Removing it doesn't limit our ability to enforce the code of conduct, and we can still encourage maintainers to help maintain high standards for the level of discourse in their subsystem. Signed-off-by: Chris Mason <[email protected]> Acked-by: Alex Deucher <[email protected]> Acked-by: Amir Goldstein <[email protected]> Acked-by: Andrew Morton <[email protected]> Acked-by: Anna-Maria Gleixner <[email protected]> Acked-by: Ard Biesheuvel <[email protected]> Acked-by: Benjamin Herrenschmidt <[email protected]> Acked-by: Boris Brezillon <[email protected]> Acked-by: Borislav Petkov <[email protected]> Acked-by: Christian Lütke-Stetzkamp <[email protected]> Acked-by: Christoph Hellwig <[email protected]> Acked-by: Colin Ian King <[email protected]> Acked-by: Dan Carpenter <[email protected]> Acked-by: Dan Williams <[email protected]> Acked-by: Daniel Borkmann <[email protected]> Acked-by: Dave Airlie <[email protected]> Acked-by: Dave Hansen <[email protected]> Acked-by: David Ahern <[email protected]> Acked-by: David Sterba <[email protected]> Acked-by: Dmitry Torokhov <[email protected]> Acked-by: Dominik Brodowski <[email protected]> Acked-by: Eric Dumazet <[email protected]> Acked-by: Felipe Balbi <[email protected]> Acked-by: Felix Kuehling <[email protected]> Acked-by: Florian Fainelli <[email protected]> Acked-by: Florian Westphal <[email protected]> Acked-by: Geert Uytterhoeven <[email protected]> Acked-by: Grant Likely <[email protected]> Acked-by: Gregory CLEMENT <[email protected]> Acked-by: Guenter Roeck <[email protected]> Acked-by: Gustavo A. R. Silva <[email protected]> Acked-by: Hans Verkuil <[email protected]> Acked-by: Hans de Goede <[email protected]> Acked-by: Harry Wentland <[email protected]> Acked-by: Heiko Stuebner <[email protected]> Acked-by: Ingo Molnar <[email protected]> Acked-by: Jaegeuk Kim <[email protected]> Acked-by: James Smart <[email protected]> Acked-by: James Smart <[email protected]> Acked-by: Jan Kara <[email protected]> Acked-by: Jason A. Donenfeld <[email protected]> Acked-by: Jeff Kirsher <[email protected]> Acked-by: Jens Axboe <[email protected]> Acked-by: Jessica Yu <[email protected]> Acked-by: Jia-Ju Bai <[email protected]> Acked-by: Jiri Kosina <[email protected]> Acked-by: Jiri Olsa <[email protected]> Acked-by: Joerg Roedel <[email protected]> Acked-by: Johan Hovold <[email protected]> Acked-by: Johannes Thumshirn <[email protected]> Acked-by: Jonathan Corbet <[email protected]> Acked-by: Julia Lawall <[email protected]> Acked-by: Kees Cook <[email protected]> Acked-by: Kirill Tkhai <[email protected]> Acked-by: Kuninori Morimoto <[email protected]> Acked-by: Laurent Pinchart <[email protected]> Acked-by: Lina Iyer <[email protected]> Acked-by: Linus Torvalds <[email protected]> Acked-by: Linus Walleij <[email protected]> Acked-by: Mark Brown <[email protected]> Acked-by: Masahiro Yamada <[email protected]> Acked-by: Masami Hiramatsu <[email protected]> Acked-by: Mathieu Desnoyers <[email protected]> Acked-by: Matias Bjørling <[email protected]> Acked-by: Maxime Ripard <[email protected]> Acked-by: Michael Ellerman <[email protected]> Acked-by: Mike Rapoport <[email protected]> Acked-by: Mimi Zohar <[email protected]> Acked-by: Miquel Raynal <[email protected]> Acked-by: Nikolay Borisov <[email protected]> Acked-by: Oded Gabbay <[email protected]> Acked-by: Olof Johansson <[email protected]> Acked-by: Palmer Dabbelt <[email protected]> Acked-by: Paul E. McKenney <[email protected]> Acked-by: Peter Zijlstra <[email protected]> Acked-by: Rafael J. Wysocki <[email protected]> Acked-by: Richard Weinberger <[email protected]> Acked-by: Rik van Riel <[email protected]> Acked-by: Rob Clark <[email protected]> Acked-by: Rob Herring <[email protected]> Acked-by: Rodrigo Vivi <[email protected]> Acked-by: Sebastian Andrzej Siewior <[email protected]> Acked-by: Sebastian Reichel <[email protected]> Acked-by: Sergio Paracuellos <[email protected]> Acked-by: Shawn Guo <[email protected]> Acked-by: Shuah Khan <[email protected]> Acked-by: Simon Horman <[email protected]> Acked-by: Srinivas Kandagatla <[email protected]> Acked-by: Stephen Hemminger <[email protected]> Acked-by: Takashi Iwai <[email protected]> Acked-by: Tejun Heo <[email protected]> Acked-by: Theodore Ts'o <[email protected]> Acked-by: Thierry Reding <[email protected]> Acked-by: Thomas Gleixner <[email protected]> Acked-by: Tim Bird <[email protected]> Acked-by: Todd Poynor <[email protected]> Acked-by: Trond Myklebust <[email protected]> Acked-by: Viresh Kumar <[email protected]> Acked-by: Wei Yongjun <[email protected]> Acked-by: YueHaibing <[email protected]> Reviewed-by: Mauro Carvalho Chehab <[email protected]> Reviewed-by: Steven Rostedt <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-10-21Merge branch 'i2c/for-current' of ↵Greg Kroah-Hartman2-1/+13
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux Wolfram writes: "i2c for 4.19 Another driver bugfix and MAINTAINERS addition from I2C." * 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux: i2c: rcar: cleanup DMA for all kinds of failure MAINTAINERS: Add entry for Broadcom STB I2C controller
2018-10-21Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/netGreg Kroah-Hartman4-8/+8
David writes: "Networking: A few straggler bug fixes: 1) Fix indexing of multi-pass dumps of ipv6 addresses, from David Ahern. 2) Revert RCU locking change for bonding netpoll, causes worse problems than it solves. 3) pskb_trim_rcsum_slow() doesn't handle odd trim offsets, resulting in erroneous bad hw checksum triggers with CHECKSUM_COMPLETE devices. From Dimitris Michailidis. 4) a revert to some neighbour code changes that adjust notifications in a way that confuses some apps." * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: Revert "neighbour: force neigh_invalidate when NUD_FAILED update is from admin" net/ipv6: Fix index counter for unicast addresses in in6_dump_addrs net: fix pskb_trim_rcsum_slow() with odd trim offset Revert "bond: take rcu lock in netpoll_send_skb_on_dev"
2018-10-20Revert "neighbour: force neigh_invalidate when NUD_FAILED update is from admin"Roopa Prabhu1-2/+1
This reverts commit 8e326289e3069dfc9fa9c209924668dd031ab8ef. This patch results in unnecessary netlink notification when one tries to delete a neigh entry already in NUD_FAILED state. Found this with a buggy app that tries to delete a NUD_FAILED entry repeatedly. While the notification issue can be fixed with more checks, adding more complexity here seems unnecessary. Also, recent tests with other changes in the neighbour code have shown that the INCOMPLETE and PROBE checks are good enough for the original issue. Signed-off-by: Roopa Prabhu <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2018-10-20net/ipv6: Fix index counter for unicast addresses in in6_dump_addrsDavid Ahern1-2/+4
The loop wants to skip previously dumped addresses, so loops until current index >= saved index. If the message fills it wants to save the index for the next address to dump - ie., the one that did not fit in the current message. Currently, it is incrementing the index counter before comparing to the saved index, and then the saved index is off by 1 - it assumes the current address is going to fit in the message. Change the index handling to increment only after a succesful dump. Fixes: 502a2ffd7376a ("ipv6: convert idev_list to list macros") Signed-off-by: David Ahern <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2018-10-20i2c: rcar: cleanup DMA for all kinds of failureWolfram Sang1-1/+5
DMA needs to be cleaned up not only on timeout, but on all errors where it has been setup before. Fixes: 73e8b0528346 ("i2c: rcar: add DMA support") Signed-off-by: Wolfram Sang <[email protected]> Signed-off-by: Wolfram Sang <[email protected]>
2018-10-20MAINTAINERS: Add entry for Broadcom STB I2C controllerKamal Dasu1-0/+8
Add an entry for the Broadcom STB I2C controller in the MAINTAINERS file. Signed-off-by: Kamal Dasu <[email protected]> Acked-by: Florian Fainelli <[email protected]> [wsa: fixed sorting and a whitespace error] Signed-off-by: Wolfram Sang <[email protected]>
2018-10-20Merge branch 'x86-urgent-for-linus' of ↵Greg Kroah-Hartman9-18/+30
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip Ingo writes: "x86 fixes: It's 4 misc fixes, 3 build warning fixes and 3 comment fixes. In hindsight I'd have left out the 3 comment fixes to make the pull request look less scary at such a late point in the cycle. :-/" * 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: x86/swiotlb: Enable swiotlb for > 4GiG RAM on 32-bit kernels x86/fpu: Fix i486 + no387 boot crash by only saving FPU registers on context switch if there is an FPU x86/fpu: Remove second definition of fpu in __fpu__restore_sig() x86/entry/64: Further improve paranoid_entry comments x86/entry/32: Clear the CS high bits x86/boot: Add -Wno-pointer-sign to KBUILD_CFLAGS x86/time: Correct the attribute on jiffies' definition x86/entry: Add some paranoid entry/exit CR3 handling comments x86/percpu: Fix this_cpu_read() x86/tsc: Force inlining of cyc2ns bits
2018-10-20Merge branch 'sched-urgent-for-linus' of ↵Greg Kroah-Hartman2-4/+22
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip Ingo writes: "scheduler fixes: Two fixes: a CFS-throttling bug fix, and an interactivity fix." * 'sched-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: sched/fair: Fix the min_vruntime update logic in dequeue_entity() sched/fair: Fix throttle_list starvation with low CFS quota
2018-10-20Merge branch 'perf-urgent-for-linus' of ↵Greg Kroah-Hartman12-45/+39
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip Ingo writes: "perf fixes: Misc perf tooling fixes." * 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: perf tools: Stop fallbacking to kallsyms for vdso symbols lookup perf tools: Pass build flags to traceevent build perf report: Don't crash on invalid inline debug information perf cpu_map: Align cpu map synthesized events properly. perf tools: Fix tracing_path_mount proper path perf tools: Fix use of alternatives to find JDIR perf evsel: Store ids for events with their own cpus perf_event__synthesize_event_update_cpus perf vendor events intel: Fix wrong filter_band* values for uncore events Revert "perf tools: Fix PMU term format max value calculation" tools headers uapi: Sync kvm.h copy tools arch uapi: Sync the x86 kvm.h copy
2018-10-20net: fix pskb_trim_rcsum_slow() with odd trim offsetDimitris Michailidis1-2/+3
We've been getting checksum errors involving small UDP packets, usually 59B packets with 1 extra non-zero padding byte. netdev_rx_csum_fault() has been complaining that HW is providing bad checksums. Turns out the problem is in pskb_trim_rcsum_slow(), introduced in commit 88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends"). The source of the problem is that when the bytes we are trimming start at an odd address, as in the case of the 1 padding byte above, skb_checksum() returns a byte-swapped value. We cannot just combine this with skb->csum using csum_sub(). We need to use csum_block_sub() here that takes into account the parity of the start address and handles the swapping. Matches existing code in __skb_postpull_rcsum() and esp_remove_trailer(). Fixes: 88078d98d1bb ("net: pskb_trim_rcsum() and CHECKSUM_COMPLETE are friends") Signed-off-by: Dimitris Michailidis <[email protected]> Reviewed-by: Eric Dumazet <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2018-10-20Merge tag 'drm-fixes-2018-10-20-1' of git://anongit.freedesktop.org/drm/drmGreg Kroah-Hartman4-5/+35
Dave writes: "drm fixes for 4.19 final (part 2) Looked like two stragglers snuck in, one very urgent the pageflipping was missing a reference that could result in a GPF on non-i915 drivers, the other is an overflow in the sun4i dotclock calcs resulting in a mode not getting set." * tag 'drm-fixes-2018-10-20-1' of git://anongit.freedesktop.org/drm/drm: drm/sun4i: Fix an ulong overflow in the dotclock driver drm: Get ref on CRTC commit object when waiting for flip_done
2018-10-20Merge tag 'trace-v4.19-rc8-2' of ↵Greg Kroah-Hartman2-7/+105
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace Steven writes: "tracing: A few small fixes to synthetic events Masami found some issues with the creation of synthetic events. The first two patches fix handling of unsigned type, and handling of a space before an ending semi-colon. The third patch adds a selftest to test the processing of synthetic events." * tag 'trace-v4.19-rc8-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace: selftests: ftrace: Add synthetic event syntax testcase tracing: Fix synthetic event to allow semicolon at end tracing: Fix synthetic event to accept unsigned modifier
2018-10-20Merge branch 'for-linus' of ↵Greg Kroah-Hartman1-0/+1
git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input Dmitry writes: "Input updates for 4.19-rc8 Just an addition to elan touchpad driver ACPI table." * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input: Input: elan_i2c - add ACPI ID for Lenovo IdeaPad 330-15IGM
2018-10-20Merge tag 'drm-misc-fixes-2018-10-19' of ↵Dave Airlie4-5/+35
git://anongit.freedesktop.org/drm/drm-misc into drm-fixes Second pull request for v4.19: - Fix ulong overflow in sun4i - Fix a serious GPF in waiting for flip_done from commit_tail(). Signed-off-by: Dave Airlie <[email protected]> From: Maarten Lankhorst <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
2018-10-19selftests: ftrace: Add synthetic event syntax testcaseMasami Hiramatsu1-0/+80
Add a testcase to check the syntax and field types for synthetic_events interface. Link: http://lkml.kernel.org/r/153986838264.18251.16627517536956299922.stgit@devbox Acked-by: Shuah Khan <[email protected]> Signed-off-by: Masami Hiramatsu <[email protected]> Signed-off-by: Steven Rostedt (VMware) <[email protected]>
2018-10-19tracing: Fix synthetic event to allow semicolon at endMasami Hiramatsu1-1/+1
Fix synthetic event to allow independent semicolon at end. The synthetic_events interface accepts a semicolon after the last word if there is no space. # echo "myevent u64 var;" >> synthetic_events But if there is a space, it returns an error. # echo "myevent u64 var ;" > synthetic_events sh: write error: Invalid argument This behavior is difficult for users to understand. Let's allow the last independent semicolon too. Link: http://lkml.kernel.org/r/153986835420.18251.2191216690677025744.stgit@devbox Cc: Shuah Khan <[email protected]> Cc: Tom Zanussi <[email protected]> Cc: [email protected] Fixes: commit 4b147936fa50 ("tracing: Add support for 'synthetic' events") Signed-off-by: Masami Hiramatsu <[email protected]> Signed-off-by: Steven Rostedt (VMware) <[email protected]>
2018-10-19tracing: Fix synthetic event to accept unsigned modifierMasami Hiramatsu1-6/+24
Fix synthetic event to accept unsigned modifier for its field type correctly. Currently, synthetic_events interface returns error for "unsigned" modifiers as below; # echo "myevent unsigned long var" >> synthetic_events sh: write error: Invalid argument This is because argv_split() breaks "unsigned long" into "unsigned" and "long", but parse_synth_field() doesn't expected it. With this fix, synthetic_events can handle the "unsigned long" correctly like as below; # echo "myevent unsigned long var" >> synthetic_events # cat synthetic_events myevent unsigned long var Link: http://lkml.kernel.org/r/153986832571.18251.8448135724590496531.stgit@devbox Cc: Shuah Khan <[email protected]> Cc: Tom Zanussi <[email protected]> Cc: [email protected] Fixes: commit 4b147936fa50 ("tracing: Add support for 'synthetic' events") Signed-off-by: Masami Hiramatsu <[email protected]> Signed-off-by: Steven Rostedt (VMware) <[email protected]>
2018-10-19Revert "bond: take rcu lock in netpoll_send_skb_on_dev"David S. Miller1-2/+0
This reverts commit 6fe9487892b32cb1c8b8b0d552ed7222a527fe30. It is causing more serious regressions than the RCU warning it is fixing. Signed-off-by: David S. Miller <[email protected]>
2018-10-19Merge tag 'usb-4.19-final' of ↵Greg Kroah-Hartman7-27/+65
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb I wrote: "USB fixes for 4.19-final Here are a small number of last-minute USB driver fixes Included here are: - spectre fix for usb storage gadgets - xhci fixes - cdc-acm fixes - usbip fixes for reported problems All of these have been in linux-next with no reported issues." * tag 'usb-4.19-final' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb: usb: gadget: storage: Fix Spectre v1 vulnerability USB: fix the usbfs flag sanitization for control transfers usb: xhci: pci: Enable Intel USB role mux on Apollo Lake platforms usb: roles: intel_xhci: Fix Unbalanced pm_runtime_enable cdc-acm: correct counting of UART states in serial state notification cdc-acm: do not reset notification buffer index upon urb unlinking cdc-acm: fix race between reset and control messaging usb: usbip: Fix BUG: KASAN: slab-out-of-bounds in vhci_hub_control() selftests: usbip: add wait after attach and before checking port status
2018-10-19Merge tag 'for-linus-20181019' of git://git.kernel.dk/linux-blockGreg Kroah-Hartman2-27/+3
Jens writes: "Block fixes for 4.19-final Two small fixes that should go into this release." * tag 'for-linus-20181019' of git://git.kernel.dk/linux-block: block: don't deal with discard limit in blkdev_issue_discard() nvme: remove ns sibling before clearing path
2018-10-19drm/sun4i: Fix an ulong overflow in the dotclock driverBoris Brezillon1-1/+11
The calculated ideal rate can easily overflow an unsigned long, thus making the best div selection buggy as soon as no ideal match is found before the overflow occurs. Fixes: 4731a72df273 ("drm/sun4i: request exact rates to our parents") Cc: <[email protected]> Signed-off-by: Boris Brezillon <[email protected]> Acked-by: Maxime Ripard <[email protected]> Signed-off-by: Maxime Ripard <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
2018-10-19Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/netGreg Kroah-Hartman57-187/+253
David writes: "Networking 1) Fix gro_cells leak in xfrm layer, from Li RongQing. 2) BPF selftests change RLIMIT_MEMLOCK blindly, don't do that. From Eric Dumazet. 3) AF_XDP calls synchronize_net() under RCU lock, fix from Björn Töpel. 4) Out of bounds packet access in _decode_session6(), from Alexei Starovoitov. 5) Several ethtool bugs, where we copy a struct into the kernel twice and our validations of the values in the first copy can be invalidated by the second copy due to asynchronous updates to the memory by the user. From Wenwen Wang. 6) Missing netlink attribute validation in cls_api, from Davide Caratti. 7) LLC SAP sockets neet to be SOCK_RCU FREE, from Cong Wang. 8) rxrpc operates on wrong kvec, from Yue Haibing. 9) A regression was introduced by the disassosciation of route neighbour references in rt6_probe(), causing probe for neighbourless routes to not be properly rate limited. Fix from Sabrina Dubroca. 10) Unsafe RCU locking in tipc, from Tung Nguyen. 11) Use after free in inet6_mc_check(), from Eric Dumazet. 12) PMTU from icmp packets should update the SCTP transport pathmtu, from Xin Long. 13) Missing peer put on error in rxrpc, from David Howells. 14) Fix pedit in nfp driver, from Pieter Jansen van Vuuren. 15) Fix overflowing shift statement in qla3xxx driver, from Nathan Chancellor. 16) Fix Spectre v1 in ptp code, from Gustavo A. R. Silva. 17) udp6_unicast_rcv_skb() interprets udpv6_queue_rcv_skb() return value in an inverted manner, fix from Paolo Abeni. 18) Fix missed unresolved entries in ipmr dumps, from Nikolay Aleksandrov. 19) Fix NAPI handling under high load, we can completely miss events when NAPI has to loop more than one time in a cycle. From Heiner Kallweit." * git://git.kernel.org/pub/scm/linux/kernel/git/davem/net: (49 commits) ip6_tunnel: Fix encapsulation layout tipc: fix info leak from kernel tipc_event net: socket: fix a missing-check bug net: sched: Fix for duplicate class dump r8169: fix NAPI handling under high load net: ipmr: fix unresolved entry dumps net: mscc: ocelot: Fix comment in ocelot_vlant_wait_for_completion() sctp: fix the data size calculation in sctp_data_size virtio_net: avoid using netif_tx_disable() for serializing tx routine udp6: fix encap return code for resubmitting mlxsw: core: Fix use-after-free when flashing firmware during init sctp: not free the new asoc when sctp_wait_for_connect returns err sctp: fix race on sctp_id2asoc r8169: re-enable MSI-X on RTL8168g net: bpfilter: use get_pid_task instead of pid_task ptp: fix Spectre v1 vulnerability net: qla3xxx: Remove overflowing shift statement geneve, vxlan: Don't set exceptions if skb->len < mtu geneve, vxlan: Don't check skb_dst() twice sctp: get pr_assoc and pr_stream all status with SCTP_PR_SCTP_ALL instead ...
2018-10-19Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparcGreg Kroah-Hartman2-2/+14
David writes: "Sparc fixes: The main bit here is fixing how fallback system calls are handled in the sparc vDSO. Unfortunately, I fat fingered the commit and some perf debugging hacks slipped into the vDSO fix, which I revert in the very next commit." * git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc: sparc: Revert unintended perf changes. sparc: vDSO: Silence an uninitialized variable warning sparc: Fix syscall fallback bugs in VDSO.
2018-10-19Merge tag 'drm-fixes-2018-10-19' of git://anongit.freedesktop.org/drm/drmGreg Kroah-Hartman4-72/+40
Dave writes: "drm fixes for 4.19 final Just a last set of misc core fixes for final. 4 fixes, one use after free, one fb integration fix, one EDID fix, and one laptop panel quirk," * tag 'drm-fixes-2018-10-19' of git://anongit.freedesktop.org/drm/drm: drm/edid: VSDB yCBCr420 Deep Color mode bit definitions drm: fix use of freed memory in drm_mode_setcrtc drm: fb-helper: Reject all pixel format changing requests drm/edid: Add 6 bpc quirk for BOE panel in HP Pavilion 15-n233sl
2018-10-19Merge tag 'for-gkh' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdmaGreg Kroah-Hartman2-0/+6
Doug writes: "Really final for-rc pull request for 4.19 Ok, so last week I thought we had sent our final pull request for 4.19. Well, wouldn't ya know someone went and found a couple Spectre v1 fixes were needed :-/. So, a couple *very* small specter patches for this (hopefully) final -rc week." * tag 'for-gkh' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma: RDMA/ucma: Fix Spectre v1 vulnerability IB/ucm: Fix Spectre v1 vulnerability
Powered by cgit, Gruvboxed by Blaster4385.