aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-09-20staging: i4l: act2000: Move assignment out of if statementsayli karnik1-1/+2
This patch places assignments which are inside the if condition, above it. Done using coccinelle: @@ statement s; expression e; identifier id; @@ - if ((id = e)) + id = e; + if (id) s Signed-off-by: sayli karnik <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: i4l: Remove unused variableSandhya Bankar1-2/+0
Remove unused variable. This change is made by below coccinelle script: @@ type T; identifier i; constant C; @@ ( extern T i; | - T i; <+... when != i - i = C; ...+> ) Signed-off-by: Sandhya Bankar <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: i4l: Use !x instead of x == NULL.Sandhya Bankar1-1/+1
Use !x instead of x == NULL. This issue was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: i4l: Do not initialise statics to 0.Sandhya Bankar1-1/+1
Do not initialise statics to 0. Static variable by default initialise to 0, so no need to explicit initialisation. This issue was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: i4l: Remove NULL comparison.Sandhya Bankar1-2/+2
This patch removes the explicit NULL comparison. This issue was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: iio: isl29018: remove the FSF's mailing addressBrian Masney1-4/+0
Address warning from checkpatch: CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Signed-off-by: Brian Masney <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: iio: meter: ade7754: Match alignment with open parenthesisGeorgiana Rodica Chelu1-34/+25
Reorganize the parameters to improve the readability of the code in two manners: - parameters of distinctive variable types on different lines - parameters of similar variable types on the same line Also, take advantage of the horizontal space available and place all the parameters on a single line. Issues found by checkpatch.pl script. Signed-off-by: Georgiana Rodica Chelu <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: iio: meter: ade7758_ring: Match alignment with open parenthesisGeorgiana Rodica Chelu1-7/+3
Organize the parameters on a single line to improve the readability of the code. Also, indent the line to match alignment with the open parenthesis. Ensure that the modifications do not break the rule of 80 characters per line. Issues found by checkpatch.pl script. Signed-off-by: Georgiana Rodica Chelu <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: dgnc: Merge assignment with returnRehas Sachdeva1-7/+5
Instead of storing the return value of a function call into a variable and then returning it, we can club the two into a single return statement. This change was made using the following semantic patch by Coccinelle: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rtl8188eu: core: rtw_xmit: Remove extra bracesGeorgiana Rodica Chelu1-12/+7
Remove the braces {} in the following cases: - when there is a single branch with a single statement. - when both branches have a single statement The modifications improve the coding style. Issues found by checkpatch.pl script. Signed-off-by: Georgiana Rodica Chelu <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: rtl8712: rtl871x_cmd: Use !x instead of x == NULL.Sandhya Bankar1-11/+11
Use !x instead of x == NULL. This patch was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: rtl8712: rtl8712_xmit: Use !x instead of x == NULLSandhya Bankar1-1/+1
Use !x instead of x == NULL. This patch was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: rtl8712: rtl8712_recv: Use !x instead of x == NULLSandhya Bankar1-6/+6
Use !x instead of x == NULL. This patch was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: rtl8712: rtl8712_efuse: Use !x instead of x == NULL.Sandhya Bankar1-1/+1
Use !x instead of x == NULL. This patch was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rtl8192e: Insert blank line after function declarationNamrata A Shettar1-0/+1
Insert blank line after function declaration to resolve checkpatch issue. Signed-off-by: Namrata A Shettar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rtl8192e: Add space around binary operator '+'Namrata A Shettar1-2/+2
Add space around binary operator '+' to resolve checkpatch issue. Signed-off-by: Namrata A Shettar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rtl8192e: Remove unnecessary blank linesNamrata A Shettar1-2/+0
Remove unneccessary blank lines to resolve checkpatch issue. Signed-off-by: Namrata A Shettar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rtl8192e: Add space around '+'Namrata A Shettar1-5/+5
Add space around '+' to resolve checkpatch issue. Signed-off-by: Namrata A Shettar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20Staging: rtl8192u: Remove useless type conversionBhumika Goyal5-13/+13
Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by: Bhumika Goyal <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: rtl8192u: r8192U_core: fix checkpatch permission warningsXavier Roumegue1-3/+3
Fix the following warnings: Symbolic permissions are not preferred. Consider using octal permissions. Signed-off-by: Xavier Roumegue <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: remove GET_HAL_DATA macroIvan Safonov15-187/+124
GET_HAL_DATA replaced by its definition. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: remove GET_RF_TYPE macroIvan Safonov1-1/+0
This macro does not used. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: set correct type for HalData member of adapter structureIvan Safonov1-1/+1
To avoid unnecessary typecast. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: remove HW_VAR_DM_FLAG member of hw_variables enumerationIvan Safonov2-8/+0
rtw_hal_set_hwreg and rtw_hal_get_hwreg does not used with HW_VAR_DM_FLAG parameter. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: remove usb_hal.hIvan Safonov5-23/+0
usb_hal.h is empty. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: remove rtl8188eu_set_hal_ops functionIvan Safonov3-11/+5
rtl8188eu_set_hal_ops only allocates HalData member of adapter structure. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: replace N_BYTE_ALIGMENT macro with PTR_ALIGNIvan Safonov4-9/+5
PTR_ALIGN is a bit shorter than N_BYTE_ALIGMENT. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: delete rtw_usb_bulk_size_boundary functionIvan Safonov1-15/+0
This function does not used. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: remove pkt_hdrlen member of pkt_attrib structureIvan Safonov2-4/+1
pkt_hdrlen has a constant value. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: remove xmitframe_direct functionIvan Safonov1-13/+6
xmitframe_direct is a simple wrapper around rtw_xmitframe_coalesce and rtw_dump_xframe functions. Many wrappers complicates code reading. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: r8188eu: change last argument type of the usb_write_port functionIvan Safonov3-18/+17
usb_write_port writes only xmit_buf object data to device. In addition, an appropriate name for this argument is used. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: wilc1000: Merge assignment with returnRehas Sachdeva3-8/+3
Instead of storing the return value into a variable and then returning it, we can club the two into a single return statement. This change was made using the following semantic patch by Coccinelle: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move parahotplug_request_list and related lockDavid Kershner1-3/+3
parahotplug_request_list and parahotplug_request_list_lock should be defined closer to where we are actually using them. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: remove fix_vbus_dev_info prototypeDavid Kershner1-129/+127
Move the visordriver_probe_device and visorbus_register_visor_driver functions lower in the file to get rid of the function prototype fix_vbus_dev_info. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus move visorbus_type to remove prototypesDavid Kershner1-14/+12
Move the struct visorbus_type down in the file to get rid of the function prototypes visorbus_uevent and visorbus_match. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move deviceenabled/disabled store functionsDavid Kershner1-213/+205
Move the deviceenabled/devicedisabled store functions so that function prototypes can be removed. This caused us to move several of the structures farther down in the file as well. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move the remaining_steps_show/store functionsDavid Kershner1-34/+28
Moving the remaining_steps functions allows us to get rid of an unneeded prototype. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move textid store and show functionsDavid Kershner1-34/+29
The textid store and show functions were moved to allow us to remove the function prototypes. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move error store/show functionsDavid Kershner1-33/+28
Move the show and store functions for the error DEV_ATTR_RW so that the function prototypes can be removed. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: remove parser_done prototypeDavid Kershner1-3/+0
Remove the unneeded prototype parser_done. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: remove controlvm_respond_physdev_changestateDavid Kershner1-4/+0
Remove the unneeded prototype declaration for function controlvm_respond_physdev_changestate. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move parser_init_byte_streamDavid Kershner1-58/+58
The function parser_init_byte_stream needs to be moved lower in the file to avoid extraneous function prototypes. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move boottotoolDavid Kershner1-39/+33
Move the boottotool show and store functions so the function prototypes can be removed. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move toolaction functions to remove prototypesDavid Kershner1-35/+29
The toolchain functions show and store needed to be moved so the prototypes were no longer needed. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: remove controlvm_respond_chipset_init prototypeDavid Kershner1-33/+30
Remove the unneeded controlvm_respond_chipset_init prototype by moving the functions controlvm_init_response and controlvm_respond_chipset_init up in the file. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: remove prototype controlvm_respondDavid Kershner1-2/+0
Remove the unneeded prototype for controlvm_respond. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move parahotplug_process_listDavid Kershner1-32/+31
The function parahotplug_process_list needs to be moved lower in the file to avoid extraneous function prototypes. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move read_controlvm_eventDavid Kershner1-21/+21
The function read_controlvm_event needs to be moved lower in the file to avoid extraneous function prototypes. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: move handle_commandDavid Kershner1-115/+115
Handle_command gets moved lower in the file to avoid the need for extraneous function prototypes. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-20staging: unisys: visorbus: reorder controlvm_periodic_workDavid Kershner1-67/+67
Move controlvm_periodic_work lower in the file to avoid having to create function prototypes. Reported-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.