| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Trivial fix to spelling mistake in dev_dbg message
Signed-off-by: Colin Ian King <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch solves the code indentation issue inside the if block
Signed-off-by: Janani Sankara Babu <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The fusb302 Type-C port-controller cannot control the current-limit
directly, so we need to exported the limit so that another driver
(e.g. the charger driver) can pick the limit up and configure the
system accordingly.
The power-supply subsys already provides infrastructure for this,
power-supply devices have the notion of being supplied by another
power-supply and have properties through which we can export the
current-limit.
Register a power_supply and export the current-limit through the
power_supply's current-max property.
Cc: "Yueyao (Nathan) Zhu" <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The fusb302 port-controller relies on an external device doing USB2
charger-type detection.
The Intel Whiskey Cove PMIC with which the fusb302 is combined on some
X86/ACPI platforms already has a charger-type detection driver which
uses extcon to communicate the detected charger-type.
Rather then inventing a new API for USB2 charger-type detection
specifically for use with the tcpm code, this commit simply re-uses the
existing extcon API and uses that do USB2 charger detection.
Note that the "fcs,extcon-name" property name is only for kernel internal
use by X86/ACPI platform code and as such is NOT documented in
the fusb302 devicetree bindings.
Cc: "Yueyao (Nathan) Zhu" <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The fusb302 is also used on x86 systems where the platform code sets
the irq in client->irq and there is no gpio named fcs,int_n.
Cc: "Yueyao (Nathan) Zhu" <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This is board specific info so it should come from board config, such
as devicetree.
I've chosen to prefix these with "fcs," treating them as fusb302 driver
specific for now. We may want to revisit this and replace these with
properties which are part of a (to be written) generic type-c controller
devicetree binding.
Since this commit adds new dt-properties it also adds devicetree-bindings
documentation (which so far was absent for the fusb302 driver).
Cc: Rob Herring <[email protected]>
Cc: Frank Rowand <[email protected]>
Cc: [email protected]
Cc: "Yueyao (Nathan) Zhu" <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
Acked-by: Rob Herring <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Anything higher then 5V may damage hardware not capable of it, so
the only sane default here is 5V. If a board is able to handle a
higher voltage that should come from board specific data such as
device-tree and not be hard coded into the fusb302 code.
Cc: "Yueyao (Nathan) Zhu" <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
A Rp signalling the default current limit indicates that we're possibly
connected to an USB2 power-source. In some cases the type-c port-controller
may provide the capability to detect the current-limit in this case,
through e.g. BC1.2 detection.
This commit adds an optional get_current_limit tcpc_dev callback which
allows the port-controller to provide current-limit detection for when
the CC pin is pulled up with Rp.
Signed-off-by: Hans de Goede <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch makes use of predefined identifier __func__ inorder to clear
the warning: Prefer using '"%s...", __func__' to using 'update_bmc_sta',
this function's name, in a string
Signed-off-by: Janani Sankara Babu <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The patch removes "WARNING: Prefer using '"%s...", __func__'
to using 'xxxxxxxx', this function's name, in a string" warnings
reported by checkpatch.pl script.
Signed-off-by: Simo Koskinen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fixed paranthesis alignment for compliance with checkpatch.
Signed-off-by: Edvard Holst <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Changing pr_err to dev_err in visor_check_channel. Added device
as an argument to visor_check_channel to pass into dev_err.
Signed-off-by: Sameer Wadgaonkar <[email protected]>
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Removing EXPORT_SYMBOL_GPU from visor_check_channel since it is
used only in visorbus.
Signed-off-by: Sameer Wadgaonkar <[email protected]>
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fix up the GUID definition to remove some checkpatch warnings as well as
using the whole width of the screen.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Every channel_type must have a valid GUID, checking for the name was just
redundant.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The size of the channel should be pulled from the channel header, not
from the message. All channels must be at least the size of the
channel_header.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Removes unnecessary return value in send_rcv_posts_if_needed(), since
NAPI polling functions do not return errors.
Signed-off-by: David Binder <[email protected]>
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The file visorchipset had a bunch of comments that were not using the full
screen before they wrapped, update the comments to wrap at 80 characters
instead.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Shorten the name of the function parser_init_byte_stream to just
parser_init_stream.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The parser functions were defined at the top of the file even though they
were not referenced until later in the file. This patch moves them closer
to where they are defined so they can be easily referenced.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Several variables were initialized when not needed. Remove the extraneous
initializations.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The function visorutil_spar_detect had an if clause that returns from the
function, no need to do the rest of the code in an else clause.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The data field was being defined as a character array and then casted into
a visor_controlvm_parameters_header structure. This patch converts it to
just point to the visor_controlvm_parameters_header structure. The data
following the header is still behind the header_info.
Reported-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Visorbus_configure had a block of "else if" clauses at the beginning of the
function. Simplify this to just being "if" clauses since each code block
ended with a goto.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The variable parm_addr will never be null, so no need to check for it.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The variable ctx was allocated with kzalloc, so all the data inside is
zero, no need to reset it to 0.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Currently setting it in the right location, so no longer not sure.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The functions to create the controlvm channel were disjointed and ignoring
information that was available. This patch consolidates it so it clearer
what is happening.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Checkpatch reports an error that no comment was next to the mutex lock.
Add an appropriate message for the lock.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The macro to convert to the driver object was giving a checkpatch warning
when it ateempted to check for a null driver. It would return NULL if it
found it, but only one location was checking to see if it was NULL.
Remove the check in the MACRO and do it prior to calling the macro if
required.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The dev_err was using the hardcoded function name, as reported by
checkpatch, it should be using __func__.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Several macros in visorchannel.c were doing complex arithmetic, converted
them to functions so that valid type checking could be done.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fixed the following checkpatch warning:
visorchannel.c:443: CHECK: Alignment should match open parenthesis
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The function vmcall address needed to be cleaned up. The structure
vmcall_controlvm_addr was not needed so it was removed and was replaced
with vmcall_io_controlvm_addr_params since it needs to be allocated on the
heap for DMA access.
With the structure removed and the fields as local variables, it helped
clean up the formatting of the function.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fixes miscellaneous formatting issues with several block comments
throughout visornic_main.c.
Signed-off-by: David Binder <[email protected]>
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Refactors existing static function comments to increase code readability.
Signed-off-by: David Binder <[email protected]>
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
visorbus_register_visor_driver.
The error return values for the drv->probe, drv->remove, drv->pause
and drv->resume checks should be -EINVAL instead of -ENODEV.
Reported-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Sameer Wadgaonkar <[email protected]>
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes a bug in the function parser_init_byte_stream()
by removing the call to parser_done from goto err_finish_ctx.
The function parser_done() decrements
chipset_dev->controlvm_payload_bytes_buffered which is not
incremented before this gets called.
Signed-off-by: Sameer Wadgaonkar <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The kernel already provides a min function, we should be using that
instead of creating our own MINNUM.
Reviewed-by: Sameer Wadgaonkar <[email protected]>
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Removed printk statements for debugging. The same information can be
acquired via ftrace, so these print statements are uneccessary.
Signed-off-by: Jonathan Whitaker <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Make this const as it is not modified anywhere.
Signed-off-by: Bhumika Goyal <[email protected]>
Acked-by: Shuah Khan <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Move the USB phy NULL checking before issuing usb_phy_set_charger_current()
to avoid unchecked dereference warning.
Signed-off-by: Baolin Wang <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Make this const as it is not modified anywhere.
Signed-off-by: Bhumika Goyal <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Make this structure const as it is not modified. And replace __initdata
with __initconst to avoid section conflict error.
Signed-off-by: Bhumika Goyal <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The mt8173-mtu3.txt actually holds the bindings for all mediatek
SoCs with usb3 DRD IP, so add a generic compatible and change the
name to mediatek,mtu3.txt.
Signed-off-by: Chunfeng Yun <[email protected]>
Acked-by: Rob Herring <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The mt8173-xhci.txt actually holds the bindings for all mediatek
SoCs with xHCI controller, so add a generic compatible and change
the name to mediatek,mtk-xhci.txt to reflect that.
Signed-off-by: Chunfeng Yun <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The xhci-mtk driver is a generic driver for MediaTek xHCI IP, add
a generic compatible to avoid confusion when support new SoCs but
use a compatible with specific SoC's name "mt8173".
Signed-off-by: Chunfeng Yun <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch adds recovery from false busy state on concurrent attach
operation.
The procedure of attach operation is as below.
1) Find an unused port in /sys/devices/platform/vhci_hcd/status.
(userspace)
2) Request attach found port to driver through
/sys/devices/platform/vhci_hcd/attach. (userspace)
3) Lock table, reserve requested port and unlock table. (vhci driver)
Attaching more than one remote devices concurrently, same unused port
number will be found in step-1. Then one request will succeed and
others will fail even though there are some unused ports.
With this patch, driver returns EBUSY when requested port has already
been used. In this case, attach command retries from step-1: finding
another unused port. If there's no unused port, the attach operation
will fail in step-1. Otherwise it retries automatically using another
unused port.
vhci-hcd's interface (only errno) is changed as following.
Current errno New errno Condition
EINVAL same as left specified port number is in invalid
range
EAGAIN same as left platform_get_drvdata() failed
EINVAL same as left specified socket fd is not valid
EINVAL EBUSY specified port status is not free
The errno EBUSY was not used in userspace
src/usbip_attach.c:import_device(). It is needed to distinguish the
condition to be able to retry from other unrecoverable errors.
It is possible to avoid this failure by introducing userspace exclusive
control. But it's exaggerated for this special condition. The locking
itself has done in driver.
As an alternate solution, userspace doesn't specify port number, driver
searches unused port and it returns port number to the userspace. With
this solution, the interface is much different than this patch.
Signed-off-by: Nobuo Iwata <[email protected]>
Acked-by: Shuah Khan <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The kerneldoc comment for the genpool_algo_t typedef was incomplete and
incorrectly formatted, leading to a raft of warnings during the docs build.
Fix it appropriately.
Signed-off-by: Jonathan Corbet <[email protected]>
|
|
For LS1046a and LS1043a v1.1, the MSI controller has 4 MSIRs and 4 GIC
SPI interrupts which can be associated with different Core.
So we can support affinity to improve the performance.
The MSI message data is a byte for Layerscape MSI.
7 6 5 4 3 2 1 0
| - | IBS | SRS |
SRS bit0-1 is to select a MSIR which is associated with a CPU.
IBS bit2-6 of ls1046, bit2-4 of ls1043a v1.1 is to select bit of the
MSIR. With affinity, only bits of MSIR0(srs=0 cpu0) are available.
All other bits of the MSIR1-3(cpu1-3) are reserved. The MSI hwirq
always equals bit index of the MSIR0. When changing affinity, MSI
message data will be appended corresponding SRS then MSI will be
moved to the corresponding core.
But in affinity mode, there is only 8 MSI interrupts for a controller
of LS1043a v1.1. It cannot meet the requirement of the some PCIe
devices such as 4 ports Ethernet card. In contrast, without affinity,
all MSIRs can be used for core 0, the MSI interrupts can up to 32.
So the parameter is added to control affinity mode.
"lsmsi=no-affinity" will disable affinity and increase MSI
interrupt number.
Signed-off-by: Minghuan Lian <[email protected]>
Signed-off-by: Hou Zhiqiang <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
|