aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-03-29staging: rtl8723bs: Fix lines too long in update_recvframe_attrib().Quytelda Kahja1-8/+22
Fix lines over the 80 character limit in update_recvframe_attrib(). Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Remove unnecessary blank lines in 'rtl8723bs_recv.c'.Quytelda Kahja1-7/+0
Condense multiple blank lines to one, and remove blank lines before braces. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Change camel case to snake case in 'rtl8723bs_recv.c'.Quytelda Kahja1-16/+16
Linux kernel coding style dictates the use of snake case for variable naming. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Add missing braces in else statement.Quytelda Kahja1-1/+2
The style rule to leave out braces in single line conditional statements doesn't apply when one branch is multiple lines. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Add spaces around ternary operators.Quytelda Kahja1-1/+1
The Linux kernel coding style calls for spaces around binary and ternary operators. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Fix lines with trailing open parentheses.Quytelda Kahja1-6/+5
Realign the arguments for update_recvframe_attrib() and update_recvframe_phyinfo() so there is no trailing open parenthesis. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Remove unnecessary length #define's.Quytelda Kahja2-19/+3
This driver statically defines constants representing the size of certain structs using literal integers as values. Replace those constants with the sizeof() macro. Other length constants are already defined in 'linux/ieee80211.h'; remove those #define's. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Fix IEEE80211 authentication algorithm constants.Quytelda Kahja2-12/+8
This driver's local ieee80211 include file defines the constants AUTH_ALG_* to represent authenication algorithm options. However, these constants are defined in 'linux/ieee80211.h' as WLAN_AUTH_*, and have the correct values. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Fix alignment in rtw_wx_set_auth().Quytelda Kahja1-3/+3
Realign the function parameters and comment blocks to match the kernel coding style. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Remove braces from single statement conditionals.Quytelda Kahja1-9/+9
Several conditionals in rtw_wx_set_auth() contain a comment then a single statement. Move the comments to the top of the conditionals so that braces can be removed from the statements, which saves space and makes the code more readable. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Remove unecessary braces from switch statement.Quytelda Kahja1-27/+23
The switch statement in rtw_wx_set_auth() wraps individual cases in braces for no reason. Remove those braces and unindent the code. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Fix newlines in rtw_wx_set_auth().Quytelda Kahja1-9/+1
There are a lot of extra newlines in this function that waste space. Remove those newlines, but add one newline before the return statement. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Replace RTW_IEEE80211_STYPE_* with IEEE80211_STYPE_*.Quytelda Kahja3-45/+2
This driver defines the constants RTW_IEEE80211_STYPE_*, but all these values are already defined in 'linux/ieee80211.h' as IEEE80211_STYPE_*. Remove the locally defined constants, and substitute the kernel constants. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Replace RTW_IEEE80211_FTYPE_* with IEEE80211_FTYPE_*.Quytelda Kahja3-8/+3
This driver defines the constants RTW_IEEE80211_FTYPE_*, but all these values are already defined in 'linux/ieee80211.h' as IEEE80211_FTYPE_*. Remove the locally defined constants, and substitute the kernel constants. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Replace RTW_IEEE80211_FCTL_* with IEEE80211_FCTL_*.Quytelda Kahja3-20/+6
This driver defines the constants RTW_IEEE80211_FCTL_* for frame control constants, but all these values are already defined in 'linux/ieee80211.h' as IEEE80211_FCTL_*. Remove the locally defined constants, and substitute the kernel constants. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: rtl8723bs: Remove #defines shadowing enums in 'linux/ieee80211.h'Quytelda Kahja1-56/+0
The modified file includes 'linux/ieee80211.h', but #define's many constants that shadow enum members in the header. This will create a conflict if the values are ever changed in the kernel. Remove these Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29drivers: staging: rtl8192e: fixed a space coding style issueRene Hickersberger1-1/+1
There was a weird space before the struct which is now removed. Signed-off-by: Rene Hickersberger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: r8822be: fix typos in header guard macrosColin Ian King2-2/+2
The macros for __PHYDMKFREE_H__ and __PHYDM_FEATURES_H__ contain typos and don't match the #if guard check. Defined them correctly. Cleans up clang warnings: warning: '__PHYDMKFREE_H__' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] warning: '__PHYDM_FEATURES_H__' is used as a header guard here, followed by #define of a different macro [-Wheader-guard] Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: bcm2835-audio: Release resources on module_exit()Kirill Marinushkin1-29/+25
In the current implementation, `rmmod snd_bcm2835` does not release resources properly. It causes an oops when trying to list sound devices. This commit fixes it. The details WRT allocation / free are described below. Device structure WRT allocation: pdev \childdev[] \card \chip \pcm \ctl Allocation / register sequence: * childdev: devm_kzalloc - freed during driver detach * childdev: device_initialize - freed during device_unregister * pdev: devres_alloc - freed during driver detach * childdev: device_add - removed during device_unregister * pdev, childdev: devres_add - freed during driver detach * card: snd_card_new - freed during snd_card_free * chip: kzalloc - freed during kfree * card, chip: snd_device_new - freed during snd_device_free * chip: new_pcm - TODO: free pcm * chip: new_ctl - TODO: free ctl * card: snd_card_register - unregistered during snd_card_free Free / unregister sequence: * card: snd_card_free * card, chip: snd_device_free * childdev: device_unregister * chip: kfree Steps to reproduce the issue before this commit: ~~~~ $ rmmod snd_bcm2835 $ aplay -L [ 138.648130] Unable to handle kernel paging request at virtual address 7f1343c0 [ 138.660415] pgd = ad8f0000 [ 138.665567] [7f1343c0] *pgd=3864c811, *pte=00000000, *ppte=00000000 [ 138.674887] Internal error: Oops: 7 [#1] SMP ARM [ 138.683571] Modules linked in: sha256_generic cfg80211 rfkill snd_pcm snd_timer snd fixed uio_pdrv_genirq uio ip_tables x_tables ipv6 [last unloaded: snd_bcm2835 ] [ 138.706594] CPU: 3 PID: 463 Comm: aplay Tainted: G WC 4.15.0-rc1-v 7+ #6 [ 138.719833] Hardware name: BCM2835 [ 138.726016] task: b877ac00 task.stack: aebec000 [ 138.733408] PC is at try_module_get+0x38/0x24c [ 138.740813] LR is at snd_ctl_open+0x58/0x194 [snd] [ 138.748485] pc : [<801c4d5c>] lr : [<7f0e6b2c>] psr: 20000013 [ 138.757709] sp : aebedd60 ip : aebedd88 fp : aebedd84 [ 138.765884] r10: 00000000 r9 : 00000004 r8 : 7f0ed440 [ 138.774040] r7 : b7e469b0 r6 : 7f0e6b2c r5 : afd91900 r4 : 7f1343c0 [ 138.783571] r3 : aebec000 r2 : 00000001 r1 : b877ac00 r0 : 7f1343c0 [ 138.793084] Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 138.803300] Control: 10c5387d Table: 2d8f006a DAC: 00000055 [ 138.812064] Process aplay (pid: 463, stack limit = 0xaebec210) [ 138.820868] Stack: (0xaebedd60 to 0xaebee000) [ 138.828207] dd60: 00000000 b848d000 afd91900 00000000 b7e469b0 7f0ed440 aebedda4 aebedd88 [ 138.842371] dd80: 7f0e6b2c 801c4d30 afd91900 7f0ea4dc 00000000 b7e469b0 aebeddcc aebedda8 [ 138.856611] dda0: 7f0e250c 7f0e6ae0 7f0e2464 b8478ec0 b7e469b0 afd91900 7f0ea388 00000000 [ 138.870864] ddc0: aebeddf4 aebeddd0 802ce590 7f0e2470 8090ab64 afd91900 afd91900 b7e469b0 [ 138.885301] dde0: afd91908 802ce4e4 aebede1c aebeddf8 802c57b4 802ce4f0 afd91900 aebedea8 [ 138.900110] de00: b7fa4c00 00000000 00000000 00000004 aebede3c aebede20 802c6ba8 802c56b4 [ 138.915260] de20: aebedea8 00000000 aebedf5c 00000000 aebedea4 aebede40 802d9a68 802c6b58 [ 138.930661] de40: b874ddd0 00000000 00000000 00000001 00000041 00000000 afd91900 aebede70 [ 138.946402] de60: 00000000 00000000 00000002 b7e469b0 b8a87610 b8d6ab80 801852f8 00080000 [ 138.962314] de80: aebedf5c aebedea8 00000001 80108464 aebec000 00000000 aebedf4c aebedea8 [ 138.978414] dea0: 802dacd4 802d970c b8a87610 b8d6ab80 a7982bc6 00000009 af363019 b9231480 [ 138.994617] dec0: 00000000 b8c038a0 b7e469b0 00000101 00000002 00000238 00000000 00000000 [ 139.010823] dee0: 00000000 aebedee8 00080000 0000000f aebedf3c aebedf00 802ed7e4 80843f94 [ 139.027025] df00: 00000003 00080000 b9231490 b9231480 00000000 00080000 af363000 00000000 [ 139.043229] df20: 00000005 00000002 ffffff9c 00000000 00080000 ffffff9c af363000 00000003 [ 139.059430] df40: aebedf94 aebedf50 802c6f70 802dac70 aebec000 00000000 00000001 00000000 [ 139.075629] df60: 00020000 00000004 00000100 00000001 7ebe577c 0002e038 00000000 00000005 [ 139.091828] df80: 80108464 aebec000 aebedfa4 aebedf98 802c7060 802c6e6c 00000000 aebedfa8 [ 139.108025] dfa0: 801082c0 802c7040 7ebe577c 0002e038 7ebe577c 00080000 00000b98 e81c8400 [ 139.124222] dfc0: 7ebe577c 0002e038 00000000 00000005 7ebe57e4 00a20af8 7ebe57f0 76f87394 [ 139.140419] dfe0: 00000000 7ebe55c4 76ec88e8 76df1d9c 60000010 7ebe577c 00000000 00000000 [ 139.156715] [<801c4d5c>] (try_module_get) from [<7f0e6b2c>] (snd_ctl_open+0x58/0x194 [snd]) [ 139.173222] [<7f0e6b2c>] (snd_ctl_open [snd]) from [<7f0e250c>] (snd_open+0xa8/0x14c [snd]) [ 139.189683] [<7f0e250c>] (snd_open [snd]) from [<802ce590>] (chrdev_open+0xac/0x188) [ 139.205465] [<802ce590>] (chrdev_open) from [<802c57b4>] (do_dentry_open+0x10c/0x314) [ 139.221347] [<802c57b4>] (do_dentry_open) from [<802c6ba8>] (vfs_open+0x5c/0x88) [ 139.236788] [<802c6ba8>] (vfs_open) from [<802d9a68>] (path_openat+0x368/0x944) [ 139.248270] [<802d9a68>] (path_openat) from [<802dacd4>] (do_filp_open+0x70/0xc4) [ 139.263731] [<802dacd4>] (do_filp_open) from [<802c6f70>] (do_sys_open+0x110/0x1d4) [ 139.279378] [<802c6f70>] (do_sys_open) from [<802c7060>] (SyS_open+0x2c/0x30) [ 139.290647] [<802c7060>] (SyS_open) from [<801082c0>] (ret_fast_syscall+0x0/0x28) [ 139.306021] Code: e3c3303f e5932004 e2822001 e5832004 (e5943000) [ 139.316265] ---[ end trace 7f3f7f6193b663ed ]--- [ 139.324956] note: aplay[463] exited with preempt_count 1 ~~~~ Signed-off-by: Kirill Marinushkin <[email protected]> Cc: Eric Anholt <[email protected]> Cc: Stefan Wahren <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> Cc: Florian Fainelli <[email protected]> Cc: Ray Jui <[email protected]> Cc: Scott Branden <[email protected]> Cc: [email protected] Cc: Michael Zoran <[email protected]> Cc: Andy Shevchenko <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Cc: [email protected] Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: comedi: s626: Use Preferred kernel typePaul McQuade1-4/+4
Change to kenel type u8 or u16 instead of uint8_t or uint16_t Signed-off-by: Paul McQuade <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: mt7621-dts: Replace spaces with tabs in indentationNishka Dasgupta1-1/+1
Replace spaces with tabs in indentation. Issue found with checkpatch. Signed-off-by: Nishka Dasgupta <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: Remove unused member 'reg_net' from 'ks_wlan_private'.Quytelda Kahja1-1/+0
'reg_net' is never used in this driver. Signed-off-by: Quytelda Kahja <[email protected]>x Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: Change mac_address_valid to a bool instead of int.Quytelda Kahja3-5/+5
'mac_address_valid' is only ever assigned 0 or 1, so it makes more sense to use a bool type for this variable. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: Remove unecessary cast.Quytelda Kahja1-1/+1
The driver casts '&ks_wlan_handler_def' to 'struct iw_handler_def *', but it is already of that type. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: replace uint8_t in favour of u8 in michael_get_micSergio Paracuellos1-1/+1
This commit replaces uint8_t parameter for preferred one u8 in michael_get_mic function. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: replace uint8_t in favour of u8 in michael_appendSergio Paracuellos1-3/+3
This commit replaces param which is uint8_t in michael_append function in favour of preferred one u8. It also removes no more needed casts when calling this function. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: replace uint8_t in favour of u8 in michael_initSergio Paracuellos1-1/+1
This commit replaces uint8_t for preferred one u8 in parameter of michael_init function. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: remove some dead code from ks_wlan_set_essid functionSergio Paracuellos1-15/+0
This commit removes death code which is not being used at all. The statements which are contained inside the else block of preprocessor #if 1 directive are no sense. Also remove #if 1 preprocessor stuff just because it is just true and being executed always. This change improves a bit readability of ks_wlan_set_essid function. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: replace MichaelBlockFunction macro with inline functionSergio Paracuellos1-15/+16
This commit replaces MichaelBlockFunction macro with similar inline function renaming it to michael_block. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: replace GetUInt32 macro with get_unaligned_le32Sergio Paracuellos1-7/+4
This commit replaces custom GetUInt32 macro with get_unaligned_le32 which is included in the linux kernel. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: replace PutUInt32 macro with put_unaligned_le32()Sergio Paracuellos1-11/+3
This commit replaces PutUInt32 custom macro with put_unaligned_le32 function included in the linux kernel. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: avoid camel cases in MichaelGetMIC functionSergio Paracuellos1-14/+13
This commit avoid camel cases in MichaelGetMIC function and params renaming it to michael_get_mic. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: replace macro MichaelClear with inline functionSergio Paracuellos1-8/+8
This commit replaces MichaelClear macro with similar inline function renaming it to michael_clear. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: avoid camel cases in MichaelAppend functionSergio Paracuellos1-23/+22
This commit avoid camel cases in MichaelAppend function and params renaming it to michael_append. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: avoid camel cases for MichaelInitFunctionSergio Paracuellos1-6/+5
This commit avoid camel cases in MichaelInitFunction signature and params renaming it to michael_init. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-29staging: ks7010: avoid camel cases in MichaelMICFunctionSergio Paracuellos3-23/+21
This commit replace camel cases for name and params used in MichaelMICFunction. This improves a bit readability. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: vt6655: Delete unused typedef enum _chip_typeNishka Dasgupta1-4/+0
Delete unused typedef enum _chip_type. Signed-off-by: Nishka Dasgupta <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: vt6655: Delete unused typedef struct _versionNishka Dasgupta1-7/+0
Delete unused typedef struct _version. Signed-off-by: Nishka Dasgupta <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: vt6655: Delete unused typedef enum _CARD_STATUS_TYPENishka Dasgupta1-6/+0
Delete unused typedef enum _CARD_STATUS_TYPE. Signed-off-by: Nishka Dasgupta <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: vt6655: Delete unused enum CARD_PKT_TYPENishka Dasgupta1-7/+0
Delete unused enum CARD_PKT_TYPE. Signed-off-by: Nishka Dasgupta <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: rtl8723bs: Remove duplicate #defines.Quytelda Kahja1-12/+0
The modified file includes 'linux/ieee80211.h', but redefines many constants that already exist in the header. This will create a conflict if the values are ever changed in the kernel. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: ks7010: factor out some functions from hostif_initSergio Paracuellos1-24/+53
This commit factors out some init functions from hostif_init to improve readability. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: ks7010: avoid camel case in function name get_DWORDSergio Paracuellos1-11/+10
This commit renames function get_DWORD into get_dword to avoid camel case. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: ks7010: avoid camel case in function name get_WORDSergio Paracuellos1-10/+9
This commit renames get_WORD function into get_word to avoid camel case. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: ks7010: avoid camel case in function name get_BYTESergio Paracuellos1-12/+11
This commit renames get_BYTE function in favour of get_byte to avoid camel case. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: ks7010: use GENMASK instead of custom defines in SME_WEP_VAL_MASKSergio Paracuellos1-1/+1
This commits replaces custom defines that were been used to define a mask using GENMASK macro from linux bitops header file. With this change the "WARNING: line over 80 characters" warning message reported by checkpatch script is also removed. Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: ks7010: Fix spelling mistakes.Quytelda Kahja2-2/+2
Fix two spelling mistakes in comments. Signed-off-by: Quytelda Kahja <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: ks7010: use lower case names in michael_mic_t struct fieldsSergio Paracuellos3-38/+38
Replace upper case fields and camel cases for fields included in michael_mic_t structure Signed-off-by: Sergio Paracuellos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: wilc1000: fix memdup.cocci warningsFengguang Wu1-6/+4
drivers/staging/wilc1000/host_interface.c:946:32-39: WARNING opportunity for kmemdup drivers/staging/wilc1000/host_interface.c:970:30-37: WARNING opportunity for kmemdup Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Fixes: aaea2164bdff ("staging: wilc1000: check for kmalloc allocation failures") CC: Colin Ian King <[email protected]> Signed-off-by: Fengguang Wu <[email protected]> Signed-off-by: Julia Lawall <[email protected]> Reviewed-by: Claudiu Beznea <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-03-28staging: wilc1000: remove unused return variableHariPrasath Elango1-4/+2
In this function,removed the unused integer variable as it is not actually used to return function success or failure. Return is a pointer to net_device structure. Signed-off-by: HariPrasath Elango <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.