aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-09-23staging: rtl8192u: remove unused functions in r8192U_core.cBaoyou Xie1-49/+0
We get 2 warnings when building kernel with W=1: drivers/staging/rtl8192u/r8192U_core.c:925:12: warning: no previous declaration for 'ieeerate2rtlrate' [-Wmissing-declarations] drivers/staging/rtl8192u/r8192U_core.c:958:12: warning: no previous declaration for 'rtl8192_rate2rate' [-Wmissing-declarations] drivers/staging/rtl8192u/r8192U_core.c:1322:11: warning: no previous declaration for 'rtl8192_IsWirelessBMode' [-Wmissing-declarations] In fact, these functions are unused in r8192U_core.c, but should be removed. So this patch removes the unused functions. Signed-off-by: Baoyou Xie <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: rtl8192u: ieee80211: ieee80211_softmac: mark symbols static where ↵Baoyou Xie1-6/+10
possible We get 5 warnings when building kernel with W=1: drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:287:13: warning: no previous declaration for 'softmac_ps_mgmt_xmit' [-Wmissing-declarations] drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:323:24: warning: no previous declaration for 'ieee80211_probe_req' [-Wmissing-declarations] drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:643:24: warning: no previous declaration for 'ieee80211_authentication_req' [-Wmissing-declarations] drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:981:24: warning: no previous declaration for 'ieee80211_association_req' [-Wmissing-declarations] drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:3094:24: warning: no previous declaration for 'ieee80211_disassociate_skb' [-Wmissing-declarations] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: android: ion: mark symbols static where possibleBaoyou Xie2-11/+11
We get 4 warnings when building kernel with W=1: drivers/staging/android/ion/ion_carveout_heap.c:36:17: warning: no previous prototype for 'ion_carveout_allocate' [-Wmissing-prototypes] drivers/staging/android/ion/ion_carveout_heap.c:50:6: warning: no previous prototype for 'ion_carveout_free' [-Wmissing-prototypes] drivers/staging/android/ion/ion_of.c:28:5: warning: no previous prototype for 'ion_parse_dt_heap_common' [-Wmissing-prototypes] drivers/staging/android/ion/ion_of.c:54:5: warning: no previous prototype for 'ion_setup_heap_common' [-Wmissing-prototypes] In fact, these functions are only used in the file in which they are declared and don't need a declaration, but can be made static. so this patch marks these functions with 'static'. Signed-off-by: Baoyou Xie <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: most: aim-cdev: make syscall write accept buffers of arbitrary sizeChristian Gromm1-15/+22
This patch allows to call the write() function for synchronous and isochronous channels with buffers of any size. The AIM simply waits for data to fill up the MOST buffer object according to the network interface controller specification for streaming channels, before it submits the buffer to the HDM. The new behavior is backward compatible to the old applications, since all known applications needed to fill the buffer completely anyway. Signed-off-by: Christian Gromm <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: greybus: Use setup_timer functionsayli karnik1-3/+2
This patch uses setup_timer function instead of initializing timer with the function and data fields. Signed-off-by: sayli karnik <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: wlan-ng: remove unnecessary spaces before castsJannik Becher7-53/+53
Fixed a coding style issue by removing unnecessary spaces before casts. Signed-off-by: Jannik Becher <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: ks7010: add blank line after variable declarationsJohan Svensson1-0/+3
Fixes warnings found by checkpatch Missing a blank line after declarations Signed-off-by: Johan Svensson <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: r8188eu: remove RFType member of odm_dm_struct structureIvan Safonov4-43/+12
rf_type is always equal to ODM_1T1R. So, only RF PATH A exists for r8188eu device... Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: r8188eu: remove rf_type member of hal_data_8188e structureIvan Safonov7-23/+5
rf_type is always equal to RF_1T1R. Signed-off-by: Ivan Safonov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: rtl8188eu: hal: rtl8188e_cmd: Use ether_addr_copy() instead of memcpy()Georgiana Rodica Chelu1-17/+17
The checkpatch.pl found the warning: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Checked if the the Ethernet addresses are __aligned(2) by using pahole tool. The type of pwlanhdr is struct ieee80211_hdr and pahole shows that addr1, addr2, and addr3 are aligned to u16. struct ieee80211_hdr { __le16 frame_control; /* 0 2 */ __le16 duration_id; /* 2 2 */ u8 addr1[6]; /* 4 6 */ u8 addr2[6]; /* 10 6 */ u8 addr3[6]; /* 16 6 */ __le16 seq_ctrl; /* 22 2 */ u8 addr4[6]; /* 24 6 */ /* size: 30, cachelines: 1, members: 7 */ /* last cacheline: 30 bytes */ }; Both eeprompriv from struct adapter and MacAddress from struct wlan_bssid_ex have the offset multiple of sizeof(u16). Also, the array bc_addr and the pointers: StaAddr, mac, and bssid, start from an even offset. Signed-off-by: Georgiana Rodica Chelu <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: lustre: llite: removed uneeded return variablesJuliana Rodrigues1-16/+8
Removed variables used only for return purposes and replaced them for the return value itself. Found using Coccinelle's semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Juliana Rodrigues <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: wlan-ng: removed blank linesJuliana Rodrigues1-1/+0
Removed an unecessary blank line after open brace, fixing a checkpatch issue. Signed-off-by: Juliana Rodrigues <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: greybus: arche-apb-ctrl: declare struct of_device_id as constEva Rachel Retuya1-1/+1
Declare the 'arche_apb_ctrl_of_match' array as const. This array is only stored in the .of_match_table field of a device_driver structure, which is declared as const. This addresses the checkpatch warning: WARNING: struct of_device_id should be normally const Signed-off-by: Eva Rachel Retuya <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-23staging: greybus: arche-platform: declare struct of_device_id as constEva Rachel Retuya1-2/+2
Declare the arrays 'arche_platform_of_match' and 'arche_combined_id' as const. 'arche_platform_of_match' is only stored in the .of_match_table field of a device_driver structure, which is declared as const. 'arche_combined_id' is passed to MODULE_DEVICE_TABLE. This macro does not modify the array and therefore the array can be declared as const. Checkpatch pointed out both issues. WARNING: struct of_device_id should be normally const Signed-off-by: Eva Rachel Retuya <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22Staging: speakup: kobjects: Add space around the operator.Sandhya Bankar1-5/+5
This issue was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22Staging: speakup: varhandlers: Add space around the operator.Sandhya Bankar1-3/+3
This patch was found by checkpatch. Signed-off-by: Sandhya Bankar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: slicoss: Move NULL test closer to assignmentRehas Sachdeva1-3/+3
Move the test to check if a variable is NULL, to right after it is being assigned, rather than some statements later. Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: ks7010: Remove unnecessary variable used to store return valuesayli karnik1-3/+2
This patch removes an unnecessary variable used to store return values in order to reduce memory usage. Done using coccinelle: @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret return - ret + C ; Signed-off-by: sayli karnik <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: octeon-usb: Remove unnecessary assignmentRehas Sachdeva1-1/+0
Remove 'x=a;' from a consecutive double assignment of the form 'x=a; x=b;'. Issue detected by the semantic patch found here: https://github.com/coccinelle/coccinellery/blob/master/write2/write2.cocci Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22Staging:rtl8188eu: Fix multiple blank linesYannis Damigos1-1/+0
This patch fixes multiple black lines issue found by checkpatch.pl Signed-off-by: Yannis Damigos <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: sm750fb: Remove unnecessary parenthesesRehas Sachdeva1-2/+2
Remove unnecessary parentheses from right side of an assignment. Issue detected by the following Coccinelle semantic patch: @r@ identifier x; expression e1, e2; @@ - x = (e1 << e2); + x = e1 << e2; Signed-off-by: Rehas Sachdeva <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: sm750fb: Use BIT(x) macroRehas Sachdeva1-1/+1
Replaces left shift operation (1 << d) by BIT(x) macro. Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: xgifb: Remove unused variable and if statementRehas Sachdeva1-5/+1
Setting the variable 'refresh_rate = 60;' has no use to the rest of the function. Hence the if statement setting it and the variable itself can be removed. This was detected using the following Coccinelle semantic patch: @@ type T; identifier i; constant C; @@ ( extern T i; | - T i; <+... when != i - i = C; ...+> ) Signed-off-by: Rehas Sachdeva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: speakup: Remove unnecessary parenthesesKatie Dunne1-2/+2
Issue found by checkpatch. Signed-off-by: Katie Dunne <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: add maintainer for uart and log protocol driversDavid Lin1-0/+6
Add myself as greybus uart and log protocol driver maintainer. Signed-off-by: David Lin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: uart.c: fix alignment to match open parenthesisChaehyun Lim1-14/+14
Fixes checkpatch.pl warning: CHECK: Alignment should match open parenthesis Signed-off-by: Chaehyun Lim <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: uart.c: change 'unsigned' to 'unsigned int'Chaehyun Lim1-1/+1
Fixes checkpatch.pl warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Chaehyun Lim <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: audio_codec.c: code indent should use tabs where possibleRichard Groux1-1/+1
Minor error spotted by checkpatch.pl in greybus code indent should use tabs where possible Signed-off-by: Richard Groux <[email protected]> Reviewed-by: Alex Elder <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: audio_codec.c: space required before the open braceRichard Groux1-1/+1
Minor error spotted by checkpatch.pl in greybus space required before the open brace '{' Signed-off-by: Richard Groux <[email protected]> Reviewed-by: Alex Elder <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: arche-platform: compress return logic into one lineEva Rachel Retuya1-2/+1
Modify return statement to use the value being returned directly instead of assigning it first to 'ret' and returning this variable. Coccinelle semantic patch used: @@ expression e; local idexpression ret; @@ -ret = +return e; -return ret; Signed-off-by: Eva Rachel Retuya <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: audio: delete unnecessary parenthesesEva Rachel Retuya1-1/+1
Eliminate unneeded parentheses around the right hand side of an assignment. Coccinelle semantic patch used: @@ expression e1, e2; identifier v; @@ ( v = (e1 == e2) | v = (e1 != e2) | v = (e1 <= e2) | v = (e1 >= e2) | v = - ( e1 - ) ) Signed-off-by: Eva Rachel Retuya <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: greybus: camera: simplify NULL testEva Rachel Retuya1-1/+1
Replace direct comparisons to NULL i.e. 'x == NULL' with '!x' for consistency. Coccinelle semantic patch used: @@ identifier func; expression x; statement Z; @@ x = func(...); if ( ( + ! x - == NULL | + ! - NULL == x ) ) Z Signed-off-by: Eva Rachel Retuya <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: most: replace MOST_CH_ISOC_AVP with MOST_CH_ISOCAndrey Shvetsov5-11/+11
This patch replaces the enum value MOST_CH_ISOC_AVP with the more appropriate MOST_CH_ISOC. Signed-off-by: Andrey Shvetsov <[email protected]> Signed-off-by: Christian Gromm <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: most: clean up configuration stringsChristian Gromm2-8/+15
This patch adds the strings 'rx', 'tx' and 'isoc' to the list of accepted identifiers when setting up a channel configuration. To keep consistency it removes the prefix "dir_" from strings returned by the attributes set_direction and available_directions and it removes the suffix "_avp" from the string "isoc_avp" returned by the attributes set_datatype and available_datatypes. Signed-off-by: Christian Gromm <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: most: core: remove trailing zero from text propertyAndrey Shvetsov1-2/+2
This patch removes trailing zeros from the strings returned by the attributes available_datatypes and available_directions. Signed-off-by: Andrey Shvetsov <[email protected]> Signed-off-by: Christian Gromm <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: most: make function most_submit_mbo return voidChristian Gromm4-17/+7
Function most_submit_mbo() causes an exception only if either the pointer mbo or mbo->context equals NULL. From the underlying architecture's point of view both cases must _not_ come true and would happen only, if something has tampered with the pointers. This would render runtime code unable to recover anyway. So, instead trying to hide that things are already critically out of control we're better off with a WARN_ON() assertion. This patch replaces the return type of the function most_submit_mbo() with 'void' and adds a WARN_ONCE() assertion. Additionally, code calling the function is adapted accordingly. Signed-off-by: Christian Gromm <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: wlan-ng: fixed block comment formattingJuliana Rodrigues1-1/+2
This patch fixes a checkpatch warning in a block comment by adapting it to the community preferred coding style. Signed-off-by: Juliana Rodrigues <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: wlan-ng: fixed alignment not matchingJuliana Rodrigues1-1/+1
This patch fixes a checkpatch warning by moving arguments to the right and aligning them to their open parenthesis. Signed-off-by: Juliana Rodrigues <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: wlan-ng: fixed parenthesis alignmentJuliana Rodrigues1-1/+1
This patch fixes a checkpatch warning by moving arguments to the right and aligning them to the open parenthesis above. Signed-off-by: Juliana Rodrigues <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-22staging: wlan-ng: fixed block comment trailingJuliana Rodrigues1-1/+2
Moved trailing */ to a new line and added * to subsequent lines on a block comment. Signed-off-by: Juliana Rodrigues <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: greybus: add maintainer for greybus platform driversVaibhav Hiremath1-0/+7
Add Vaibhav Hiremath as a Maintainer of Greybus platform drivers. Signed-off-by: Vaibhav Hiremath <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: greybus: fix up camera Kconfig dependanciesGreg Kroah-Hartman1-1/+1
CONFIG_MEDIA is not a thing, but CONFIG_MEDIA_SUPPORT is, so use that. Reported-by: Valentin Rothberg <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: include: remove unused ULTRA_CHANNELCLI_STRINGDavid Kershner1-22/+0
The inline ULTRA_CHANNELCLI_STRING is not being used so remove it. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: include: remove unused spar_channel_client_release_osDavid Kershner1-22/+0
The function spar_channel_client_release_os is not being used so remove it. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: include: remove unused spar_channel_client_acquire_osDavid Kershner1-104/+0
The function spar_channel_client_acquire_os is not being used so remove it. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: include: remove unused function pathname_last_n_nodesDavid Kershner1-32/+0
The function pathname_last_n_nodes is not used, get rid of it. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: visorhba: remove prototypes for visorhba_main.cDavid Kershner1-29/+21
Remove not needed prototypes in visorhba. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: visornic: remove poll_for_irq prototypeDavid Kershner1-2/+0
Remove poll_for_irq prototype not needed. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: visornic: remove visornic_poll prototypeDavid Kershner1-1/+0
Remove visornic_poll prototype, because it is not needed. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-09-21staging: unisys: visornic: remove visornic debugfs protoyptesDavid Kershner1-14/+9
Remove visornic debugfs prototypes, they are not needed. Signed-off-by: David Kershner <[email protected]> Reviewed-by: Tim Sell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.