aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-10-18staging: pi433: rf69.c style fix - space before asteriskMarcin Ciupak1-1/+1
This patch fixes the following checkpatch.pl error: ERROR: "(foo*)" should be "(foo *)" in rf69.c file as requested by TODO file. Additionally some style warnings remain valid here and could be fixed by another patch. Signed-off-by: Marcin Ciupak <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: pi433: rf69.c style fix - code indent should use tabsMarcin Ciupak1-2/+2
This patch fixes the following checkpatch.pl error: ERROR: code indent should use tabs where possible in rf69.c file as requested by TODO file. Additionally some style warnings remain valid here and could be fixed by another patch. Signed-off-by: Marcin Ciupak <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: pi433: rf69.c style fix - spaces before/afterMarcin Ciupak1-77/+77
his patch fixes the following checkpatch.pl errors: ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that ',' (ctx:WxV) ERROR: space prohibited before that close parenthesis ')' ERROR: space required after that ',' (ctx:VxV) ERROR: space required before the open parenthesis '(' in rf69.c file as requested by TODO file. Additionally some style warnings remain valid here and could be fixed by another patch. Signed-off-by: Marcin Ciupak <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: pi433: rf69.c style fix - spaces required aroundMarcin Ciupak1-10/+16
This patch fixes the following checkpatch.pl errors: ERROR: spaces required around that '+=' (ctx:WxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) in rf69.c file as requested by TODO file. Additionally some style warnings remain valid here and could be fixed by another patch. Signed-off-by: Marcin Ciupak <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: pi433: rf69.c style fix - trailing statementsMarcin Ciupak1-17/+41
This patch fixes the following checkpatch.pl error: ERROR: trailing statements should be on next line in rf69.c file as requested by TODO file. Note: ERROR: spaces required around that '=' (ctx:VxV) remains valid here and is going to be fixed by the next patch in set. Additionally some style warnings remain valid here and could be fixed by another patch. Signed-off-by: Marcin Ciupak <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18Staging: pi433: Fix the position of brace after ifSrishti Sharma1-36/+18
Fix the position of the brace after if when it is on the next line. Done using the following semantic patch by coccinelle. @r1@ position p1, p2; @@ if(...)@p1 {@p2 ... } @script: python r2@ p1 << r1.p1; p2 << r1.p2; @@ l1 = int (p1[0].line) l2 = int (p2[0].line) c1 = int (p1[0].column_end) c2 = int (p2[0].column) if l1 == l2 and c1+1 == c2: cocci.include_match(False) @r3@ position r1.p1, r1.p2; @@ if(... - )@p1 -{@p2 +) { ... } Signed-off-by: Srishti Sharma <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtlwifi: phydm: Remove useless parenthesesFrank A. Cancio Bello5-22/+22
Remove unnecessary parentheses to comply with preferred coding style for the linux kernel and avoid the following checkpatch's message: 'CHECK: Unnecessary parentheses around'. Credits to checkpatch. Signed-off-by: Frank A. Cancio Bello <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtlwifi: Remove unnecessary parenthesesFrank A. Cancio Bello4-35/+35
Remove unnecessary parentheses to comply with preferred coding style for the linux kernel and avoid the following checkpatch's message: 'CHECK: Unnecessary parentheses around'. Credits to checkpatch. Signed-off-by: Frank A. Cancio Bello <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18rtlwifi: Fix typo in if ... else if ... else constructLarry Finger1-2/+2
The kbuild test robot reports two conditions with no effect (if == else). These are the result of copy and paste typographical errors. Signed-off-by: Larry Finger <[email protected]> Cc: Ping-Ke Shih <[email protected]> Cc: Yan-Hsuan Chuang <[email protected]> Cc: Birming Chiu <[email protected]> Cc: Shaofu <[email protected]> Cc: Steven Ting <[email protected]> Cc: [email protected] Cc: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtlwifi: halmac: mark expected switch fall-throughGustavo A. R. Silva1-1/+1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtlwifi: mark expected switch fall-through in rtl_make_smps_actionGustavo A. R. Silva1-3/+1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtlwifi: Convert timers to use timer_setup()Kees Cook6-48/+15
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Also drops unused odm timer code. Cc: Greg Kroah-Hartman <[email protected]> Cc: Larry Finger <[email protected]> Cc: Kalle Valo <[email protected]> Cc: Ping-Ke Shih <[email protected]> Cc: shaofu <[email protected]> Cc: [email protected] Signed-off-by: Kees Cook <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: comedi: adv_pci_dio: update for PCI-1761Anton Dozenko2-4/+26
Advantech PCI-1761 device support to the driver adv_pci_dio has been added. Patch has been successfully tested on a real card (8 digital outs, 8 digital inputs). Signed-off-by: Anton Dozenko <[email protected]> Signed-off-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: comedi: dt282x: fix IRQ assignment for dev->irq.Arvind Yadav1-0/+2
Here, dev->irq is not assigned with irq. comedi_legacy_detach() is using dev->irq for release irq and dt282x_attach() is using dev->irq for initialize comedi_subdevice. Signed-off-by: Arvind Yadav <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: comedi: s526: mark expected switch fall-throughGustavo A. R. Silva1-3/+2
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging/comedi: Convert timers to use timer_setup()Kees Cook3-17/+22
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Adds pointer back to comedi device from private struct. Cc: H Hartley Sweeten <[email protected]> Cc: [email protected] Signed-off-by: Kees Cook <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8192e: mark expected switch fall-throughGustavo A. R. Silva1-2/+1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8192e: Use __func__ instead of function nameMihaela Muraru1-2/+6
Use identifier __func__ instead of the name of the function. Issue found by checkpatch.pl. Signed-off-by: Mihaela Muraru <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8192e: Convert timers to use timer_setup()Kees Cook8-74/+61
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman <[email protected]> Cc: Derek Robson <[email protected]> Cc: Suniel Mahesh <[email protected]> Cc: Malcolm Priestley <[email protected]> Cc: Gargi Sharma <[email protected]> Cc: Julia Lawall <[email protected]> Cc: "David S. Miller" <[email protected]> Cc: Johannes Berg <[email protected]> Cc: Yamanappagouda Patil <[email protected]> Cc: Georgiana Rodica Chelu <[email protected]> Cc: Colin Ian King <[email protected]> Cc: Baoyou Xie <[email protected]> Cc: [email protected] Cc: Greg Kroah-Hartman <[email protected]> Cc: Derek Robson <[email protected]> Cc: Suniel Mahesh <[email protected]> Cc: Malcolm Priestley <[email protected]> Cc: Gargi Sharma <[email protected]> Cc: Julia Lawall <[email protected]> Cc: Yamanappagouda Patil <[email protected]> Cc: "David S. Miller" <[email protected]> Cc: Johannes Berg <[email protected]> Cc: Georgiana Rodica Chelu <[email protected]> Cc: Colin Ian King <[email protected]> Cc: Baoyou Xie <[email protected]> Cc: [email protected] Signed-off-by: Kees Cook <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8192u: Convert timers to use timer_setup()Kees Cook9-50/+46
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman <[email protected]> Cc: Derek Robson <[email protected]> Cc: simran singhal <[email protected]> Cc: Riccardo Marotti <[email protected]> Cc: Fabrizio Perria <[email protected]> Cc: Arnd Bergmann <[email protected]> Cc: Baoyou Xie <[email protected]> Cc: Tuomo Rinne <[email protected]> Cc: Colin Ian King <[email protected]> Cc: [email protected] Signed-off-by: Kees Cook <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8188eu: usb_ops_linux: mark expected switch fall-throughGustavo A. R. Silva1-0/+1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1077613 Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8188eu: usb_halinit: mark expected switch fall-throughGustavo A. R. Silva1-0/+1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1373894 Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18rtl8188eu: Fix a possible sleep-in-atomic bug in _rtw_pwr_wakeupJia-Ju Bai1-1/+1
The driver may sleep under a spinlock, and the function call path is: rtw_set_802_11_disassociate(acquire the spinlock) _rtw_pwr_wakeup usleep_range --> may sleep To fix it, usleep_range is replaced with udelay. This bug is found by my static analysis tool and my code review. Signed-off-by: Jia-Ju Bai <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18rtl8188eu: Fix a possible sleep-in-atomic bug in rtw_createbss_cmdJia-Ju Bai1-1/+1
The driver may sleep under a spinlock, and the function call path is: rtw_surveydone_event_callback(acquire the spinlock) rtw_createbss_cmd kzalloc(GFP_KERNEL) --> may sleep To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. This bug is found by my static analysis tool and my code review. Signed-off-by: Jia-Ju Bai <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18rtl8188eu: Fix a possible sleep-in-atomic bug in rtw_disassoc_cmdJia-Ju Bai1-1/+1
The driver may sleep under a spinlock, and the function call path is: rtw_set_802_11_bssid(acquire the spinlock) rtw_disassoc_cmd kzalloc(GFP_KERNEL) --> may sleep To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. This bug is found by my static analysis tool and my code review. Signed-off-by: Jia-Ju Bai <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8188eu: add spaces around algebric and boolean operatorsAastha Gupta1-18/+18
This patch fixes checkpatch.pl warnings about preferring spaces around algebric and boolean operators. Signed-off-by: Aastha Gupta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8188eu: fix spaces before tabsAastha Gupta2-6/+6
This patch fixes checkpatch.pl warning: WARNING: please, no space before tabs Signed-off-by: Aastha Gupta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8188eu: fix space between function name and '('Aastha Gupta1-1/+1
This patch fixes checkpatch.pl warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Aastha Gupta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8188eu: fix block comment styling in rtl8188eu filesAastha Gupta27-395/+514
This patch fixes checkpatch.pl warnings for block comment styling. 1. Block comment use a trailing */ on a separate line. 2. Block comment use * on subsequent lines. 3. Block comment should align * on each line. Signed-off-by: Aastha Gupta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: fix comparisons should place the constant on the right sideAastha Gupta1-1/+1
This patch fixes checkpatch.pl warning: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: Aastha Gupta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: fix incorrect multi-line comment styleAastha Gupta2-36/+21
This patch fixes the checkpatch.pl warning: WARNING: block comments use a trailing */ on a separate line Signed-off-by: Aastha Gupta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtlwifi: rtl8822be: Align the * in block commentFrank A. Cancio Bello1-3/+3
Align the * on each line of a block comment to comply with kernel coding style and address the following checkpatch message: 'WARNING: Block comments should align the * on each line'. Credits to checkpatch. Signed-off-by: Frank A. Cancio Bello <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtlwifi: rtl8822be: Remove useless parenthesesFrank A. Cancio Bello4-17/+17
Remove unnecessary parentheses to comply with preferred coding style for the linux kernel and avoid the following checkpatch's message: 'CHECK: Unnecessary parentheses around'. Credits to checkpatch. Signed-off-by: Frank A. Cancio Bello <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtlwifi: rtl8822be: Use __func__ instead of hardcoded nameFrank A. Cancio Bello1-3/+3
Switch hardcoded function name with a reference to __func__ making the code more maintenable and addressing the checkpatch warning: WARNING: Prefer using '"%s...", __func__' to using 'rtl8822be_sc_mapping', this function's name, in a string + "rtl8822be_sc_mapping: Not Correct Primary40MHz Setting\n"); Credits to checkpatch. Signed-off-by: Frank A. Cancio Bello <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtlwifi: rtl8822be: Balance braces in else statementFrank A. Cancio Bello2-2/+4
Add braces to else statements to comply with section 3) of 'Linux kernel coding style' and avoid the following checkpatch message: 'CHECK: Unbalanced braces around else statement' Credits to checkpatch. Signed-off-by: Frank A. Cancio Bello <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8822be: Keep array subscript no lower than zeroLarry Finger1-0/+2
The kbuild test robot reports the following: drivers/staging//rtlwifi/phydm/phydm_dig.c: In function 'odm_pause_dig': drivers/staging//rtlwifi/phydm/phydm_dig.c:494:45: warning: array subscript is below array bounds [-Warray-bounds] odm_write_dig(dm, dig_tab->pause_dig_value[max_level]); This condition is caused when a loop falls through. The fix is to pin max_level to be >= 0. Signed-off-by: Larry Finger <[email protected]> c: kbuild test robot <[email protected]> Fixes: 9ce99b04b5b82fdf11e4c76b60a5f82c1e541297 staging: r8822be: Add phydm mini driver Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: ccree: fix boolreturn.cocci warningSuniel Mahesh1-1/+1
This fixes the following coccinelle warning: WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. return "false" instead of 0. Signed-off-by: Suniel Mahesh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: ccree: Fix bool comparisonSuniel Mahesh1-1/+1
Comparision operator "equal to" not required on a variable "foo" of type "bool". Bool has only two values, can be used directly or with logical not. This fixes the following coccinelle warning: WARNING: Comparison of bool to 0/1 Signed-off-by: Suniel Mahesh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging/ccree: Declare compiled out functions static inlineRishabh Hardas1-2/+2
Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler' that they were not declared and need to be made static. This patch makes both the symbols static inline, to remove the warnings. Signed-off-by: Rishabh Hardas <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: rtl8188eu: Convert timers to use timer_setup()Kees Cook11-52/+51
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Greg Kroah-Hartman <[email protected]> Cc: Juliana Rodrigues <[email protected]> Cc: Ivan Safonov <[email protected]> Cc: Gargi Sharma <[email protected]> Cc: sayli karnik <[email protected]> Cc: Yamanappagouda Patil <[email protected]> Cc: Luca Ceresoli <[email protected]> Cc: Victor Carvajal <[email protected]> Cc: Sebastian Haas <[email protected]> Cc: [email protected] Signed-off-by: Kees Cook <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: rpc: mark expected switch fall-throughsGustavo A. R. Silva1-4/+9
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1077604 Addresses-Coverity-ID: 1077605 Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: ptlrpc: mark expected switch fall-throughsGustavo A. R. Silva1-3/+3
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: osc: mark expected switch fall-throughGustavo A. R. Silva1-0/+1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1077598 Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: ldlm: mark expected switch fall-throughGustavo A. R. Silva1-0/+1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: lprocfs: mark expected switch fall-throughsGustavo A. R. Silva1-0/+4
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1271166 Addresses-Coverity-ID: 1271167 Addresses-Coverity-ID: 1271168 Addresses-Coverity-ID: 1271169 Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: llite: mark expected switch fall-throughGustavo A. R. Silva1-1/+3
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: lnet: selftest: mark expected switch fall-throughsGustavo A. R. Silva1-1/+4
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: lnet: selftest: mark expected switch fall-throughGustavo A. R. Silva1-0/+1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: lnet: net_fault: mark expected switch fall-throughGustavo A. R. Silva1-0/+1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-10-18staging: lustre: lnet: socklnd: mark expected switch fall-throughGustavo A. R. Silva1-1/+1
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Andreas Dilger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.