aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-10-21staging: lustre: Remove typedef and update cfs_hash_lock unionLisa Nguyen2-14/+14
Remove typedef keyword and rename the cfs_hash_lock_t union to cfs_hash_lock in libcfs_hash.h. These changes resolve the "Do not add new typedefs" warning generated by checkpatch.pl and meet kernel coding style. The union variables in hash.c are updated to reflect this change as well. Signed-off-by: Lisa Nguyen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-21staging:lustre: replace foo* with foo *Dulshani Gunawardhana3-10/+10
Fix checkpatch.pl warning of "(foo*)" should be "(foo *)" in lustre/lov Signed-off-by: Dulshani Gunawardhana <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-21staging:lustre: Fix externs should be avoided in .c files warningDulshani Gunawardhana3-2/+4
Fix the checkpatch.pl warning 'externs should be avoided in .c files' in lustre/lov. Signed-off-by: Dulshani Gunawardhana <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-21staging:lustre: Fix space before open parenthesisDulshani Gunawardhana6-6/+6
Fix checkpatch.pl error "space required before the open parenthesis '('" in lustre/lov. Signed-off-by: Dulshani Gunawardhana <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-21staging:lustre: Replace max() with max_t()Dulshani Gunawardhana1-1/+1
Replace max() with max_t() in accordance to chekpatch.pl warning in lov_obd.c. Signed-off-by: Dulshani Gunawardhana <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-21staging:lustre: Fix C99 style commentsDulshani Gunawardhana1-1/+1
Fix C99 style comments in lov_obd.c in accordance to checkpatch.pl warning. Signed-off-by: Dulshani Gunawardhana <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-21staging:lustre: Remove space between function name and open parenthesisDulshani Gunawardhana4-38/+38
Remove checkpatch.pl warning of space prohibited between function name and open parenthesis '('in /lustre/lov. Signed-off-by: Dulshani Gunawardhana <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-21staging: lustre: libcfs: Remove bitmap.h fileLisa Nguyen1-110/+0
The functions in the bitmap.h header file are not being used by any source file in the lustre driver. Unless there are any objections, please remove the bitmap.h header file as it contains unused code in the kernel. Signed-off-by: Lisa Nguyen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-20iio:adc:max1363 support SMBus for 8-bit devicesVivien Didelot1-19/+57
The driver currently supports only I2C access. But supported devices with an accuracy of 8-bit are compatible with the SMBus byte access routines. This patch wraps the send and receive routines depending on the chip accuracy and fonctionnalities of its adapter. For instance, this allows us to use a MAX11603 on a ICH7 controller. This patch also simplifies the max1363_write_basic_config() routine to use the struct max1363_state fields directly. Signed-off-by: Vivien Didelot <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
2013-10-20iio: Correct description how to convert microtesla to gaussPeter Meerwald1-1/+1
this just fixes the comment; however, I'm not sure if the driver reports measurements correctly; the raw values are 0.3 uT / LSB; IIO is supposed to report magnetic fields in Gauss, so the scale should be around 1/300 (ignoring ASA) -- but value and scale are returned as VAL_INT Signed-off-by: Peter Meerwald <[email protected]> Signed-off-by: Jonathan Cameron <[email protected]>
2013-10-19staging: rtl8187se: checkpatch cleanupsTeodora Baluta1-2/+2
Fix the following checkpatch.pl errors: drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:890: "foo* bar" should be "foo *bar" drivers/staging/rtl8187se/ieee80211/ieee80211_softmac.c:944: "foo* bar" should be "foo *bar" Signed-off-by: Teodora Baluta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: rtl8187se: fix static sparse warningsTeodora Baluta7-60/+64
This patch fixes sparse warnings regarding functions that should be static in driver rtl8187se. Signed-off-by: Teodora Baluta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: rtl8187se: add missing __iomem annotationTeodora Baluta1-8/+8
Fix the following type of sparse warnings: drivers/staging/rtl8187se/r8180_core.c:163:48: warning: incorrect type in argument 1 (different address spaces) drivers/staging/rtl8187se/r8180_core.c:163:48: expected void const volatile [noderef] <asn:2>*addr drivers/staging/rtl8187se/r8180_core.c:163:48: got unsigned char [usertype] * Signed-off-by: Teodora Baluta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: rtl8187se: use gfp_t instead of intTeodora Baluta1-1/+1
Fix the following type of sparse warnings: drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c:249:17: warning: incorrect type in argument 2 (different base types) drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c:249:17: expected restricted gfp_t [usertype] flags drivers/staging/rtl8187se/ieee80211/ieee80211_tx.c:249:17: got int [signed] gfp_mask Signed-off-by: Teodora Baluta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: sb105x: Remove redundant null checkRashika Kheria1-4/+1
This patch fixes the following Sparse information in sb_pci_mp.c- ~/git/kernels/linux/drivers/staging/sb105x/sb_pci_mp.c:1813 mp_unregister_driver() info: redundant null check on drv->state calling kfree() Signed-off-by: Rashika Kheria <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: line6: replacing -EINVAL with retval in driver.cAshvini Varatharaj1-1/+1
drivers/staging/line6/driver.c:208 line6_send_raw_message_async_part() info: why not propagate 'retval' from usb_submit_urb() instead of (-22)? Signed-off-by: Ashvini Varatharaj <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: line6: replacing -EINVAL with retvalAshvini Varatharaj1-1/+1
drivers/staging/line6/midi.c:147 send_midi_async() info: why not propagate 'retval' from usb_submit_urb() instead of (-22)? Signed-off-by: Ashvini Varatharaj <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: speakup: replacing simple_strtoul with kstrtoulAshvini Varatharaj1-3/+5
Fix checkpatch warning: WARNING: simple_strtoul is obsolete, use kstrtoul instead Signed-off-by: Ashvini Varatharaj <[email protected]> Reviewed-by: Peter P Waskiewicz Jr <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: sep: Fix Smatch Warning in sep_crypto.cRashika Kheria1-2/+2
This patch fixes the following smatch warning- ~/git/kernels/linux/drivers/staging/sep/sep_crypto.c:1137 sep_crypto_block_data() info: why not propagate 'int_error' from sep_oddball_pages() instead of (-12)? ~/git/kernels/linux/drivers/staging/sep/sep_crypto.c:1152 sep_crypto_block_data() info: why not propagate 'int_error' from sep_oddball_pages() instead of (-12)? Signed-off-by: Rashika Kheria <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: vt6655: Fix C99 commenting style in michael.hArchana kumari1-5/+5
This patch fixes C99 commenting style in staging:vt6655:michael.h Signed-off-by: Archana kumari <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: slicoss: Fix quoted string split across linesRashika Kheria1-2/+1
This patch fixes the following checkpatch.pl warning in slicoss.c- WARNING: quoted string split across lines Signed-off-by: Rashika Kheria <[email protected]> Reviewed-by: Peter P Waskiewicz Jr <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: slicoss: Refactor code by introducing new function ↵Rashika Kheria1-58/+62
slic_interrupt_card_up() This patch fixes the following checkpatch.pl warning in slicoss.c: WARNING: Too many leading tabs - consider code refactoring Signed-off-by: Rashika Kheria <[email protected]> Reviewed-by: Peter P Waskiewicz Jr <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: slicoss: Replace printk() with pr_debug() or dev_dbg() as requiredRashika Kheria1-4/+4
This patch fixes the following checkpatch.pl warning in slicoss.c: WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... Signed-off-by: Rashika Kheria <[email protected]> Reviewed-by: Peter P Waskiewicz Jr <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: slicoss: Removal of if check since debugfs_remove(NULL) is safeRashika Kheria1-12/+3
This patch fixes the following checkpatch.pl warning in slicoss.c: WARNING: debugfs_remove(NULL) is safe this check is probably not required Signed-off-by: Rashika Kheria <[email protected]> Reviewed-by: Peter P Waskiewicz Jr <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: dgnc: avoiding buffer overflowAshvini Varatharaj1-1/+1
drivers/staging/dgnc/dgnc_neo.c:1969 neo_vpd() error: buffer overflow 'brd->vpd' 128 <= 128 drivers/staging/dgnc/dgnc_neo.c:1970 neo_vpd() warn: buffer overflow 'brd->vpd' 128 <= 130 drivers/staging/dgnc/dgnc_neo.c:1970 neo_vpd() warn: buffer overflow 'brd->vpd' 128 <= 130 Signed-off-by: Ashvini Varatharaj <[email protected]> Reviewed-by: Peter P Waskiewicz Jr <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: dgnc: removing the comparison 'board<0'Ashvini Varatharaj1-1/+1
Fix dgnc_mgmt_ioctl() warn: unsigned 'board' is never less than zero. Signed-off-by: Ashvini Varatharaj <[email protected]> Reviewed-by: Peter P Waskiewicz Jr <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: dgnc: braces {} are not necessary for single statement in dgnc_driver.cArchana kumari1-2/+1
Fixes "braces {} are not necessary for single statement blocks" warning in dgnc_driver.c Signed-off-by: Archana kumari <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: dgnc:Removed unecessary error messages in dgnc_driver.cArchana kumari1-2/+0
Fixed removal of unecessary error messages in staging:dgnc:dgnc_driver.c Signed-off-by: Archana kumari <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: wlags49_h2: Fixes the sparse warning in sta_h2.cArchana kumari1-2/+2
This patch fixes sparse warning "Using plain integer as NULL pointer" in sta_h2.c Signed-off-by: Archana kumari <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: wlags49_h2: fixed space prohibited warnings in hcf.hArchana kumari1-11/+11
This patch fixes the following warnings in hcf.c: "space prohibited between function name and open parenthesis '(' " "space prohibited before that close parenthesis ')' ". Signed-off-by: Archana kumari <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: comedi: s626: bitfield manipulation macros for CRA, CRB and setupIan Abbott1-41/+212
Some bits of the 'CRB' register have different functions when read or written, so add macros to define the read-only parts. Add macros to define the widths of the bitfields in the 'CRA' and 'CRB' registers and the standard encoder setup value. Add macros to construct and extract parts of the 'CRA' and 'CRB' register values and the standard encoder setup value, along with a couple of general helper macros for the above. Redefine the bitfield mask macros for 'CRA', 'CRB' and standard encoder setup using the above. Signed-off-by: Ian Abbott <[email protected]> Reviewed-by: H Hartley Sweeten <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: comedi: s626: add missing bits for 'CRB' registerIan Abbott1-3/+11
There are some bits in the 'CRB' register not defined in "s626.h". Three of these are read-only bits that overlay the write-only interrupt control bits. Another missing bit controls whether counter 'B' is cleared when counter 'A' overflows. Add the missing bit definitions for completeness. Signed-off-by: Ian Abbott <[email protected]> Reviewed-by: H Hartley Sweeten <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: comedi: s626: correct S626_CRAMSK_CLKPOL_A macro (unused)Ian Abbott1-1/+1
The counter 'A' clock polarity field in the 'CRA' register is only 1 bit wide, but the `S626_CRAMSK_CLKPOL_A` macro shows it as 2 bits wide, which would overlap with the counter 'A' interrupt source field. This is harmless as the macro isn't actually used yet, but correct it anyway as I want to use it! Signed-off-by: Ian Abbott <[email protected]> Reviewed-by: H Hartley Sweeten <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: comedi: s626: distinguish counter src from encoder modeIan Abbott2-61/+67
The macros `S626_CLKSRC_COUNTER`, `S626_CLKSRC_TIMER` and `S626_CLKSRC_EXTENDER` are used logically to set the operating mode of an encoder channel. `S626_CLKSRC_COUNTER` (0) is also used as a 2-bit physical value to set the counter source of an encoder channel to "encoder". Rename the macros to `S626_ENCMODE_COUNTER`, `S626_ENCMODE_TIMER` and `S626_ENCMODE_EXTENDER` and rename some other macros and (unused) functions relating to the encoder mode for consistency. Define new macros to specify the physical counter source values for the 'CRA' register and rename the corresponding bitshift and mask macros accordingly. The physical values for the counter source are: S626_CNTSRC_ENCODER = 0 // encoder S626_CNTSRC_DIGIN = 1 // digital inputs S626_CNTSRC_SYSCLK = 2 // system clock up S626_CNTSRC_SYSCLK_DOWN = 3 // system clock down Also use the `S626_CNTSRC_SYSCLK` value as a bitmask (bit 1) to indicate either of the system clock values, with the direction (bit 0) indicated separately in this case. Signed-off-by: Ian Abbott <[email protected]> Reviewed-by: H Hartley Sweeten <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: comedi: s626: correct a comment in s626_get_mode_b()Ian Abbott1-1/+1
Signed-off-by: Ian Abbott <[email protected]> Reviewed-by: H Hartley Sweeten <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: comedi: s626: specify bitshift for encoder A clock sourceIan Abbott1-1/+1
When setting the clock source for one of the 'A' encoders to operate in "counter" mode in `s626_set_mode_a()`, bitshift the clock source value by `S626_CRABIT_CLKSRC_A` for consistency with the other modes. This has no effect on the value since `S626_CRABIT_CLKSRC_A` is 0. Signed-off-by: Ian Abbott <[email protected]> Reviewed-by: H Hartley Sweeten <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: comedi: s626: clock polarity and direction are the sameIan Abbott1-4/+0
When setting up an encoder channel, the setup value includes a polarity and direction, but these are the same bit of the setup value: S626_CLKPOL_POS = S626_CNTDIR_UP = 0 S626_CLKPOL_NEG = S626_CNTDIR_DOWN = 1 In the construction of the setup value, both the CLKPOL and the CNTDIR constants are shifted by the same amount `S626_BF_CLKPOL`. Only the following combinations are set up currently (this may change if user configuration of the encoder is implemented properly): (S626_CLKPOL_POS << S626_BF_CLKPOL) (S626_CLKPOL_POS << S626_BF_CLKPOL) | (S626_CNTDIR_UP << S626_BF_CLKPOL) (S626_CLKPOL_POS << S626_BF_CLKPOL) | (S626_CNTDIR_DOWN << S626_BF_CLKPOL) The first two are used in "counter" mode and is equivalent to: (S626_CLKPOL_POS << S626_BF_CLKPOL) The last one is used in "timer" mode and is equivalent to: (S626_CNTDIR_DOWN << S626_BF_CLKPOL) Use the shorter equivalents. The comments in "s626.h" indicate that the 'CLKPOL' constants make more sense for the "counter" mode (when the encoders operate as up/down counters) and the 'CNTDIR' constants make more sense for the "timer" mode. Signed-off-by: Ian Abbott <[email protected]> Reviewed-by: H Hartley Sweeten <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: comedi: rtd520: use normal bitfield functionsIan Abbott1-20/+7
The `unsigned char chan_is_bipolar[]` member of `struct rtd_private` is used with some macros as a packed array of 1-bit values that indicate whether the corresponding entries in the hardware's "channel-gain" table have been set to a bipolar (1) or unipolar (0) range, as the raw samples from the hardware need to be cooked differently in each case. Replace the declaration of the member with a standard Linux bitfield using `DECLARE_BITFIELD()`, and replace the home-grown macros used access the bitfield with the standard Linux non-atomic bitop functions, `__set_bit()`, `__clear_bit()` and `test_bit()`. Signed-off-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19Staging: ft1000: fixed two coding style issuesAldo Iljazi1-2/+2
Fixed two coding style issues, specifically: ft1000_proc.c:35: ERROR: space required before the open parenthesis '(' ft1000_proc.c:42: ERROR: space required before the open parenthesis '(' Signed-off-by: Aldo Iljazi <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: xillybus: Use dev_* functions instead of pr_* in xillybus_coreEli Billauer1-46/+69
Suggested-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Eli Billauer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: xillybus: Use dev_* functions instead of pr_* in xillybus_ofEli Billauer1-6/+8
Suggested-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Eli Billauer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: xillybus: Use dev_* functions instead of pr_* in xillybus_pcieEli Billauer1-13/+12
Suggested-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Eli Billauer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging: xillybus: Remember device pointer for use with dev_* functionsEli Billauer1-1/+1
This is necessary so that xillybus_core uses the correct device pointer for PCIe devices in diagnostic message calls (dev_err, dev_warn and dev_info) Signed-off-by: Eli Billauer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging/lustre/lnet: Remove unnecessary spaces in router_proc.cLisa Nguyen1-10/+10
Remove unnecessary spaces between function names and open parentheses in router_proc.c to meet kernel coding style. Signed-off-by: Lisa Nguyen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging/lustre/lnet: Fix static initialization error in router_proc.cLisa Nguyen1-1/+1
Fixed the static initialization error generated by checkpatch.pl to meet kernel coding standards. Signed-off-by: Lisa Nguyen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging/lustre/lnet: Reformat pointer variable in lib-move.cLisa Nguyen1-1/+1
Reformat a pointer variable in lib-move.c to meet kernel coding standards. Signed-off-by: Lisa Nguyen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging/lustre/lnet: Remove () from return statements in lib-move.cLisa Nguyen1-13/+13
Remove unnecessary parentheses from return statements to eliminate errors generated by checkpatch.pl and meet kernel coding standards. Signed-off-by: Lisa Nguyen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging/lustre/lnet: Adjust lines to meet 80 column limit in lib-move.cLisa Nguyen1-11/+17
Fixed lines to not exceed more than 80 columns per line to meet kernel coding standards. Signed-off-by: Lisa Nguyen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging/lustre/lnet: Move open braces to previous lines in lib-move.cLisa Nguyen1-8/+4
Move open braces to previous lines in lib-move.c to meet kernel coding standards. Signed-off-by: Lisa Nguyen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2013-10-19staging/lustre/lnet: Remove unnecessary whitespace in lib-move.cLisa Nguyen1-147/+147
Remove unnecessary whitespace around open parentheses in lib-move.c to meet kernel coding standards. Signed-off-by: Lisa Nguyen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.