aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-05-19m68k/atari - atari_scsi: change abort/reset return codesMichael Schmitz5-53/+42
[Resend of earlier patch - added equivalent changes to sun3 NCR5380 code] The abort/reset lowlevel return codes had changed with the new error SCSI handling - update Atari and Sun3 NCR5380 drivers to reflect this. Change reset handling for Atari to clear queues only, do not attempt to call done() on each command aborted by the reset. The EH code should do that for us. Queues _must_ be cleared, otherwise atari_scsi_bus_reset will not release the ST-DMA lock, deadlocking further error recovery. Update the Sun3 NCR5380 driver as well - the Sun3 driver was derived from the Atari one. Kudos to Finn Thain for the Sun3 part and cleaning up the header files. After the header cleanup, the initio.h include (!) can be dropped from sun3_scsi.h now. Signed-off-by: Michael Schmitz <[email protected]> Signed-off-by: Finn Thain <[email protected]> Acked-by: Sam Creasey <[email protected]> Cc: Geert Uytterhoeven <[email protected]> Cc: James E.J. Bottomley <[email protected]> Cc: [email protected] Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19aic79xx: fix misuse of static variablesMathias Krause1-13/+5
The format strings for various printk()s make use of a temporary variable that is declared 'static'. This is probably not intended, so fix those. Found in the PaX patch, written by the PaX Team. Signed-off-by: Mathias Krause <[email protected]> Acked-by: Hannes Reinecke <[email protected]> Cc: "James E.J. Bottomley" <[email protected]> Cc: PaX Team <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19esas2r: Fix commentMarek Vasut1-1/+1
Minor fix for a message in the driver so that it matches the function name. Signed-off-by: Marek Vasut <[email protected]> Cc: James Bottomley <[email protected]> Cc: Sergei Shtylyov <[email protected]> Acked-by: Bradley Grove <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19bfa: allocate memory with GFP_ATOMIC in spinlock contextAlexey Khoroshilov1-1/+1
bfa_fcb_pbc_vport_create() is called only from bfa_fcs_pbc_vport_init(), that is called only from bfad_drv_start() with bfad_lock spinlock held. So the patch replaces GFP_KERNEL with GFP_ATOMIC to avoid sleeping in atomic spinlock context. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <[email protected]> Acked-by: Anil Gurumurthy <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Update driver version to 5.04.00-k6Vikas Chaudhary1-1/+1
Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Fix smatch warning in func qla4xxx_conn_get_paramAdheer Chandravanshi1-4/+0
Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Fix smatch warning in func qla4xxx_get_ep_paramAdheer Chandravanshi1-3/+3
Fix following smatch warning:- drivers/scsi/qla4xxx/ql4_os.c:1752 qla4xxx_get_ep_param() warn: variable dereferenced before check 'qla_ep' (see line 1745) Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Fix memory leak for ha->saved_acbNilesh Javali1-2/+4
Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Export sysfs DDBs from DPC handlerNilesh Javali3-6/+11
Issue: modprobe qla4xxx is killed by systemd due to timeout. Solution: The exporting of sysfs DDBs from qla4xxx_probe_adapter added delay of approximately 15s due to which system-udevd killed the modprobe of the driver. Added fix to export the sysfs DDBs from the DPC handler. Signed-off-by: Nilesh Javali <[email protected]> Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Disable INTx interrupt for ISP82XXTej Parkash1-7/+5
Signed-off-by: Tej Parkash <[email protected]> Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Update driver version to 5.04.00-k5Vikas Chaudhary1-1/+1
Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Fix memory leak in func qla4_84xx_config_acb()Vikas Chaudhary1-1/+1
Use correct goto statement to free dma memory in case of failure in function qla4_84xx_config_acb() Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Initialize hardware queue for ISP40XXVikas Chaudhary1-0/+2
Issue: System crash while target discovery for ISP40XX Root cause: Function qla4xxx_init_rings() is not called for ISP40XX Fix: Call function qla4xxx_init_rings() for ISP40XX from qla4xxx_start_firmware(). Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Check for correct return statusVikas Chaudhary1-1/+1
Check for correct return status in function - qla4_8xxx_minidump_pex_dma_read Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: qla4xxx: Move qla4_8xxx_ms_mem_write_128b to ql4_nx.cVikas Chaudhary2-106/+106
Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Added PEX DMA Support for ISP8022 AdapterTej Parkash3-33/+28
Signed-off-by: Tej Parkash <[email protected]> Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Added new opcodes for 84XX Minidump templateTej Parkash3-0/+382
Updated driver with new opcode (RDDFE, RDMDIO and POLLWR) which are added with latest firmware minidump template Signed-off-by: Tej Parkash <[email protected]> Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Add support of 0xFF capture mask for minidumpTej Parkash3-3/+33
Signed-off-by: Tej Parkash <[email protected]> Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Change default capture to firmware defined capture maskTej Parkash1-2/+2
Signed-off-by: Tej Parkash <[email protected]> Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla4xxx: Do not wait for IO completion, after issuing stop_firmwareTej Parkash1-3/+0
Problem: iSCSI stop_firmware mailbox command is not completing outstanding IO. Solution: Do not wait for IO completion after issuing stop_firmware mailbox command Signed-off-by: Tej Parkash <[email protected]> Signed-off-by: Vikas Chaudhary <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19Update Maintainers for IBM Power 842, vscsi, and vfc driversNathan Fontenot1-5/+11
Update the MAINTAINERS file to indicate the current maintainers for the IBM Power 842 Compression driver, IBM Power Virtual SCSI driver and the IBM Power Virtual FC Driver. Signed-off-by: Nathan Fontenot <[email protected]> Acked-by: Brian King <[email protected]> Acked-by: Robert Jennings <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19scsi/libiscsi: Fix static checker warning on bh lockingShlomo Pongratz1-2/+2
Commit 659743b "[SCSI] libiscsi: Reduce locking contention in fast path" introduced a new smatch warning on libiscsi.c "iscsi_xmit_task() warn: inconsistent returns bottom_half:: locked (1410 [(-61)]) unlocked (1425 [0], 1425 [s32min-(-1),1-s32max])", which we can eliminate by using non bh locking on the nested spin_lock call. Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Shlomo Pongratz <[email protected]> Signed-off-by: Or Gerlitz <[email protected]> Reviewed-by: Mike Christie <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19fnic: fnic Control Path Trace UtilityHiral Shah6-43/+637
Fnic Ctlr Path Trace utility is a tracing functionality built directly into fnic driver to trace the control path frames like discovery, FLOGI request/reply, PLOGI request/reply, link event etc. It will be one trace file for all fnics. It will help us to debug and resolve the discovery and initialization related issues in more convenient way. This trace information includes time stamp, Host Number, Frame type, Frame Length and Frame. By default,64 pages are allocated but we can change the number of allocated pages by module parameter fnic_fc_trace_max_page. Each entry is of 256 byte and available entries are depends on allocated number of pages. We can turn on or off the fnic control path trace functionality by module paramter fc_trace_enable and/or reset the trace contain by module paramter fc_trace_clear. Signed-off-by: Hiral Shah <[email protected]> Signed-off-by: Sesidhar Baddela <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19fnic: Failing to queue aborts due to Q full cause terminate driver timeoutHiral Shah1-6/+7
In fnic abort handler, abort queuing can be failed when hardware queue is full. The command state is left as abort queued. The command with abort queued state will never be queued next time for abort or termiantion. Fix restores the command state in above case. Signed-off-by: Hiral Shah <[email protected]> Signed-off-by: Sesidhar Baddela <[email protected]> Signed-off-by: Narsimhulu Musini <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19fnic: NoFIP solicitation frame in NONFIP mode and changed IO Throttle countHiral Shah3-7/+4
This patch contains following three minor fixes. 1) During Probe, fnic was sending FIP solicitation in Non FIP mode which is not expected, setting the internal fip state to Non FIP mode explicitly, avoids sending FIP frame. 2) When target goes offline, all outstanding IOs belong to the target will be terminated by driver, If the termination count is high, then it influences firmware responsiveness. To improve the responsiveness, default IO throttle count is reduced to 256. 3) Accessing Virtual Fabric Id (vfid) and fc_map of Fibre-Channel Forwarder(FCF) is invalid in fnic driver when Clear Virtual Link(CVL) is received prior to receiving flogi reject from switch. As CVL clears all FCFs. Signed-off-by: Hiral Shah <[email protected]> Signed-off-by: Sesidhar Baddela <[email protected]> Signed-off-by: Narsimhulu Musini <[email protected]> Signed-off-by: Anantha Tungarakodi <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Update the driver version to 8.07.00.08-k.Saurav Kashyap1-1/+1
Signed-off-by: Giridhar Malavali <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Remove wait for online from host reset handler.Chad Dupuis2-46/+6
This can block progress of the SCSI error handler thread and cause long I/O outages. Instead just fail immediately if another reset is going on or we are accessing flash memory. Signed-off-by: Chad Dupuis <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Do logins from a chip reset in DPC thread instead of the error ↵Chad Dupuis2-39/+7
handler thread. Attempting to do any logins from the SCSI reset handler can lead to a deadlock scenario if a rport times out and the FC transport layer. Move doing any port logins to the DPC thread so as not to impede the progress of the SCSI error handler thread and avoid deadlock situations. Signed-off-by: Chad Dupuis <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: ABTS cause double free of qla_tgt_cmd +.Quinn Tran1-3/+26
Fix double free problem within qla2xxx driver where current code prematurely free qla_tgt_cmd while firmware still has the command. When firmware release the command after abort, the code attempt a second free as part of command completion processing. When TCM start the free process, NULL pointer was hit. ------ WARNING: CPU: 8 PID: 43613 at lib/list_debug.c:62 __list_del_entry+0x82/0xd0() list_del corruption. next->prev should be ffff88082b5cfb08, but was 6b6b6b6b6b6b6b6b CPU: 8 PID: 43613 Comm: kworker/8:0 Tainted: GF W O 3.13.0-rc3-nab_t10dif+ #6 Hardware name: HP ProLiant DL380p Gen8, BIOS P70 08/20/2012 Workqueue: events cache_reap 000000000000003e ffff88081b2e3c78 ffffffff815a051f 000000000000003e ffff88081b2e3cc8 ffff88081b2e3cb8 ffffffff8104fc2c 0000000000000000 ffff88082b5cfb00 ffff88081c788d00 ffff88082b5d7200 ffff88082b5d3080 Call Trace: [<ffffffff815a051f>] dump_stack+0x49/0x62 [<ffffffff8104fc2c>] warn_slowpath_common+0x8c/0xc0 [<ffffffff8104fd16>] warn_slowpath_fmt+0x46/0x50 [<ffffffff812b6592>] __list_del_entry+0x82/0xd0 [<ffffffff8106d48c>] process_one_work+0x12c/0x510 [<ffffffff8106d4d3>] ? process_one_work+0x173/0x510 [<ffffffff8106ebdf>] worker_thread+0x11f/0x3a0 [<ffffffff8106eac0>] ? manage_workers+0x170/0x170 [<ffffffff81074f26>] kthread+0xf6/0x120 [<ffffffff8109f103>] ? __lock_release+0x133/0x1b0 [<ffffffff81074e30>] ? __init_kthread_worker+0x70/0x70 [<ffffffff815aec2c>] ret_from_fork+0x7c/0xb0 [<ffffffff81074e30>] ? __init_kthread_worker+0x70/0x70 ---[ end trace dfc05c3f7caf8ebe ]--- BUG: unable to handle kernel NULL pointer dereference at 0000000000000008 IP: [<ffffffff8106d391>] process_one_work+0x31/0x510 ------- Signed-off-by: Quinn Tran <[email protected]> Signed-off-by: Giridhar Malavali <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: T10-Dif: add T10-PI supportQuinn Tran10-76/+851
Add support for T10-Dif for Target Mode to qla driver. The driver will look for firmware attribute that support this feature. When the feature is present, the capabilities will be report to TCM layer. Add CTIO CRC2 iocb to build T10-Dif commands. Add support routines to process good & error cases. Signed-off-by: Quinn Tran <[email protected]> Signed-off-by: Nicholas Bellinger <[email protected]> Signed-off-by: Giridhar Malavali <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Remove mapped vp index iterator macro dead code.Himanshu Madhani1-7/+0
Signed-off-by: Himanshu Madhani <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Add MBC option for fast SFP data access.Joe Carnuccio1-1/+1
Signed-off-by: Joe Carnuccio <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Fix beacon blink logic for ISP26xx/83xx.Himanshu Madani2-7/+6
Signed-off-by: Himanshu Madani <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Don't check for firmware hung during the reset context for ISP82XX.Tej Prakash1-30/+13
Signed-off-by: Tej Prakash <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Delay driver unload if there is any pending activity going on.Sawan Chandak1-0/+24
Signed-off-by: Sawan Chandak <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: ISP27xx queue index shadow registers.Joe Carnuccio6-11/+33
For ISP27xx use the request/response queue index shadow registers to avoid directly access them on the PCI bus. Signed-off-by: Joe Carnuccio <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: ISP27xx firmware dump template spec updates (including T274).Joe Carnuccio3-33/+78
Signed-off-by: Joe Carnuccio <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Reduce the time we wait for a command to complete during SCSI error ↵Chad Dupuis1-1/+1
handling. Signed-off-by: Chad Dupuis <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Check the QLA8044_CRB_DRV_ACTIVE_INDEX register when we are not the ↵Hiral Patel3-63/+59
owner of the reset. Signed-off-by: Hiral Patel <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Clear loop_id for ports that are marked lost during fabric scanning.Chad Dupuis1-1/+1
Signed-off-by: Chad Dupuis <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Adjust adapter reset routine to the changes in firmware ↵Armen Baloyan2-8/+48
specification for ISPFx00. Signed-off-by: Armen Baloyan <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Avoid escalating the SCSI error handler if the command is not found ↵Chad Dupuis3-5/+26
in firmware. If the firmware cannot find the command specified then return SUCCESS to the error handler so as not to needlessly escalate. Also cleanup the resources for the command since we cannot expect the original command to returned in interrupt context. Signed-off-by: Chad Dupuis <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: IOCB data should be copied to I/O mem using memcpy_toio.Atul Deshmukh1-1/+1
Signed-off-by: Atul Deshmukh <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: ISP8044 poll ipmdio bus timeout improvement.Joe Carnuccio1-8/+7
Signed-off-by: Joe Carnuccio <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Remove unnecessary printk_ratelimited from qla_nx2.cChad Dupuis1-2/+0
Signed-off-by: Chad Dupuis <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Include <delay.h> file for msleep declartion in qla_nx2.c file.Atul Deshmukh1-0/+1
Signed-off-by: Atul Deshmukh <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Use proper log message for flash lock failed error.Atul Deshmukh3-3/+7
Signed-off-by: Atul Deshmukh <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Decrease pci access for response queue processing for ISPFX00.Armen Baloyan1-1/+1
Signed-off-by: Armen Baloyan <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Change copyright year to 2014 in all the source files.Armen Baloyan29-29/+29
Signed-off-by: Armen Baloyan <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
2014-05-19qla2xxx: Update entry type 270 to match spec update.Joe Carnuccio1-1/+1
Increment the address by 4 on each iteration. Signed-off-by: Joe Carnuccio <[email protected]> Signed-off-by: Saurav Kashyap <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.