aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-07-05iio: hid-sensors: Fix compilation warningSachin Kamat1-2/+2
Move the 'static' keyword to beginning of definition to silence the following compilation warning: drivers/iio/common/hid-sensors/hid-sensor-attributes.c:34:1: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration] Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2014-07-03iio: xilinx-xadc: Remove unused variableSachin Kamat1-6/+0
'offset’ is not used in the function. Remove it. Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Cc: Michal Simek <michal.simek@xilinx.com> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2014-07-03iio: ad5686: Remove redundant variableSachin Kamat1-2/+1
‘regdone’ is not used in the function. Remove it. Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Cc: Michael Hennerich <hennerich@blackfin.uclinux.org> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2014-07-03iio: ad5504: Remove redundant variableSachin Kamat1-4/+1
By re-arranging the code, 'ret' can be removed from this function. Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2014-07-03iio: ad5624r_spi: Remove redundant variableSachin Kamat1-4/+1
By re-arranging the code, 'ret' can be removed from this function. Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2014-07-03iio: adis16400: Remove unused variableSachin Kamat1-2/+1
'rx' is not used in this function. Remove it. Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com> Acked-by: Lars-Peter Clausen <lars@metafoo.de> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
2014-07-01staging: cxt1e1: remove driverKristina Martšenko31-10070/+0
Remove the driver as it hasn't been cleaned up and it doesn't look like anyone is going to work on it anymore. This can be reverted if someone wants to work to fix the remaining issues the driver has. Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com> Cc: Bob Beers <bob.beers@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-30staging: dgrp: remove driverKristina Martšenko18-10404/+0
Remove the driver as it hasn't been cleaned up and it doesn't look like anyone is going to work on it anymore. This can be reverted if someone wants to work to fix the remaining issues the driver has. Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com> Cc: Bill Pemberton <wfp5p@worldbroken.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-30staging: serqt_usb2: remove driverKristina Martšenko5-1541/+0
Remove the driver as it hasn't been cleaned up and it doesn't look like anyone is going to work on it anymore. This can be reverted if someone wants to work to fix the remaining issues the driver has. Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com> Cc: Bill Pemberton <wfp5p@virginia.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-30staging: wlags49_h2(5): remove driverKristina Martšenko80-44844/+0
Remove the driver as it hasn't been cleaned up and it doesn't look like anyone is going to work on it anymore. Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com> Cc: Henk de Groot <pe1dnn@amsat.org> Cc: David Kilroy <kilroyd@googlemail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: gdm72xx: use lower case for variable names for consistencyBen Chan2-20/+20
Signed-off-by: Ben Chan <benchan@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: gdm72xx: use int instead of u32 whenever makes senseBen Chan2-11/+10
This patch addresses the following issues: - Use int instead of u32 whenever makes sense - Turn extract_qos_list() in gdm_qos.c, which previously always returned 0, into a void function. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Reported-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Ben Chan <benchan@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: gdm72xx: use bool instead of custom-defined BOOLEANBen Chan2-8/+6
Signed-off-by: Ben Chan <benchan@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: gdm72xx: return -EINVAL instead of BUG_ON for invalid data lengthBen Chan2-2/+4
This patch changes gdm_usb_send() and gdm_sdio_send() to return -EINVAL instead of calling BUG_ON if an invalid data length is passed to the functions. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Reported-by: Michalis Pappas <mpappas@fastmail.fm> Signed-off-by: Ben Chan <benchan@chromium.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: dgnc_driver.c: code style fixesGuillaume Morin1-6/+5
Simple code style fixes: - "if(" -> "if (" - "switch(" -> "switch (" - move one open brace to the line of the declaration instead of its own line - remove trailing whitespace Signed-off-by: Guillaume Morin <guillaume@morinfr.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29Staging: rtl8192ee: fixed tab coding style issue in base.hMorgan S. Stuart1-2/+2
Fixes the tab error found in base.h, reported by checkpatch.pl tool Signed-off-by: Morgan Stuart <morgansstuartdev@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29drivers/staging/rtl8821ae/rtl8821ae/hal_btc.c: remove unnecessary null test ↵Fabian Frederick1-2/+1
before kfree Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com> Cc: devel@driverdev.osuosl.org Signed-off-by: Fabian Frederick <fabf@skynet.be> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: wlan-ng/hfa384x_usb.c: add blank line after declarationsCheng-Wei Lee1-0/+1
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c: WARNING: Missing a blank line after declarations Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: lustre: lnet: api-ni.c: fixed sparse warningsAnil Belur1-12/+12
- this fixes few sparse warnings for missing static in functions: drivers/staging/lustre/lnet/lnet/api-ni.c:63:6: warning: symbol 'lnet_get_routes' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:69:6: warning: symbol 'lnet_get_networks' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:93:1: warning: symbol 'lnet_init_locks' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:102:1: warning: symbol 'lnet_fini_locks' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:180:6: warning: symbol 'lnet_assert_wire_constants' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:273:7: warning: symbol 'lnet_find_lnd_by_type' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:419:1: warning: symbol 'lnet_create_interface_cookie' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:450:1: warning: symbol 'lnet_res_container_cleanup' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:494:1: warning: symbol 'lnet_res_container_setup' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:612:1: warning: symbol 'lnet_prepare' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:917:1: warning: symbol 'lnet_shutdown_lndnis' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/api-ni.c:1034:1: warning: symbol 'lnet_startup_lndnis' was not declared. Should it be static? Signed-off-by: Anil Belur <askb23@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29drivers/staging/lustre/lustre/llite: sparse warning correctionsSami Laine1-29/+30
Sparse warning corrections: NULL-pointers as NULL instead of static 0's. Signed-off-by: Sami Laine <laine.j.sami@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29Staging: bcm: Lines shortened in download_ddr_settings()Matthias Beyer1-10/+21
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29Staging: bcm: Lines shortened in ddr_init()Matthias Beyer1-42/+134
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29Staging: bcm: Moved doubled if-blockMatthias Beyer1-11/+5
This patch moves the doubled if block inside the retval-checking one level up. As the if-else-block it was in is now a one-statement if-else block, I removed the braces from it. Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29Staging: bcm: Fixed indention for inner if-blockMatthias Beyer1-5/+5
The inner if-statement was aligned just like the outer one. Why? This indention was introduced by f34c488c3894968e8cdbdc3b1ed617d78315cace which is a indention-fix patch itself. That's why I'm curious about it. I did not merge these nested if-statements, as I don't know if I'm destroying logical seperated checks with it. Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29Staging: bcm: Indentation fixesMatthias Beyer1-15/+15
This patch fixes some indentation errors, where multi-line statements where not indented. Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29Staging: bcm: Misc whitespace fixesMatthias Beyer1-18/+18
Signed-off-by: Matthias Beyer <mail@beyermatthias.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: vt6656: device_init_registers move out vnt_set_bss_modeMalcolm Priestley1-1/+3
Move to vnt_add_interface and allow to refresh at the start of every software scan in vnt_sw_scan_start Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: vt6656: set BBvSetVGAGainOffset inside vnt_set_bss_modeMalcolm Priestley2-5/+2
vnt_set_bss_mode changes the state of abyBBVGA so move BBvSetVGAGainOffset to the function. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: vt6656: remove vnt_add_basic_rateMalcolm Priestley3-28/+2
The driver never sets basic rate any more so remove function. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: vt6656: dead code remove RXvWorkItem and RXvFreeRCBMalcolm Priestley3-98/+0
Remove work_struct and queue variables Remove EnqueueRCB and DequeueRCB macros Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: vt6656: Remove rx handing from RXvWorkItemMalcolm Priestley2-33/+30
In s_nsBulkInUsbIoCompleteRead reuse or reallocate sb_buff and resubmit urb. In device_alloc_bufs allocate memory to rcb individually and call PIPEnsBulkInUsbRead to submit the urbs Change handling to free rcb in device_free_rx_bufs Remove calls to workqueue. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: vt6656: vnt_tx_packet remove first assignment of time_stamp.Malcolm Priestley1-3/+0
This is assigned later in function and should have been removed in an out-of-tree merge. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: vt6656: rxtx replace wFragCtl with frag_ctl.Malcolm Priestley2-7/+7
Use base type to __le16 and do endian correction. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: vt6656: rxtx struct vnt_mic_hdr change tsc_47_16/tsc_15_0Malcolm Priestley2-9/+2
Replace with ccmp_pn with size of IEEE80211_CCMP_PN_LEN(6) memcpy the struct ieee80211_key_seq -> ccmp.pn onto ccmp_pn removing the need for endian conversion. Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: mite: cleanup mite_unsetup()H Hartley Sweeten8-45/+17
This function is only called by comedi drivers during the (*detach) of the driver. After it is called mite_free() is always called to kfree the allocated mite_struct pointer. Rename this function to mite_detach() and merge the kfree() from mite_free() into it. Remove the unnecessary clearing of the mite variables since the mite pointer is going to be kfree()'d anyway. The mite_detach() function checks if the pointer is valid so remove the unnecessary checks in the callers. The check can also be removed in ni_660x since the ni_660x_free_mite_rings() function does not actually need the 'mite' pointer. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: mite.h: remove mite_device()H Hartley Sweeten1-5/+0
This inline function is not used. Just remove it. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: mite.h: remove mite_irq()H Hartley Sweeten6-11/+6
This inline function simply returns the 'irq' of the struct pci_dev pointer that is stored in struct mite_struct. This pci_dev pointer is the same as the one that is already available in the (*auto_attach) functions where mite_irq() is used. Use the pci_dev pointer directly to get the irq and remove the unnecessary inline function to remove the indirection. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_pcimio: remove ATMIO and PCIMIO definesH Hartley Sweeten1-3/+0
These defines were probably intended to be used so that ni_mio_common.c could detect if it was included by a driver that uses ioport or memory mapped register access. This can actually be detected by checking if the 'mite' member in the private data has been allocated. Regardless, the symbols are not used. Just remove them. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_mio_cs: remove ATMIO and PCIMIO definesH Hartley Sweeten1-3/+0
These defines were probably intended to be used so that ni_mio_common.c could detect if it was included by a driver that uses ioport or memory mapped register access. This can actually be detected by checking if the 'mite' member in the private data has been allocated. Regardless, the symbols are not used. Just remove them. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_atmio: remove ATMIO and PCIMIO definesH Hartley Sweeten1-3/+0
These defines were probably intended to be used so that ni_mio_common.c could detect if it was included by a driver that uses ioport or memory mapped register access. This can actually be detected by checking if the 'mite' member in the private data has been allocated. Regardless, the symbols are not used. Just remove them. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_pcimio: remove DRV_NAME defineH Hartley Sweeten1-2/+0
This define is not used ny the driver. Remove it. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_stc.h: the boardinfo 'name' should be firstH Hartley Sweeten3-15/+15
By convention, the first member of the boardinfo is a 'const char *' to the board name, especially for those comedi drivers that rely on the comedi core to set dev->board_ptr to the entry matching the board name when doing a legacy (*attach) to a comedi driver. Modify the ni_board_struct appropriately for consistency, although the board name is only used for informational purposes by this driver (only the driver name is matched by the comedi core). For aesthetics, also move the members in the boardinfo declarations. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_atmio: tidy up the boardinfoH Hartley Sweeten1-130/+131
For aesthetics, add some whitespace to the boardinfo declaration. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_mio_cs: remove NI_SIZE defineH Hartley Sweeten1-2/+0
This define is not used by the driver. Remove it. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_atmio: remove NI_SIZE defineH Hartley Sweeten1-3/+1
This define is only used in the comedi_request_region() to specify the size of the region. Remove the define and just open code the value. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_atmio: remove '= 0' boardinfo dataH Hartley Sweeten1-20/+0
Remove all the boardinfo data the is set to '0'. They will default to that when the boardinfo is declared. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_mio_common.c: remove IRQ_POLARITY definesH Hartley Sweeten4-11/+6
Pass the irq_polarity to ni_E_init() and remove the defines. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_mio_common drivers: remove NI_E_IRQ_FLAGS definesH Hartley Sweeten2-6/+2
These defines are only used in the request_irq() calls. Remove them and just open code the values. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_mio_common.c: remove interrupt_pin() macrosH Hartley Sweeten4-11/+6
Pass the 'interrupt_pin' to ni_E_init() and remove the macros. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-29staging: comedi: ni_pcimio: remove forward declarationsH Hartley Sweeten1-72/+62
Move some functions to avoid the need for the forward declarations. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Powered by cgit, Gruvboxed by Blaster4385.