aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-01-25Staging: rtl8723bs: Use !x instead of NULL comparisonShreeya Patel1-8/+8
If "x" is compared to NULL, use "!x" instead of it, so as to follow the kernel coding style. Signed-off-by: Shreeya Patel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-25Staging: rtl8723bs: Remove dead codeShreeya Patel1-15/+0
"oldmem==NULL;" The above bug under the ifdef code would have caused a GCC warning if it were ever compiled. Hence, remove the dead ifdefed code from the file. Signed-off-by: Shreeya Patel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-25Staging: rtl8723bs: Change names to conform to the kernel codeShreeya Patel1-357/+357
Change names of some variables and functions to conform to the kernel coding style. The changes include some removal of CamelCase warnings and renaming the variable and field names that encode their type (eg the pointers seem to start with p). Signed-off-by: Shreeya Patel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-25staging: ccree: Fix missing blank line after declarationKamal Heib1-0/+1
Fix the following warning found by checkpatch.pl WARNING: Missing a blank line after declarations + struct cc_cipher_handle *blkcipher_handle = drvdata->blkcipher_handle; + if (blkcipher_handle) { Signed-off-by: Kamal Heib <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-25staging: rtl8188eu: remove redundant initialization of 'pwrcfgcmd'Colin Ian King1-1/+1
Structure pwrcfgcmd is being zero'd at initialization however this value is never read as few statements later in a loop it is being assigned a new value, hence the initialization is redundant and can be removed. Cleans up clang warning: drivers/staging/rtl8188eu/hal/pwrseqcmd.c:25:20: warning: Value stored to 'pwrcfgcmd' during its initialization is never read Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-25staging: rtlwifi: remove unused RTLHALMAC_ST and RTLPHYDM_STCorentin Labbe1-10/+0
Since nothing builds/depends on RTLHALMAC_ST and RTLPHYDM_ST, we could remove them. Furthermore, they are totally undocumented Signed-off-by: Corentin Labbe <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-25staging: fbtft: remove unused FB_TFT_SSD1325 kconfigCorentin Labbe1-6/+0
Since nothing builds/depends on FB_TFT_SSD1325, we could remove it. Signed-off-by: Corentin Labbe <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-23staging: comedi: dt2811: remove redundant initialization of 'ns'Colin Ian King1-1/+1
Variable ns is being initialized with a value that is never read, ns is being re-assigned a new value later on. Remove the redundant initialization. Cleans up clang warning: drivers/staging/comedi/drivers/dt2811.c:310:21: warning: Value stored to 'ns' during its initialization is never read Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-23staging: wilc1000: fix alignments to match open parenthesisAjay Singh3-22/+22
Fix "Alignment should match open parenthesis" issues reported by checkpatch.pl script. changes to comply with linux coding style. Signed-off-by: Ajay Singh <[email protected]> Reviewed-by: Claudiu Beznea <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-23staging: wilc1000: removed unnecessary defined enums typedefAjay Singh1-36/+36
Fix the "do not add new typedefs" issue found by checkpatch.pl script Signed-off-by: Ajay Singh <[email protected]> Reviewed-by: Claudiu Beznea <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-23staging: wilc1000: remove unnecessary use of parenthesesAjay Singh8-51/+51
Fix "Unnecessary parentheses around" issue found by checkpatch.pl script.Remove the unnecessary parentheses to follow linux coding style. Signed-off-by: Ajay Singh <[email protected]> Reviewed-by: Claudiu Beznea <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-23staging: rtl8192u: remove redundant initialization of 'timeout'Colin Ian King1-1/+1
Variable timeout is initialized however this value is never read and it is reassigned a new value a little later, hence the initialization is redundant and can be removed. Cleans up clang warning: drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1728:6: warning: Value stored to 'timeout' during its initialization is never read Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-23staging: sm750fb: fix CamelCase for dispSet varPetr Sedlak1-7/+7
Fix warning reported by checkpatch: CHECK: Avoid CamelCase: <dispSet> By renaming dispSet to disp_set Signed-off-by: Petr Sedlak <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-23staging: lustre: lnet/selftest: fix compile error on UP buildNeilBrown1-9/+8
When compiled without CONFIG_SMP, we get a compile error as ->ctb_parts is not defined. There is already a function, cfs_cpt_cpumask(), which will get the cpumask we need, and which handles the UP case by returning a NULL pointer. So use that and handle NULL. Also avoid the #ifdef by allocating a cpumask_var and copying into it, rather than sharing the mask. Reported-by: kbuild test robot <[email protected]> Fixes: 6106c0f82481 ("staging: lustre: lnet: convert selftest to use workqueues") Signed-off-by: NeilBrown <[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: rtl8723bs: hal_com_phycfg: Remove unneeded semicolonsChristopher Díaz Riveros1-9/+7
Trivial fix removes unneeded semicolons after switch blocks. This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: rts5208: Fix "seg_no" calculation in reset_ms_card()Dan Carpenter1-1/+2
I get some static checker warnings like this: drivers/staging/rts5208/ms.c:2607 ms_build_l2p_tbl() error: buffer underflow 'ms_card->segment' (-1)-16 The problem is that we memset "ms_card" to zero at the start of the reset_ms_card() function. That means that when we try to calculate "ms_card->total_block / 512 - 1" then it's just always -1. The fix is to calculate "seg_no" before doing the memset(). This is a static checker fix, and I am not able to test it. My theory is that reset_ms_card() gets very little testing which is why this bug exists. Fixes: fa590c222fba ("staging: rts5208: add support for rts5208 and rts5288") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: greybus: audio_codec.h Fix alignment should match open parenthesisKamal Heib1-1/+1
Fix "Alignment should match open parenthesis" checkpatch.pl errors. Signed-off-by: Kamal Heib <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: greybus: audio_codec.h: Prefer kernel type 'u32' over 'uint32_t'Kamal Heib1-5/+5
Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Kamal Heib <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: greybus: audio_codec.c: Prefer kernel type 'u32' over 'uint32_t'Kamal Heib1-3/+3
Fix the following errors found by checkpatch.pl: CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Kamal Heib <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: greybus: audio_codec.c: Logical continuations should be on the ↵Kamal Heib1-2/+2
previous line Fix the following error found by checkpatch.pl: CHECK: Logical continuations should be on the previous line Signed-off-by: Kamal Heib <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: greybus: audio_codec.c: Space required around ':'Kamal Heib1-2/+2
Space is required when using the question mark operator around ':' Signed-off-by: Kamal Heib <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: greybus: audio_codec.c: Cleanup blank linesKamal Heib1-3/+0
Remove the blank lines. Signed-off-by: Kamal Heib <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: greybus: audio_codec.c: Fix alignment should match open parenthesisKamal Heib1-3/+3
Cleanup "Alignment should match open parenthesis" checkpatch.pl errors. Signed-off-by: Kamal Heib <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: greybus: authentication.c: Fix alignment should match open parenthesisKamal Heib1-1/+1
Fix the following error found by checkpatch.pl: CHECK: Alignment should match open parenthesis +static int cap_ioctl(struct gb_cap *cap, unsigned int cmd, + void __user *buf) Signed-off-by: Kamal Heib <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: rtl8192e: remove two redundant assignmentsColin Ian King2-2/+1
Clang detected two redundant assignments that can be safely removed. The first is the removal of the duplicated assignment to pointer 'hdr', this has already been initialized with the same value. The second is the removal of the redundant initialization of variable 'timeout', this assigned value is never read and the variable is reassigned a new value a little later. Remove both redundant assignments, cleans up clang warnings: drivers/staging/rtl8192e/rtllib_rx.c:1305:27: warning: Value stored to 'hdr' during its initialization is never read drivers/staging/rtl8192e/rtllib_softmac.c:1971:6: warning: Value stored to 'timeout' during its initialization is never read Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: rtl8712: remove redundant initialization to 'rfPath'Colin Ian King1-1/+1
The value stored to rfPath during initialization is never read, the following switch statement re-assigns it a new value on all the case and default paths. Hence the initialization is redundant and can be removed. Cleans up clang warning: drivers/staging/rtl8712/rtl871x_mp.c:544:5: warning: Value stored to 'rfPath' during its initialization is never read Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: fsl-mc: Add SPDX license identifiersBogdan Purcareata32-563/+36
The fsl-mc bus and dpio driver files use a combination of GPL-2.0 and GPL-2.0+ OR BSD-3-Clause licenses. Add SPDX tags and delete the full license text, keeping the existing license for each file. Add GPL-2.0 for Kconfig / Makefile, where not present. Signed-off-by: Bogdan Purcareata <[email protected]> Reviewed-by: Laurentiu Tudor <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: most: replace function name to __func__Sidong Yang1-1/+1
Fix checkpatch.pl warning message about logging code. Previous code contains hard coded function name. Fix this code by using __func__ macro. Signed-off-by: Sidong Yang <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: lustre: libcfs: Prevent harmless read underflowDan Carpenter1-1/+1
Because this is a post-op instead of a pre-op, then it means we check if knl_buffer[-1] is a space. It doesn't really hurt anything, but it causes a static checker warning so let's fix it. Fixes: d7e09d0397e8 ("staging: add Lustre file system client support") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: lustre: lnet: remove null check before kfreeSumit Pundir1-2/+1
Since kfree(NULL) is safe there is no need to place a check before it. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: lustre: lnet: prefer kcalloc over kzalloc with multiplySumit Pundir1-2/+2
Use kcalloc for allocating an array instead of kzalloc with multiply. kcalloc is the preferred API. Issue reported by checkpatch.pl Signed-off-by: Sumit Pundir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: lustre: Align struct member identifiersFabian Huegel1-22/+22
This patch properly left aligns all member identifiers in every struct defined in obd_class.h for better readability. Signed-off-by: Fabian Huegel <[email protected]> Signed-off-by: Christoph Volkert <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-22staging: lustre: Fix comment styleFabian Huegel1-20/+27
Most multi-line comments started on the first line, but the preferred linux kernel style is to start multi-line comments on the second line. Some comments became less readable after the change, so we changed them to single-line comments. Signed-off-by: Fabian Huegel <[email protected]> Signed-off-by: Christoph Volkert <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename strStatistics & tenuAuth_type to avoid camelCaseAjay Singh1-15/+15
This is a cleanup patch to avoid using camelCase for variable names. Changes fix "Avoid camelCase" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename pstrCfgParamVal varaible in set_wiphy_params()Ajay Singh1-11/+11
This is a cleanup patch to fix camelCase issue found by checkpatch.pl script. In this patch, renamed pstrCfgParamVal to cfg_param_val to avoid camelCase for variable name. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename strStaParams variable to avoid camelCaseAjay Singh1-22/+22
This is a cleanup patch to rename strStaParams to sta_params to avoid camelCase. Changes fix "Avoid camelCase" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename variables using camelCase in add_key()Ajay Singh1-28/+28
This is a cleanup patch to avoid using camelCase for variable names. Changes fix "Avoid camelCase" issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename NullBssid to null_bssid to avoid camelCase ↵Ajay Singh1-4/+4
variable name This is cleanup patch, it fixes "Avoid CamelCase: <NullBssid>" found by checkpatch.pl. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename pstrWFIDrv to wfi_drv to avoid camelCase namingAjay Singh1-18/+18
This is cleanup patch, it fixes "Avoid CamelCase: <pstrWFIDrv>" issue found by checkpatch.pl Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename camelCase used in functions start with WILC_WFI_CfgAjay Singh1-17/+17
This is cleanup patch, to fix the camelCase issue reported by checkpatch.pl. In this patch remane the function starts with "WILC_WFI_Cfg" to avoid camelCase names. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename CfgConnectResult() and its local variable namesAjay Singh1-37/+37
This is cleanup patch,to avoid use of camelCase for variable name and function names in CfgConnectResult(). Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename s32Error variable to avoid camelCase notationAjay Singh1-69/+69
This is cleanup patch, rename "s32Error" to fix "Avoid CamelCase: <s32Error>" found by checkpatch.pl script. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: remove unused element in wilc_wfi_p2p_listen_params structAjay Singh1-1/+0
This is cleanup patch, to remove the unused "tenuChannelType" element from wilc_wfi_p2p_listen_params structure. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename au8Sta_AssociatedBss element sta_info structureAjay Singh2-5/+5
This is a cleanup patch, to rename au8Sta_AssociatedBss element of sta_info structure. The changes fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename wilc_wfi_p2pListenParams struct and its member ↵Ajay Singh2-20/+20
variable This is a cleanup patch to avoid the use of camelCase for variable names. In this patch, "Avoid camelCase" issue found by checkpatch.pl is fixed. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: wilc1000: rename elements of wilc_priv struct to avoid using camelCaseAjay Singh2-53/+53
This is cleanup patch, to avoid the use of camelCase for "wilc_priv" structure member variables. The changes fix the camelCase issue reported by checkpatch.pl script. Signed-off-by: Ajay Singh <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: fsl-mc: make function its_fsl_mc_msi_init staticColin Ian King1-1/+1
The function its_fsl_mc_msi_init is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'its_fsl_mc_msi_init' was not declared. Should it be static? Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: fsl-mc: Convert documentation to rst formatIoana Radulescu2-387/+404
Update the doc file to comply with the rst format. It's not integrated into the documentation build structure yet, since it's still located in drivers/staging. Signed-off-by: Ioana Radulescu <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: dgnc: drop unused neo_uart_structGreg Kroah-Hartman2-6/+1
Now that the "neo" portion of the driver is gone (it was never being used), drop the unused neo_uart_struct variable as well. Cc: Lidza Louina <[email protected]> Cc: Mark Hounschell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2018-01-17staging: dgnc: remove "vpd" board variableGreg Kroah-Hartman3-31/+0
It was only ever read from the device, and spit out to the kernel log for no good reason. So remove it, and the way it was read from the device, and the now unused "board file" callback. Cc: Lidza Louina <[email protected]> Cc: Mark Hounschell <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.