aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-06-20staging: rtl8192e: remove comparison to trueMichael Straube1-1/+1
Remove a comparison to true reported by checkpatch. CHECK: Using comparison to true is error prone Signed-off-by: Michael Straube <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-20staging: rtl8192e: remove return statement from void functionMichael Straube1-1/+0
Remove unnecessary return statement from the void function rtl92e_config_mac(). Issue found by checkpatch. WARNING: void function return statements are not generally useful Signed-off-by: Michael Straube <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-20staging: rtl8192e: convert else if sequence to switchMichael Straube1-5/+9
Convert a sequence of else if statements that all check the same variable to a single switch statement. With a switch statement it is easier to see what is going on. Additionally this clears a checkpatch warning. WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: Michael Straube <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-20staging: rtl8192e: clean up brace coding style issuesMichael Straube7-22/+30
Clean up brace coding style in if/else statements to improve readability and clear checkpatch issues. CHECK: braces {} should be used on all arms of this statement CHECK: Unbalanced braces around else statement Signed-off-by: Michael Straube <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-20staging: rtl8723bs: Fix blank line issuesFranziska Naepelt1-46/+0
Fix the following checkpatch blank line issues: - CHECK: Please don't use multiple blank lines - CHECK: Blank lines aren't necessary before a close brace '}' - CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: Franziska Naepelt <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-20staging: rtl8723bs: Fix block comment issueFranziska Naepelt1-5/+5
Fix the following checkpatch block comment issue: - WARNING: Block comments use * on subsequent lines Signed-off-by: Franziska Naepelt <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-20staging: rtl8723bs: Fix indentation issuesFranziska Naepelt1-3/+3
Fix the following checkpatch indentation issues: - WARNING: suspect code indent for conditional statements (32, 48) - WARNING: suspect code indent for conditional statements (24, 24) - ERROR: code indent should use tabs where possible Signed-off-by: Franziska Naepelt <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-20staging: vchiq_arm: Remove extra struct vchiq_instance declarationUmang Jain1-2/+0
Additional declaration of struct vchiq_instance was introduced in the commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks"). Drop the extra declaration. Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks") Signed-off-by: Umang Jain <[email protected]> Reviewed-by: Stefan Wahren <[email protected]> Reviewed-by: Kieran Bingham <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Rename variable InitialGainHandlerYogesh Hegde3-4/+4
Rename variable InitialGainHandler to init_gain_handler to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde <[email protected]> Link: https://lore.kernel.org/r/a2f37a6cb962e9775978ae5f4fde958b74806a4e.1687183827.git.yogi.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Rename variable LeisurePSLeaveYogesh Hegde4-4/+4
Rename variable LeisurePSLeave to leisure_ps_leave to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde <[email protected]> Link: https://lore.kernel.org/r/3c63f4d750b7365f233c35c676325c5e4ca54a4c.1687183827.git.yogi.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Rename variable SetBWModeHandlerYogesh Hegde4-8/+8
Rename variable SetBWModeHandler to set_bw_mode_handler to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde <[email protected]> Link: https://lore.kernel.org/r/fe6c16cfe1d8f7ff41b5fce90fc63383fbfec4f5.1687183827.git.yogi.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Rename variable SetWirelessModeYogesh Hegde3-8/+8
Rename variable SetWirelessMode to set_wireless_mode to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde <[email protected]> Link: https://lore.kernel.org/r/c0a65d217d272bf457917c89462c49e67bbfedb2.1687183827.git.yogi.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Rename RTLLIB_LINKED_SCANNINGPhilipp Hortmann4-6/+6
Rename RTLLIB_LINKED_SCANNING to MAC80211_LINKED_SCANNING to align with rtlwifi driver. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/25b97cd436c636e750c50f0c03386fcc46e56610.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Rename RTLLIB_LINKED to MAC80211_LINKEDPhilipp Hortmann11-62/+62
Rename RTLLIB_LINKED to MAC80211_LINKED to align with rtlwifi driver. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/532bd98301657b2a8329e95eccb993540ae9ba3f.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Rename RTLLIB_NOLINK to MAC80211_NOLINKPhilipp Hortmann4-20/+20
Rename RTLLIB_NOLINK to MAC80211_NOLINK to align with rtlwifi driver. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/74feefdf800304deaf918efbc04344865f7aa01d.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Rename state to link_statePhilipp Hortmann11-99/+99
Rename state to link_state to align with rtlwifi driver and to increase readability as state is to general. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/9cf4d0b01c6a84a11939099b628754d4c6d54839.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Rename rtllib_state to rtl_link_statePhilipp Hortmann1-2/+2
Rename rtllib_state to rtl_link_state to align with rtlwifi driver and to increase readability as state is to general. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/f21541c16c83356e3cd1e08059847ef9a9eb2ef8.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Remove unused enum led_ctl_modePhilipp Hortmann1-11/+0
Remove unused enum led_ctl_mode to shorten code. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/554729dba4d9358bdd6146ebd8fa17a0f525702e.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Rename constant IEEE_x to WIRELESS_MODE_xPhilipp Hortmann10-39/+34
Rename constant IEEE_B to WIRELESS_MODE_B, IEEE_G -> WIRELESS_MODE_G and IEEE_N_24G -> WIRELESS_MODE_N_24G to align with rtlwifi driver as requested in TODO. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/37d81ab3cbb0231868d75b11eaa2f65a0e6a9379.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Remove unsupported modes IEEE_N_5G and IEEE_APhilipp Hortmann6-20/+6
Remove unsupported modes IEEE_N_5G and IEEE_A as those are not supported by hardware and are not offered by user software. Remove resulting dead code and unused defines. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/40c5b21654376348144280dbe45203140c6e6807.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Remove variable stats->freq as it is constantPhilipp Hortmann3-20/+5
stats->freq is initialized with 1 and then unchanged. All evaluations will result accordingly. Remove resulting dead code and unused defines. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/4d8801d37889e6af4f43dff10d1426fc7918f562.1687007788.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-19staging: rtl8192e: Add missing entry CFG80211 in KconfigPhilipp Hortmann1-0/+1
Add missing entry CFG80211 in Kconfig to ensure that CFG80211 is available when selecting hardware rtl8192e. Fixes: d88b46ce5ab8 ("staging: rtl8192e: Add cfg80211.h and remove defined variables") Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/20230618194454.GA10653@matrix-ESPRIMO-P710 Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-17axis-fifo: remove the unnecessary dev_info()Prathu Baronia1-3/+0
This dev_info() statement is not needed since drivers need to be quiet under normal operation and its not a good idea to print addresses in kernel log. Signed-off-by: Prathu Baronia <[email protected]> Message-ID: <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-15staging: rtl8192e: Use standard api to calculate channel to frequencyPhilipp Hortmann3-15/+6
Use ieee80211_channel_to_freq_khz() to calculate channel to frequency to omit proprietary code. Signed-off-by: Philipp Hortmann <[email protected]> Message-ID: <c3a94a403d04ba810cffff8afa734a94a218a4e9.1686166624.git.philipp.g.hortmann@gmail.com> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-15staging: rtl8192e: Use standard api to calculate frequency to channelPhilipp Hortmann1-8/+1
Use ieee80211_freq_khz_to_channel() to calculate frequency to channel to omit proprietary code. Signed-off-by: Philipp Hortmann <[email protected]> Message-ID: <fc332e81f6677965e9e51f1fcef9815997effcb5.1686166624.git.philipp.g.hortmann@gmail.com> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-15staging: rtl8192e: Add cfg80211.h and remove defined variablesPhilipp Hortmann2-12/+1
Add cfg80211 and remove defined variables rfc1042_header and bridge_tunnel_header as they are then already defined. Usage of cfg80211 is required to merge driver into wireless subsystem. Signed-off-by: Philipp Hortmann <[email protected]> Message-ID: <20230603085251.GA20230@matrix-ESPRIMO-P710> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-15staging: rtl8192e: remove blank linesMichael Straube13-159/+0
Remove unnecessary blank lines reported by checkpatch. Signed-off-by: Michael Straube <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Message-ID: <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-06-15Staging: rts5208: rtsx: Removed new line in else and else ifDeepanshu Kartikey1-13/+7
Removed new line in else and else if, this warning was given by checkpatch.pl Signed-off-by: Deepanshu Kartikey <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Message-ID: <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: clean unnecessary braces warning on r8192E_phy.cDavid Tadokoro1-2/+1
Clean a checkpatch.pl warning of type "braces {} are not necessary for single statement blocks" on r8192E_phy.c file. Signed-off-by: David Tadokoro <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: pi433: Remove stray gpiod_unexport() callAndy Shevchenko1-1/+0
There is no gpiod_export() and gpiod_unexport() looks pretty much stray. If user space tools somehow belong to that, they should be fixed, the gpiod_export() and gpiod_unexport() shouldn't be used in a new code, GPIO sysfs is deprecated. That said, and taking into account staging state of the driver, simply drop the stray call. Signed-off-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: most: Switch i2c driver back to use .probe()Uwe Kleine-König1-1/+1
After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct i2c_driver. Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: olpc_dcon: Switch i2c driver back to use .probe()Uwe Kleine-König1-1/+1
After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() call-back type"), all drivers being converted to .probe_new() and then 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert back to (the new) .probe() to be able to eventually drop .probe_new() from struct i2c_driver. Signed-off-by: Uwe Kleine-König <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28drivers: staging: wlan-ng: Remove GPL/MPL boilerplateBagas Sanjaya21-441/+0
Remove the license boilerplate as there is already SPDX license identifier added in b24413180f5600 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") which fulfills the same intention as the boilerplate. Cc: Dan Carpenter <[email protected]> Cc: Kate Stewart <[email protected]> Cc: Philippe Ombredanne <[email protected]> Cc: Thomas Gleixner <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: Bagas Sanjaya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: vchiq_arm: mark vchiq_platform_init() staticArnd Bergmann1-2/+2
This function has no callers from other files, and the declaration was removed a while ago, causing a W=1 warning: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:465:5: error: no previous prototype for 'vchiq_platform_init' Marking it static solves this problem but introduces a new warning since gcc determines that 'g_fragments_base' is never initialized in some kernel configurations: In file included from include/linux/string.h:254, from include/linux/bitmap.h:11, from include/linux/cpumask.h:12, from include/linux/mm_types_task.h:14, from include/linux/mm_types.h:5, from include/linux/buildid.h:5, from include/linux/module.h:14, from drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:8: In function 'memcpy_to_page', inlined from 'free_pagelist' at drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:433:4: include/linux/fortify-string.h:57:33: error: argument 2 null where non-null expected [-Werror=nonnull] include/linux/highmem.h:427:9: note: in expansion of macro 'memcpy' 427 | memcpy(to + offset, from, len); | ^~~~~~ Add a NULL pointer check for this in addition to the static annotation to avoid both. Fixes: 89cc4218f640 ("staging: vchiq_arm: drop unnecessary declarations") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Reviewed-by: Umang Jain <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: add missing spaces around operatorsMichael Straube6-94/+94
Add missing spaces around operators to improve readability and clear checkpatch issues. Signed-off-by: Michael Straube <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Unlock wx_mutex not in rtllib_wx_set_scanPhilipp Hortmann1-3/+1
On start of rtllib_wx_set_scan lock was taken with mutex_lock(&ieee->wx_mutex). Unlocking was done at the end of schedule_work(&ieee->wx_sync_scan_wq) which lead to the error "lock held when returning to user space!". Pushing lock to beginning of ieee->wx_sync_scan_wq to improve overview. Removed lock from rtllib_wx_set_scan as ieee->state, ieee->iw_mode and ieee->proto_started are not protected in many other places. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/20230516192206.GA7710@matrix-ESPRIMO-P710 Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Exclude scan_mutex in rtllib_softmac_stop_scanPhilipp Hortmann1-3/+3
Exclude scan_mutex from cancel_delayed_work_sync(&ieee->softmac_scan_wq) as ieee->softmac_scan_wq takes scan_mutex as well. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/20230514204033.GA20187@matrix-ESPRIMO-P710 Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8723bs: replace ternary operator with if-else blockAtin Bainada1-1/+4
replace the ternary operator used for assignment of pHalData->ant_path with an if-else block for better readability Signed-off-by: Atin Bainada <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Remove undefined function LedControlHandlerPhilipp Hortmann5-46/+0
Remove function LedControlHandler as it is not defined. Remove resulting unused local variables bLedBlinking, type, fc and LedAction. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/e3c29c3db33d314dffb673f8e563da0fb1f2b22f.1683960685.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Remove undefined function UpdateBeaconInterruptHandlerPhilipp Hortmann3-10/+0
Remove function UpdateBeaconInterruptHandler as it is not defined. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/7cc71096fb1e6fee755dd96de0095ef1fb6d51e1.1683960685.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Remove undefined function SetFwCmdHandlerPhilipp Hortmann3-13/+3
Remove function SetFwCmdHandler as it is not defined. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/e141f44176aab38e11d7211ed79cebda68aea5ed.1683960685.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Remove undefined function set_securityPhilipp Hortmann2-8/+0
Remove function set_security as it is not defined. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/bdc9bc3a70ca2b5d86bdd2cb5c815d0b3c67972f.1683960684.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Remove undefined function hard_start_xmitPhilipp Hortmann2-14/+1
Remove function hard_start_xmit as it is not defined. Equation !ieee->hard_start_xmit always evaluates to true. When (*ieee->hard_start_xmit)(txb, dev) == 0 is called the my computer is freezing. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/603a143ba506ca031d7bd70a844b9f080872d601.1683960684.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Remove undefined function reset_portPhilipp Hortmann2-21/+0
Remove function reset_port as it is not defined. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/faa1fa979b214f709012a8bd65debbcc2bb59049.1683960684.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Remove functions rtllib_start_hw_scan and stopPhilipp Hortmann2-21/+3
Remove functions rtllib_start_hw_scan and rtllib_stop_hw_scan as they are not defined. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/868524470321b8936f63d3ea06ba86c34fc89bb7.1683960684.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Remove undefined function data_hard_resumePhilipp Hortmann3-29/+2
Remove function data_hard_resume as it is not defined. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/07048d775759fffe1d1c63d0416214da8311129a.1683960684.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: rtl8192e: Remove undefined function data_hard_stopPhilipp Hortmann3-14/+0
Remove function data_hard_stop as it is not defined. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/4cc180b9538d6c9c32ff0f56646a642fa217a4a4.1683960684.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-28staging: add HAS_IOPORT dependenciesNiklas Schnelle2-2/+2
In a future patch HAS_IOPORT=n will result in inb()/outb() and friends not being declared. We thus need to add HAS_IOPORT as dependency for those drivers using them. Co-developed-by: Arnd Bergmann <[email protected]> Signed-off-by: Arnd Bergmann <[email protected]> Signed-off-by: Niklas Schnelle <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-13staging: rtl8192e: Refactor tmp_ofdm_index variable assignmentYogesh Hegde1-2/+2
Refactor tmp_ofdm_index variable assignment to avoid multiple assignments which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/af7bc22ec142c33cf7346c1ab13d192b55095d1e.1683730854.git.yogi.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-05-13staging: rtl8192e: Rename tmpCCK20Mindex and tmpCCK40MindexYogesh Hegde1-14/+14
Rename variable tmpCCK20Mindex to tmp_cck_20m_index and tmpCCK40Mindex to tmp_cck_40m_index to avoid CamelCase which is not accepted by checkpatch. Signed-off-by: Yogesh Hegde <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/3e8b6cd85e6e4fcc934cc1d813f5f594cef8ff92.1683730854.git.yogi.kernel@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.