aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-10-21staging: qlge: Retire the driverBenjamin Poirier17-10841/+0
No significant improvements have been done to this driver since commit a7c3ddf29a78 ("staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land") in January 2021. The driver should not stay in staging forever. Since it has been abandoned by the vendor and no one has stepped up to maintain it, delete it. If some users manifest themselves, the driver will be restored to drivers/net/ as suggested in the linked message. Link: https://lore.kernel.org/netdev/[email protected]/ Suggested-by: Jakub Kicinski <[email protected]> Cc: Manish Chopra <[email protected]> Cc: Coiby Xu <[email protected]> Signed-off-by: Benjamin Poirier <[email protected]> Acked-by: Jakub Kicinski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-21staging: qlge: Update TODOBenjamin Poirier1-10/+5
Update TODO file to reflect the changes that have been done: * multiple functions were renamed to have the "qlge_" prefix in commit f8c047be5401 ("staging: qlge: use qlge_* prefix to avoid namespace clashes with other qlogic drivers") * a redundant memset() was removed in commit 953b94009377 ("staging: qlge: Initialize devlink health dump framework") * the loop boundary in ql(ge)_alloc_rx_buffers() was updated in commit e4c911a73c89 ("staging: qlge: Remove rx_ring.type") * pci_enable_msi() was replaced in commit 4eab532dca76 ("staging: qlge/qlge_main.c: Replace depracated MSI API.") * pci_dma_* were replaced in commit e955a071b9b3 ("staging: qlge: replace deprecated apis pci_dma_*") * the while loops were rewritten in commit 41e1bf811ace ("Staging: qlge: Rewrite two while loops as simple for loops") * indentation was fixed in commit 0eb79fd1e911 ("staging: qlge: cleanup indent in qlge_main.c") I also slipped in one new TODO item, naughty me! Signed-off-by: Benjamin Poirier <[email protected]> Acked-by: Jakub Kicinski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17staging: wlan-ng: remove function prism2sta_ev_txexcCalvince Otieno3-28/+2
The function prism2sta_ev_txexc() is called by the function hfa384x_usbin_txcompl() to print the transmit exception event - a debug information using netdev_dbg(). The debugging utility function can be called directly by hfa384x_usbin_txcompl(). Signed-off-by: Calvince Otieno <[email protected]> Link: https://lore.kernel.org/r/ZS5eKFCfu7sGOCHL@lab-ubuntu Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17staging: wlan-ng: use netdev_dbg over pr_debugCalvince Otieno1-58/+69
This patch replaces the usage of pr_debug() with netdev_dbg(). The change is made to enhance context-aware debugging, improve code clarity, and maintain compatibility with established network debugging practices. There were no functional code changes. Signed-off-by: Calvince Otieno <[email protected]> Link: https://lore.kernel.org/r/ZS5RSsaNvOvshNj6@lab-ubuntu Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17staging: greybus: Modify lines end with a '('Nandha Kumar Singaram1-4/+3
Adhere to linux coding style. Reported by checkpatch.pl: CHECK: Lines should not end with a '(' Signed-off-by: Nandha Kumar Singaram <[email protected]> Link: https://lore.kernel.org/r/20231017023544.GA6684@ubuntu Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17staging: vt6655: Rename variable byBBPreEDRSSIGilbert Adikankwu2-2/+2
Remove byte Type encoding "by" from variable name and replace camelcase with snakecase. Mute checkpatch error: CHECK: Avoid CamelCase: <byBBPreEDRSSI> Signed-off-by: Gilbert Adikankwu <[email protected]> Link: https://lore.kernel.org/r/d525f5837bb343001447646fe17746370256694f.1697495598.git.gilbertadikankwu@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17staging: vt6655: Rename variable byCurPwrGilbert Adikankwu4-6/+6
Remove byte Type encoding "by" from variable name and replace camelcase with snakecase Mute checkpatch.pl error: CHECK: Avoid CamelCase: <byCurPwr> Signed-off-by: Gilbert Adikankwu <[email protected]> Link: https://lore.kernel.org/r/4c24962988ac990ae21c95e4a1754cfabfd2db8d.1697495598.git.gilbertadikankwu@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17staging: vt6655: Rename variable byCurrentChGilbert Adikankwu2-7/+7
Remove byte Type encoding "by" from variable name and replace camelcase with snakecase. Mute checkpatch.pl error: CHECK: Avoid CamelCase: <byCurrentCh> Signed-off-by: Gilbert Adikankwu <[email protected]> Link: https://lore.kernel.org/r/cd4c073d0e67e2ce6ed9f38a7add9bbd2fe760ce.1697495598.git.gilbertadikankwu@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17staging: vt6655: Rename variable bUpdateBBVGAGilbert Adikankwu4-6/+6
Remove bool Type encoding "b" from variable name and replace camelcase with snakecase. Mute checkpatch.pl error: CHECK: Avoid CamelCase: <bUpdateBBVGA> Signed-off-by: Gilbert Adikankwu <[email protected]> Link: https://lore.kernel.org/r/9bd935c464671db2654c654964812cc48f4603d3.1697495598.git.gilbertadikankwu@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17Staging: sm750fb: Rename ddk750_setModeTimingDorcas AnonoLitunya3-3/+3
Rename function ddk750_setModeTiming to ddk750_set_mode_timing. This patch affects three files as the function is imported to other external files. This follows snakecase naming convention and ensures a consistent naming style throughout the file. Issue found by checkpatch. Mutes the following checkpatch error: CHECK:Avoid CamelCase: <ddk750_setModeTiming> Signed-off-by: Dorcas AnonoLitunya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17Staging: sm750fb: Rename programModeRegistersDorcas AnonoLitunya1-3/+3
Rename function programModeRegisters to program_mode_registers. This follows snakecase naming convention and ensures a consistent naming style throughout the file. Issue found by checkpatch. Mutes the following checkpatch error: CHECK: Avoid CamelCase: <programModeRegisters> Signed-off-by: Dorcas AnonoLitunya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17Staging: sm750fb: Rename dispControlDorcas AnonoLitunya1-16/+16
Rename variable dispControl to disp_control. This follows snakecase naming convention and ensures a consistent naming style throughout the file. Issue found by checkpatch. Mutes the following checkpatch error: CHECK: Avoid CamelCase: <dispControl> Signed-off-by: Dorcas AnonoLitunya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17Staging: sm750fb: Rename pModeParamDorcas AnonoLitunya1-26/+26
Rename variable pModeParam to mode_param. This follows snakecase naming convention and ensures a consistent naming style throughout the file. Issue found by checkpatch. Mutes the following checkpatch error: CHECK: Avoid CamelCase: <pModeParam> Signed-off-by: Dorcas AnonoLitunya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17Staging: sm750fb: Rename displayControlAdjust_SM750EDorcas AnonoLitunya1-3/+3
Rename function displayControlAdjust_SM750E to display_control_adjust_SM750E. This follows snakecase naming convention and ensures a consistent naming style throughout the file. Issue found by checkpatch. Mutes the following error: CHECK:Avoid CamelCase: <displayControlAdjust_SM750E> Signed-off-by: Dorcas AnonoLitunya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-17staging: rtl8192u: remove entry from MakefileGreg Kroah-Hartman1-1/+0
In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the driver was removed, along with the Kconfig entry, but the Makefile line in drivers/staging/Makefile was not updated, so things like 'make clean' fail to work properly as they will decend into all subdirectories to try to clean things up. Resolve this by removing the entry in the main staging Makefile. Reported-by: Thorsten Leemhuis <[email protected]> Cc: Philipp Hortmann <[email protected]> Cc: Arnd Bergmann <[email protected]> Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver") Tested-by: Thorsten Leemhuis <[email protected]> Link: https://lore.kernel.org/r/2023101709-amuck-upward-46f1@gregkh Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-16staging: wlan-ng: replace pr_debug() with netdev_dbg()Calvince Otieno1-6/+6
This patch replaces the usage of pr_debug() with netdev_dbg(). The change is made to enhance context-aware debugging, improve code clarity, and maintain compatibility with established network debugging practices. There were no functional code changes. Signed-off-by: Calvince Otieno <[email protected]> Link: https://lore.kernel.org/r/ZS0AZahhusLoN4b/@lab-ubuntu Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-16staging: wlan-ng: replace strncpy() with strscpy()Calvince Otieno1-1/+1
Checkpatch suggests the use of strscpy() instead of strncpy(). The advantages are that it always adds a NUL terminator and it prevents a read overflow if the src string is not properly terminated. One potential disadvantage is that it doesn't zero pad the string like strncpy() does. In this code, strscpy() and strncpy() are equivalent and it does not affect runtime behavior. The string is zeroed on the line before using memset(). The resulting string was always NUL terminated and PRISM2_USB_FWFILE is string literal "prism2_ru.fw" so it's NUL terminated. However, even though using strscpy() does not fix any bugs, it's still nicer and makes checkpatch happy. Signed-off-by: Calvince Otieno <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/ZSzapU+eKWvHVwxi@lab-ubuntu Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-16staging: wlan-ng: remove undefined functionCalvince Otieno1-3/+0
The function p80211wext_get_wireless_stats() is declared in the code but has neither been defined nor referenced. It's definition was removed 13 years ago in the commit cb3126e60ffc ("Staging: wlan-ng: Switch from wext to cfg80211") Signed-off-by: Calvince Otieno <[email protected]> Link: https://lore.kernel.org/r/ZSzphFeckE7dM5g/@lab-ubuntu Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-16staging: wlan-ng: remove unnecessary helper functionCalvince Otieno1-28/+2
The function prism2sta_inf_handover() is called by the parent function prism2sta_ev_info() to print a literal debug information string using pr_debug(). The debugging utility function can be called directly within prism2sta_ev_info(). Furthermore, to make the debugging more module-specific, the netdev_dbg() function is preferred over the generic pr_debug() utility function. Signed-off-by: Calvince Otieno <[email protected]> Link: https://lore.kernel.org/r/ZSzJuwlEKPBj9kLN@lab-ubuntu Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-16staging: wlan-ng: remove unused function prototypesCalvince Otieno1-8/+0
These functions are declared but not defined or used anywhere. Their definitions were removed 15 years ago. prism2mgmt_set_grpaddr() was removed in the commit 1e7201836c57 ("Staging: wlan-ng: Delete a pile of unused mibs. And fix WEXT SET_TXPOWER.") It's signature was changed in the commit 5a2214e2e02f ("staging: wlang-ng: avoid new typedef: hfa384x_t") prism2mgmt_get_grpaddr() and prism2mgmt_get_grpaddr_index() were removed in the commit cbec30c4c00c ("Staging: wlan-ng: Delete a large pile of now-unused code.") Signed-off-by: Calvince Otieno <[email protected]> Link: https://lore.kernel.org/r/ZSxFS8EnFr998PqS@lab-ubuntu Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: qlge: Replace the occurrences of (1<<x) by BIT(x)Nandha Kumar Singaram1-2/+2
Adhere to linux coding style. Reported by checkpatch.pl: CHECK: Prefer using the BIT macro Signed-off-by: Nandha Kumar Singaram <[email protected]> Link: https://lore.kernel.org/r/20231015133558.GA5489@ubuntu Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: vme_user: Add spaces around '<<' operatorSoumya Negi1-274/+274
Add spaces around all instances of << in the header vme_tsi148.h to conform with Linux coding style. Issue found by checkpatch.pl Signed-off-by: Soumya Negi <[email protected]> Link: https://lore.kernel.org/r/f84f353dedc28f99e42d2419b379ace41d0cb218.1697240381.git.soumya.negi97@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: vme_user: Add spaces around '*'Soumya Negi1-1/+1
Add space around * operator to adhere to Linux coding style. Issue found by checkpatch.pl Signed-off-by: Soumya Negi <[email protected]> Link: https://lore.kernel.org/r/81181dcc1ffa648f32cbe3c4ec8731e66349e450.1697240381.git.soumya.negi97@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: vme_user: Fix unbalanced {} in if-else blocksSoumya Negi2-4/+6
Add missing braces so that {} are balanced in all arms of if-else statements as per Linux coding style. Issue found by checkpatch.pl Signed-off-by: Soumya Negi <[email protected]> Link: https://lore.kernel.org/r/b0fad6de7405a105235b3b595e0bb2c51be7dcf0.1697240381.git.soumya.negi97@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: vme_user: Correct spelling mistakes in commentsSoumya Negi1-2/+2
Fix misspelled words in vme.c. Issue found by checkpatch.pl Signed-off-by: Soumya Negi <[email protected]> Link: https://lore.kernel.org/r/f41caa8e7c987fdc010942838117fece8151affe.1697240381.git.soumya.negi97@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: vt6655: Type encoding info dropped from variable name "byBBVGANew"Pavan Bobba2-8/+8
variable name "byBBVGANew" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/abb105b822090a82ef081b2e28705bf14b8ce058.1696791459.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: vt6655: Type encoding info dropped from variable name "byBBVGACurrent"Pavan Bobba4-10/+10
variable name "byBBVGACurrent" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/f0dfd4d2460f858540d465dd8bcfc920c219e94d.1696791459.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: vt6655: Type encoding info dropped from array name "abyBBVGA"Pavan Bobba4-26/+26
array name "abyBBVGA" updated like below: a.type encoding info dropped from name b.camelcase name replaced by snakecase Issue found by checkpatch Signed-off-by: Pavan Bobba <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/13a233dff4d6daf728f75ab18b38ec9d0703764b.1696791459.git.opensource206@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15Staging: rtl8192e: Rename variable pTSTree Davies4-65/+65
Rename variable pTS to ts to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15Staging: rtl8192e: Rename variable ReasonCodeTree Davies1-13/+13
Rename variable ReasonCode to reason_code to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15Staging: rtl8192e: Rename variable TSInfoTree Davies3-5/+5
Rename variable TSInfo to ts_info to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15Staging: rtl8192e: Rename variable pBaTree Davies1-3/+3
Rename variable pBa to ba to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: rtl8192e: Remove unused enums dm_dig_sta and dm_dig_algPhilipp Hortmann1-19/+0
Remove unused enums dm_dig_sta and dm_dig_alg. Remove unused entries of enum dm_dig_connect. Signed-off-by: Philipp Hortmann <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/0aab74bcda5f582a5fe44a4c1405940d0c8261ad.1697127817.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: rtl8192e: Remove unused variable dig_statePhilipp Hortmann2-5/+0
Remove variable dig_state as it is unused. Remove unused variable dig_highpwr_state as well. Signed-off-by: Philipp Hortmann <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/7bacd7e152a2d044527924d57efdbbaae0f4c9e8.1697127817.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: rtl8192e: Remove unchanged variable dig_algorithm_switchPhilipp Hortmann2-20/+0
Remove variable dig_algorithm_switch as its value is set to 0 at initialization. The equations result accordingly. Remove dead code. Signed-off-by: Philipp Hortmann <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/a76d8b86f2591446a071b4f614adf628b0fe5c93.1697127817.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: rtl8192e: Remove _rtl92e_dm_ctrl_initgain_byrssi_false_alarm()Philipp Hortmann1-115/+0
Remove function _rtl92e_dm_ctrl_initgain_byrssi_false_alarm() as it is unused. Remove in above function called function _rtl92e_dm_ctrl_initgain_byrssi_highpwr() as well. Signed-off-by: Philipp Hortmann <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/80a5a0b67d9d225a58c96781c33e2216c0ea1c6e.1697127817.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: rtl8192e: Remove unchanged variable dig_algorithmPhilipp Hortmann3-20/+1
Remove variable dig_algorithm as its value is set to DIG_ALGO_BY_RSSI at initialization. No further writes to dig_algorithm are done. The equations result accordingly. Remove dead code. Signed-off-by: Philipp Hortmann <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/66f7275aa46e68577cc4c20582ffbd16de13f470.1697127817.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: rtl8192e: Remove unchanged variable dig_enable_flagPhilipp Hortmann2-12/+0
Remove variable dig_enable_flag as its value is set to 1 at initialization. No further writes to dig_enable_flag are done. The equations result accordingly. Remove dead code. Signed-off-by: Philipp Hortmann <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/24a9245840093c5a14124f9fc896433c7d85d18c.1697127817.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: rts5208: Remove macros scsi_lock(), scsi_unlock()Soumya Negi2-19/+12
The scsi_lock() and scsi_unlock() macros protect the sm_state and the single queue element srb for write access in the driver. As suggested, these names are very generic. Remove the macros from header file and call spin_lock_irq() & spin_unlock_irq() directly instead. Suggested-by: Dan Carpenter <[email protected]> Suggested-by: Julia Lawall <[email protected]> Signed-off-by: Soumya Negi <[email protected]> Link: https://lore.kernel.org/r/75a5990190cf7a5d20d1c27237b90b583e68ced8.1697152251.git.soumya.negi97@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: rts5208: Refactor macros to static inline functionsSoumya Negi1-19/+40
Driver rts5208 uses macros to read/write data & to perform generic PCI functions. Rewrite these macros as static inline functions in the header file. Suggested-by: Dan Carpenter <[email protected]> Suggested-by: Julia Lawall <[email protected]> Signed-off-by: Soumya Negi <[email protected]> Link: https://lore.kernel.org/r/c7431fe4d7f72138d8dc86269794f87c30d21a38.1697152251.git.soumya.negi97@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: rtl8192u: Remove broken driverPhilipp Hortmann48-29816/+0
Tests on rtl8192u hardware have shown that this driver is broken since 2016. Remove broken driver. Find fix for two bugs in second link. Link: https://lore.kernel.org/lkml/[email protected]/ Link: https://lore.kernel.org/lkml/[email protected]/ Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/20231014211051.GA29518@matrix-ESPRIMO-P710 Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-15staging: greybus: Add __counted_by for struct apr_rx_buf and use struct_size()Gustavo A. R. Silva1-2/+2
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). While there, use struct_size() helper, instead of the open-coded version, to calculate the size for the allocation of the whole flexible structure, including of course, the flexible-array member. This code was found with the help of Coccinelle, and audited and fixed manually. Signed-off-by: "Gustavo A. R. Silva" <[email protected]> Reviewed-by: Kees Cook <[email protected]> Reviewed-by: Alex Elder <[email protected]> Link: https://lore.kernel.org/r/ZSR2O6zGyT/VX6ve@work Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-07staging: rtl8192e: Remove unused file rtllib_debug.hPhilipp Hortmann2-48/+0
Remove #define DRV_NAME "rtllib_92e" as it is already set. Remove enum RTL_DEBUG as it is unused. Remove #include <linux/bits.h> as it is unused. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/b7b61bd068e8090b954e3c025bc724d9e85fc568.1696548527.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-07staging: rtl8192e: Remove unused variable rt_global_debug_componentPhilipp Hortmann2-5/+0
Remove unused variable rt_global_debug_component. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/082272e20dc0659e7700f7756a6bf1a8b71c411e.1696548527.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-07staging: rtl8192e: Remove function _rtl92e_wx_set_debug()Philipp Hortmann1-40/+0
Remove function _rtl92e_wx_set_debug() as this functionality is not commonly used and the tool to access it is deprecated. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/887ca5f66bad5105eeba449a9bd3e40be4b835ce.1696548527.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-07staging: rtl8192e: Remove unchanged variable active_scanPhilipp Hortmann3-5/+1
Remove variable active_scan as its value is set to 1 at initialization. No further writes to active_scan are done. The equation results accordingly. Remove dead code. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/eea9f6cb1feeb8aa5beb546034562f55a03da449.1696548527.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-07staging: rtl8192e: Remove function _rtl92e_wx_set_scan_type()Philipp Hortmann1-20/+0
Remove function _rtl92e_wx_set_scan_type() as this functionality is not commonly used and the tool to access it is deprecated. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/8a0ce95447dbd736e3aeec5f7aa0e997f916b7d8.1696548527.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-07staging: rtl8192e: Remove constant variable ps_forcePhilipp Hortmann2-3/+1
Remove constant variable ps_force as its value is always 0. The equation results accordingly. Remove dead code. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/ecebc90415c202e4e465bfb5b10c54be8b42e684.1696548527.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-07staging: rtl8192e: Remove function _rtl92e_wx_adapter_power_status()Philipp Hortmann1-37/+0
Remove function _rtl92e_wx_adapter_power_status() as this functionality is not commonly used and the tool to access it is deprecated. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/2fc8f18019c760125ae7c52c765271d2877c52bd.1696548527.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2023-10-07staging: rtl8192e: Remove constant variable reg_max_lps_awake_intvlPhilipp Hortmann3-18/+1
Remove constant variable reg_max_lps_awake_intvl as this value is just written to MaxPeriod. Function _rtl92e_init_priv_constant() is then empty and can be removed as well. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/d5b2ccc0f10c28f960552dd2b2c5ec83aa62041f.1696548527.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>