aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-04-24bcache: Make sure blocksize isn't smaller than device blocksizeKent Overstreet1-2/+6
Sanity check to make sure we don't end up doing IO the device doesn't support. Signed-off-by: Kent Overstreet <[email protected]>
2013-04-22bcache: Fix merge_bvec_fn usage for when it modifies the bvmKent Overstreet1-9/+8
Stacked md devices reuse the bvm for the subordinate device, causing problems... Reported-by: Michael Balser <[email protected]> Signed-off-by: Kent Overstreet <[email protected]>
2013-04-20bcache: Correctly check against BIO_MAX_PAGESKent Overstreet1-5/+4
bch_bio_max_sectors() was checking against BIO_MAX_PAGES as if the limit was for the total bytes in the bio, not the number of segments. Signed-off-by: Kent Overstreet <[email protected]>
2013-04-20bcache: Hack around stuff that clones up to bi_max_vecsKent Overstreet1-0/+9
Signed-off-by: Kent Overstreet <[email protected]>
2013-04-20bcache: Set ra_pages based on backing device's ra_pagesKent Overstreet1-0/+4
Signed-off-by: Kent Overstreet <[email protected]>
2013-04-20bcache: Take data offset from the bdev superblock.Kent Overstreet3-57/+100
Add a new superblock version, and consolidate related defines. Signed-off-by: Gabriel de Perthuis <[email protected]> Signed-off-by: Kent Overstreet <[email protected]>
2013-04-08bcache: Disable broken btree fuzz testerKent Overstreet1-2/+4
Reported-by: <[email protected]> Signed-off-by: Kent Overstreet <[email protected]>
2013-04-08bcache: Fix a format string overflowKent Overstreet1-2/+2
Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Kent Overstreet <[email protected]>
2013-04-08bcache: Fix a minor memory leak on device teardownKent Overstreet1-1/+3
Reported-by: Mike Snitzer <[email protected]> Signed-off-by: Kent Overstreet <[email protected]>
2013-04-08bcache: Documentation updatesKent Overstreet1-0/+88
Signed-off-by: Kent Overstreet <[email protected]>
2013-04-08bcache: Use WARN_ONCE() instead of __WARN()Kent Overstreet1-1/+1
Signed-off-by: Kent Overstreet <[email protected]>
2013-04-08bcache: Add missing #include <linux/prefetch.h>Geert Uytterhoeven2-0/+2
m68k/allmodconfig: drivers/md/bcache/bset.c: In function ‘bset_search_tree’: drivers/md/bcache/bset.c:727: error: implicit declaration of function ‘prefetch’ drivers/md/bcache/btree.c: In function ‘bch_btree_node_get’: drivers/md/bcache/btree.c:933: error: implicit declaration of function ‘prefetch’ Signed-off-by: Geert Uytterhoeven <[email protected]> Signed-off-by: Kent Overstreet <[email protected]>
2013-04-08bcache: Sparse fixesKent Overstreet4-90/+92
Signed-off-by: Kent Overstreet <[email protected]>
2013-03-28bcache: Don't export utility code, prefix with bch_Kent Overstreet13-101/+89
Signed-off-by: Kent Overstreet <[email protected]> Cc: [email protected] Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: fix if(); found by kbuild test robotLars Ellenberg1-1/+1
Recently introduced al_begin_io_nonblock() was returning -EBUSY, even when it should return -EWOULDBLOCK. Impact: A few spurious wake_up() calls in prepare_al_transaction_nonblock(). Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: use sched_setscheduler()Philipp Reisner2-3/+5
It was unnoticed for some time that assigning to current->policy is no longer sufficient to set a real time priority for a kernel thread. Reported-by: Charlie Suffin <[email protected]> Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: fix for deadlock when using automatic split-brain-recoveryPhilipp Reisner1-1/+0
With an automatic after split-brain recovery policy of "after-sb-1pri call-pri-lost-after-sb", when trying to drbd_set_role() to R_SECONDARY, we run into a deadlock. This was first recognized and supposedly fixed by 2009-06-10 "Fixed a deadlock when using automatic split brain recovery when both nodes are" replacing drbd_set_role() with drbd_change_state() in that code-path, but the first hunk of that patch forgets to remove the drbd_set_role(). We apparently only ever tested the "two primaries" case. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: add module_put() on error path in drbd_proc_open()Alexey Khoroshilov1-2/+8
If single_open() fails in drbd_proc_open(), module refcount is left incremented. The patch adds module_put() on the error path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <[email protected]> Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: fix drbd epoch write count for ahead/behind modeLars Ellenberg1-7/+7
The sanity check when receiving P_BARRIER_ACK does expect all write requests with a given req->epoch to have been either all replicated, or all not replicated. Because req->epoch was assigned before calling maybe_pull_ahead(), this expectation was not met, leading to an off-by-one in the sanity check, and further to a "Protocol Error". Fix: move the call to maybe_pull_ahead() a few lines up, and assign req->epoch only after that. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: Fix build error when CONFIG_CRYPTO_HMAC is not setPhilipp Reisner1-2/+2
Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: validate resync_after dependency on attach alreadyLars Ellenberg2-3/+18
We validated resync_after dependencies, if changed via disk-options. But we did not validate them when first created via attach. We also did not check or cleanup dependencies that used to be correct, but now point to meanwhile removed minor devices. If the drbd_resync_after_valid() validation in disk-options tried to follow a dependency chain in this way, this could lead to NULL pointer dereference. Validate resync_after settings in drbd_adm_attach() already, as well as in drbd_adm_disk_opts(), and and only reject dependency loops. Depending on non-existing disks is allowed and equivalent to no dependency. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: fix memory leakLars Ellenberg1-0/+1
We forgot to free the disk_conf, so for each attach/detach cycle we leaked 336 bytes. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: only fail empty flushes if no good data is reachableLars Ellenberg2-4/+16
We completed empty flushes (blkdev_issue_flush()) with IO error if we lost the local disk, even if we still have an established replication link to a healthy remote disk. Fix this to only report errors to upper layers, if neither local nor remote data is reachable. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: Fix disconnect to keep the peer disk state if connection breaks during ↵Philipp Reisner4-10/+15
operation The issue was that if the connection broke while we did the gracefull state change to C_DISCONNECTING (C_TEARDOWN), then we returned a success code from the state engine. (SS_CW_NO_NEED) The result of that is that we missed to call the fence-peer script in such a case. Fixed that by introducing a new error code (SS_OUTDATE_WO_CONN). This one should never reach back into user space. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: fix spurious warning about bitmap being locked from detachPhilipp Reisner1-1/+5
Introduced in drbd: always write bitmap on detach, the bitmap bulk writeout on detach was indicating it expected exclusive bitmap access. Where I meant to say: expect no more modifications, but testing/counting is still allowed. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: drop now useless duplicate state request from invalidatePhilipp Reisner1-34/+28
Patch best viewed with git diff --ignore-space-change. Now that we attempt the fallback to local bitmap operation only when disconnected, we can safely drop the extra "silent" state request from both invalidate and invalidate-remote. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: fix effective error returned when refusing an invalidatePhilipp Reisner1-0/+7
Since commit drbd: Disallow the peer_disk_state to be D_OUTDATED while connected trying to invalidate a disconnected Primary returned an error code that did not really match the situation: "Refusing to be Outdated while Connected" Insert two more specific conditions into is_valid_state(), changing that to "Need access to UpToDate data", respectively "Need a connection to start verify or resync". Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: move invalidating the whole bitmap out of after_state ch()Philipp Reisner2-23/+20
To avoid other state change requests, after passing through sanitize_state(), to be mistaken for an invalidate, move the "set all bits as out-of-sync" into the invalidate path. Make invalidate and invalidate-remote behave consistently wrt. current connection state (need either an established replication link, or really be disconnected). Also mention that in the documentation. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: abort start of resync early, if it raced with connection breakagePhilipp Reisner1-1/+3
We've seen a spurious full resync, because a connection breakage raced with drbd_start_resync(, C_SYNC_TARGET), and the resulting state change request intended to start the resync ended up looking like a local invalidate. Fix: Double check the state inside the lock, and don't even request that state change, if we had connection or IO problems. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28drbd: reset ap_in_flight counter for new connectionsPhilipp Reisner1-0/+1
Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-28idr: document exit conditions on idr_for_each_entry betterGeorge Spelvin1-4/+6
And some manual common subexpression elimination which may help the compiler produce smaller code. Signed-off-by: George Spelvin <[email protected]> Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-25bcache: Fix for the build fixesKent Overstreet1-1/+0
Commit 82a84eaf7e51ba3da0c36cbc401034a4e943492d left a return 0 in closure_debug_init(). Whoops. Signed-off-by: Kent Overstreet <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-25aoe: get rid of cached bv variable in bufinit()Jens Axboe1-4/+2
Less error prone if we just kill it, it's only used once anyway. Signed-off-by: Jens Axboe <[email protected]>
2013-03-25bcache: Style/checkpatch fixesKent Overstreet10-56/+51
Took out some nested functions, and fixed some more checkpatch complaints. Signed-off-by: Kent Overstreet <[email protected]> Cc: [email protected] Signed-off-by: Jens Axboe <[email protected]>
2013-03-25bcache: Build fixes from test robotKent Overstreet5-5/+6
config: make ARCH=i386 allmodconfig All error/warnings: drivers/md/bcache/bset.c: In function 'bch_ptr_bad': >> drivers/md/bcache/bset.c:164:2: warning: format '%li' expects argument of type 'long int', but argument 4 has type 'size_t' [-Wformat] -- drivers/md/bcache/debug.c: In function 'bch_pbtree': >> drivers/md/bcache/debug.c:86:4: warning: format '%li' expects argument of type 'long int', but argument 4 has type 'size_t' [-Wformat] -- drivers/md/bcache/btree.c: In function 'bch_btree_read_done': >> drivers/md/bcache/btree.c:245:8: warning: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t' [-Wformat] -- drivers/md/bcache/closure.o: In function `closure_debug_init': >> (.init.text+0x0): multiple definition of `init_module' >> drivers/md/bcache/super.o:super.c:(.init.text+0x0): first defined here Signed-off-by: Kent Overstreet <[email protected]> Cc: Fengguang Wu <[email protected]> Cc: [email protected] Signed-off-by: Jens Axboe <[email protected]>
2013-03-24Merge branch 'bcache-for-upstream' of ↵Jens Axboe41-0/+16503
http://evilpiepirate.org/git/linux-bcache into for-3.10/drivers
2013-03-23bcache: A block layer cacheKent Overstreet36-0/+16474
Does writethrough and writeback caching, handles unclean shutdown, and has a bunch of other nifty features motivated by real world usage. See the wiki at http://bcache.evilpiepirate.org for more. Signed-off-by: Kent Overstreet <[email protected]>
2013-03-23Export __lockdep_no_validate__Kent Overstreet1-0/+1
Hack, but bcache needs a way around lockdep for locking during garbage collection - we need to keep multiple btree nodes locked for coalescing and rw_lock_nested() isn't really sufficient or appropriate here. Signed-off-by: Kent Overstreet <[email protected]> CC: Peter Zijlstra <[email protected]> CC: Ingo Molnar <[email protected]>
2013-03-23Export blk_fill_rwbs()Kent Overstreet1-0/+1
Exported so it can be used by bcache's tracepoints Signed-off-by: Kent Overstreet <[email protected]> CC: Steven Rostedt <[email protected]> CC: Frederic Weisbecker <[email protected]> CC: Ingo Molnar <[email protected]>
2013-03-23Export get_random_int()Kent Overstreet1-0/+1
Needed for bcache - need a cheap source of random numbers for perturbing IO sizes, for rate limiting IO to the SSD. Signed-off-by: Kent Overstreet <[email protected]> CC: "Theodore Ts'o" <[email protected]>
2013-03-23Revert "rw_semaphore: remove up/down_read_non_owner"Kent Overstreet2-0/+26
This reverts commit 11b80f459adaf91a712f95e7734a17655a36bf30. Bcache needs rw semaphores for cache coherency in writeback mode - writes have to take a read lock on a per cache device rw sem, and release it when the bio completes. But since this is for bios it's naturally not in the context of the process that originally took the lock. Signed-off-by: Kent Overstreet <[email protected]> CC: Christoph Hellwig <[email protected]> CC: David Howells <[email protected]>
2013-03-22drbd: adjust upper limit for activity log extentsLars Ellenberg2-15/+43
Now that the on-disk activity-log ring buffer size is adjustable, the maximum active set can become larger, and is now limited by the use of 16bit "labels". This increases the maximum working set from 6433 to 65534 extents, each of which covers an area of 4MiB. Which means that if you use the maximum, you'd have to resync more than 250 GiB after an unclean Primary shutdown. With capable backend storage and replication links, this is entirely feasible. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-22drbd: try hard to max out the updates per AL transactionLars Ellenberg1-0/+31
There may have been more incoming requests while we where preparing the current transaction. Try to consolidate more updates into this transaction until we make no more progres. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-22drbd: move start io accounting before activity log transactionLars Ellenberg1-3/+3
The IO accounting of the drbd "queue depth" was misleading. We only started IO accounting once we already wrote the activity log. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-22drbd: consolidate as many updates as possible into one AL transactionLars Ellenberg3-14/+107
Depending on current IO depth, try to consolidate as many updates as possible into one activity log transaction. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-22lru_cache: introduce lc_get_cumulative()Lars Ellenberg2-10/+47
New helper to be able to consolidate more updates into a single transaction. Without this, we can only grab a single refcount on an updated element while preparing a transaction. lc_get_cumulative - like lc_get; also finds to-be-changed elements @lc: the lru cache to operate on @enr: the label to look up Unlike lc_get this also returns the element for @enr, if it is belonging to a pending transaction, so the return values are like for lc_get(), plus: pointer to an element already on the "to_be_changed" list. In this case, the cache was already marked %LC_DIRTY. Caller needs to make sure that the pending transaction is completed, before proceeding to actually use this element. Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Fixed up by Jens to export lc_get_cumulative(). Signed-off-by: Jens Axboe <[email protected]>
2013-03-22drbd: queue writes on submitter thread, unless they pass the activity log ↵Lars Ellenberg1-8/+12
fastpath Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-22drbd: split out some helper functions to drbd_al_begin_ioLars Ellenberg1-21/+28
To make the code easier to follow, use an explicit find_active_resync_extent(), and add a "nonblock" parameter to _al_get(). Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-22drbd: split drbd_al_begin_io into fastpath, prepare, and commitLars Ellenberg2-33/+72
Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
2013-03-22drbd: prepare to queue write requests on a submit workerLars Ellenberg4-1/+68
Signed-off-by: Philipp Reisner <[email protected]> Signed-off-by: Lars Ellenberg <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.