aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-10-02Staging: dgnc: Remove return in void functionMahati Chamarthy1-3/+0
This fixes the following checkpatch.pl warnings: WARNING: void function return statements are not generally useful Signed-off-by: Mahati Chamarthy <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-02staging/lustre/lvfs: fix building without CONFIG_PROC_FSArnd Bergmann1-14/+17
Patch "staging/lustre/lvfs: remove the lvfs layer" moved some code around that was previously only built when CONFIG_PROC_FS was set, which now causes an invalid access to the obd_memory variable: ERROR: "obd_memory" [drivers/staging/lustre/lustre/obdclass/obdclass.ko] undefined! This fixes it by using adding a compile-time check around the access. Signed-off-by: Arnd Bergmann <[email protected]> Fixes: fdedd94509fd ("staging/lustre/lvfs: remove the lvfs layer") Cc: James Simmons <[email protected]> Cc: Mikhail Pershin <[email protected]> Cc: John L. Hammond <[email protected]> Cc: Jian Yu <[email protected]> Cc: Bob Glossman <[email protected]> Cc: Oleg Drokin <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-02Staging: bcm: Removed unnecessary else.Heena Sirwani1-2/+2
The following patch fixes the checkpatch.pl warning: WARNING: else is not generally useful after a break or return. Signed-off-by: Heena Sirwani <[email protected]> Reviewed-by: Josh Triplett <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-02Staging: media: omap24xx: Merge two lines and remove unused variableMahati Chamarthy1-3/+1
This patch merges two lines and removes a variable that becomes unused after merging. Signed-off-by: Mahati Chamarthy <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-02Revert "staging: media: cxd2099: use usleep_range()"Greg Kroah-Hartman1-1/+1
This reverts commit 7b86477c0e5b7b1406f27da519d4df841f306b92. It was broken and broke the build :( Reported-by: kbuild test robot <[email protected]> Reported-by: Stephen Rothwell <[email protected]> Cc: Tapasweni Pathak <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-30staging: r8192ee: Remove staging driverLarry Finger66-50331/+0
A new version of this driver has been merged into the regular wireless tree. The staging version is hereby removed. Signed-off-by: Larry Finger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-29staging: rtl8821ae: remove driverGreg Kroah-Hartman75-70878/+0
There is now a "real" driver in the wireless tree for this hardware device, so remove the staging driver as it is no longer needed. Reported-by: Larry Finger <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-29staging: et131x: Simplify for loop in et131x_init_send()Mark Einon1-2/+4
The for loop in this function increments two variables and has an unusual starting index of 1 (not 0). Make it look more familiar. Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Mark Einon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-29staging: et131x: Audit and update commentsMark Einon1-307/+21
Many of the functions and variables in the driver have been renamed and are now more understandable, as well as defines added for various constants. Update / remove some comments to reflect this. Also many comments were unnecessary dialogue describing what is evident from the code, or comments were just plain incorrect. Remove these too. Signed-off-by: Mark Einon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8192u: ieee80211: Converted symbol to static.Aybuke Ozdemir1-1/+1
This patch fixes this sparse warning: drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c:60:6: warning: symbol 'ieee80211_ccmp_aes_encrypt' was not declared. Should it be static? Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8192u: Add blank line after variable declarationsGeorgiana Chelu1-0/+2
Fix the following checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Georgiana Chelu <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28Staging: rtl8192e: Remove unused variableMahati Chamarthy1-2/+0
This patch removes a variable which has never been used. The following Coccinelle semantic patch was used to make this transformation: @@ type T; identifier i; constant C; @@ - T i; <... when != i - i = C; ...> Signed-off-by: Mahati Chamarthy <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8192u: Fixed trailing whitespace in copyingEsra Altintas1-5/+5
The following patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Esra Altintas <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8192u: remove space before close parenthesis ")"Roxana Blaj1-4/+4
This fixes the checkpatch.pl error: ERROR: space prohibited before that close parenthesis ')' Signed-off-by: Roxana Blaj <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8192u: remove space before semicolonRoxana Blaj1-2/+2
This fixes the checkpatch.pl warning: WARNING: space prohibited before semicolon Signed-off-by: Roxana Blaj <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8192u: add space after close brace '}'Roxana Blaj1-7/+7
This fixes the checkpatch.pl error: ERROR: space required after that close brace '}' Signed-off-by: Roxana Blaj <[email protected]> Acked-by: Daniel Baluta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: slicoss: Fix void function return statements style warningDilek Uzulmez1-1/+0
This fixes "void function return statements are not generally useful" checkpatch.pl warning slicoss.c Signed-off-by: Dilek Uzulmez <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8192u: add space before the open parenthesis '('Roxana Blaj1-6/+6
This fixes the checkpatch.pl error: ERROR: space required before the open parenthesis '(' Signed-off-by: Roxana Blaj <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28Staging: rtl8192e: rtl8192e: Remove assigned unused variableMahati Chamarthy1-6/+2
This patch removes an initialized variable which has never been used. The following Coccinelle semantic patch was used to make this transformation: @e@ identifier i; position p; type T; @@ extern T i@p; @@ type T; identifier i; constant C; position p != e.p; @@ - T i@p; <+... when != i - i = C; ...+> The braces around if and else which become unnecessary after the transformation were also removed. Signed-off-by: Mahati Chamarthy <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: octeon: Fix missing blank line warning.Melike Yurtoglu1-0/+5
Fixes "Missing a blank line after declarations" checkpatch.pl warning in ethernet-rgmii.c Signed-off-by: Melike Yurtoglu <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: octeon: Removed unnecessary else expression.Dilek Uzulmez1-4/+2
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning ethernet-util.h Signed-off-by: Dilek Uzulmez <[email protected]> Acked-by: Daniel Baluta <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: octeon: Fix line 80 characters in ethernet.cEsra Altintas1-1/+2
The following patch fixes the checpatch.pl warning: WARNING: line over 80 characters Signed-off-by: Esra Altintas <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28drivers: staging: gdm72xx: Removed unnecessary braces.Gulsah Kose1-2/+1
This patch fixes "braces {} are not necessary for single statement blocks" checkpatch.pl warning in netlink_k.c Signed-off-by: Gulsah Kose <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28drivers: staging: gdm72xx: Removed unnecessary else expression.Gulsah Kose1-6/+5
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning in netlink_k.c Signed-off-by: Gulsah Kose <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: gdm724x: Removed unnecessary else expression.Gulsah Kose1-2/+1
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning in gdm_usb.c Signed-off-by: Gulsah Kose <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: ft1000: ft1000-pcmcia: Add require space after that ','Aybuke Ozdemir1-3/+3
This patch fixes checkpatch.pl error in file ft1000_hw.c ERROR: space required after that ';' (ctx:VxV) Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: ft1000: ft1000-pcmcia: Used "linux" instead of "asm".Gulsah Kose1-2/+2
This patch fixes "Use #include <linux/uaccess.h> instead of <asm/uaccess.h" checkpatch.pl warning in ft1000_dnld.c Signed-off-by: Gulsah Kose <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: ft1000: ft1000-pcmcia: Removed unnecessary else expression.Gulsah Kose1-3/+2
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning in ft1000_dnld.c Signed-off-by: Gulsah Kose <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28Staging: unisys: common-spar: include: channels: Remove unnecessary semicolonAybuke Ozdemir1-2/+2
This fixes the checkpatch.pl warning: WARNING: macros should not use a trailing semicolon. Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: vt6655: Merge three lines into oneTapasweni Pathak1-3/+1
This patch merges three lines into one, removing unecessary if check. Signed-off-by: Tapasweni Pathak <[email protected]> Reviewed-by: Himangi Saraogi <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: vt6656: Merge three lines into oneTapasweni Pathak1-3/+1
This patch merges three lines into one, removing if branch Signed-off-by: Tapasweni Pathak <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: vt6655: Type conversion was made.Gulsah Kose1-1/+1
This patch fixes this sparse warning: drivers/staging/vt6655/device_main.c:385:40: warning: mixing different enum types drivers/staging/vt6655/device_main.c:385:40: int enum _VIA_BB_TYPE versus drivers/staging/vt6655/device_main.c:385:40: int enum _VIA_PKT_TYPE Signed-off-by: Gulsah Kose <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28Staging: vt6655: Add require space before that '('Aybuke Ozdemir1-2/+2
This patch fixes checkpatch.pl error in file device_main.c ERROR: space required before the open parenthesis '(' Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28Staging: vt6655: Add require space after that ','Aybuke Ozdemir1-1/+1
This patch fixes checkpatch.pl error in file device_main.c ERROR: space required after that ';' (ctx:VxV) Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: speakup: Added blank line.Aybuke Ozdemir1-0/+1
This patch fixes "Missing a blank line after declarations" checkpatch.pl warning in selection.c Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28Staging: speakup: Fix trailing spaceAybuke Ozdemir1-18/+18
This patch fixes checkpatch.pl error in file spkguide.txt ERROR: trailing whitespace Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28Staging: wlan-ng: Fix unnecessary space before function pointer argumentsAybuke Ozdemir1-7/+7
This patch fixes these warning messages found by checkpatch.pl: WARNING: Unnecessary space before function pointer arguments Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8723au: core: Add space after '|'Aybuke Ozdemir1-1/+1
This patch fixes checkpatch.pl error in file rtw_ap.c ERROR: need consistent spacing around '|' (ctx:WxV) Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8723au: core: Add consistent spacing around '&'Aybuke Ozdemir1-1/+1
This patch fixes checkpatch.pl error in file rtw_ap.c ERROR: need consistent spacing around '&' (ctx:WxV) Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8723au: hal: Removed unnecessary braces.Aybuke Ozdemir1-2/+1
This patch fixes "braces {} are not necessary for single statement blocks" checkpatch.pl warning in hal_com.c Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8723au: hal: Fix missing blank line warning.Aybuke Ozdemir1-0/+1
This patch fixes "Missing a blank line after declarations" checkpatch.pl warning in hal_com.c Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: rtl8723au: hal: Fix unnecessary whitespace before a quoted newlineAybuke Ozdemir1-4/+4
Fix checkpatch.pl issues with unnecessary whitespace before a quoted newline in hal_com.c Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: emxx_udc: Fixed else is not usefull warning.Gulsah Kose1-2/+1
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning in emxx_udc.c Signed-off-by: Gulsah Kose <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: ft1000-usb: use usleep_range instead of msleepCatalina Mocanu1-1/+1
This fixes the following checkpatch.pl warning: WARNING : msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt Signed-off-by: Catalina Mocanu <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: ft1000-usb: remove unnecessary return statementCatalina Mocanu1-2/+0
This fixes the following checkpatch.pl warning: WARNING: void function return statements are not generally useful Signed-off-by: Catalina Mocanu <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: media: omap4iss: Removed unnecessary else expression.Gulsah Kose1-2/+1
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning iss_resizer.c Signed-off-by: Gulsah Kose <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: media: omap4iss: Removed unnecessary else expression.Gulsah Kose1-2/+1
This patch fixes "else is not generally useful after a break or return" checkpatch.pl warning iss_ipipeif.c Signed-off-by: Gulsah Kose <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: media: omap24xx: Added blank line.Gulsah Kose1-0/+1
This patch fixes "Missing a blank line after declarations" checkpatch.pl warning in tcm825x.c Signed-off-by: Gulsah Kose <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: media: omap24xx: Added new line after declarations.Gulsah Kose1-0/+1
This patch fixes "Missing a blank line after declarations" checkpatch.pl warning in omap24xxcam-dma.c Signed-off-by: Gulsah Kose <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-28staging: media: cxd2099: use usleep_range()Tapasweni Pathak1-1/+1
This patch fixes checkpatch.pl warning in file cxd2099.c WARNING : msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt Signed-off-by: Tapasweni Pathak <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>