aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-09-11staging: rtl8723bs: Remove unused function rtw_ch2freqPhilipp Hortmann3-30/+0
Remove unused function rtw_ch2freq with array ch_freq_map and comments. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/53a8ee320803ae3efe22b648f2a4555482efaf46.1725826273.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: Remove unused files rtw_debug.c and rtw_debug.hPhilipp Hortmann43-63/+0
Remove unused files rtw_debug.c and rtw_debug.h. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/ab3d501e2ef0bb3980d8d271fb667ce20ed8dca5.1725826273.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: Remove unused function dump_4_regsPhilipp Hortmann1-12/+0
Remove unused function dump_4_regs. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/583ba389a269a11f4c2497ae5152ad8299d88455.1725826273.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: Remove unused function mac_reg_dumpPhilipp Hortmann2-12/+0
Remove unused function mac_reg_dump. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/80e89052b30d8c495f375e43fc4c1deeea75a624.1725826273.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: Remove unused function bb_reg_dumpPhilipp Hortmann2-11/+0
Remove unused function bb_reg_dump. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/e0372c46a62df20ecce9a9e66846cbd3484eb85d.1725826273.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: Remove unused function dump_4_rf_regsPhilipp Hortmann1-13/+0
Remove unused function dump_4_rf_regs. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/b660342da763d1e03c44f2b3fdac0378b077e6b9.1725826273.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: Remove unused function rf_reg_dumpPhilipp Hortmann2-12/+0
Remove unused function rf_reg_dump. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/b66d915668366258523095adf388acef945dc0fa.1725826273.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: Remove unused function rtw_hal_get_odm_varPhilipp Hortmann2-7/+0
Remove unused function rtw_hal_get_odm_var. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/adbeaac00054c87e4c55714817ffb85f68d37c4a.1725826273.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: Remove unused function rxmem_to_recvframePhilipp Hortmann1-10/+0
Remove unused function rxmem_to_recvframe and its comment. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/1016603607501abe08334f9577728dd3c4209572.1725826273.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: Remove unused function RTW_DISABLE_FUNCPhilipp Hortmann1-7/+0
Remove unused function RTW_DISABLE_FUNC and its comment. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/46545805edb962ae97b15be60e0a3446aae42701.1725826273.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: core: Fix spelling mistake in rtw_xmit.cRoshan Khatri1-1/+1
This patch fixes spelling mistake to increase code readability and searching. Signed-off-by: Roshan Khatri <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/90f26f7bce03d80848e3c0fc166c5ab584b83446.1725933169.git.topofeverest8848@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: include: Fix spelling mistake in rtw_mlme.hRoshan Khatri1-1/+1
This patch fixes spelling mistake to increase code readability and searching. Signed-off-by: Roshan Khatri <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/8b9184ba4e489d7eec389389ae435fa4d9232113.1725933169.git.topofeverest8848@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: include: Fix spelling mistake in rtw_io.hRoshan Khatri1-1/+1
This patch fixes spelling mistake to increase code readability and searching. Signed-off-by: Roshan Khatri <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/f77f1155d07de7780726562d628e8ed3a3ce4b4f.1725933169.git.topofeverest8848@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: rtl8723bs: include: Fix spelling mistake in rtw_xmit.hRoshan Khatri1-1/+1
This patch fixes spelling mistake to increase code readability and searching. Signed-off-by: Roshan Khatri <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/93a1b568ec96dea13dfc75232a08bbf42e270599.1725933169.git.topofeverest8848@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Revert "staging: greybus: Fix capitalization and punctuation inconsistencies"Johan Hovold5-48/+48
This reverts commit 30db8460f984a7f5299b6e07ea8a57cd09fc9557. The offending commit tried to make the error messages of a few Greybus drivers in staging more consistent by capitalising messages, but the rest of the Greybus code do not follow this style so the change ended up introducing an inconsistency instead. Signed-off-by: Johan Hovold <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable RxDrvInfoSizeTree Davies4-5/+5
Rename variable RxDrvInfoSize to rx_drv_info_size to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable RxBufShiftTree Davies3-5/+5
Rename variable RxBufShift to rx_buf_shift to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable bAddNewTsTree Davies2-3/+3
Rename variable bAddNewTs to add_new_ts to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable nStuckCountTree Davies2-5/+5
Rename variable nStuckCount to stuck_count to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable isEncryptTree Davies1-1/+1
Rename variable isEncrypt to is_encrypt to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable SignalQualityTree Davies2-8/+8
Rename variable SignalQuality to signal_quality to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable bAssocTree Davies1-1/+1
Rename variable bAssoc to assoc to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable OperationTree Davies2-4/+4
Rename variable Operation to operation to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable ScanOperationBackupHandlerTree Davies4-6/+6
Rename variable ScanOperationBackupHandler to scan_operation_backup_handler to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable Para2Tree Davies2-7/+7
Rename variable Para2 to para2 to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable Para1Tree Davies2-7/+7
Rename variable Para1 to para1 to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable bPacketToSelfTree Davies2-6/+6
Rename variable bPacketToSelf to packet_to_self to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable pFrameTree Davies2-3/+3
Rename variable pFrame to frame to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable SignalStrengthTree Davies3-10/+10
Rename variable SignalStrength to signal_strength to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable SeqNumTree Davies3-48/+48
Rename variable SeqNum to seq_num to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11Staging: rtl8192e: Rename variable pReorderEntryTree Davies2-32/+32
Rename variable pReorderEntry to reorder_entry to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: vchiq_core: Pass enumerated flag instead of intUmang Jain1-1/+2
Pass proper enumerated flag which exists, instead of an integer while calling queue_message(). It helps with readability of the code. Signed-off-by: Umang Jain <[email protected]> Reviewed-by: Stefan Wahren <[email protected]> Tested-by: Stefan Wahren <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: vchiq_core: Remove unused function argumentUmang Jain1-3/+3
The argument 'is_blocking' in queue_message_sync() is not used in the function. Drop it. Signed-off-by: Umang Jain <[email protected]> Reviewed-by: Stefan Wahren <[email protected]> Tested-by: Stefan Wahren <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: vchiq_core: Drop vchiq_bulk_transfer()Umang Jain3-73/+0
Drop vchiq_bulk_transfer() as every VCHIQ_BULK_MODE_* mode now have their own dedicated functions to execute bulk transfers. Also, drop the temporary label we introduced earlier in vchiq-dev.c to jump over the vchiq_bulk_transfer() call when each separate mode helper was being developed. Signed-off-by: Umang Jain <[email protected]> Tested-by: Stefan Wahren <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: vchiq_core: Factor out bulk transfer for (no/)callback modeUmang Jain4-7/+54
Factor out bulk transfer for VCHIQ_BULK_MODE_NOCALLBACK and VCHIQ_BULK_MODE_CALLBACK mode into a separate dedicated function bulk_xfer_callback_interruptible(). It is suffixed by "_interruptible" to denote that it can be interrupted and -EAGAIN can be returned. It would be up to the users of the function to retry the call in those cases. bulk_xfer_callback_interruptible() also takes in 'mode' parameter to differentiate between VCHIQ_BULK_MODE_NOCALLBACK and VCHIQ_BULK_MODE_CALLBACK, which then is directly passed to vchiq_bulk_xfer_queue_msg_interruptible() inside the function. Adjust the calls to vchiq-dev.c ioctl interface and vchiq_arm.c for the respective bulk transfers. Signed-off-by: Umang Jain <[email protected]> Tested-by: Stefan Wahren <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: vchiq_core: Factor out bulk transfer for blocking modeUmang Jain4-9/+60
Factor out bulk transfer for blocking mode into a separate dedicated function bulk_xfer_blocking_interruptible(). It is suffixed by "_interruptible" to denote that it can be interrupted and -EAGAIN can be returned. It would be up to the users of the function to retry the call in those cases. Adjust the calls to vchiq-dev.c ioctl interface and vchiq_arm.c for blocking bulk transfers. Signed-off-by: Umang Jain <[email protected]> Tested-by: Stefan Wahren <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: vchiq_core: Simplify vchiq_bulk_transfer()Umang Jain1-96/+114
Factor out core logic for preparing bulk data transfer(mutex locking, waits on vchiq_bulk_queue wait-queue, initialising the bulk transfer) out of the vchiq_bulk_transfer(). This simplifies the existing vchiq_bulk_transfer() and makes it more readable since all the core logic is handled in vchiq_bulk_xfer_queue_msg_interruptible(). It will also help us to refactor vchiq_bulk_transfer() easily for different vchiq bulk transfer modes. No functional changes intended in this patch. Signed-off-by: Umang Jain <[email protected]> Tested-by: Stefan Wahren <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-11staging: vchiq: Factor out bulk transfer for VCHIQ_BULK_MODE_WAITINGUmang Jain3-8/+54
The bulk transfer is VCHIQ_BULK_MODE_WAITING is used by VCHIQ ioctl interface. It is factored out to a separate function from vchiq_bulk_transfer() to bulk_xfer_waiting_interruptible(). This is a part of vchiq_bulk_transfer refactoring. Each bulk mode will have their dedicated functions to execute bulk transfers. Each mode will be handled separately in subsequent patches. bulk_xfer_waiting_interruptible() is suffixed with "_interruptible" to denote that it can be interrupted when a signal is received. -EAGAIN maybe returned in those cases, similar to what vchiq_bulk_transfer() does. Adjust the vchiq_irq_queue_bulk_tx_rx() in the vchiq-dev.c to call bulk_xfer_waiting_interruptible() for waiting mode. A temporary goto label has been introduced to jump the call execution over vchiq_bulk_transfer() for waiting mode only. When all dedicated bulk transfer calls are introduced, this label shall be dropped. No function changes intended in this patch. Signed-off-by: Umang Jain <[email protected]> Tested-by: Stefan Wahren <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-05staging: vme_user: changed geoid data type from int to u32Riyan Dhiman2-6/+6
Geoid is a module parameter which is set by root user. Its valid values are between 0 and VME_MAX_SLOTS. So, changing data type of geoid from int to u32 since it will always be positive. Signed-off-by: Riyan Dhiman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-05Staging: rtl8723bs: Rename function SelectChannel()vivek t s4-6/+6
Rename function SelectChannel() to r8723bs_select_channel(), to avoid CamelCase and to improve cleanliness of the global namespace. Signed-off-by: vivek t s <[email protected]> Link: https://lore.kernel.org/r/ZtmD8i7YZLRIcaI9@victor-IdeaPad-Gaming-3-16IAH7 Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-05staging: rtl8723bs: include: Fix spelling mistake in rtw_event.hRoshan Khatri1-1/+1
This patch fixes spelling mistake to increase code readability and searching. Signed-off-by: Roshan Khatri <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-05staging: rtl8723bs: include: Fix spelling mistake in rtl8723b_hal.hRoshan Khatri1-1/+1
This patch fixes spelling mistake to increase code readability and searching. Signed-off-by: Roshan Khatri <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-03staging: rtl8723bs: Remove an unused struct in rtw_cmd.hQianqiang Liu1-4/+0
struct getcountjudge_rsp is not used, just remove it. Signed-off-by: Qianqiang Liu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-03staging: greybus: Fix capitalization and punctuation inconsistenciesSteven Davis5-48/+48
There were a lot of inconsistencies in outputs and comments, some were properly formatted and capitalized, and some weren't. This patch resolves this by properly formatting the inconsistent comments and outputs. Signed-off-by: Steven Davis <[email protected]> Link: https://lore.kernel.org/r/SJ2P223MB102660087EA9382BE5287FDBF7912@SJ2P223MB1026.NAMP223.PROD.OUTLOOK.COM Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-03staging: rtl8723bs: Remove trailing space after \n newlineColin Ian King1-1/+1
There is a extraneous space after a newline in a netdev_dbg message. Remove it. Signed-off-by: Colin Ian King <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-03staging: rtl8192e: Constify struct pci_device_idRiyan Dhiman1-1/+1
static variable struct pci_device_id rtl8192_pci_id_tbl is not modified in file rtl_core.c. Constifying this structure moves some data to a read-only section, so increase overall security. Before ====== text data bss dec hex filename 17838 893 1 18732 492c drivers/staging/rtl8192e/rtl8192e/rtl_core.o After ===== text data bss dec hex filename 18006 725 1 18732 492c drivers/staging/rtl8192e/rtl8192e/rtl_core.o Signed-off-by: Riyan Dhiman <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-03Staging: rtl8192e: Add spaces around operators.Tree Davies1-31/+31
Add spaces around arithmetic and bitwise operators to improve readability of the code. Signed-off-by: Tree Davies <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-03Staging: rtl8192e: Rename variable bHwErrorTree Davies2-5/+5
Rename variable bHwError to hw_error to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-03Staging: rtl8192e: Rename variable pNetworkTree Davies2-19/+19
Rename variable pNetwork to network to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-09-03staging: rtl8192e: Fix parenthesis alignment in rtl_core.cGabriel Tassinari1-1/+1
fix parenthesis alignment in _rtl92e_qos_handle_probe_response to silence checkpatch warning: CHECK: Alignment should match open parenthesis Signed-off-by: Gabriel Tassinari <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>