aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-12-02staging: rtl8712: remove unnecessary else after returnMike Krinkin1-5/+4
Fixes checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Mike Krinkin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: comedi: change some printk calls to pr_errChase Southwood2-8/+8
There are a handful of calls to printk in ni_stc.h without specified log levels, as well as one in ni_mio_common.c. This patch converts these calls to pr_err() instead, so that they are now explicitly log level ERR. Signed-off-by: Chase Southwood <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: hal: Removed the extra semicolonAnjana Sasindran1-3/+3
This patch fix the checkpatch.pl warning: WARNING: Statement terminations use 1 semicolon Signed-off-by: Anjana Sasindran <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02lustre: Deletion of unnecessary checks before three function callsMarkus Elfring2-5/+3
The functions free_ll_remote_perm(), free_rmtperm_hash() and iput() test whether their argument is NULL and then return immediately. Thus the test around their calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: lustre: fix sparse warnings: static function declarationVincenzo Scotti1-1/+1
Signed-off-by: Vincenzo Scotti <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: lustre: fixed sparse warnings related to static declarationsJanet Liu1-6/+6
drivers/staging/lustre/lustre/mdc/mdc_request.c:63:5: warning: symbol 'mdc_unpack_capa' was not declared. Should it be static? drivers/staging/lustre/lustre/mdc/mdc_request.c:150:5: warning: symbol 'mdc_getstatus' was not declared. Should it be static? drivers/staging/lustre/lustre/mdc/mdc_request.c:217:5: warning: symbol 'mdc_getattr' was not declared. Should it be static? drivers/staging/lustre/lustre/mdc/mdc_request.c:261:5: warning: symbol 'mdc_getattr_name' was not declared. Should it be static? drivers/staging/lustre/lustre/mdc/mdc_request.c:444:5: warning: symbol 'mdc_setxattr' was not declared. Should it be static? drivers/staging/lustre/lustre/mdc/mdc_request.c:455:5: warning: symbol 'mdc_getxattr' was not declared. Should it be static? Signed-off-by: Janet Liu <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: unisys: remove duplicate headerSudip Mukherjee2-3/+0
these header files were included multiple times Signed-off-by: Sudip Mukherjee <[email protected]> Signed-off-by: Benjamin Romer <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: unisys: remove unneeded structureJulia Lawall1-3/+0
Delete a local structure that is only used to be initialized by memset. A semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier x,i; @@ { ... when any -struct i x; <+... when != x - memset(&x,...); ...+> } // </smpl> Signed-off-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: ft1000 : replace __attribute ((__packed__) with __packedGeoff Darst1-2/+2
Replace two instances of __attribute ((__packed__) with __packed macro to address the warning found by the checkpatch.pl tool. Signed-off-by: Geoff Darst <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02drivers: staging: rtl8192e: Include "asm/unaligned.h" instead of ↵Chen Gang1-1/+2
"access_ok.h" in "rtl819x_BAProc.c" "asm/unaligned.h" is more generic than "access_ok.h", and it may include "access_ok.h", so need use it instead of "access_ok.h". During building, "rtllib.h" has already include "asm/unaligned.h", so will cause building issue. The related error (with allmodconfig under parisc): CC [M] drivers/staging/rtl8192e/rtl819x_BAProc.o In file included from ./arch/parisc/include/asm/unaligned.h:4:0, from include/linux/ieee80211.h:22, from include/net/lib80211.h:31, from drivers/staging/rtl8192e/rtllib.h:45, from drivers/staging/rtl8192e/rtl819x_BAProc.c:20: include/linux/unaligned/be_struct.h:6:19: error: redefinition of 'get_unaligned_be16' static inline u16 get_unaligned_be16(const void *p) ^ In file included from drivers/staging/rtl8192e/rtl819x_BAProc.c:19:0: include/linux/unaligned/access_ok.h:22:19: note: previous definition of 'get_unaligned_be16' was here static inline u16 get_unaligned_be16(const void *p) ^ ... For independent from other include files, still suggest it includes "asm/unaligned.h" too. And also include "asm/byteorder.h" since it is the first include file". Signed-off-by: Chen Gang <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02Drivers:staging:rtl8192e: Fixed checkpatch warningAthira Lekshmi1-1/+1
Fixed checkpatch warning: WARNING: space prohibited before semicolon Signed-off-by: Athira Lekshmi <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02Drivers:staging:clocking-wizard: Added a newlineAthira Sharikkal1-0/+1
Fixed checkpatch warning: Missing a newline after declarations Signed-off-by: Athira Sharikkal <[email protected]> Acked-by: Soren Brinkmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: clocking-wizard: check for a valid clk_name pointerDevendra Naga1-0/+5
The clk_name gets the return value from kasprintf (part of which does the allocation of the returned buffer). So check the return pointer before using it for clk_register_fixed_factor. Signed-off-by: Devendra Naga <[email protected]> Reviewed-by: Soren Brinkmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Hal_InitPGData() avoid unnecessary typecastsJes Sorensen1-7/+5
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: _DisableAnalog(): Avoid zero-init variables unnecessarilyJes Sorensen1-5/+5
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Remove unnecessary wrapper _ResetDigitalProcedure1()Jes Sorensen1-8/+2
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: _ResetDigitalProcedure1_92C() reduce code obfuscationJes Sorensen1-32/+30
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Remove unnecessary wrapper _DisableRFAFEAndResetBB()Jes Sorensen1-7/+2
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: _DisableRFAFEAndResetBB8192C(): Reduce code obfuscationJes Sorensen1-4/+3
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: _DisableRFAFEAndResetBB8192C(): Use correct enum valueJes Sorensen1-2/+2
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Fold _BlockWrite() into _PageWrite()Jes Sorensen1-14/+4
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: rtl8723a_update_ramask(): Fix up some bad formattingJes Sorensen1-19/+18
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Remove unused slimcombo debug flagJes Sorensen2-15/+0
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: rtl8723au_read_interrupt() addr argument wasn't usedJes Sorensen4-6/+4
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: rtl8723au_read_port() addr argument wasn't usedJes Sorensen4-15/+10
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Use a local variable to state if MAC was already powered onJes Sorensen2-9/+8
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: phy_SsPwrSwitch92CU() was never called with bRegSSPwrLvl ↵Jes Sorensen1-238/+84
!= 1 Get rid of the alternate code paths since these weren't used and have never been tested according to the in-code comments. Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Fold _ps_open_RF23a() into rtl8723au_hal_init()Jes Sorensen1-9/+7
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Do not write garbage to REG_SPS0_CTRLJes Sorensen1-10/+9
Use a separate variable to hold the value of REG_SPS0_CTRL to avoid it getting clobbered and writing out garbage to it, for the case of eRFPowerState == rf_sleep/rf_off && bRegSSPwrLvl == 1. Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Remove no-op _InitHWLed() functionJes Sorensen1-6/+0
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Fold _InitNormalChipQueuePriority() into ↵Jes Sorensen1-6/+1
_InitQueuePriority() Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: _InitPowerOn(): Don't zero init variables unnecessarilyJes Sorensen1-4/+3
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Fold rtl8723au_set_queue_pipe_mapping into ↵Jes Sorensen3-21/+11
rtl8723au_chip_configure() Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Remove write only struct hal_data_8723a.interfaceIndexJes Sorensen2-5/+0
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Remove unused rtw_sctx_done23a() functionJes Sorensen2-6/+0
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Eliminate do_queue_select() functionsJes Sorensen2-26/+2
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Fold rtw_ack_tx_done23a() into rtw23a_sctx_done_err()Jes Sorensen5-35/+18
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8732au: Partial clean up of rtl8723a_rf6052.cJes Sorensen1-106/+123
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: Fold ODM_PhyStatusQuery23a_92CSeries() into ↵Jes Sorensen1-11/+2
ODM_PhyStatusQuery23a() Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: recv_priv->rssi is not used for anythingJes Sorensen3-11/+6
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: rtl8723au: recv_priv.is_signal_dbg is never setJes Sorensen2-60/+46
Signed-off-by: Jes Sorensen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging:ft1000_pcmcia:Added a blank line after declarationAnjana Sasindran1-0/+1
This patch fix the checkpatch.pl warning WARNING: Missing a blank line after declaration Signed-off-by: Anjana Sasindran <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: vt6655: s_cbFillTxBufHead remove parameter cbFrameBodySizeMalcolm Priestley1-5/+5
skb->len is available locally use that instead. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: vt6655: s_cbFillTxBufHead remove parameter *pPacketMalcolm Priestley1-5/+4
skb->data is available locally so use that instead. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: vt6655: s_cbFillTxBufHead remove unused parameter *puMACfragNumMalcolm Priestley1-8/+3
*puMACfragNum was part of old legacy functions. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: vt6655: remove unused typedef struct tagSSromRegMalcolm Priestley1-34/+0
Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: vt6655: srom remove dead functionsMalcolm Priestley2-264/+0
Remove these unused functions SROMbWriteEmbedded SROMvRegBitsOn SROMvRegBitsOff SROMbIsRegBitsOn SROMbIsRegBitsOff SROMvWriteAllContents SROMvWriteEtherAddress SROMvReadSubSysVenId SROMbAutoLoad Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: vt6655: remove duplicate MACvSetPacketFilterMalcolm Priestley2-79/+0
Packet filtering is already done in vnt_configure. A call to MACvSetPacketFilter is not necessary in MACvInitialize as this will be done by vnt_configure when interface is up. Also remove macros associated with this function. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: panel: Move LCD-related state into struct lcdMariusz Gorski1-121/+134
Move more or less all LCD-related state into struct lcd in order to get better cohesion; use bool instead of int where it makes sense. Signed-off-by: Mariusz Gorski <[email protected]> Acked-by: Willy Tarreau <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-12-02staging: panel: Remove more magic number comparisonMariusz Gorski1-10/+10
Use a defined value instead of magic number comparison for checking whether a module param value has been set. Signed-off-by: Mariusz Gorski <[email protected]> Acked-by: Willy Tarreau <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.