aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-11-26rtl8188eu: Fix a typo in rtw_led.*Krzysztof Konopko2-3/+5
A rather obvious typo in one of the identifier has been found. This patch fixes the typo and ensures any lines changed do not exceed 80 characters as indicated by scripts/checkpatch.pl Signed-off-by: Krzysztof Konopko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26rtl8188eu: Fix FSF_MAILING_ADDRESS in rtw_led.*Krzysztof Konopko2-8/+0
rtw_led.* files include Free Software Foundation's mailing address in the sample GPL notice. This is not desired and picked when running scripts/checkpatch.pl. Signed-off-by: Krzysztof Konopko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26rtl8188eu: Simplify rtw_endofpktfile() in xmit_linux.cKrzysztof Konopko1-7/+1
scripts/checkpatch.pl reports a coding style problem in xmit_linux.c WARNING:BRACES: braces {} are not necessary for single statement blocks #61852: FILE: rtl8188eu/os_dep/xmit_linux.c:70: This patch removes unnecessary braces and simplifies the function to a single return statement. Signed-off-by: Krzysztof Konopko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-27powerpc: 32 bit getcpu VDSO function uses 64 bit instructionsAnton Blanchard1-2/+2
I used some 64 bit instructions when adding the 32 bit getcpu VDSO function. Fix it. Fixes: 18ad51dd342a ("powerpc: Add VDSO version of getcpu") Cc: [email protected] Signed-off-by: Anton Blanchard <[email protected]> Signed-off-by: Michael Ellerman <[email protected]>
2014-11-27powerpc/powernv: Replace OPAL_DEASSERT_RESET with EEH_RESET_DEACTIVATEGavin Shan1-1/+1
The flag passed to ioda_eeh_phb_reset() should be EEH_RESET_DEACTIVATE, which is translated to OPAL_DEASSERT_RESET or something else by the EEH backend accordingly. The patch replaces OPAL_DEASSERT_RESET with EEH_RESET_DEACTIVATE for ioda_eeh_phb_reset(). Cc: [email protected] Signed-off-by: Gavin Shan <[email protected]> Signed-off-by: Michael Ellerman <[email protected]>
2014-11-27powerpc/eeh: Fix PE state formatGavin Shan1-1/+1
Obviously I had wrong format given to the PE state output from /sys/bus/pci/devices/xxxx/eeh_pe_state with some typoes, which was introduced by commit 2013add4ce73. The patch fixes it up. Fixes: 2013add4ce73 ("powerpc/eeh: Show hex prefix for PE state sysfs") Signed-off-by: Gavin Shan <[email protected]> Signed-off-by: Michael Ellerman <[email protected]>
2014-11-27powerpc/pseries: Fix endiannes issue in RTAS call from xmonLaurent Dufour1-3/+3
On pseries system (LPAR) xmon failed to enter when running in LE mode, system is hunging. Inititating xmon will lead to such an output on the console: SysRq : Entering xmon cpu 0x15: Vector: 0 at [c0000003f39ffb10] pc: c00000000007ed7c: sysrq_handle_xmon+0x5c/0x70 lr: c00000000007ed7c: sysrq_handle_xmon+0x5c/0x70 sp: c0000003f39ffc70 msr: 8000000000009033 current = 0xc0000003fafa7180 paca = 0xc000000007d75e80 softe: 0 irq_happened: 0x01 pid = 14617, comm = bash Bad kernel stack pointer fafb4b0 at eca7cc4 cpu 0x15: Vector: 300 (Data Access) at [c000000007f07d40] pc: 000000000eca7cc4 lr: 000000000eca7c44 sp: fafb4b0 msr: 8000000000001000 dar: 10000000 dsisr: 42000000 current = 0xc0000003fafa7180 paca = 0xc000000007d75e80 softe: 0 irq_happened: 0x01 pid = 14617, comm = bash cpu 0x15: Exception 300 (Data Access) in xmon, returning to main loop xmon: WARNING: bad recursive fault on cpu 0x15 The root cause is that xmon is calling RTAS to turn off the surveillance when entering xmon, and RTAS is requiring big endian parameters. This patch is byte swapping the RTAS arguments when running in LE mode. Cc: [email protected] Signed-off-by: Laurent Dufour <[email protected]> Signed-off-by: Michael Ellerman <[email protected]>
2014-11-27powerpc/powernv: Fix the hmi event version check.Mahesh Salgaonkar1-1/+1
The current HMI event structure is an ABI and carries a version field to accommodate future changes without affecting/rearranging current structure members that are valid for previous versions. The current version check "if (hmi_evt->version != OpalHMIEvt_V1)" doesn't accomodate the fact that the version number may change in future. If firmware starts returning an HMI event with version > 1, this check will fail and no HMI information will be printed on older kernels. This patch fixes this issue. Cc: [email protected] # 3.17+ Signed-off-by: Mahesh Salgaonkar <[email protected]> [mpe: Reword changelog] Signed-off-by: Michael Ellerman <[email protected]>
2014-11-26staging: r8188eu: Fix scheduling while atomic error introduced in commit ↵Larry Finger3-18/+18
fadbe0cd In commit fadbe0cd5292851608e2e01b91d9295fa287b9fe entitled "staging: rtl8188eu:Remove rtw_zmalloc(), wrapper for kzalloc()", the author failed to note that the original code in the wrapper tested whether the caller could sleep, and set the flags argument to kzalloc() appropriately. After the patch, GFP_KERNEL is used unconditionally. Unfortunately, several of the routines may be entered from an interrupt routine and generate a BUG splat for every such call. Routine rtw_sitesurvey_cmd() is used in the example below: BUG: sleeping function called from invalid context at mm/slub.c:1240 in_atomic(): 1, irqs_disabled(): 0, pid: 756, name: wpa_supplicant INFO: lockdep is turned off. CPU: 2 PID: 756 Comm: wpa_supplicant Tainted: G WC O 3.18.0-rc4+ #34 Hardware name: TOSHIBA TECRA A50-A/TECRA A50-A, BIOS Version 4.20 04/17/2014 ffffc90005557000 ffff880216fafaa8 ffffffff816b0bbf 0000000000000000 ffff8800c3b58000 ffff880216fafac8 ffffffff8107af77 0000000000000001 0000000000000010 ffff880216fafb18 ffffffff811b06ce 0000000000000000 Call Trace: [<ffffffff816b0bbf>] dump_stack+0x4e/0x71 [<ffffffff8107af77>] __might_sleep+0xf7/0x120 [<ffffffff811b06ce>] kmem_cache_alloc_trace+0x4e/0x1f0 [<ffffffffa0888226>] ? rtw_sitesurvey_cmd+0x56/0x2a0 [r8188eu] [<ffffffffa0888226>] rtw_sitesurvey_cmd+0x56/0x2a0 [r8188eu] [<ffffffffa088f00d>] rtw_do_join+0x22d/0x370 [r8188eu] [<ffffffffa088f6e8>] rtw_set_802_11_ssid+0x218/0x3d0 [r8188eu] [<ffffffffa08c3ca5>] rtw_wx_set_essid+0x1e5/0x410 [r8188eu] [<ffffffffa08c3ac0>] ? rtw_wx_get_rate+0x50/0x50 [r8188eu] [<ffffffff816938f1>] ioctl_standard_iw_point+0x151/0x3f0 [<ffffffff81693d52>] ioctl_standard_call+0xb2/0xe0 [<ffffffff81597df7>] ? rtnl_lock+0x17/0x20 [<ffffffff816945a0>] ? iw_handler_get_private+0x70/0x70 [<ffffffff81693ca0>] ? call_commit_handler+0x40/0x40 [<ffffffff81693256>] wireless_process_ioctl+0x176/0x1c0 [<ffffffff81693e79>] wext_handle_ioctl+0x69/0xc0 [<ffffffff8159fe79>] dev_ioctl+0x309/0x5e0 [<ffffffff810be9c7>] ? call_rcu+0x17/0x20 [<ffffffff8156a472>] sock_ioctl+0x142/0x2e0 [<ffffffff811e0c70>] do_vfs_ioctl+0x300/0x520 [<ffffffff81101514>] ? __audit_syscall_entry+0xb4/0x110 [<ffffffff81101514>] ? __audit_syscall_entry+0xb4/0x110 [<ffffffff810102bc>] ? do_audit_syscall_entry+0x6c/0x70 [<ffffffff811e0f11>] SyS_ioctl+0x81/0xa0 [<ffffffff816ba1d2>] system_call_fastpath+0x12/0x17 Additional routines that generate this BUG are rtw_joinbss_cmd(), rtw_dynamic_chk_wk_cmd(), rtw_lps_ctrl_wk_cmd(), rtw_rpt_timer_cfg_cmd(), rtw_ps_cmd(), report_survey_event(), report_join_res(), survey_timer_hdl(), and rtw_check_bcn_info(). Signed-off-by: Larry Finger <[email protected]> Cc: navin patidar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: rtl8192e: add missing tasklet_kill on remove pathDevendra Naga1-0/+1
The powersave tasklet is created in rtllib_softmac_init and it is not removed while unloading the module. Cc: Larry Finger <[email protected]> Signed-off-by: Devendra Naga <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: wlan-ng: prism2fw: fixed code style issueAede Symen Hoekstra1-1/+2
Fixed checkpatch.pl warning message: line over 80 characters Signed-off-by: Aede Symen Hoekstra <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26Drivers:staging:dgap: Added a blank line after declarationAnjana Sasindran1-0/+1
This patch fixes the checkpatch.pl warning: WARNING:Missing a blank line after declaration Signed-off-by: Anjana Sasindran <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: olpc_dcon: Deletion of a check before backlight_device_unregister()Markus Elfring1-2/+1
The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: ozwpan: Deletion of unnecessary checks before the function call ↵Markus Elfring1-4/+2
"oz_free_urb_link" The oz_free_urb_link() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: fwserial: remove multiple blank linesLe Tan1-3/+0
This patch fixes the multiple blank lines issue complained by checkpatch.pl by removing useless blank lines. Signed-off-by: Le Tan <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: panel: Use better names for two defined valuesMariusz Gorski1-8/+8
Give DEFAULT_KEYPAD and DEFAULT_LCD defines better names, so that their meaning is emphasized. Signed-off-by: Mariusz Gorski <[email protected]> Acked-By: Willy Tarreau <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: panel: Reorder module parameter declarationsMariusz Gorski1-35/+38
Change the order of the module parameter declarations so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <[email protected]> Acked-By: Willy Tarreau <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: panel: Reorder DEFAULT_* values redefinesMariusz Gorski1-13/+13
Change the order of the DEFAULT_* values redefines so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <[email protected]> Acked-By: Willy Tarreau <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: panel: Reorder initial DEFAULT_* definesMariusz Gorski1-4/+4
Change the order of the initial DEFAULT_* defines so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <[email protected]> Acked-By: Willy Tarreau <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: octeon-usb: eliminate cvmx_dprintf() usageAaro Koskinen1-3/+9
Eliminate cvmx_dprintf() usage and use dev_err() instead. Signed-off-by: Aaro Koskinen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: octeon-usb: move helper functionsAaro Koskinen1-10/+10
Move helper functions to make them visible to all functions. Signed-off-by: Aaro Koskinen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: octeon-ethernet: drop multiple NAPI instancesAaro Koskinen3-106/+10
Octeon Ethernet driver is currently trying to wake up multiple CPU cores for parallel NAPI processing when needed, to cope with the fact that all network interfaces are handled through the same receive queue processed by a single core/interrupt (see http://marc.info/?l=linux-kernel&m=137209784914565&w=2). This partially overlaps with generic RPS functionality. Commit a6a39a7fcff5 ("staging: octeon-ethernet: disable load balance for receiving packet when CONFIG_RPS is enabled") already disabled this when RPS is enabled. Let's delete this code altogether as it has issues like packet reordering and potential problems with CPU offlining/onlining. Tested on EdgeRouter Lite. Signed-off-by: Aaro Koskinen <[email protected]> Acked-By: David Daney <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: android: ion: Deletion of unnecessary checks before two function callsMarkus Elfring3-12/+6
The functions ion_heap_destroy() and vfree() perform also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26Merge tag 'master-2014-11-25' of ↵David S. Miller4-15/+24
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless John W. Linville says: ==================== pull request: wireless 2014-11-26 Please pull this little batch of fixes intended for the 3.18 stream... For the iwlwifi one, Emmanuel says: "Not all the firmware know how to handle the HOT_SPOT_CMD. Make sure that the firmware will know this command before sending it. This avoids a firmware crash." Along with that, Larry sends a pair of rtlwifi fixes to address some discrepancies from moving drivers out of staging. Larry says: "These two patches are needed to fix a regression introduced when driver rtl8821ae was moved from staging to the regular wireless tree." Please let me know if there are problems! ==================== Signed-off-by: David S. Miller <[email protected]>
2014-11-26staging: vt6655: rf.c clean up function commentsMalcolm Priestley1-28/+31
Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: rf.c Removed unneeded commentsMalcolm Priestley1-134/+0
Type and function that are not present comments Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: rf.c: Remove author commentsMalcolm Priestley1-18/+3
Moving names to file header comment Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: rf.c camel calse vnt_private rename pDevice to privMalcolm Priestley1-36/+36
Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: IFRFbWriteEmbedded replace __iomem with vnt_privateMalcolm Priestley2-42/+45
Fixing callers to vnt_private Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: rf remove __iomem *dwIoBase from functionsMalcolm Priestley3-15/+24
replacing with vnt_private and removing dereferencing from callers Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: card.c move __iomem into functions.Malcolm Priestley4-15/+20
Removing dereferencing from callers Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: card Remove function vUpdateIFSMalcolm Priestley3-67/+0
vUpdateIFS does the same operations of CARDbSetPhyParameter there is not need to call this function. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: always keep abyCurrentNetAddr aligned to 2Malcolm Priestley1-1/+1
Because the driver now uses ether_addr_copy the alignment of this variable must be maintained at 2. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: change typedef enum _VIA_PKT_TYPE to macroMalcolm Priestley2-14/+11
Replacing for u8 type and removing cast for byBBType. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: replace typedef enum _VIA_BB_TYPE with macrosMalcolm Priestley1-7/+4
Replacing type with u8 Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: CARDbSetPhyParameter remove unused parametersMalcolm Priestley3-9/+4
wCapInfo byERPField, *pvSupportRateIEs *pvExtSupportRateIEs Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: dead code remove typedef enum _CARD_PHY_TYPEMalcolm Priestley2-8/+0
Removing unused eCurrentPHYType Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: s_vCalculateOFDMRParameter use bb_type for CARD_PHY_TYPEMalcolm Priestley1-10/+10
using u8 for bb_type and replacing PHY_TYPE_11A with BB_TYPE_11A Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: CARDvSetRSPINF us bb_type for CARD_PHY_TYPEMalcolm Priestley2-11/+11
Using u8 for bb_type Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: CARDbSetPhyParameter change CARD_PHY_TYPE to bb_typeMalcolm Priestley2-5/+5
using u8 for bb_type Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: dead code remove CARDbAddBasicRateMalcolm Priestley2-13/+0
we nonlonger set rates in the driver Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: CARDvUpdateBasicTopRate use basic_rates to find top rateMalcolm Priestley1-2/+2
basic_rates should now be used to find it. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26sparc: Add NOP dma_cache_sync() implementation.David S. Miller1-0/+8
This can be a NOP because we forward dma_{alloc,free}_noncoherent to dma_{alloc,free}_coherent. Signed-off-by: David S. Miller <[email protected]>
2014-11-26staging: lustre: ldlm: Remove space before braces for defined() checkAndreas Ruprecht2-2/+2
checkpatch complains about two places where a space is prohibited before the braces for in "#if defined()" check. This patch removes these warnings. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Remove unnecessary braces at ifsAndreas Ruprecht2-7/+4
checkpatch complains about three places where braces are not necessary. This patch removes the braces. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Remove unnecessary line continuationsAndreas Ruprecht1-2/+2
checkpatch finds two unnecessary line continuations in ldlm_lockd.c which are removed by this patch. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Fix warning about unneeded return statementAndreas Ruprecht1-1/+0
checkpatch complains about an unneeded return statement in the function search_granted_lock(), which is removed by this patch. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Fix initialization of static variablesAndreas Ruprecht2-2/+2
checkpatch complains about static variables being initialized to 0 which is unnecessary. This patch removes the initialization. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Fix indentation errors for switch-caseAndreas Ruprecht2-25/+25
checkpatch complains about two indentation errors where the case statements are on a higher indentation level than the corresponding switch statement. This patch removes these errors. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Fix warning about missing spacesAndreas Ruprecht3-7/+8
checkpatch.pl complains about a number of places where spaces were missing. This patch fixes all of these errors. For better readability, the warning of hitting the 80 character per line limit in line 1349 introduced by this change is ignored deliberately. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.