aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2008-05-22sfc: Change type of efx_nic::nic_data to struct falcon_nic_data *Ben Hutchings2-5/+2
Remove redundant casts and variable. Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Use __packed macroBen Hutchings1-2/+2
Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Do not define inline macroBen Hutchings1-5/+0
Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Use DMA_BIT_MASK() instead of our own DMA mask macrosBen Hutchings3-15/+3
Also change type of efx_nic_type::max_dma_mask to u64, matching pci_dma_supported() parameter type. Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Correct and expand some commentsBen Hutchings1-6/+14
These comments have been revised in response to questions raised by Andrew Morton in <[email protected]>. Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Use resource_size_t for PCI bus addressBen Hutchings2-6/+7
This should make the driver work on 32-bit systems with 64-bit PCI support. Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Merged efx_page_offset() into efx_rx_buf_offset()Ben Hutchings1-7/+3
Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Replaced various macros with inline functionsBen Hutchings11-75/+105
Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Added and removed braces to comply with kernel styleBen Hutchings4-8/+13
Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Removed unncesssary UL suffixes on 0 literalsBen Hutchings1-2/+2
Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Simplified efx_rx_calc_buffer_size() using get_order()Ben Hutchings1-21/+8
Merged it into its only caller, efx_init_channels(). Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Removed casts to voidBen Hutchings5-13/+13
Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-22sfc: Use mod_timer() to set expiry and add_timer() togetherBen Hutchings1-6/+3
Signed-off-by: Ben Hutchings <[email protected]> Signed-off-by: Jeff Garzik <[email protected]>
2008-05-21net: The world is not perfect patch.Rami Rosen3-362/+3
Unless there will be any objection here, I suggest consider the following patch which simply removes the code for the -DI_WISH_WORLD_WERE_PERFECT in the three methods which use it. The compilation errors we get when using -DI_WISH_WORLD_WERE_PERFECT show that this code was not built and not used for really a long time. Signed-off-by: Rami Rosen <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-21tcp: Make prior_ssthresh a u32Ilpo Järvinen1-1/+1
If previous window was above representable values of u16, strange things will happen if undo with the truncated value is called for. Alternatively, this could be fixed by some max trickery but that would limit undoing high-speed undos. Adds 16-bit hole but there isn't anything to fill it with. Signed-off-by: Ilpo Järvinen <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-21xfrm_user: Remove zero length key checks.David S. Miller1-11/+0
The crypto layer will determine whether that is valid or not. Suggested by Herbert Xu, based upon a report and patch by Martin Willi. Signed-off-by: David S. Miller <[email protected]> Acked-by: Herbert Xu <[email protected]>
2008-05-21net/ipv4/arp.c: Use common hex_asc helpersDenis Cheng1-3/+2
Here the local hexbuf is a duplicate of global const char hex_asc from lib/hexdump.c, except the hex letters' cases: const char hexbuf[] = "0123456789ABCDEF"; const char hex_asc[] = "0123456789abcdef"; and here to print HW addresses, the hex cases are not significant. Thanks to Harvey Harrison to introduce the hex_asc_hi/hex_asc_lo helpers. Signed-off-by: Denis Cheng <[email protected]> Signed-off-by: Harvey Harrison <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-21cassini: Only use chip checksum for ipv4 packets.David S. Miller1-4/+7
According to David Monro, at least with Natsemi Saturn chips the cassini driver has some trouble with ipv6 checksums. Until we have more information about what's going on here, only use the chip checksums for ipv4. This workaround was suggested and tested by David. Update version and release date. Signed-off-by: David S. Miller <[email protected]>
2008-05-21tcp: TCP connection times out if ICMP frag needed is delayedSridhar Samudrala1-4/+6
We are seeing an issue with TCP in handling an ICMP frag needed message that is received after net.ipv4.tcp_retries1 retransmits. The default value of retries1 is 3. So if the path mtu changes and ICMP frag needed is lost for the first 3 retransmits or if it gets delayed until 3 retransmits are done, TCP doesn't update MSS correctly and continues to retransmit the orginal message until it timesout after tcp_retries2 retransmits. I am seeing this issue even with the latest 2.6.25.4 kernel. In tcp_retransmit_timer(), when retransmits counter exceeds tcp_retries1 value, the dst cache entry of the socket is reset. At this time, if we receive an ICMP frag needed message, the dst entry gets updated with the new MTU, but the TCP sockets dst_cache entry remains NULL. So the next time when we try to retransmit after the ICMP frag needed is received, tcp_retransmit_skb() gets called. Here the cur_mss value is calculated at the start of the routine with a NULL sk_dst_cache. Instead we should call tcp_current_mss after the rebuild_header that caches the dst entry with the updated mtu. Also the rebuild_header should be called before tcp_fragment so that skb is fragmented if the mss goes down. Signed-off-by: Sridhar Samudrala <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-21netfilter: Move linux/types.h inclusions outside of #ifdef __KERNEL__Patrick McHardy4-4/+4
Greg Steuck <[email protected]> points out that some of the netfilter headers can't be used in userspace without including linux/types.h first. The headers include their own linux/types.h include statements, these are stripped by make headers-install because they are inside #ifdef __KERNEL__ however. Move them out to fix this. Reported and Tested by Greg Steuck. Signed-off-by: Patrick McHardy <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-21af_key: Fix selector family initialization.Kazunori MIYAZAWA1-1/+1
This propagates the xfrm_user fix made in commit bcf0dda8d2408fe1c1040cdec5a98e5fcad2ac72 ("[XFRM]: xfrm_user: fix selector family initialization") Based upon a bug report from, and tested by, Alan Swanson. Signed-off-by: Kazunori MIYAZAWA <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-20Merge branch 'master' of ↵David S. Miller8-23/+44
master.kernel.org:/pub/scm/linux/kernel/git/linville/wireless-2.6
2008-05-20libertas: Fix ethtool statisticsDavid Woodhouse1-14/+13
Fix various problems: - We converted MESH_ACCESS to a direct command but missed this caller. - We were trying to access mesh stats even on meshless firmware. - We should really zero the buffer if something goes wrong. Signed-off-by: David Woodhouse <[email protected]> Acked-by: Dan Williams <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-20mac80211: fix NULL pointer dereference in ieee80211_compatible_ratesHelmut Schaa1-4/+11
Fix a possible NULL pointer dereference in ieee80211_compatible_rates introduced in the patch "mac80211: fix association with some APs". If no bss is available just use all supported rates in the association request. Signed-off-by: Helmut Schaa <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-20pktgen: make sure that pktgen_thread_worker has been executedDenis V. Lunev1-0/+4
The following courruption can happen during pktgen stop: list_del corruption. prev->next should be ffff81007e8a5e70, but was 6b6b6b6b6b6b6b6b kernel BUG at lib/list_debug.c:67! :pktgen:pktgen_thread_worker+0x374/0x10b0 ? autoremove_wake_function+0x0/0x40 ? _spin_unlock_irqrestore+0x42/0x80 ? :pktgen:pktgen_thread_worker+0x0/0x10b0 kthread+0x4d/0x80 child_rip+0xa/0x12 ? restore_args+0x0/0x30 ? kthread+0x0/0x80 ? child_rip+0x0/0x12 RIP list_del+0x48/0x70 The problem is that pktgen_thread_worker can not be executed if kthread_stop has been called too early. Insert a completion on the normal initialization path to make sure that pktgen_thread_worker will gain the control for sure. Signed-off-by: Denis V. Lunev <[email protected]> Acked-by: Alexey Dobriyan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-20mac80211: don't claim iwspy supportJohannes Berg1-1/+0
We removed iwspy support a very long time ago because it is useless, but forgot to stop claiming to support it. Apparently, nobody cares, but remove it nonetheless. Signed-off-by: Johannes Berg <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-20orinoco_cs: add ID for SpeedStream wireless adaptersPavel Roskin1-0/+1
Reported by Gerald Willmann <[email protected]> Signed-off-by: Pavel Roskin <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-20hostap_cs: add ID for Conceptronic CON11CProPavel Roskin1-0/+1
Reported by Santiago Garcia Mantinan <[email protected]> Signed-off-by: Pavel Roskin <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-20rtl8187: resource leak in error caseOliver Neukum1-2/+12
This fixes resource leaks in error cases due to urb submission failures. Signed-off-by: Oliver Neukum <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-20[VLAN]: Propagate selected feature bits to VLAN devicesPatrick McHardy4-2/+41
Propagate feature bits from the NETDEV_FEAT_CHANGE notifier. For now only TSO is propagated for devices that announce their ability to support TSO in combination with VLAN accel by setting the NETIF_F_VLAN_TSO flag. Signed-off-by: Patrick McHardy <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-20drivers/atm/: remove CVS keywordsAdrian Bunk6-17/+1
This patch removes CVS keywords that weren't updated for a long time. Signed-off-by: Adrian Bunk <[email protected]> Acked-by: Chas Williams <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-20ath5k: Fix loop variable initializationsBob Copeland2-2/+6
In ath5k_tasklet_rx, both status structures 'rxs' and 'rs' are initialized at the top of the tasklet, but not within the loop. If the loop is executed multiple times in the tasklet then the variables may see changes from previous packets. For TKIP, this results in 'Invalid Michael MIC' errors if two packets are processed in the tasklet: rxs.flag gets set to RX_DECRYPTED by mac80211 when it decrypts the first encrypted packet. The subsequent packet will have RX_DECRYPTED set upon entry to mac80211, so mac80211 will not try to decrypt it. We currently initialize all but two fields in the structures, so fix the other two. Signed-off-by: Bob Copeland <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-20vlan: Correctly handle device notifications for layered VLAN devicesPatrick McHardy1-3/+1
Commit 30688a9 ([VLAN]: Handle vlan devices net namespace changing) changed the device notifier to special-case notifications for VLAN devices, effectively disabling state propagation to underlying VLAN devices. This is needed for layered VLANs though, so restore the original behaviour. Signed-off-by: Patrick McHardy <[email protected]> Acked-by: Pavel Emelyanov <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-20net: Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags()David Woodhouse1-1/+1
Am I just being particularly dim today, or can the call to dev->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() never happen? We've just set dev->flags = flags & IFF_MULTICAST, effectively. So the condition '(dev->flags ^ flags) & IFF_MULTICAST' is _never_ going to be true. Signed-off-by: David Woodhouse <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-20net_sched: cls_api: fix return value for non-existant classifiersPatrick McHardy1-1/+1
cls_api should return ENOENT when the requested classifier doesn't exist. Signed-off-by: Patrick McHardy <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-20ipsec: Use the correct ip_local_out functionHerbert Xu2-2/+2
Because the IPsec output function xfrm_output_resume does its own dst_output call it should always call __ip_local_output instead of ip_local_output as the latter may invoke dst_output directly. Otherwise the return values from nf_hook and dst_output may clash as they both use the value 1 but for different purposes. When that clash occurs this can cause a packet to be used after it has been freed which usually leads to a crash. Because the offending value is only returned from dst_output with qdiscs such as HTB, this bug is normally not visible. Thanks to Marco Berizzi for his perseverance in tracking this down. Signed-off-by: Herbert Xu <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-19ipv6 addrconf: Allow infinite prefix lifetime.YOSHIFUJI Hideaki2-25/+52
We need to handle infinite prefix lifetime specially. With help from original reporter "Bonitch, Joseph" <[email protected]>. Signed-off-by: YOSHIFUJI Hideaki <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-19ipv6 route: Fix lifetime in netlink.YOSHIFUJI Hideaki1-1/+3
We could not see appropriate lifetime if the route had been scheduled to expired at 0 (in jiffies). We should check rt6i_flags instead of rt6i_expires to determine whether lifetime is valid or not. Signed-off-by: YOSHIFUJI Hideaki <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-19ipv6 addrconf: Fix route lifetime setting in corner case.YOSHIFUJI Hideaki1-1/+1
Because of arithmetic overflow avoidance, the actual lifetime setting (vs the value given by RA) did not increase monotonically around 0x7fffffff/HZ. Signed-off-by: YOSHIFUJI Hideaki <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-19Merge branch 'master' of ↵David S. Miller7-18/+73
master.kernel.org:/pub/scm/linux/kernel/git/linville/wireless-2.6
2008-05-19ndisc: Add missing strategies for per-device retrans timer/reachable time ↵YOSHIFUJI Hideaki3-5/+9
settings. Noticed from Al Viro <[email protected]> via David Miller <[email protected]>. Signed-off-by: YOSHIFUJI Hideaki <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-19ipv6: Move <linux/in6.h> from header-y to unifdef-y.Robert P. J. Day1-1/+1
Given that <linux/in6.h> contains a __KERNEL__ test, it should be unifdef-ed. Signed-off-by: Robert P. J. Day <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-19l2tp: avoid skb truesize bug if headroom is increasedJames Chapman1-5/+8
A user reported seeing occasional bugs such as the following when using the L2TP driver. SKB BUG: Invalid truesize (272) len=72, sizeof(sk_buff)=208 When L2TP adds its header in the transmit path, it might need to increase the headroom of the skb. In some cases, the increased headroom trips a kernel bug when the skb is freed because the skb has grown beyond its truesize value. The fix is to increase the truesize by the amount of headroom added, after orphaning the skb. While here, fix a misleading comment. Thanks to Iouri Kharon <[email protected]> for the initial report and testing the fix. Signed-off-by: James Chapman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
2008-05-16wireless: Create 'device' symlink in sysfsMasakazu Mokuno3-0/+3
Some network interfaces of the wireless drivers lack the 'device' symlink in sysfs. This patch lets the drivers create the links. Signed-off-by: Masakazu Mokuno <[email protected]> Acked-by: Dan Williams <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-16wireless, airo: waitbusy() won't delayRoel Kluin1-1/+1
There will be no delay even when COMMAND_BUSY (defined 0x8000) is set: 0x8000 & (delay < 10000) will evaluate to 0 - when delay is 0. Signed-off-by: Roel Kluin <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-16libertas: fix command timeout after firmware failureBrian Cavagnolo1-0/+1
This is a fix for OLPC ticket #6586: "SCAN command fails, timer doesn't fire". In fact, the timer was firing; the problem was that the dnld_sent state variable was not being updated after the timer expired, so lbs_execute_next_command was not being called. Signed-off-by: Brian Cavagnolo <[email protected]> Signed-off-by: Javier Cardona <[email protected]> Signed-off-by: David Woodhouse <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-16mac80211: Add RTNL version of ieee80211_iterate_active_interfacesIvo van Doorn2-3/+59
Since commit e38bad4766a110b61fa6038f10be16ced8c6cc38 mac80211: make ieee80211_iterate_active_interfaces not need rtnl rt2500usb and rt73usb broke down due to attempting register access in atomic context (which is not possible for USB hardware). This patch restores ieee80211_iterate_active_interfaces() to use RTNL lock, and provides the non-RTNL version under a new name: ieee80211_iterate_active_interfaces_atomic() So far only rt2x00 uses ieee80211_iterate_active_interfaces(), and those drivers require the RTNL version of ieee80211_iterate_active_interfaces(). Since they already call that function directly, this patch will automatically fix the USB rt2x00 drivers. v2: Rename ieee80211_iterate_active_interfaces_rtnl Signed-off-by: Ivo van Doorn <[email protected]> Acked-by: Johannes Berg <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-16mac80211 : Association with 11n hidden ssid ap.Abhijeet Kolekar1-9/+5
This patch fixes the association problem with 11n hidden ssid ap. Patch fixes the problem of associating with hidden ssid when all three parameters ap,essid and channel are given to iwconfig. This patch removes the condition of checking three parameters and always checks for bss in bss list while associating. Signed-off-by: Abhijeet Kolekar <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-15hostap: fix "registers" registration in procfsMathieu Chouquet-Stringer1-5/+4
The "registers" entry was incorrectly created in the procfs root instead of the device specific directory. Move "registers" registration immediately after the containing procfs directory is created. Signed-off-by: Mathieu Chouquet-Stringer <[email protected]> Signed-off-by: Pavel Roskin <[email protected]> Signed-off-by: John W. Linville <[email protected]>
2008-05-14isdn/capi: Return proper errnos on module init.Marcin Slusarz1-3/+3
cdebug_init() is called from kcapi_init() which is module initialization function, so it must return negative values on errors. Signed-off-by: Marcin Slusarz <[email protected]> Acked-by: Karsten Keil <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: David S. Miller <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.