aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-10-15Staging: sst: more copy_to_user() changesDan Carpenter1-43/+30
Vinod wanted the copy_to_user() calls in this format: if (copy_to_user()) retval = -EFAULT; instead of this: retval = copy_to_user(); if (retval) retval = -EFAULt; I've done that for the whole intel_sst_app_interface.c file. In the process I noticed a couple more places that returned -EBUSY or -EAGAIN instead of -EFAULT. Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15Staging: intel_sst: off by one bugDan Carpenter2-2/+1
This should be >= instead of > or we go passed the end of the array. Also the arrays are declared with size MAX_NUM_STREAMS. This is the only place that uses MAX_NUM_STREAMS_MFLD. It seems like asking for trouble to use two variables for the same information. I've changed everything to use MAX_NUM_STREAMS. This bug isn't really harmful. In the worst case, if you enabled debugging then you would see a message. Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15Staging: intel_sst: return -EFAULT if copy_to_user() failsDan Carpenter1-1/+3
copy_to_user() returns the number of bytes remaining to be copied but we want to return an error code. And that error code is -EFAULT not -EIO. Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Alan Cox <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: hv: Convert camel cased functions in channel_mgmt.c to lower caseHaiyang Zhang4-53/+55
Convert camel cased functions in channel_mgmt.c to lower case Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: hv: Convert camel cased local variable names in channel_mgmt.c to ↵Haiyang Zhang1-125/+133
lower case Convert camel cased local variable names in channel_mgmt.c to lower case Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: hv: Convert camel cased parameter in channel_interface.h to lower caseHaiyang Zhang1-2/+2
Convert camel cased parameter in channel_interface.h to lower case Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: hv: Convert camel cased function names in channel_interface.c to ↵Haiyang Zhang3-22/+22
lower cases Convert camel cased function names in channel_interface.c to lower cases Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: hv: Convert camel cased local variables in channel_interface.c to ↵Haiyang Zhang1-62/+64
lower cases Convert camel cased local variables in channel_interface.c to lower cases Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: tidspbridge: Clean up error-handling codeJulia Lawall1-3/+7
In the first hunk, 0 is returned on memory allocation failure, even though other failures return -ENOMEM or other similar values. In the second hunk, there was error handling code that returned without freeing psz_path_name. A simplified version of the semantic match that finds the first problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ expression ret; expression x,e1,e2,e3; @@ ret = 0 ... when != ret = e1 *x = \(kmalloc\|kcalloc\|kzalloc\)(...) ... when != ret = e2 if (x == NULL) { ... when != ret = e3 return ret; } // </smpl> Signed-off-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: ft1000: Use specific error return code for reg_ft1000_netdev().Marek Belisko3-5/+7
Signed-off-by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: ft1000: Use specific return error codes.Marek Belisko1-13/+17
Signed-off-by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: ft1000: Check return value when init net device.Marek Belisko1-1/+5
Signed-off-by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: ft1000: Remove DRVMGS typedef usage.Marek Belisko3-9/+9
Signed-off-by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: ft1000: Remove PSEUDO_HDR typedef usage.Marek Belisko5-63/+27
Signed-off-by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: ft1000: Remove PROV_RECORD typedef usage.Marek Belisko3-11/+10
Signed-off-by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: ft1000: Remove APP_INFO_BLOCK typedef usage.Marek Belisko1-14/+13
Signed-off-by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: ft1000: Remove DSPINITMSG typedef usage.Marek Belisko2-15/+15
Signed-off-by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: ft1000: Remove MEDIAMSG typedef usage.Marek Belisko2-5/+4
Signed-off-by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: ft1000: Remove unused function ft1000_hbchk()Marek Belisko1-147/+1
Signed-off-by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15Staging: intel_sst: cleanup naming a littleDan Carpenter1-5/+3
&sst_drv_ctx->streams[str_id].lock and &stream->lock are the same. The mutex_lock() uses &stream->lock so this makes things consistent and it's nicer to read as well. Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Vinod Koul <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15Staging: ft1000-usb: use the correct list headDan Carpenter1-1/+1
Using pdpram_blk here would cause an oops. We intended to use &freercvpool. Signed-off-by: Dan Carpenter <[email protected]> Tested by: Marek Belisko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15Staging: lirc: fix PTR_ERR() checkDan Carpenter1-1/+1
This is a typo. It's supposed to be IS_ERR() here instead of PTR_ERR(). Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Jarod Wilson <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15Staging: ft1000-usb: fix array overflowDan Carpenter1-2/+1
The code here is supposed checking if we exited the loop without hitting a break. The problem is that in the error handling "i" is out of bounds and it corrupts memory when we do an info->app_info[i].nRxMsgMiss++. >From the comments, it looks like someone noticed this corruption and updated the code, but didn't totally fix the problem. The correct fix is just to remove nRxMsgMiss++ from the error path. I believe this bug can be triggered remotely. Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_dectlk.c: style fixesChristopher Brannon1-15/+22
* Clean this file based on reports from checkpatch.pl. * Replace a function-like macro with an inline function. * Remove an incorrect use of the volatile qualifier. The previously-volatile variable is now always protected by a spinlock. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_txprt.c: style fixesChristopher Brannon1-7/+7
* Clean this file based on reports from checkpatch.pl. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_spkout.c: style fixesChristopher Brannon1-8/+8
* Clean this file based on reports from checkpatch.pl. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_soft.c: style fixesChristopher Brannon1-21/+34
* Clean this file based on reports from checkpatch.pl. * Make the file_operations structure const. * Use strict_strtoul instead of simple_strtoul. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_ltlk.c: style fixesChristopher Brannon1-11/+10
* Clean this file based on reports from checkpatch.pl. * Remove an unused function-like macro. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_keypc.c: style fixesChristopher Brannon1-10/+18
* Clean this file based on reports from checkpatch.pl. * Eliminate the unused synth_readable macro. * Convert function-like macros to inline functions. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_dummy.c: style fixesChristopher Brannon1-7/+7
* Clean this file based on reports from checkpatch.pl. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_dtlk.c: style fixesChristopher Brannon1-20/+36
* Clean this file based on reports from checkpatch.pl. * Replace function-like macros with inline functions. * Simplify some boolean expressions. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_decpc.c: style fixesChristopher Brannon1-10/+11
* Clean this file based on reports from checkpatch.pl. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_decext.c: style fixesChristopher Brannon1-13/+24
* Clean this file based on reports from checkpatch.pl. * Replace function-like macros with inline macros. * Eliminate a use of the ternary operator, for readability. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_bns.c: style fixesChristopher Brannon1-7/+7
* Clean this file based on reports from checkpatch.pl. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_audptr.c: style fixesChristopher Brannon1-8/+8
* Clean this file based on reports from checkpatch.pl. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_apollo.c: style fixesChristopher Brannon1-10/+12
* Clean this file based on reports from checkpatch.pl. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_acntsa.c: style fixesChristopher Brannon1-8/+7
* Clean this file based on reports from checkpatch.pl. * Eliminate an unused function-like macro. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-15staging: speakup: speakup_acntpc.c: style fixesChristopher Brannon1-12/+20
* Clean this file based on reports from checkpatch.pl. * Eliminate the unused synth_readable macro. * Convert function-like macros to inline functions. Signed-off-by: Christopher Brannon <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14drivers: misc: ti-st: fix review commentsPavan Savoy3-65/+25
Based on comments from Jiri Slaby, drop the register storage specifier, remove the unused code, cleanup the const to non-const type casting. Also make the line discipline ops structure static, since its a singleton, unmodified structure which need not be in heap. Reported-by: Jiri Slaby <[email protected]> Signed-off-by: Pavan Savoy <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14staging: brcm80211: remove unrefrenced malloced field[email protected]1-2/+0
from 'struct osl_info' structure Signed-off-by: Mike Rapoport <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14staging: brcm80211: replace MFREE with kfree[email protected]28-145/+115
Signed-off-by: Mike Rapoport <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14staging: brcm80211: remove unused NATIVE_{MALLOC,MFREE}[email protected]1-3/+0
Signed-off-by: Mike Rapoport <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14staging: brcm80211: replace MALLOC() with k[zm]alloc[email protected]26-129/+74
Signed-off-by: Mike Rapoport <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14staging: brcm80211: remove osl_malloced()/MALLOCED()[email protected]15-42/+16
because there are other means to track memory leaks in kernel Signed-off-by: Mike Rapoport <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14staging: brcm80211: remove DHD_USE_STATIC_BUF[email protected]7-264/+1
The DHD_USE_STATIC_BUF cannot be enabled in the build configuration, remove it. Signed-off-by: Mike Rapoport <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14Staging: brcm80211: fix up compiler warnings I createdGreg Kroah-Hartman1-3/+3
I messed up on some of the uintptr conversions, this fixes them up properly. Cc: Brett Rudley <[email protected]> Cc: Henry Ptasinski <[email protected]> Cc: Nohee Ko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14staging: brcm80211: remove OSL_DELAY[email protected]20-143/+129
and use udelay and mdelay instead Signed-off-by: Mike Rapoport <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14staging: brcm80211: brcmfmac: bug fix - scan result reportnohee ko1-5/+11
Scan result was reported with some duplicated information. Those were about SSID/ rate. With this patch, the duplication can be erased. Signed-off-by: Nohee Ko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14staging: brcm80211: brcmfmac: replace KILL_PROC with send_sig()nohee ko4-14/+6
logic optimization : replace KILL_PROC with send_sig() Signed-off-by: Nohee Ko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-10-14staging: brcm80211: Purge unused bcmwpa.[ch]Brett Rudley6-145/+4
Move two macros into wlc_mac80211.h and purge the rest. Signed-off-by: Brett Rudley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.