Age | Commit message (Collapse) | Author | Files | Lines |
|
copy_to_user() returns the number of bytes remaining to be copied but we
want to return an error code. And that error code is -EFAULT not -EIO.
Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Alan Cox <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Convert camel cased functions in channel_mgmt.c to lower case
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
lower case
Convert camel cased local variable names in channel_mgmt.c to lower case
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Convert camel cased parameter in channel_interface.h to lower case
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
lower cases
Convert camel cased function names in channel_interface.c to lower cases
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
lower cases
Convert camel cased local variables in channel_interface.c to lower cases
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
In the first hunk, 0 is returned on memory allocation failure, even though
other failures return -ENOMEM or other similar values.
In the second hunk, there was error handling code that returned without
freeing psz_path_name.
A simplified version of the semantic match that finds the first problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression ret;
expression x,e1,e2,e3;
@@
ret = 0
... when != ret = e1
*x = \(kmalloc\|kcalloc\|kzalloc\)(...)
... when != ret = e2
if (x == NULL) { ... when != ret = e3
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
&sst_drv_ctx->streams[str_id].lock and &stream->lock are the same.
The mutex_lock() uses &stream->lock so this makes things consistent and
it's nicer to read as well.
Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Vinod Koul <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Using pdpram_blk here would cause an oops. We intended to use
&freercvpool.
Signed-off-by: Dan Carpenter <[email protected]>
Tested by: Marek Belisko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This is a typo. It's supposed to be IS_ERR() here instead of PTR_ERR().
Signed-off-by: Dan Carpenter <[email protected]>
Acked-by: Jarod Wilson <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The code here is supposed checking if we exited the loop without hitting
a break. The problem is that in the error handling "i" is out of bounds
and it corrupts memory when we do an info->app_info[i].nRxMsgMiss++.
>From the comments, it looks like someone noticed this corruption and
updated the code, but didn't totally fix the problem. The correct fix
is just to remove nRxMsgMiss++ from the error path.
I believe this bug can be triggered remotely.
Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
* Replace a function-like macro with an inline function.
* Remove an incorrect use of the volatile qualifier. The
previously-volatile variable is now always protected by a spinlock.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
* Make the file_operations structure const.
* Use strict_strtoul instead of simple_strtoul.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
* Remove an unused function-like macro.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
* Eliminate the unused synth_readable macro.
* Convert function-like macros to inline functions.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
* Replace function-like macros with inline functions.
* Simplify some boolean expressions.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
* Replace function-like macros with inline macros.
* Eliminate a use of the ternary operator, for readability.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
* Eliminate an unused function-like macro.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
* Clean this file based on reports from checkpatch.pl.
* Eliminate the unused synth_readable macro.
* Convert function-like macros to inline functions.
Signed-off-by: Christopher Brannon <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Based on comments from Jiri Slaby, drop the register
storage specifier, remove the unused code, cleanup
the const to non-const type casting.
Also make the line discipline ops structure static, since
its a singleton, unmodified structure which need not be
in heap.
Reported-by: Jiri Slaby <[email protected]>
Signed-off-by: Pavan Savoy <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
from 'struct osl_info' structure
Signed-off-by: Mike Rapoport <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Mike Rapoport <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Mike Rapoport <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Signed-off-by: Mike Rapoport <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
because there are other means to track memory leaks in kernel
Signed-off-by: Mike Rapoport <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The DHD_USE_STATIC_BUF cannot be enabled in the build configuration,
remove it.
Signed-off-by: Mike Rapoport <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
I messed up on some of the uintptr conversions, this fixes them up
properly.
Cc: Brett Rudley <[email protected]>
Cc: Henry Ptasinski <[email protected]>
Cc: Nohee Ko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
and use udelay and mdelay instead
Signed-off-by: Mike Rapoport <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Scan result was reported with some duplicated information.
Those were about SSID/ rate. With this patch, the duplication
can be erased.
Signed-off-by: Nohee Ko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
logic optimization : replace KILL_PROC with send_sig()
Signed-off-by: Nohee Ko <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Move two macros into wlc_mac80211.h and purge the rest.
Signed-off-by: Brett Rudley <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fix printk format warning:
drivers/staging/speakup/serialio.c:44: warning: format '%x' expects type 'unsigned int', but argument 2 has type 'long unsigned int'
Signed-off-by: Randy Dunlap <[email protected]>
Cc: <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove functions and definitions that refer to USB since the driver
doesn't support USB and it's not planned to add USB support to that
driver. So the code is just dead code which can be removed.
Cc: David Daney <[email protected]>
Signed-off-by: Bernhard Walle <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|