aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-03-05Staging: rtl8192e: Rename varoable osCcxVerNumTree Davies1-6/+6
Rename variable osCcxVerNum to os_vcx_ver_num to fix checkpatch warning Avoid CamelCase, Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable CcxAironetBufTree Davies1-4/+4
Rename variable CcxAironetBuf to ccx_aironet_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable osCcxAironetIETree Davies1-8/+8
Rename variable osCcxAironetIE to os_ccx_aironet_ie to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable AironetIeOuiTree Davies1-3/+3
Rename variable AironetIeOui to aironet_ie_oui to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable asRsnTree Davies2-14/+14
Rename variable asRsn to rsn to fix checkpatch warning Avoid CamelCase, and adjust spacing to avoid alignment check. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable CcxVerNumBufTree Davies1-4/+4
Rename variable CcxVerNumBuf to ccx_ver_num_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable BssCcxVerNumberTree Davies3-7/+7
Rename variable BssCcxVerNumber to bss_ccx_ver_number to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable CcxRmCapBufTree Davies1-3/+3
Rename variable CcxRmCapBuf to ccx_rm_cap_buf to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable bCcxRmEnableTree Davies3-7/+7
Rename variable bCcxRmEnable to ccx_rm_enable to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable bCkipSupportedTree Davies3-7/+7
Rename variable bCkipSupported to ckip_supported to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable osCcxRmCapTree Davies1-6/+6
Rename variable osCcxRmCap to os_ccx_rm_cap to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable Turbo_EnableTree Davies3-5/+5
Rename variable Turbo_Enable to turbo_enable to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable PMKIDListTree Davies2-4/+4
Rename variable PMKIDList to pmkid_list to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename function SecIsInPMKIDList()Tree Davies1-2/+2
Rename function SecIsInPMKIDList to sec_is_in_pmkid_list to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename variable NumRecvDataInPeriodTree Davies5-9/+9
Rename variable NumRecvDataInPeriod to num_recv_data_in_period to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8192e: Rename function rtllib_rx_ADDBAReq()Tree Davies3-3/+3
Rename function rtllib_rx_ADDBAReq to rtllib_rx_add_ba_req to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: vme_user: Fix misaligned closing comment */Jonathan Bergh1-4/+2
This patch makes the following change: * Ensures the trailing */ for comments is on the same line as the opening /* Signed-off-by: Jonathan Bergh <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: fbtft: remove unused variable 'count'Colin Ian King1-2/+0
The variable count is being initialized and incremented but it is never actually referenced in any other way. The variable is redundant and can be removed. Cleans up clang scan build warning: drivers/staging/fbtft/fbtft-core.c:330:6: warning: variable 'count' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: pi433: Move FIFO_THRESHOLD define to source fileShahar Avidar2-1/+1
FIFO_THRESHOLD is only being used in pi433_if.c source files. Signed-off-by: Shahar Avidar <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: pi433: Remove the unused FREQUENCY defineShahar Avidar1-2/+0
FREQUENCY is not being used, delete its comment. Signed-off-by: Shahar Avidar <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: pi433: Redefine F_OSC using units.h macroShahar Avidar1-1/+2
Use HZ_PER_MHZ for a more robust definition. Suggested-by: Andy Shevchenko <[email protected]> Signed-off-by: Shahar Avidar <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: pi433: Remove a duplicated F_OSC defineShahar Avidar1-1/+0
F_OSC is already defined & only used by rf69.c source file. Signed-off-by: Shahar Avidar <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: pi433: Remove a duplicated FIFO_SIZE defineShahar Avidar1-1/+0
FIFO_SIZE is being used in both rf69.c & pi433_if.c source files. It is also already defined in rf69.h header file. Signed-off-by: Shahar Avidar <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: rename enum members to upper caseMichael Straube2-16/+16
Enum members are usually named all upper case. Rename the members of the enum fsync_state to improve readability and follow the common kernel coding style. Default_Fsync -> DEFAULT_FSYNC HW_Fsync -> HW_FSYNC SW_Fsync -> SW_FSYNC Signed-off-by: Michael Straube <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: remove empty cases from switch statementsMichael Straube1-3/+0
Rmove empty cases from switch statements to improve readability. All of these empty cases are covered by a default case already. Signed-off-by: Michael Straube <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: rename rateIndex to rate_indexMichael Straube1-32/+32
Rename the variable rateIndex in the function _rtl92e_update_received_rate_histogram_stats() to avoid camel case. rateIndex -> rate_index Signed-off-by: Michael Straube <[email protected]> Tested-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8723bs: remove redundant variable hoffsetColin Ian King1-12/+2
Variable hoffset in functions hal_EfuseGetCurrentSize_WiFi and hal_EfuseGetCurrentSize_BT is being assigned a value but it not being read for any useful reason at all. The variable is redundant and can be removed. Cleans up clang scan build warnings for lines 957 and 1050: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:957:5: warning: variable 'hoffset' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8723bs: Remove dead code from _rtw_free_network()Meir Elisha1-2/+0
Clean dead code from is_same_network() and _rtw_free_network(). Signed-off-by: Meir Elisha <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: rtl8723bs: Remove unnecessary braces in rtw_update_ht_capMeir Elisha1-4/+3
Remove braces from single statement blocks to improve coding style. Signed-off-by: Meir Elisha <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: octeon: Match parenthesis alignmentDorine Tipo1-1/+1
Align the function parameters to silence a checkpatch warning. Signed-off-by: Dorine Tipo <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: Remove unused variables ntotalfrag and Seq_NumPhilipp Hortmann2-10/+0
Remove unused variables ntotalfrag and Seq_Num as they are set and never evaluated. Remove resulting local variables seq, sc and hdr as well. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/4a3f2d217631076ee9994b46f8672eceaea8568c.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: Remove unused variables bShortPreamble and fragoffsetPhilipp Hortmann2-4/+0
Remove unused variables bShortPreamble and fragoffset as they are set and never evaluated. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/17c516c195acc458366ab182e0fd1200b7e2b1da.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: Remove unused variables nic_type and RxPowerPhilipp Hortmann3-5/+0
Remove unused variables nic_type and RxPower as they are set and never evaluated. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/96f8c089aefe6648dad0c68663211b375f016517.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: Remove variables fraglength and packetlengthPhilipp Hortmann2-5/+0
Remove unused variables fraglength and packetlength as they are set and never evaluated. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/cca48e6e3d4d32010699118d55fd82b1dbc6eda6.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: Remove variables bIsQosData and RxIs40MHzPacketPhilipp Hortmann3-7/+0
Remove unused variables bIsQosData and RxIs40MHzPacket as they are set and never evaluated. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/7a8b579fd3d377fa961fe71e37fe4afa22f2a3b9.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: Remove unused variable bShiftPhilipp Hortmann2-5/+0
Remove unused variable bShift as it is set and never evaluated. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/ff505fd05683a59b02ac2e3da115718d8a22735b.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: Remove variables Wakeup, Reserved0 and AGCPhilipp Hortmann1-3/+0
Remove unused variables Wakeup, Reserved0 and AGC. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/ed88686c1e9213dac1cc8f698f7dea8cb5fa01f9.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: rtl8192e: Remove variables tsf, beacon_time and AntennaPhilipp Hortmann1-3/+0
Remove unused variables tsf, beacon_time and Antenna. Signed-off-by: Philipp Hortmann <[email protected]> Link: https://lore.kernel.org/r/8f400e46ed16ec7a226284c42654855b2aba6502.1708461563.git.philipp.g.hortmann@gmail.com Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: fieldbus: make fieldbus_class constantRicardo B. Marliere1-1/+1
Since commit 43a7206b0963 ("driver core: class: make class_register() take a const *"), the driver core allows for struct class to be in read-only memory, so move the fieldbus_class structure to be declared at build time placing it into read-only memory, instead of having to be dynamically allocated at boot time. Cc: Greg Kroah-Hartman <[email protected]> Suggested-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: "Ricardo B. Marliere" <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: octeon: Don't bother filling in ethtool driver versionJohn Garry1-2/+0
The version is same as the default, so don't bother filling it in. Signed-off-by: John Garry <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: vc04_services: bcm2835-camera: fix brace code style checkMoritz C. Weber1-32/+28
Reformat function parameters to fix checkpatch check: Increase readability and consistency Signed-off-by: "Moritz C. Weber" <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05Staging: vc04_services: bcm2835-camera: fix blank line style checkMoritz C. Weber1-1/+0
Remove blank line to fix checkpatch check: Increase readability and consistency Signed-off-by: "Moritz C. Weber" <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05greybus: Avoid fake flexible array for response dataKees Cook3-14/+10
FORTIFY_SOURCE has been ignoring 0-sized destinations while the kernel code base has been converted to flexible arrays. In order to enforce the 0-sized destinations (e.g. with __counted_by), the remaining 0-sized destinations need to be handled. Instead of converting an empty struct into using a flexible array, just directly use a pointer without any additional indirection. Remove struct gb_bootrom_get_firmware_response and struct gb_fw_download_fetch_firmware_response. Signed-off-by: Kees Cook <[email protected]> Reviewed-by: Alex Elder <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: greybus: fix get_channel_from_mode() failure pathDan Carpenter1-4/+4
The get_channel_from_mode() function is supposed to return the channel which matches the mode. But it has a bug where if it doesn't find a matching channel then it returns the last channel. It should return NULL instead. Also remove an unnecessary NULL check on "channel". Fixes: 2870b52bae4c ("greybus: lights: add lights implementation") Signed-off-by: Dan Carpenter <[email protected]> Reviewed-by: Rui Miguel Silva <[email protected]> Reviewed-by: Alex Elder <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05staging: greybus: Remove redundant variable 'mask'Colin Ian King1-3/+0
The variable mask is being assigned and bit-set but it is never being used apart from this. The variable is redundant and can be removed. Cleans up clang scan build warning: drivers/staging/greybus/audio_topology.c:764:15: warning: variable 'mask' set but not used [-Wunused-but-set-variable] Signed-off-by: Colin Ian King <[email protected]> Acked-by: Vaibhav Agarwal <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-03-05greybus: audio: apbridgea: Remove flexible array from struct audio_apbridgea_hdrErick Archer1-1/+0
When a struct containing a flexible array is included in another struct, and there is a member after the struct-with-flex-array, there is a possibility of memory overlap. These cases must be audited [1]. See: struct inner { ... int flex[]; }; struct outer { ... struct inner header; int overlap; ... }; This is the scenario for the "struct audio_apbridgea_hdr" structure that is included in the following "struct audio_apbridgea_*_request" structures: struct audio_apbridgea_set_config_request struct audio_apbridgea_register_cport_request struct audio_apbridgea_unregister_cport_request struct audio_apbridgea_set_tx_data_size_request struct audio_apbridgea_prepare_tx_request struct audio_apbridgea_start_tx_request struct audio_apbridgea_stop_tx_request struct audio_apbridgea_shutdown_tx_request struct audio_apbridgea_set_rx_data_size_request struct audio_apbridgea_prepare_rx_request struct audio_apbridgea_start_rx_request struct audio_apbridgea_stop_rx_request struct audio_apbridgea_shutdown_rx_request The pattern is like the one shown below: struct audio_apbridgea_hdr { ... __u8 data[]; } __packed; struct audio_apbridgea_*_request { struct audio_apbridgea_hdr hdr; ... } __packed; In this case, the trailing flexible array can be removed because it is never used. Link: https://github.com/KSPP/linux/issues/202 [1] Signed-off-by: Erick Archer <[email protected]> Reviewed-by: Alex Elder <[email protected]> Acked-by: Mark Greer <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-02-19staging/nvec: update TODOMarc Dietrich1-4/+3
replace old/implemented items with new todo list Signed-off-by: Marc Dietrich <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-02-19staging/nvec: update comment regarding udelay in the isrMarc Dietrich1-3/+4
Update the comment before the udelay on how to replace it. Signed-off-by: Marc Dietrich <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-02-17staging: gdm724x: constantify the struct device_type usageRicardo B. Marliere1-1/+1
Since commit aed65af1cc2f ("drivers: make device_type const"), the driver core can properly handle constant struct device_type. Move the wwan_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Signed-off-by: Ricardo B. Marliere <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2024-02-17staging: vme: make vme_bus_type constRicardo B. Marliere2-2/+2
Now that the driver core can properly handle constant struct bus_type, move the vme_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Suggested-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Ricardo B. Marliere <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.