aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-12-21[SCSI] bfa: IOC fwtrace save logic & state machine fixes.Krishna Gudipati1-67/+74
- Move fw trace save logic to bfa_ioc_sm_fail_entry(), so that fw trace is saved irrespective of the cause of the failure. - Make bfa_ioc_sm_fail() a failure parking state. - Rename bfa_ioc_sm_initfail() to a more appropriate bfa_ioc_sm_fail_retry() as it is no longer a parking state. Signed-off-by: Krishna Gudipati <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] bfa: remove unused functions and misc cleanupsMaggie Zhang8-457/+110
Remove unused functions and fix checkpatch errors. Misc cleanups in comment and formatting. Signed-off-by: Maggie Zhang <[email protected]> Signed-off-by: Jing Huang <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] bfa: remove all OS wrappersMaggie Zhang28-304/+210
Remove OS wrapper functions/macros, and as a result remove bfa_os_inc.h. Signed-off-by: Maggie Zhang <[email protected]> Signed-off-by: Jing Huang <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] bfa: remove all SCSI IO callbacksMaggie Zhang8-204/+49
Remove SCSI IO callbacks, and as a result remove bfa_cb_ioim.h. Signed-off-by: Maggie Zhang <[email protected]> Signed-off-by: Jing Huang <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] bfa: scatter gather processing changeMaggie Zhang1-81/+59
Modified scatter gather processing to use the kernel provided scsi_for_each_sg() macro. 1) Instead of allocating and setting up sgpg in bfa_ioim_sge_setup(), we only do allocation. As a result, we remove bfa_ioim_sgpg_setup() and rename bfa_ioim_sge_setup() to bfa_ioim_sgpg_alloc(). 2) bfa_ioim_send_ioreq() call scsi_for_each_sg() to handle both inline and sgpg setup. Signed-off-by: Maggie Zhang <[email protected]> Signed-off-by: Jing Huang <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] bfa: remove a file with small sizeMaggie Zhang5-112/+88
Removed bfa_drv.c, merged it to bfa_core.c and modified Makefile. Signed-off-by: Maggie Zhang <[email protected]> Signed-off-by: Jing Huang <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] bfa: clean up one line functionsMaggie Zhang19-930/+259
Cleaned up one line functions. Signed-off-by: Maggie Zhang <[email protected]> Signed-off-by: Jing Huang <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] bfa: remove unused and empty functionsMaggie Zhang15-710/+4
Removed unused and empty functions. Signed-off-by: Maggie Zhang <[email protected]> Signed-off-by: Jing Huang <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] ibmvfc: Improve ibmvfc_async_desc memory layoutRobert Jennings2-15/+15
By changing field ordering we can avoid a couple of memory holes in the tables that use the ibmvfc_async_desc structure. Signed-off-by: Robert Jennings <[email protected]> Acked-by: Brian King <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] iscsi: add module aliasStephen Hemminger1-0/+1
Since iscsi transport can be built as a module and uses netlink socket to communicate. The module should have an alias to autoload when socket of NETLINK_ISCSI type is requested. Signed-off-by: Stephen Hemminger <[email protected]> Acked-by: Mike Christie <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] zfcp: Add allow_lun_scan module parameterChristof Schmitt1-1/+6
The zfcpdump tool requires a method to attach exactly one LUN. The easiest way to achieve this is to add a new zfcp module parameter. When allow_lun_scan is set to "false", zfcp only accepts LUNs that have been configured through the unit_add sysfs interface. Reviewed-by: Swen Schillig <[email protected]> Signed-off-by: Christof Schmitt <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] zfcp: Add __init declaration to zfcp_cache_hw_alignChristof Schmitt1-2/+2
The function zfcp_cache_hw_align is only called from zfcp_module_init, so it should be declared with __init as well. Reviewed-by: Steffen Maier <[email protected]> Signed-off-by: Christof Schmitt <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] zfcp: Move qdio setup from erp to zfcp_qdio.cChristof Schmitt2-12/+3
Initialization of the qdio waitqueue should happen when the qdio data is initialized and the QDIOUP flag should be handled in the qdio code as well. Adjust the code accordingly and remove the superfluos function zfcp_erp_adapter_strategy_open_qdio. Reviewed-by: Steffen Maier <[email protected]> Signed-off-by: Christof Schmitt <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] zfcp: Redesign of the debug tracing final cleanup.Swen Schillig12-181/+180
This patch is the final cleanup of the redesign from the zfcp tracing. Structures and elements which were used by multiple areas of the former debug tracing are now changed to the new scheme. Signed-off-by: Swen Schillig <[email protected]> Signed-off-by: Christof Schmitt <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] zfcp: Redesign of the debug tracing for SCSI records.Swen Schillig5-265/+132
This patch is the continuation to redesign the zfcp tracing to a more straight-forward and easy to extend scheme. This patch deals with all trace records of the zfcp SCSI area. Signed-off-by: Swen Schillig <[email protected]> Signed-off-by: Christof Schmitt <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] zfcp: Redesign of the debug tracing for HBA records.Swen Schillig5-431/+229
This patch is the continuation to redesign the zfcp tracing to a more straight-forward and easy to extend scheme. This patch deals with all trace records of the zfcp HBA area. Signed-off-by: Swen Schillig <[email protected]> Signed-off-by: Christof Schmitt <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] zfcp: Redesign of the debug tracing for SAN records.Swen Schillig5-202/+85
This patch is the continuation to redesign the zfcp tracing to a more straight-forward and easy to extend scheme. This patch deals with all trace records of the zfcp SAN area. Signed-off-by: Swen Schillig <[email protected]> Signed-off-by: Christof Schmitt <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] zfcp: Redesign of the debug tracing for recovery actions.Swen Schillig4-285/+139
The tracing environment of the zfcp LLD has become very bulky and hard to maintain. Small changes involve a large modification process which is error-prone and not effective. This patch is the first of a set to redesign the zfcp tracing to a more straight-forward and easy to extend scheme. It removes all interpretation and visualization parts and focuses on bare logging of the information. This patch deals with all trace records of the zfcp error recovery. Signed-off-by: Swen schillig <[email protected]> Signed-off-by: Christof Schmitt <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: Update driver version to 5.02.00-k5Vikas Chaudhary1-1/+1
Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: Updated the Copyright headerVikas Chaudhary16-18/+18
Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: do not reset hba if ql4xdontresethba is setVikas Chaudhary1-7/+9
Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: do not check for fw hung if reset retry is in progressLalit Chandivade1-1/+3
Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Lalit Chandivade <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: cache new IP address acquired via DHCPPrasanna Mumbai1-1/+2
Prior to firmware state change from ACQUIRING to READY, an 0x8029 AEN is received. Added code to check previous state being ACQUIRING in order to update the ip address in the driver. Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Prasanna Mumbai <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: Fail initialization if qla4_8xxx_pci_mem_write_2M failsLalit Chandivade1-6/+11
Since if fw load is failing, running on incomplete fw load would be fatal. Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Lalit Chandivade <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: put device in FAILED state for 82XX initialization failureLalit Chandivade1-0/+8
Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Lalit Chandivade <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: do not process interrupt unconditionallyLalit Chandivade1-17/+1
in mailbox command do not process interrupt unconditionally, process interrupt only in polling mode Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Lalit Chandivade <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: use correct fw_ddb_index in abort taskKaren Higgins2-3/+2
Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Karen Higgins <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: memory wedge with peg_halt test in loopSwapnil Nagle1-0/+43
Signed-off-by: Swapnil Nagle <[email protected]> Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: initialize MSI in correct wayShyam Sundar1-1/+1
IRQF_SHARED flag should not be set when calling request_irq for MSI since this interrupt mechanism cannot be shared like standard INTx Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Shyam Sundar <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] qla4xxx: Drop use of IRQF_DISABLEVikas Chaudhary1-2/+2
IRQF_DISABLE flag is deprecated and this flag is a NOOP in kernel. Signed-off-by: Vikas Chaudhary <[email protected]> Signed-off-by: Ravi Anand <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: fix statistics for FCP input/output megabytesJoe Eykholt3-8/+12
The statistics for InputMegabytes and OutputMegabytes are misnamed. They're accumulating bytes, not megabytes. The statistic returned via /sys must be in megabytes, however, which is what the HBA-API wants. The FCP code needs to accumulate it in bytes and then divide by 1,000,000 (not 2^20) before it presented via sysfs. This affects fcoe.ko only, not fnic. The fnic driver correctly by accumulating bytes and then converts to megabytes. I checked that libhbalinux is using the /sys file directly without conversion. BTW, qla2xxx does divide by 2^20, which I'm not fixing here. Signed-off-by: Joe Eykholt <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfcoe: change fip_select to return new FCFJoe Eykholt1-10/+8
Neaten several calls to fip_select() by having it return the pointer to the new FCF. Signed-off-by: Joe Eykholt <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfcoe: reorder FCF list to put latest advertiser firstJoe Eykholt1-0/+11
When there are several FCFs to choose from, the one most likely to accept a FLOGI on certian switches is the one that last answered a multicast solicit. So, when receiving an advertisement, move the FCF to the front of the list so that it gets chosen first among those with the same priority. Without this, more FLOGIs need to be sent in a test with multiple FCFs and a switch in NPV mode, but it still eventually finds one that accepts the FLOGI. Signed-off-by: Joe Eykholt <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfcoe: add debug message for FCF destination MACJoe Eykholt1-9/+10
When multiple FCFs to the same fabric exist, the debug messages all look alike. Change the message to include the MAC address. Signed-off-by: Joe Eykholt <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfcoe: retry rejected FLOGI to another FCF if possibleJoe Eykholt2-30/+185
Switches using multiple-FCFs may reject FLOGI in order to balance the load between multiple FCFs. Even though the FCF was available, it may have more load at the point we actually send the FLOGI. If the FLOGI fails, select a different FCF if possible, among those with the same priority. If no other FCF is available, just deliver the reject to libfc for retry. Signed-off-by: Joe Eykholt <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfcoe: fix checking of conflicting fabrics in fcoe_ctlr_select()Joe Eykholt1-7/+10
The check for conflicting fabrics in fcoe_ctlr_select() ignores any FCFs that aren't usable. This is a minor problem now but becomes more pronounced after later patches. Signed-off-by: Joe Eykholt <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfcoe: move some timer code to make it reusable.Joe Eykholt1-3/+7
Move some of the code in fcoe_ctlr_timer_work() to fcoe_ctlr_select() so that it can be shared with another function in a forthcoming patch. Signed-off-by: Joe Eykholt <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfcoe: update FIP FCF announcementsJoe Eykholt1-11/+29
Move the announcement code to a separate function for reuse in a forthcoming patch. For messages regarding FCF timeout and selection, use the previously-announced FCF MAC address (dest_addr) in the fcoe_ctlr struct. Only print (announce) the FCF if it is new. Print MAC for timed-out or deselected FCFs. Signed-off-by: Joe Eykholt <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: fix fc_tm_done not freeing the allocated fsp pktYi Zou1-7/+7
Frame should be freed in fc_tm_done, this is an updated patch on the one initially submitted by Hillf Danton. Signed-off-by: Hillf Danton <[email protected]> Signed-off-by: Yi Zou <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: the timeout for the REC itself is 2 * R_A_TOV_elsYi Zou1-5/+2
The timeout for the exchange carrying REC itself is 2 * R_A_TOV_els. Signed-off-by: Yi Zou <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: fix exchange being deleted when the abort itself is timed outYi Zou1-2/+5
Should not continue when the abort itself is being timeout since in that case the exchange will be deleted and relesased. We still want to call the associated response handler to let the layer, e.g., fcp, know the exchange itself is being timed out. Signed-off-by: Yi Zou <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: do not fc_io_compl on fsp w/o any scsi_cmnd associatedYi Zou1-1/+7
Do not call fc_io_compl() on fsp w/o any scsi_cmnd, e.g., lun reset is built inside fc_fcp, not from a scsi command from queuecommnd from scsi-ml, so in in case target is buggy that is invalid flags in the FCP_RSP, as we have seen in some SAN Blaze target where all bits in flags are 0, we do not want to call io_compl on this fsp. [ Comment block added by Robert Love ] Signed-off-by: Yi Zou <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: add print of exchange id for debugging fc_fcpYi Zou1-2/+14
This is very helpful to match up the corresponding exchange to the actual I/O described by the fsp, particularly when you do a side-by-side comparison of the syslog with your trace. Signed-off-by: Yi Zou <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] drivers/scsi/fcoe: Update WARN usesJoe Perches1-1/+1
Add missing newlines. Signed-off-by: Joe Perches <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: fix memory leakage in remote portHillf Danton1-1/+2
There seems rdata should get put before return. Signed-off-by: Hillf Danton <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: fix memory leakage in local portHillf Danton1-1/+3
There seems info should get freed when error encountered. Signed-off-by: Hillf Danton <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: fix memory leakage in local portHillf Danton1-1/+3
There seems info should get freed when error encountered. Signed-off-by: Hillf Danton <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: remove tgt_flags from fc_fcp_pkt structjohn fastabend2-5/+2
We can easily remove the tgt_flags from fc_fcp_pkt struct and use rpriv->tgt_flags directly where needed. Signed-off-by: John Fastabend <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: use rport timeout values for fcp recoveryjohn fastabend1-16/+42
Use the rport value for rec_tov for timeout values when sending fcp commands. Currently, defaults are being used which may or may not match the advertised values. The default may cause i/o to timeout on networks that set this value larger then the default value. To make the timeout more configurable in the non-REC mode we remove the FC_SCSI_ER_TIMEOUT completely allowing the scsi-ml to do the timeout. This removes an unneeded timer and allows the i/o timeout to be configured using the scsi-ml knobs. Signed-off-by: John Fastabend <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>
2010-12-21[SCSI] libfc: incorrect scsi host byte codes returned to scsi-mljohn fastabend1-20/+41
The fcp packet recovery handler fc_fcp_recover() is called when errors occurr in a fcp session. Currently it is generically setting the status code to FC_CMD_RECOVERY for all error types. This results in DID_BUS_BUSY errors being returned to the scsi-ml. DID_BUS_BUSY errors indicate "BUS stayed busy through time out period" according to scsi.h. Many of the error reported by fc_rcp_recovery() are pkt errors. Here we update fc_fcp_recovery to use better host byte codes. With certain FAST FAIL flags set DID_BUS_BUSY and DID_ERROR will have different behaviors this was causing dm multipath to fail quickly in some cases where a retry would be a better action. Signed-off-by: John Fastabend <[email protected]> Signed-off-by: Robert Love <[email protected]> Signed-off-by: James Bottomley <[email protected]>