Age | Commit message (Collapse) | Author | Files | Lines |
|
Modify return statement to use the value being returned directly instead of
assigning it first to 'ret' and returning this variable. Coccinelle semantic
patch used:
@@
expression e;
local idexpression ret;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Eva Rachel Retuya <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Eliminate unneeded parentheses around the right hand side of an assignment.
Coccinelle semantic patch used:
@@
expression e1, e2;
identifier v;
@@
(
v = (e1 == e2)
|
v = (e1 != e2)
|
v = (e1 <= e2)
|
v = (e1 >= e2)
|
v =
- (
e1
- )
)
Signed-off-by: Eva Rachel Retuya <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Replace direct comparisons to NULL i.e. 'x == NULL' with '!x' for consistency.
Coccinelle semantic patch used:
@@
identifier func;
expression x;
statement Z;
@@
x = func(...);
if (
(
+ !
x
- == NULL
|
+ !
- NULL ==
x
)
) Z
Signed-off-by: Eva Rachel Retuya <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch replaces the enum value MOST_CH_ISOC_AVP with the more
appropriate MOST_CH_ISOC.
Signed-off-by: Andrey Shvetsov <[email protected]>
Signed-off-by: Christian Gromm <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch adds the strings 'rx', 'tx' and 'isoc' to the list of accepted
identifiers when setting up a channel configuration. To keep consistency it
removes the prefix "dir_" from strings returned by the attributes
set_direction and available_directions and it removes the suffix "_avp"
from the string "isoc_avp" returned by the attributes set_datatype and
available_datatypes.
Signed-off-by: Christian Gromm <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes trailing zeros from the strings returned by the
attributes available_datatypes and available_directions.
Signed-off-by: Andrey Shvetsov <[email protected]>
Signed-off-by: Christian Gromm <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Function most_submit_mbo() causes an exception only if either the pointer
mbo or mbo->context equals NULL. From the underlying architecture's point
of view both cases must _not_ come true and would happen only, if something
has tampered with the pointers. This would render runtime code unable to
recover anyway. So, instead trying to hide that things are already
critically out of control we're better off with a WARN_ON() assertion.
This patch replaces the return type of the function most_submit_mbo() with
'void' and adds a WARN_ONCE() assertion. Additionally, code calling the
function is adapted accordingly.
Signed-off-by: Christian Gromm <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes a checkpatch warning in
a block comment by adapting it to the community
preferred coding style.
Signed-off-by: Juliana Rodrigues <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes a checkpatch warning by moving
arguments to the right and aligning them to their open
parenthesis.
Signed-off-by: Juliana Rodrigues <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes a checkpatch warning by moving
arguments to the right and aligning them to the open
parenthesis above.
Signed-off-by: Juliana Rodrigues <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Moved trailing */ to a new line and added * to subsequent lines on a
block comment.
Signed-off-by: Juliana Rodrigues <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Add Vaibhav Hiremath as a Maintainer of Greybus platform
drivers.
Signed-off-by: Vaibhav Hiremath <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
CONFIG_MEDIA is not a thing, but CONFIG_MEDIA_SUPPORT is, so use that.
Reported-by: Valentin Rothberg <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The inline ULTRA_CHANNELCLI_STRING is not being used so remove it.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The function spar_channel_client_release_os is not being
used so remove it.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The function spar_channel_client_acquire_os is not being used so
remove it.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The function pathname_last_n_nodes is not used, get rid of it.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove not needed prototypes in visorhba.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove poll_for_irq prototype not needed.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove visornic_poll prototype, because it is not needed.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove visornic debugfs prototypes, they are not needed.
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Remove unneeded prototypes from visornic_main.c
Signed-off-by: David Kershner <[email protected]>
Reviewed-by: Tim Sell <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Add Vaibhav as maintainer of some Greybus Audio protocol drivers.
Signed-off-by: Vaibhav Agarwal <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Being over zealous in removing unused EXPORT_SYMBOLs the function
lustre_swab_lov_mds_md exports were removed. They need to be
exported so this patch restores those EXPORT_SYMBOLS. Same
mistake was done when porting to the upstream client.
Signed-off-by: James Simmons <[email protected]>
Reviewed-on: http://review.whamcloud.com/14545
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6486
Reviewed-by: Dmitry Eremin <[email protected]>
Reviewed-by: John L. Hammond <[email protected]>
Reviewed-by: Oleg Drokin <[email protected]>
Signed-off-by: James Simmons <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Add Viresh Kumar as Maintainer of some of the Greybus protocol drivers.
Signed-off-by: Viresh Kumar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Removes unnecessary space after a cast. Issue found by checkpatch.
Signed-off-by: Rehas Sachdeva <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Replaces left shift operation (1 << x) by BIT(x). Issue found by checkpatch.
Signed-off-by: Rehas Sachdeva <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Replaces position of constant from left to right side of a comparison.
Additionally, modifies logical continuations to be on the previous line and
fixes alignment to match open parenthesis. Issues found by checkpatch.
Signed-off-by: Rehas Sachdeva <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fixes indentation by removing unnecessary TAB. Issue found by checkpatch.
Signed-off-by: Rehas Sachdeva <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Adds spaces on either side of arithmetic and relational operators like
'-', '<' and '*'. Issue found by checkpatch.
Signed-off-by: Rehas Sachdeva <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Removes unnecessary parentheses from an expression of the form &(x).
Issue found by checkpatch.
Signed-off-by: Rehas Sachdeva <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
computation
This patch uses vma_pages function on vma object instead of explicit
computation.
Signed-off-by: sayli karnik <[email protected]>
Reviewed-by: Ian Abbott <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
No space is necessary after a cast. This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
No space is necessary after a cast. This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Adds spaces on either side of a '|'. Issue found by checkpatch.
Signed-off-by: Rehas Sachdeva <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Instead of storing the return value into a variable and then returning it, we
can club the two into a single return statement. This change was made using
the following semantic patch by Coccinelle:
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Rehas Sachdeva <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Replace pr_warn() call with its respective dev_warn() counterpart.
Semantic patch used to detect and apply the transformation:
@a@
identifier dev;
expression E;
@@
struct device *dev = E;
<+... when != dev == NULL
- pr_warn(
+ dev_warn(dev,
...);
...+>
Signed-off-by: Eva Rachel Retuya <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use dev_info() instead of printk(). Majority of the conversion was done
previously on this commit:
011b2aa [media] staging/media: Use dev_ printks in cxd2099/cxd2099.[ch]
Signed-off-by: Eva Rachel Retuya <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Instead of storing the return value into a variable and then returning it, we
can club the two into a single return statement. This change was made using
the following semantic patch by Coccinelle:
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Rehas Sachdeva <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Instead of storing the return value into a variable and then returning it, we
can club the two into a single return statement. This change was made using
the following semantic patch by Coccinelle:
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Rehas Sachdeva <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Add space around operator. This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use x instead of x != NULL. This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Use x instead of x != NULL. This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fixed several minor brace coding style issues.
Signed-off-by: Cathal Mullaney <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch was found by checkpatch.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
kzalloc()
This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes an unnecessary variable used to store return values in order
to reduce memory usage.
Done using coccinelle:
@@
type T;
constant C;
identifier ret;
@@
- T ret = C;
... when != ret
return
- ret
+ C
;
Signed-off-by: sayli karnik <[email protected]>
Acked-by: Julia Lawall <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Fixes typo,
FAILUER -> FAILURE
Recieve -> Receive
Signed-off-by: Hariharan R <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|