aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-09-27media: atomisp: sh_css_mipi: Removed unused code ↵Kate Hsuan2-45/+0
ia_css_mipi_frame_enable_check_on_size() ia_css_mipi_frame_enable_check_on_size() wasn't used by any functions. So, it can be removed. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: atomisp_compat_css20: Removed #ifdef ISP2401 to make driver ↵Kate Hsuan1-8/+6
generic Removed #ifdef ISP2401 to make code to be generic. The driver flow is determined in runtime. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: hive_isp_css_include: Removed #ifdef ISP2401 to make driver ↵Kate Hsuan2-4/+0
generic Removed #ifdef ISP2401 to make the driver generic. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: binary: Removed #ifdef ISP2401 to make driver genericKate Hsuan1-7/+8
Removed #ifdef ISP2401 to make the driver generic. The driver flow is determined in runtime. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: ia_css_raw.host: Remove #ifdef ISP2401 to make the driver ↵Kate Hsuan1-14/+7
generic Remove #ifdef from the code and made the code generic. The raw image configuration was determined during runtime. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Mark ia_css_isys_240?_init() staticHans de Goede1-2/+2
ia_css_isys_240?_init() are only used inside the C file where they are declared, mark them as static fixing: drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c:24:20: warning: no previous prototype for 'ia_css_isys_2400_init' 24 | input_system_err_t ia_css_isys_2400_init(void) | ^~~~~~~~~~~~~~~~~~~~~ drivers/staging/media/atomisp/pci/runtime/isys/src/isys_init.c:87:20: warning: no previous prototype for 'ia_css_isys_2401_init' 87 | input_system_err_t ia_css_isys_2401_init(void) | ^~~~~~~~~~~~~~~~~~~~~ Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Link: https://lore.kernel.org/r/[email protected] Reported-by: kernel test robot <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Kate Hsuan <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Remove aliases for MIPI_FORMAT_2400_CUSTOM0Hans de Goede2-3/+1
isp2400_input_system_local.h defines 2 aliases for MIPI_FORMAT_2400_CUSTOM0 MIPI_FORMAT_JPEG, which is entirely unused and MIPI_FORMAT_BINARY_8 which is used once in ia_css_isys_2400_set_fmt_type(). Drop these aliases and directly use MIPI_FORMAT_2400_CUSTOM0 in ia_css_isys_2400_set_fmt_type(). Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Kate Hsuan <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Remove empty isys_public.hHans de Goede2-20/+0
isys_public.h is empty, remove it. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Kate Hsuan <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: isys_init: Initiate atomisp in a generic mannerKate Hsuan1-16/+15
The original implementation distinguishes and initiates atomisp during compiler time. This commit allows isys_init to initiate isys for both types of atomisp in a generic manner. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: rx: Removed #if defined(ISP2401) to make driver genericKate Hsuan1-15/+4
The conflicts of variable declarations were resolved through previous commits so the #if defined(ISP2401) can be removed. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Compile the object codes for a generic driverKate Hsuan7-28/+3
Since a generic driver should support every type of atomisp, all the codes need to be compiled. The ISP2401 flag controls the Makefile to build the binary file for ISP2400 and ISP2401. Therefore, this section of Makefile should be removed allowing all the necessary codes can be built. Moreover, some parts of "removing #ifdef ISP2401" works are related to it so they were also removed here. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: ifmtr: Removed #if defined(ISP2401) to make driver genericKate Hsuan4-8/+0
Removed #if defined(ISP2401) to make driver generic. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: pipeline: Removed #if defined(ISP2401) to make driver genericKate Hsuan2-4/+0
Removed #if defined(ISP2401) to make driver generic. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: hive_isp_css_common: Removed #if defined(ISP2401) to make ↵Kate Hsuan1-2/+0
driver generic Removed #if defined(ISP2401) to make code generic. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: isys: Removed #if defined(ISP2401) to make driver genericKate Hsuan3-6/+0
Removed #if defined(ISP2401) to make code generic. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: css_2401_system: Remove #ifdef ISP2401 to make the driver ↵Kate Hsuan3-7/+0
generic Removed #if defined(2401) to make the driver generic. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Included both input system headersKate Hsuan8-26/+15
Included necessary input system header files (local, private, public scopes) for both types of atomisp. There is also a conflict of declaration issue so the unused input_system_state_s is removed. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Make two individual enum to define the MIPI formatKate Hsuan6-165/+224
The original mipi_format_t represents the MIPI format settings for both atomisp with the same name and the enum member was controlled by #if defined(ISP2401). However, if we want to make this driver generic, this enum should be individually defined for them. Since the format type is redefined, the format setting function ia_css_isys_set_fmt_type() should be reworked for ISP2400 and ISP2401 called ia_css_isys_2400_set_fmt_type() and ia_css_isys_2401_set_fmt_type() . Additionally, the function called is_mipi_format_yuv420() isn't used by any functions so it can be removed. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: ia_css_debug: Removed debug codes for dumping statusKate Hsuan9-481/+1
This portion of debug code was based on a structure for both ISP2400 and 2401 with the same name and controlled by #if defined(ISP2401). This structure was only used to dump the status of atomisp. So, to make the driver generic, this part of debug codes can be removed. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Remove v4l2_ctrl_s_ctrl(asd->run_mode) calls from atomisp_open()Hans de Goede1-3/+0
The v4l2_ctrl_s_ctrl(asd->run_mode) call in atomisp_subdev_init_struct() gets immediately overridden by a second call directly after atomisp_subdev_init_struct() is called. And the second call in atomisp_open() also is not helpful. ATOMISP_RUN_MODE_PREVIEW is the default and if changed controls are supposed to stay changed over an open/close of the /dev/video# node. So drop both calls. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Remove support for custom run-mode v4l2-ctrl on sensorsHans de Goede6-107/+0
Remove the support to update a V4L2_CID_RUN_MODE run-mode control on sensors when changing the atomisp run-mode or directly by calling the custom ATOMISP_IOC_S_SENSOR_RUNMODE IOCTL. No sensor drivers implement this and having custom controls / IOCTLs is undesirable. Even if there was such a control on sensors then userspace should directly talk to the sensor v4l2-subdev, rather than relying on a custom IOCTLs on the output /dev/video# node to pass this through to the senor. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Add some higher resolutions to atomisp_enum_framesizes()Hans de Goede1-0/+3
Add some higher resolutions to the fixed list of resolutions which atomisp_enum_framesizes() uses on sensors which can do cropping and can thus make any resolution that will fit. This is useful for higher resolution sensors like the 2560x1920 ov5693 sensor. Note the highest resolutions added here are 1920x<height> because the atomisp firmware does not support widths > 1920 with the default asd->run_mode->val == ATOMISP_RUN_MODE_PREVIEW setting. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Change atomisp_enum_framesizes() too small cut off from ↵Hans de Goede1-3/+3
2/3th to 5/8th Change atomisp_enum_framesizes() cut off for too small resolutions from 2/3th to 5/8th this results in more resolutions being available with some sensors. E.g. this allows using 800x600 with a 1280x960 sensor. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Clamp width to max 1920 pixels when in ATOMISP_RUN_MODE_PREVIEWHans de Goede1-0/+4
The pipeline firmware-binaries used in previed mode have ia_css_binary_xinfo.output.max_width set to 1920. This causes ia_css_binary_find() to fail when trying to set a higher resolution resulting in the dump_stack() call in ia_css_binary_find() triggering and resulting in the try_fmt() or set_fmt() IOCTL failing. Fix this by clamping the width to max 1920 when in preview mode. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Fix missing v4l2_fh_release() in atomisp_open() error exitHans de Goede1-2/+2
Fix missing v4l2_fh_release() in atomisp_open()'s "if (pipe->users)" error exit path. Closes: https://lore.kernel.org/r/[email protected]/ Link: https://lore.kernel.org/r/[email protected] Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: sh_css_internal: sh_css_params: Unifying sh_css_sp_group ↵Kate Hsuan2-18/+41
data structure Since some parts of the data structure elements are determined in compile time, the configuration data structure should be compiled for both two ISP models. In order to set the configuration for both ISP models in runtime, The sh_css_sp_group is unified to one data structure for the configuration to ensure the data structure can be used for both ISP2400 and 2401 in runtime. Also, the unused codes for debug purpose are removed. Form the aspect of ISP setting, the length and the content of the configuration structure for ISP2400 and ISP2401 are different. So, we need to pick up the necessary part of sp_group configuration for both models and then copy those parts into a temporary buffer. This buffer is finally written to the ISP with the corresponding length. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: Removed unused HAS_WATCHDOG_SP_THREAD_DEBUG debugKate Hsuan5-133/+1
Since the debug codes around #ifdef HAS_WATCHDOG_SP_THREAD_DEBUG are no longer used, the debug implementation of this can be removed. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27media: atomisp: ia_css_debug: Removed unused codes for debugKate Hsuan2-79/+0
This portion of the codes was not referenced so it can be completely removed. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Kate Hsuan <[email protected]> Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
2023-09-27dt-bindings: media: Add compatible for Meson-S4 IR ControllerZelong Dong1-0/+1
Add new compatible for Amlogic's Meson-S4 IR Controller. Meson IR Controller supports hardware decoder in Meson-S4 and later SoC. Signed-off-by: Zelong Dong <[email protected]> Acked-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Sean Young <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: rc: meson-ir: support rc driver type RC_DRIVER_SCANCODEZelong Dong1-71/+451
Meson IR Controller supports hardware decoder in Meson-S4 and later SoC. So far, protocol NEC could be decoded by hardware decoder. Signed-off-by: Zelong Dong <[email protected]> Reviewed-by: Neil Armstrong <[email protected]> Signed-off-by: Sean Young <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: rc: remove ir-rx51 in favour of generic pwm-ir-txSean Young5-297/+1
The ir-rx51 is a pwm-based TX driver specific to the N900. This can be handled entirely by the generic pwm-ir-tx driver, and in fact the pwm-ir-tx driver has been compatible with ir-rx51 from the start. Note that the suspend code in the ir-rx51 driver is unnecessary, since during transmit, the process is not in interruptable sleep. The process is not put to sleep until the transmit completes. Acked-by: Uwe Kleine-König <[email protected]> Tested-by: Sicelo A. Mhlongo <[email protected]> Signed-off-by: Sean Young <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27dt-bindings: media: remove nokia,n900-ir as pwm-ir-tx is compatibleSean Young2-21/+4
The generic pwm-ir-tx driver works for the Nokia n900, so nokia,n900-ir can be removed. Acked-by: Conor Dooley <[email protected]> Acked-by: Lee Jones <[email protected]> Signed-off-by: Sean Young <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: nuvoton: Add driver for NPCM video capture and encoding engineMarvin Lin7-0/+2014
Add driver for Video Capture/Differentiation Engine (VCD) and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs. As described in the datasheet NPCM750D_DS_Rev_1.0, the VCD can capture frames from digital video input and compare two frames in memory, and then the ECE can compress the frame data into HEXTILE format. This driver implements V4L2 interfaces and provides user controls to support KVM feature, also tested with VNC Viewer ver.6.22.826 and openbmc/obmc-ikvm. Signed-off-by: Marvin Lin <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: uapi: Add controls for NPCM video driverMarvin Lin3-0/+108
Create controls for Nuvoton NPCM video driver to support setting capture mode of Video Capture/Differentiation (VCD) engine and getting the count of HEXTILE rectangles that is compressed by Encoding Compression Engine (ECE). Signed-off-by: Marvin Lin <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: v4l2-ctrls: Add user control base for Nuvoton NPCM controlsMarvin Lin1-0/+6
Add a control base for Nuvoton NPCM driver controls, and reserve 16 controls. Signed-off-by: Marvin Lin <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: v4l: Add HEXTILE compressed formatMarvin Lin3-0/+9
Add HEXTILE compressed format which is defined in Remote Framebuffer Protocol (RFC 6143, chapter 7.7.4 Hextile Encoding) and is used by Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs. Signed-off-by: Marvin Lin <[email protected]> Reviewed-by: Nicolas Dufresne <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27dt-bindings: soc: nuvoton: Add NPCM GFXIMarvin Lin1-0/+39
Add dt-bindings document for Graphics Core Information (GFXI) node. It is used by NPCM video driver to retrieve Graphics core information. Signed-off-by: Marvin Lin <[email protected]> Reviewed-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: dt-bindings: nuvoton: Add NPCM VCD and ECE engineMarvin Lin2-0/+115
Add dt-bindings document for Video Capture/Differentiation Engine (VCD) and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs. Signed-off-by: Marvin Lin <[email protected]> Reviewed-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: remove the old videobuf frameworkHans Verkuil14-3460/+0
The last driver that still used this old framework has been converted to the videobuf2 framework. So it is now time to delete the old videobuf code. Signed-off-by: Hans Verkuil <[email protected]> Reviewed-by: Hans de Goede <[email protected]>
2023-09-27media: atomisp: remove left-over videobuf includeHans Verkuil1-1/+0
This source still included the media/videobuf-vmalloc.h header, even though it is no longer used. Since the old videobuf framework is about to be removed, delete this include first. Signed-off-by: Hans Verkuil <[email protected]> Reviewed-by: Hans de Goede <[email protected]>
2023-09-27media: imx-jpeg: Remove unused declarationsYue Haibing1-11/+0
These are never implemented, remove them. Signed-off-by: Yue Haibing <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: use struct_size() helperYu Liao1-1/+1
Prefer struct_size() over open-coded versions of idiom: sizeof(struct-with-flex-array) + sizeof(typeof-flex-array-elements) * count where count is the max number of items the flexible array is supposed to contain. Signed-off-by: Yu Liao <[email protected]> Reviewed-by: Tomasz Figa <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: mediatek: vcodec: fix spelling mistake "resonable" -> "reasonable"Colin Ian King2-2/+2
There are a couple of spelling mistakes in pr_err error messages. Fix them. Signed-off-by: Colin Ian King <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: exynos4-is: fimc-is: replace duplicate pmu node with phandleKrzysztof Kozlowski1-9/+24
Devicetree for the FIMC IS camera included duplicated PMU node as its child like: soc@0 { system-controller@10020000 { ... }; // Real PMU camera@11800000 { fimc-is@12000000 { // FIMC IS camera node pmu@10020000 { reg = <0x10020000 0x3000>; // Fake PMU node }; }; }; }; This is not a correct representation of the hardware. Mapping the PMU (Power Management Unit) IO memory should be via syscon-like phandle (samsung,pmu-syscon, already used for other drivers), not by duplicating "pmu" Devicetree node inside the FIMC IS. Backward compatibility is preserved. Signed-off-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: dt-bindings: samsung,fimc: correct unit addresses in DTS exampleKrzysztof Kozlowski1-11/+11
The camera node's ranges property and unit addresses of its children were not correct. If camera is @11800000, then its fimc child is @0. Acked-by: Conor Dooley <[email protected]> Signed-off-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: dt-bindings: samsung,exynos4212-fimc-is: replace duplicate pmu node ↵Krzysztof Kozlowski2-9/+11
with phandle The FIMC IS camera must access the PMU (Power Management Unit) IO memory to control camera power. This was achieved by duplicating the PMU node as its child like: soc@0 { system-controller@10020000 { ... }; // Real PMU camera@11800000 { fimc-is@12000000 { // FIMC IS camera node pmu@10020000 { reg = <0x10020000 0x3000>; // Fake PMU node }; }; }; }; This is not a correct representation of the hardware. Mapping the PMU (Power Management Unit) IO memory should be via syscon-like phandle (samsung,pmu-syscon, already used for other drivers), not by duplicating "pmu" Devicetree node inside the FIMC IS. Reviewed-by: Rob Herring <[email protected]> Signed-off-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: staging: media: sunxi: cedrus: Remove redundant of_match_ptr()Ruan Jinjie1-1/+1
The driver depends on CONFIG_OF, it is not necessary to use of_match_ptr() here. Signed-off-by: Ruan Jinjie <[email protected]> Acked-by: Jernej Skrabec <[email protected]> Acked-by: Paul Kocialkowski <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: nxp: Use devm_kmemdup to replace devm_kmalloc + memcpyLi Zetao1-3/+1
Use the helper function devm_kmemdup() rather than duplicating its implementation, which helps to enhance code readability. Signed-off-by: Li Zetao <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: cx25840: simplify cx23885_dif_setup()Hans Verkuil1-2883/+811
Instead of creating a huge switch statement (that thoroughly confuses smatch), create a table of coefficients and use that. Signed-off-by: Hans Verkuil <[email protected]>
2023-09-27media: platform: Use dev_err_probe instead of dev_errWang Ming1-3/+2
It is possible that dma_request_chan will return EPROBE_DEFER, which means that dma->xdev->dev is not ready yet. In this case, dev_err(dma->xdev->dev), there will be no output. This patch fixes the bug. Signed-off-by: Wang Ming <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> Signed-off-by: Hans Verkuil <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.