aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2014-11-26staging: comedi: addi_apci_1564: fix counter code in main driver sourceH Hartley Sweeten1-20/+24
The Rev 1.0 APCI-1564 boards do not have counters. Fix the code in the main driver source so that the I/O accesses to the counters do not happen if the devpriv->counters member is not initialized. This does not fix the code in hwdrv_apci1564.c. That code violates the comedi API and is currently broken. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: comedi: addi_apci_1564: fix timer iobase for all PLD revisionsH Hartley Sweeten2-28/+42
The APCI-1564 has different I/O mapping depending on if the PLD revision is Rev 1.0 or Rev 2.x. Add a member, 'timer', to the private data for the base address of the 12-bit timer. Fix the register defines so they will work for all PLD revisions and initialize the devpriv->timer appropriately. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: comedi: addi_apci_1564: fix dev->iobase for all PLD revisionsH Hartley Sweeten2-30/+37
The APCI-1564 has different I/O mapping depending on if the PLD revision is Rev 1.0 or Rev 2.x. Fix the main register defines so they will work for all PLD revisions and initialie the dev->iobase appropriately. Move the register defines to the main driver source file. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: comedi: addi_apci_1564: detect PLD revision for I/O mappingH Hartley Sweeten1-3/+51
The APCI-1564 has different I/O mapping depending on if the PLD revision is Rev 1.0 or Rev 2.x. The revision can be determined by reading the EEPROM register at offset 0x00 of PCI BAR 0 and checking the value of bits 7 to 4. Add this check to apci1564_auto_attach(). Currently this driver is coded to work with the Rev 2.x I/O mapping. For now, fail the attach if a Rev 1.0 PLD is detected. Document the I/O mapping for both revisions. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: comedi: addi_apci_1564: use dev->iobase for main registersH Hartley Sweeten2-62/+53
According to ADDI-DATA, the PLD Revision 2.x versions of the APCI-1564 use PCI BAR 0 for the main registers of the board. Remove the 'amcc_iobase' member of the private data and use the dev->iobase to store the base address of PCI BAR 1. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: comedi: addi_apci_1564: store PCI BAR 1 base address in private dataH Hartley Sweeten2-41/+41
According to ADDI-DATA, only the PLD Revision 2.x versions of the APCI-1564 have the 3 counters. The base address for these counters is found in PCI BAR 1. For aesthetics, save this base address in the private data. The dev->iobase can then be used for the main registers of the board. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: comedi: addi_apci_1564: use correct I/O base for ↵H Hartley Sweeten1-2/+2
APCI1564_DI_INT_STATUS_REG The APCI1564_DI_INT_STATUS_REG is located in the PCI BAR 0 I/O space. That base address is stored in devpriv->amcc_iobase. Use that to correctly read the register. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: comedi: addi_apci_1564: board does not use an AMCC PCI controllerH Hartley Sweeten1-6/+0
According to ADDI-DATA, the APCI-1564 board has a FPGA with a PCI core, it does not use an AMCC PCI controller chip. Remove the amcc_s5933.h include as well as the read of the AMCC_OP_REG_INTCSR register. That offset would actually read APCI1564_WDOG_STATUS_REG register in the FPGA which has nothing to do with the interrupt status. Signed-off-by: H Hartley Sweeten <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26rtl8188eu: Fix a typo in rtw_led.*Krzysztof Konopko2-3/+5
A rather obvious typo in one of the identifier has been found. This patch fixes the typo and ensures any lines changed do not exceed 80 characters as indicated by scripts/checkpatch.pl Signed-off-by: Krzysztof Konopko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26rtl8188eu: Fix FSF_MAILING_ADDRESS in rtw_led.*Krzysztof Konopko2-8/+0
rtw_led.* files include Free Software Foundation's mailing address in the sample GPL notice. This is not desired and picked when running scripts/checkpatch.pl. Signed-off-by: Krzysztof Konopko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26rtl8188eu: Simplify rtw_endofpktfile() in xmit_linux.cKrzysztof Konopko1-7/+1
scripts/checkpatch.pl reports a coding style problem in xmit_linux.c WARNING:BRACES: braces {} are not necessary for single statement blocks #61852: FILE: rtl8188eu/os_dep/xmit_linux.c:70: This patch removes unnecessary braces and simplifies the function to a single return statement. Signed-off-by: Krzysztof Konopko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: rtl8192e: add missing tasklet_kill on remove pathDevendra Naga1-0/+1
The powersave tasklet is created in rtllib_softmac_init and it is not removed while unloading the module. Cc: Larry Finger <[email protected]> Signed-off-by: Devendra Naga <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: wlan-ng: prism2fw: fixed code style issueAede Symen Hoekstra1-1/+2
Fixed checkpatch.pl warning message: line over 80 characters Signed-off-by: Aede Symen Hoekstra <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26Drivers:staging:dgap: Added a blank line after declarationAnjana Sasindran1-0/+1
This patch fixes the checkpatch.pl warning: WARNING:Missing a blank line after declaration Signed-off-by: Anjana Sasindran <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: olpc_dcon: Deletion of a check before backlight_device_unregister()Markus Elfring1-2/+1
The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: ozwpan: Deletion of unnecessary checks before the function call ↵Markus Elfring1-4/+2
"oz_free_urb_link" The oz_free_urb_link() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: fwserial: remove multiple blank linesLe Tan1-3/+0
This patch fixes the multiple blank lines issue complained by checkpatch.pl by removing useless blank lines. Signed-off-by: Le Tan <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: panel: Use better names for two defined valuesMariusz Gorski1-8/+8
Give DEFAULT_KEYPAD and DEFAULT_LCD defines better names, so that their meaning is emphasized. Signed-off-by: Mariusz Gorski <[email protected]> Acked-By: Willy Tarreau <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: panel: Reorder module parameter declarationsMariusz Gorski1-35/+38
Change the order of the module parameter declarations so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <[email protected]> Acked-By: Willy Tarreau <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: panel: Reorder DEFAULT_* values redefinesMariusz Gorski1-13/+13
Change the order of the DEFAULT_* values redefines so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <[email protected]> Acked-By: Willy Tarreau <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: panel: Reorder initial DEFAULT_* definesMariusz Gorski1-4/+4
Change the order of the initial DEFAULT_* defines so that it matches the Kconfig order. Signed-off-by: Mariusz Gorski <[email protected]> Acked-By: Willy Tarreau <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: octeon-usb: eliminate cvmx_dprintf() usageAaro Koskinen1-3/+9
Eliminate cvmx_dprintf() usage and use dev_err() instead. Signed-off-by: Aaro Koskinen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: octeon-usb: move helper functionsAaro Koskinen1-10/+10
Move helper functions to make them visible to all functions. Signed-off-by: Aaro Koskinen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: octeon-ethernet: drop multiple NAPI instancesAaro Koskinen3-106/+10
Octeon Ethernet driver is currently trying to wake up multiple CPU cores for parallel NAPI processing when needed, to cope with the fact that all network interfaces are handled through the same receive queue processed by a single core/interrupt (see http://marc.info/?l=linux-kernel&m=137209784914565&w=2). This partially overlaps with generic RPS functionality. Commit a6a39a7fcff5 ("staging: octeon-ethernet: disable load balance for receiving packet when CONFIG_RPS is enabled") already disabled this when RPS is enabled. Let's delete this code altogether as it has issues like packet reordering and potential problems with CPU offlining/onlining. Tested on EdgeRouter Lite. Signed-off-by: Aaro Koskinen <[email protected]> Acked-By: David Daney <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: android: ion: Deletion of unnecessary checks before two function callsMarkus Elfring3-12/+6
The functions ion_heap_destroy() and vfree() perform also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: rf.c clean up function commentsMalcolm Priestley1-28/+31
Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: rf.c Removed unneeded commentsMalcolm Priestley1-134/+0
Type and function that are not present comments Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: rf.c: Remove author commentsMalcolm Priestley1-18/+3
Moving names to file header comment Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: rf.c camel calse vnt_private rename pDevice to privMalcolm Priestley1-36/+36
Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: IFRFbWriteEmbedded replace __iomem with vnt_privateMalcolm Priestley2-42/+45
Fixing callers to vnt_private Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: rf remove __iomem *dwIoBase from functionsMalcolm Priestley3-15/+24
replacing with vnt_private and removing dereferencing from callers Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: card.c move __iomem into functions.Malcolm Priestley4-15/+20
Removing dereferencing from callers Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: card Remove function vUpdateIFSMalcolm Priestley3-67/+0
vUpdateIFS does the same operations of CARDbSetPhyParameter there is not need to call this function. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: always keep abyCurrentNetAddr aligned to 2Malcolm Priestley1-1/+1
Because the driver now uses ether_addr_copy the alignment of this variable must be maintained at 2. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: change typedef enum _VIA_PKT_TYPE to macroMalcolm Priestley2-14/+11
Replacing for u8 type and removing cast for byBBType. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: replace typedef enum _VIA_BB_TYPE with macrosMalcolm Priestley1-7/+4
Replacing type with u8 Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: CARDbSetPhyParameter remove unused parametersMalcolm Priestley3-9/+4
wCapInfo byERPField, *pvSupportRateIEs *pvExtSupportRateIEs Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: dead code remove typedef enum _CARD_PHY_TYPEMalcolm Priestley2-8/+0
Removing unused eCurrentPHYType Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: s_vCalculateOFDMRParameter use bb_type for CARD_PHY_TYPEMalcolm Priestley1-10/+10
using u8 for bb_type and replacing PHY_TYPE_11A with BB_TYPE_11A Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: CARDvSetRSPINF us bb_type for CARD_PHY_TYPEMalcolm Priestley2-11/+11
Using u8 for bb_type Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: CARDbSetPhyParameter change CARD_PHY_TYPE to bb_typeMalcolm Priestley2-5/+5
using u8 for bb_type Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: dead code remove CARDbAddBasicRateMalcolm Priestley2-13/+0
we nonlonger set rates in the driver Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: vt6655: CARDvUpdateBasicTopRate use basic_rates to find top rateMalcolm Priestley1-2/+2
basic_rates should now be used to find it. Signed-off-by: Malcolm Priestley <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Remove space before braces for defined() checkAndreas Ruprecht2-2/+2
checkpatch complains about two places where a space is prohibited before the braces for in "#if defined()" check. This patch removes these warnings. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Remove unnecessary braces at ifsAndreas Ruprecht2-7/+4
checkpatch complains about three places where braces are not necessary. This patch removes the braces. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Remove unnecessary line continuationsAndreas Ruprecht1-2/+2
checkpatch finds two unnecessary line continuations in ldlm_lockd.c which are removed by this patch. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Fix warning about unneeded return statementAndreas Ruprecht1-1/+0
checkpatch complains about an unneeded return statement in the function search_granted_lock(), which is removed by this patch. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Fix initialization of static variablesAndreas Ruprecht2-2/+2
checkpatch complains about static variables being initialized to 0 which is unnecessary. This patch removes the initialization. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Fix indentation errors for switch-caseAndreas Ruprecht2-25/+25
checkpatch complains about two indentation errors where the case statements are on a higher indentation level than the corresponding switch statement. This patch removes these errors. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-26staging: lustre: ldlm: Fix warning about missing spacesAndreas Ruprecht3-7/+8
checkpatch.pl complains about a number of places where spaces were missing. This patch fixes all of these errors. For better readability, the warning of hitting the 80 character per line limit in line 1349 introduced by this change is ignored deliberately. Signed-off-by: Andreas Ruprecht <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.