aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-05-17staging: brcm80211: Better debug support added to brcmfmac driverSukesh Srikakula4-245/+331
With the current implementation there is no way to selectively enable required debug messages, as all the messages are currently under WL_DBG. With this fix, we are introducing several log levels which will enable us to print only the required debug messages. WL_ERR --> Prints error messages WL_CONN --> Prints all debug messages pertaining to connection management WL_SCAN --> Prints all debug messages pertaining to scanning WL_TRACE --> Prints all trace(Enter/Exit) sequence of cfg80211 calls WL_INFO --> Prints all informational messages. By default, only WL_ERR messages are enabled. Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: cfg80211 up/down routines in brcmfmac driver are fixedSukesh Srikakula1-19/+8
'__wl_cfg80211_up' & '__wl_cfg80211_down' routines are updated to correctly set the 'wl->status' variable. Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: Removed unused variable from brcmfmac driverSukesh Srikakula2-6/+0
Removed unused variable from wl_profile structure Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: Fixed scan notification functionality in brcmfmac driverSukesh Srikakula1-24/+32
Earlier brcmfmac driver used to report success even for an aborted scan. This functionality is now fixed with this patch. Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: Added support to change scan times from brcmfmac driverSukesh Srikakula2-35/+50
wl_dongle_scantime function moved out of conditional compilation to allow the fullmac driver to change FW scan times. Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: Added support to change roaming parameters from brcmfmac ↵Sukesh Srikakula2-35/+66
driver 'wl_dongle_roam' function moved out of conditional compilation to allow the fullmac driver to change FW roaming parameters Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: Fixed ibss join/leave functionality in brcmfmac driverSukesh Srikakula1-73/+206
IBSS functionality is broken in fullmac driver, which is fixed with this patch Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: Fixed bss (re)connect/disconnect issues in brcmfmac driverSukesh Srikakula2-193/+189
Broken functionality of bss (re)connect/disconnect in full mac driver is fixed with this patch. Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: Optimized wl_inform_single_bss function in brcmfmac driverSukesh Srikakula1-126/+50
Earlier verion of wl_inform_single_bss function is using 'cfg80211_inform_bss_frame' API for sending bss info to cfg80211. With this patch same will be done through a more optimal 'cfg80211_inform_bss' API. Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: Fixed wl_assoc_params structure miss match in brcmfmac ↵Sukesh Srikakula1-0/+1
driver There is a mismatch in the structure definition of wl_assoc_params structure in driver & FW code. With this patch, it is corrected Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: brcmfmac driver's interface name changed to "wlan"Sukesh Srikakula1-1/+1
Currently interface name for the brcmfmac driver is "eth". This is changed to "wlan". Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: Fix for suspend issue in brcmfmac driverSukesh Srikakula5-28/+97
Currently, there are 2 callbacks registered with OS for getting notifications when system goes to suspend/resume. Racing between these 2 callbacks results in random suspend failures. With this fix, we avoid registering dhd callback for suspend/resume notification when cfg80211 is used. Relevent functionality in dhd suspend/resume callback function is moved to cfg80211 suspend/resume functions. Cc: [email protected] Cc: [email protected] Cc: Grant Grundler <[email protected]> Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: Fix for WPA GTK install issue in brcmfmac driverSukesh Srikakula1-0/+4
Last 16 bytes of the key sent by cfg80211 needs to be swapped before installing it to FW for TKIP encryption. This is not done for group key in current code, which is corrected with this fix. Cc: [email protected] Cc: [email protected] Reviewed-by: Franky (Zhenhui) Lin <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Tested-by: Grant Grundler <[email protected]> Tested-by: Aaron Plattner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: removed more unused counter related structuresRoland Vossen1-103/+0
Code cleanup. Cc: [email protected] Cc: [email protected] Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: removed counter related struct wl_cntRoland Vossen6-373/+4
Code cleanup. Struct wl_cnt contains all sorts of counters, but either these were written and never read, or set to zero at initialization but never updated. Therefore the struct and any code accessing the struct has been removed. Cc: [email protected] Cc: [email protected] Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: removed support for proprietary ioctl WLC_GET_PKTCNTSRoland Vossen2-27/+0
Cc: [email protected] Cc: [email protected] Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: removed stats WEXT support from fullmacRoland Vossen2-131/+1
Wireless Extension support is obsolete and made use of counters that are going to be removed in the next patches. Cc: [email protected] Cc: [email protected] Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: removed counter related macros that expanded to NOPRoland Vossen3-70/+0
Code cleanup. Cc: [email protected] Cc: [email protected] Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: removed unused struct net_device_stats related codeRoland Vossen2-33/+0
Code cleanup. Variables were set but never read. Cc: [email protected] Cc: [email protected] Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: fix makefiles for building drivers in kernelArend van Spriel2-2/+2
The makefiles used obj-m which forcibly builds the drivers as modules ignoring the Kconfig setting. This has been fixed in this patch. Cc: [email protected] Cc: [email protected] Reviewed-by: Roland Vossen <[email protected]> Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: cleanup functions in nvram.cArend van Spriel4-393/+10
Several function in nvram.c take a pointer value which is not actually used. These are removed and the header file contained some other prototypes that were not implemented. As this source file was the only one using the header file siutils.h it has been removed. Cc: [email protected] Cc: [email protected] Reviewed-by: Roland Vossen <[email protected]> Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: make function definitions and prototype consistentArend van Spriel1-4/+4
Couple of functions that are only used within wlc_channel.c have been prototyped with static keyword. For the function definition itself this has been added when missing. Cc: [email protected] Cc: [email protected] Reviewed-by: Roland Vossen <[email protected]> Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: remove unused functions and prototypesArend van Spriel3-78/+0
Several functions in wlc_bmac.c are not used in the driver and prototypes in wlc_pub.h that have no implementation. These have been removed. Cc: [email protected] Cc: [email protected] Reviewed-by: Roland Vossen <[email protected]> Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: remove unnecessary functions from wlc_main.cArend van Spriel3-476/+4
Couple of functions were not needed and have been removed. Cc: [email protected] Cc: [email protected] Reviewed-by: Roland Vossen <[email protected]> Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: got rid of #ifdef __mips__ by new dma_spin_for_len()Roland Vossen2-10/+20
Code cleanup. Cc: [email protected] Cc: [email protected] Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: brcm80211: replaced IL_BIGENDIAN by __BIG_ENDIANRoland Vossen4-12/+9
Code cleanup. IL_BIGENDIAN was a Broadcom specific define. Cc: [email protected] Cc: [email protected] Reviewed-by: Henry Ptasinski <[email protected]> Reviewed-by: Brett Rudley <[email protected]> Signed-off-by: Arend van Spriel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Move the contents of utils.h to hyperv.hK. Y. Srinivasan5-123/+97
Move the contents of utils.h to hyperv.h. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Move the contents of vmbus.h to hyperv.hK. Y. Srinivasan11-60/+20
Move the contents of vmbus.h to hyperv.h. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Move the contents of vmbus_api.h to hyperv.hK. Y. Srinivasan9-98/+69
Move the contents of vmbus_api.h to hyperv.h. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Move the contents of logging.h to hyperv.hK. Y. Srinivasan17-113/+68
Move the contents of logging.h to hyperv.h. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Move the contents of channel.h to hyperv.hK. Y. Srinivasan10-120/+82
Move the contents of channel.h to hyperv.h. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Move the contents of channel_mgmt.h to hyperv.hK. Y. Srinivasan4-318/+290
Move the contents of channel_mgmt.h to hyperv.h. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Move the contents of vmbus_packet_format.h to hyperv.hK. Y. Srinivasan8-167/+133
Move the contents of vmbus_packet_format.h to hyperv.h Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Move the contents of vmbus_channel_interface.h to hyperv.hK. Y. Srinivasan6-94/+65
Move the contents of vmbus_channel_interface.h to hyperv.h Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Move the contents of the file version_info.h to hyperv.hK. Y. Srinivasan9-55/+21
Move the contents of the file version_info.h to hyperv.h. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Move a subset of definitions from ring_buffer.h to hyperv.hK. Y. Srinivasan2-43/+41
Move a subset of definitions from ring_buffer.h to hyperv.h. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Add a subset of definitions from vmbus_api.h to hyperv.hK. Y. Srinivasan2-30/+30
Add a subset of definitions from vmbus_api.h to hyperv.h. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Include the newly created header file in all of the relevant ↵K. Y. Srinivasan17-5/+37
hyperv files Include the newly created header file in all of the relevant hyperv files. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17Staging: hv: Create a common header for all hyperv drivers to includeK. Y. Srinivasan1-0/+23
Create a common header for all hyperv drivers to include. When we exit staging, this would land under include/linux. Signed-off-by: K. Y. Srinivasan <[email protected]> Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Abhishek Kane <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17drivers/staging/vt6656/main_usb.c: Delete unnecessary call to usb_kill_urbJulia Lawall1-3/+0
Since in each case nothing has been done with the recently allocated urb, it is not necessary to kill it before freeing it. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ expression urb; statement S; position p1,p2; @@ urb = usb_alloc_urb@p1(...); ... when != urb if (urb == NULL) S ... when != urb usb_kill_urb@p2(urb); @other exists@ position r.p1,r.p2; @@ ... when != usb_alloc_urb@p1(...) usb_kill_urb@p2(...); @depends on !other exists@ expression urb; position r.p1,r.p2; @@ urb = usb_alloc_urb@p1(...); ... ( -usb_kill_urb@p2(urb); +usb_free_urb(urb); ... when != urb | -usb_kill_urb@p2(urb); ) // </smpl> Signed-off-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17gma500: finish off the fault handlerAlan Cox4-20/+93
GEM wants to mmap the object through the GTT (which avoids aliasing) so we need to put the object into the GTT before we provide the fault mapping for it. While we are at it update the pin interface so that it digs dev out of the GEM object itself. This provides a rather cleaner API and call environment. Fix th refcount/on-off confusion in the pin API. At this point we get a bit further with modetest but if we write to the new GEM mapping we hang solid and as yet I don't know why. Signed-off-by: Alan Cox <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17gma500: Don't try and take a GEM handle of a non GEM fbAlan Cox1-0/+2
The initial GMA500 framebuffer is not GEM but stolen memory. We can't therefore take a GEM handle of it. Stop anyone trying to do this and causing a crash. Ideally we need a way to have GEM handles to non GEM objects but it's not clear how and if GEM and the modesetting/fb interfaces it provides are supposed to or indeed if they can handle it. Signed-off-by: Alan Cox <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17comedi vmk80xx: Style improvementsJ. Ali Harlow1-53/+74
Style improvements to comedi driver vmk80xx: * One variable definition per line * Block quotes start and end with near-empty lines * If..else statements use braces for both branches * Egregious blank lines removed * Use if..else rather than goto where trivial * Don't put function return type on a separate line Signed-off-by: J. Ali Harlow <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-17staging: usbip: fix wrong endian conversionDavid Chang1-1/+1
Fix number_of_packets wrong endian conversion in function correct_endian_ret_submit() Signed-off-by: David Chang <[email protected]> Acked-by: Arjan Mels <[email protected]> Cc: stable <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-12iio: adc: ad7780: Add missing GPIOLIB dependencyMichael Hennerich1-0/+1
Signed-off-by: Michael Hennerich <[email protected]> Reported-by: Randy Dunlap <[email protected]> Acked-by: Jonathan Cameron <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-12iio: trigger: iio-trig-bfin-timer: select missing dependencyMichael Hennerich1-0/+1
This driver requires CONFIG_BFIN_GPTIMERS. Signed-off-by: Michael Hennerich <[email protected]> Acked-by: Jonathan Cameron <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-12staging: usbip: edit Kconfig and rename CONFIG optionsmatt mooney6-36/+38
Change modules usbip_common_mod to usbip-core and usbip to usbip-host; edit configuration option help text; rename CONFIG options to use a USBIP prefix and change COMMON to CORE in both the Kconfig and Makefiles; edit the menu entries; and edit the driver descriptions. Signed-off-by: matt mooney <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-12staging: usbip: fix header includesmatt mooney13-26/+42
Modify header directives to include what is needed by each file and not already included in its own header. Signed-off-by: matt mooney <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-11staging: usbip: vhci.h: reorganizematt mooney1-3/+5
Split function declarations by source file. Signed-off-by: matt mooney <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2011-05-11staging: usbip: stub.h: reorganizematt mooney1-9/+10
Move a few functions around for better organization and add missing parameter names in function declarations. Signed-off-by: matt mooney <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>