aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-09-20Staging: batman-adv: Use synchronize_rcu instead of call_rcuSven Eckelmann3-10/+2
It is recommended [1] to use synchronize_rcu to simplify the code - especially when otherwise extra locking is needed to protect other code from picking stale elements. It also protects us for emitting to many callbacks which may results in OOM conditions. The only reason not to use it, would be in performance critical sections or when we are not allowed to block. [1] Documentation/RCU/checklist.txt Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20Staging: batman-adv: Remove unneeded rcu_read_lockSven Eckelmann1-2/+0
Regions which do not use rcu functions don't need to protected by rcu_read_lock. If we want to protect data from being freed than it must be covered by the same read-side critical section or otherwise the grace period may already ended and freed the memory before we called rcu_read_lock again. Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20Staging: batman-adv: Always protect list_for_each_entry_rcu with RCUSven Eckelmann1-0/+2
receive_bat_packet is not called with rcu_read_lock so we must ensure by ourself that we protect list_for_each_entry_rcu using the correct RCU locks. Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20Staging: batman-adv: Introduce if_list_lock to protect if_listSven Eckelmann1-2/+15
The update critical sections of if_list must be protected by a locking primitive other than RCU. The iterator must also be protected by the chosen locking mechanism. The rtnl_lock in hardif_remove_interfaces must also be moved outside the iterator primitive to ensure that we don't deadlock the kernel due to differently nested locks in hardif_remove_interfaces and hard_if_event. Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20Staging: batman-adv: wait for call_rcu before unloading moduleSven Eckelmann1-1/+1
synchronize_rcu respective synchronize_net only waits for the rcu grace period to elapse and we may fail to finish the calls which were made to call_rcu in that time. In result the module could be unloaded during the execution of the RCU callbacks. rcu_barrier[1] will now wait for all outstanding RCU callbacks to finish before continuing. [1] Documentation/RCU/rcubarrier.txt Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20Staging: batman-adv: Mark debugfs files as nonseekableSven Eckelmann2-0/+5
We don't allow to seek in the debugfs socket and log files. Thus we should mark the file descriptor as nonseekable. Signed-off-by: Sven Eckelmann <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20Staging: batman-adv: Move mailing list address to .orgSven Eckelmann2-3/+4
The official mailing list is run on lists.open-mesh.org and it should be avoided to sent them to lists.open-mesh.net to reduce the number of receipents and double posts. Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20Staging: batman-adv: checkpatch cleanup of commentsSven Eckelmann3-18/+19
checkpatch now detects the start of a comment and warns about usage of multiple spaces at the beginning of a line. We have to replace the ' ' in multiple lines comments by ' * ' to fix it. Checkpatch also wants a comment after a definition of a spinlock_t which describes what it protects. It is currently not possible to add it before the actual struct which includes the spinlock. Signed-off-by: Sven Eckelmann <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20staging: hv: Remove camel cases of vmbus packet buffer structuresHaiyang Zhang5-47/+47
Remove camel cases of vmbus packet buffer structures Remove camel cases of: struct VMBUS_CHANNEL_PACKET_PAGE_BUFFER struct VMBUS_CHANNEL_PACKET_MULITPAGE_BUFFER Signed-off-by: Haiyang Zhang <[email protected]> Signed-off-by: Hank Janssen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20staging: octeon: '&pointer[0]' to 'pointer' fixAndy Shevchenko1-1/+1
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20staging: rt2870: '&pointer[0]' to 'pointer' fixAndy Shevchenko1-1/+1
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20staging: vt6655: '&pointer[0]' to 'pointer' fixAndy Shevchenko2-3/+2
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20staging: ath6kl: '&pointer[0]' to 'pointer' fixAndy Shevchenko3-5/+5
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20staging: cxt1e1: '&pointer[0]' to 'pointer' fixAndy Shevchenko1-1/+1
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20staging: otus: '&pointer[0]' to 'pointer' fixAndy Shevchenko1-1/+1
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20staging: rtl8712: '&pointer[0]' to 'pointer' fixAndy Shevchenko1-1/+1
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20staging: wlags49_h2: '&pointer[0]' to 'pointer' fixAndy Shevchenko1-1/+1
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-20staging: rt2860: '&pointer[0]' to 'pointer' fixAndy Shevchenko9-15/+14
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: Use static const char * const where possibleJoe Perches2-9/+10
Signed-off-by: Joe Perches <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16Staging: vt665x: remove unused DEF definitionCharles Clément2-8/+0
Signed-off-by: Charles Clément <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: ti-st: fix kim platform device idPavan Savoy1-1/+8
Platform devices tend to have id as -1 when only 1 device exist and a value >=0 when multiple devices exist, since we plan to store all these platform devices if multiple exist, there was a requirement to have id to be >=0. The patch fixes this problem. Signed-off-by: Pavan Savoy <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: brcm80211: use string native libraryAndy Shevchenko9-292/+23
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: brcm80211: use native ctype libraryAndy Shevchenko4-79/+11
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: usbip: resolved a space in a commentAgustin March1-1/+1
Removed a space in a comments lines at #459 Signed-off-by: Agustin March <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: msm: Remove pr_<level> uses of KERN_<level>Joe Perches1-1/+1
Signed-off-by: Joe Perches <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: keucr: fix keucr lost disconnectAl Cho1-12/+11
keucr lost the disconnect, so keucr crash when plug-in and then plug-out SD-card quickly. unmark the part of usb disconnect Signed-off-by: Al Cho <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: vt6656: Fixed indentation with spacesClelia V. Korol1-6/+6
Fixed the last 5 lines, indented with spaces, replacing spaces with tabs. Signed-off-by: Clelia V. Korol <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: vt6656: removed dummy errors like extra spacesEma Cuevas1-4/+3
As reported by checkpatch. Signed-off-by: Ema Cuevas <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: vt6656: delete some parenthesismatias1-1/+1
I remove parenthesis for a return variable, and also delete a space and tab the code line Signed-off-by: matias <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: vt6656: Space Added after definition of Variable MSG_LEVEL_INFOEmanuel Mariano Ravera1-1/+1
Added an space after the definition of the variable MSG_LEVEL_INFO on line 43 Signed-off-by: Emanuel Mariano Ravera <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: vt6656: removed not required parentheses.Diego H. Iglesias1-1/+1
Removed not required parentheses in return statements. Signed-off-by: Diego H. Iglesias <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: comedi: fix signess bugVasiliy Kulikov2-2/+2
ai_count and ao_counter are unsigned, check for < 0 doesn't make sense. Cast them to int. Signed-off-by: Vasiliy Kulikov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: crystalhd: fix signed bugVasiliy Kulikov1-1/+1
chd_dec_major is unsigned, so check chd_dec_major < 0 doesn't make sense. Since it is used as signed, declare it as int. Signed-off-by: Vasiliy Kulikov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: solo6010: fix signess bugVasiliy Kulikov2-2/+2
video_nr is unsigned, so check video_nr >= 0 doesn't make sense. The only "negative" value may be -1, so explicitly check for it. Signed-off-by: Vasiliy Kulikov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: ST_BT depends on RFKILLRandy Dunlap1-1/+1
Fix kconfig unmet dependency warning: warning: (ST_BT && STAGING && !STAGING_EXCLUDE_BUILD && BT) selects TI_ST which has unmet direct dependencies (RFKILL) Signed-off-by: Randy Dunlap <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging/bcm: fix build for CONFIG_PM not enabledRandy Dunlap1-0/+2
Handle build case of CONFIG_PM not being enabled. drivers/staging/bcm/InterfaceInit.c:280: error: 'struct usb_device' has no member named 'autosuspend_delay' Signed-off-by: Randy Dunlap <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging/bcm: fix printk format warningsRandy Dunlap2-12/+12
Fix lots of printk format warnings in bcm. Here is a sample of them: drivers/staging/bcm/CmHost.c:1955: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'long unsigned int' drivers/staging/bcm/CmHost.c:1955: warning: format '%x' expects type 'unsigned int', but argument 2 has type 'long unsigned int' drivers/staging/bcm/CmHost.c:1955: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'long unsigned int' drivers/staging/bcm/LeakyBucket.c:85: warning: format '%d' expects type 'int', but argument 4 has type 'long int' drivers/staging/bcm/LeakyBucket.c:85: warning: format '%d' expects type 'int', but argument 3 has type 'long int' drivers/staging/bcm/LeakyBucket.c:85: warning: format '%d' expects type 'int', but argument 4 has type 'long int' Signed-off-by: Randy Dunlap <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging/keucr: fix build when CONFIG_PM is not enabledRandy Dunlap1-0/+9
keucr driver has a build error when CONFIG_PM is not enabled, so fix that. drivers/staging/keucr/usb.c:42: error: 'struct us_data' has no member named 'suspend_resume_hook' drivers/staging/keucr/usb.c:43: error: 'struct us_data' has no member named 'suspend_resume_hook' drivers/staging/keucr/usb.c:64: error: 'struct us_data' has no member named 'suspend_resume_hook' drivers/staging/keucr/usb.c:65: error: 'struct us_data' has no member named 'suspend_resume_hook' Signed-off-by: Randy Dunlap <[email protected]> Cc: Al Cho <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging/keucr: update TODO list and ask question about itRandy Dunlap1-0/+3
Update keucr TODO with additional work items. Signed-off-by: Randy Dunlap <[email protected]> Cc: Al Cho <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: ath6kl: use '%pM' format to print MAC addressAndy Shevchenko3-25/+13
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: octeon: use '%pM' format to print MAC addressAndy Shevchenko1-4/+1
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: otus: use '%pM' format to print MAC addressAndy Shevchenko2-15/+5
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: rt2870: use '%pM' format to print MAC addressAndy Shevchenko1-7/+4
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: rtl8712: use '%pM' format to print MAC addressAndy Shevchenko2-5/+1
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: cxt1e1: use '%pMF' format to print MAC addressAndy Shevchenko1-3/+2
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: vt6655: use '%pM' format to print MAC addressAndy Shevchenko2-7/+4
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: wlags49_h2: use '%pM' format to print MAC addressAndy Shevchenko1-3/+1
Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-16staging: rt2860: change plain format of mac address to %pM in *printf()Andy Shevchenko12-67/+30
There are many locations where MAC or BSSID is printed. The plain format is used in such places. *printf() in kernel recognizes %pM, %pMF and %pm format parameters to print out 6-byte array as MAC address. This patch changes plain format to custom %pM which is widely used in kernel. Signed-off-by: Andy Shevchenko <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-14staging: west bridge: pnand hal fixesDavid Cross2-6/+9
This patch includes changing some defines, necessary for compilation with the linux-next tree. Signed-off-by: David Cross <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2010-09-14staging: west bridge: cyasgadget, remove file system / vfs callsDavid Cross1-42/+0
This patch remove file system specific (fat_get_block) and vfs calls from the cyasgadget driver. The current implementation expects user space to write the file (open, seek to end, 1 byte write), followed by a call to clear the dirty pages from the the page cache. Signed-off-by: David Cross <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.