aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-05-01staging: rtl8192u: ieee80211: Resolve ERROR reported by checkpatchVandana BN1-20/+20
This patch resolves coding style space ERRORs reported by checkpatch ERROR: spaces required around that '>' (ctx:VxV) ERROR: space required after that ',' (ctx:VxO) ERROR: space required before that '&' (ctx:OxV) ERROR: spaces required around that '!=' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxW) ERROR: space required before the open parenthesis '(' ERROR: spaces required around that '?' (ctx:VxE) ERROR: spaces required around that ':' (ctx:VxE) ERROR: spaces required around that '==' (ctx:VxV) Signed-off-by: Vandana BN <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-05-01staging: vc04_services: bcm2835-camera: Compress two lines into one lineVatsala Narang1-3/+1
Return value directly without saving it in a variable and remove that variable. Issue suggested by Coccinelle. Signed-off-by: Vatsala Narang <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-05-01staging: rtl8723bs: core: Use !x in place of NULL comparison.Vatsala Narang2-4/+4
Avoid NULL comparison, compare using boolean operator. Issue found using coccinelle. Signed-off-by: Vatsala Narang <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-05-01staging: rtl8723bs: core: Prefer using the BIT Macro.Vatsala Narang1-3/+5
Replace bit shifting on 1 with the BIT(x) macro. Issue found using coccinelle. Signed-off-by: Vatsala Narang <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-05-01staging: fieldbus: anybus-s: fix wait_for_completion_timeout return handlingNicholas Mc Guire1-3/+2
wait_for_completion_timeout() returns unsigned long (0 on timeout or remaining jiffies) not int. Assigning this return value to int may theoretically overflow (though not in this case where TIMEOUT is only HZ*2). Fix this inconsistency by wrapping the wait_for_completion_timeout into the if(). Signed-off-by: Nicholas Mc Guire <[email protected]> Reviewed-by: Sven Van Asbroeck <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-05-01staging: kpc2000: fix up build problems with readq()Greg Kroah-Hartman4-0/+4
The 0-day system found a bunch of warnings for when readq() is not defined on the platform, so fix this by including the linux/io-64-nonatomic-lo-hi.h file which will fix up these issues. Reported-by: kbuild test robot <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-05-01staging: rtlwifi: move remaining phydm .h filesGreg Kroah-Hartman3-2/+2
The rtl8188eu driver uses the phydm .h files from the rtlwifi driver, but now that the rtlwifi driver is gone, it's silly to have a whole directory for just 2 .h files. So move these files into the rtl8188eu driver's directory so that it can be self-contained. Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-05-01staging: rtlwifi: strip down phydm .h filesGreg Kroah-Hartman2-269/+2
The phydm .h files are used by another driver, but not all of the defines are used, so strip them down to their basic necessities before we move them out of this directory. Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-05-01staging: rtlwifi: delete the staging driverGreg Kroah-Hartman181-123321/+0
A "real" driver for this hardware is now in the wireless-drivers-next tree, to be merged in the next major kernel release, so this staging driver can now be deleted as it is not needed anymore. Note, 2 .h files remain for this driver, as they are referenced in a separate staging driver. That mess will be cleaned up in a follow-on patch. Cc: Ping-Ke Shih <[email protected]> Cc: Tzu-En Huang <[email protected]> Cc: Yan-Hsuan Chuang <[email protected]> Cc: Stanislaw Gruszka <[email protected]> Cc: Brian Norris <[email protected]> Cc: Kalle Valo <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: fieldbus: anybus-s: rename bus id field to avoid confusionSven Van Asbroeck3-5/+5
Rename the anybus-s bus id from fieldbus_type to anybus_id, to avoid confusion with an identically named variable in the fieldbus_dev framework. Although this value is called fieldbus_type in the anybus-s docs, it acts like a bus id, so the name change is appropriate. Signed-off-by: Sven Van Asbroeck <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: fieldbus: anybus-s: keep device bus id in bus endiannessSven Van Asbroeck2-5/+4
"Normal" bus structures such as USB or PCI keep device bus ids in bus endinanness, and driver bus ids in host endianness. Endianness conversion happens each time bus_match() is called. Modify anybus-s to conform to this pattern. As a pleasant side- effect, sparse warnings will now disappear. This was suggested by Al Viro. Link: https://lkml.org/lkml/2019/4/30/834 Signed-off-by: Sven Van Asbroeck <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30Staging: sm750fb: Change *array into *const arrayKelsey Skunberg1-1/+1
Resolve checkpatch warning for static const char * array by using const pointers. Checkpatch Warning in sm750.c: static const char * array should probably be static const char * const Signed-off-by: Kelsey Skunberg <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: rtl8192u: ieee80211: Fix spelling mistakeVatsala Narang1-1/+2
Replace explicitely with explicitly to get rid of checkpatch warning. Signed-off-by: Vatsala Narang <[email protected]> Acked-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: rtl8192u: ieee80211: Replace bit shifting with BIT macroVatsala Narang1-4/+4
Change suggested by coccinelle. Replace bit shifting on 1 with the BIT(x) macro. Coccinelle script: @@ expression c; @@ -(1 << c) +BIT(c) Signed-off-by: Vatsala Narang <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: vc04_services: bcm2835-camera: Modify return statement.Vatsala Narang1-6/+2
Modify return statement and remove the respective assignment. Issue found by Coccinelle. Signed-off-by: Vatsala Narang <[email protected]> Acked-by: Stefan Wahren <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: rtl8723bs: Fix checkpatch.pl warningsVandana BN1-2/+1
This patch resolves coding style brace warning and constant on right warning. WARNING: Comparisons should place the constant on the right side of the test WARNING: braces {} are not necessary for single statement blocks CHECK: Comparison to NULL could be written "!pbuf" Signed-off-by: Vandana BN <[email protected]> ------ v2- Edited commit message and subject v3- Edited commit message v4- changed NULL check to use !pbuf ------ Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: rtl8723bs: core: Remove blank line.Vatsala Narang1-5/+0
To avoid style issues, remove multiple blank lines. Signed-off-by: Vatsala Narang <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: rtl8723bs: core: Remove else after return statement.Vatsala Narang1-3/+2
Remove else after return statement as it is not useful. Issue found using checkpatch. Signed-off-by: Vatsala Narang <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: rtl8723bs: core: Remove return in void functionVatsala Narang1-2/+0
Remove return in void function to get rid of checkpatch warning. Signed-off-by: Vatsala Narang <[email protected]> Acked-by: Julia Lawall <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: octeon-ethernet: add TODOAaro Koskinen1-0/+9
Add missing TODO to describe the plan to get this driver out of staging. Signed-off-by: Aaro Koskinen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: refer to TODO in Kconfig help textAaro Koskinen1-2/+2
Refer to TODO file instead of driver_name.README that does not seem to be used. Signed-off-by: Aaro Koskinen <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: most: sound: pass correct device when creating a sound cardChristian Gromm1-1/+1
This patch fixes the usage of the wrong struct device when calling function snd_card_new. Reported-by: Eugeniu Rosca <[email protected]> Signed-off-by: Christian Gromm <[email protected]> Fixes: 69c90cf1b2fa ("staging: most: sound: call snd_card_new with struct device") Cc: stable <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: kpc2000: fix resource size calculationDan Carpenter2-2/+2
The code is calculating the resource size wrong because it should be inclusive of the "res->end" address. In other words, "end - start + 1". We can just use the resource_size() function to do it correctly. Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: kpc2000: Fix a stack information leak in kp2000_cdev_ioctl()Dan Carpenter1-0/+2
The kp2000_regs struct has a 4 byte hole between ->hw_rev and ->ssid so this could leak stack information to the user. This patch just memsets the whole struct to zero. Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers") Signed-off-by: Dan Carpenter <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: kpc2000_spi: eliminated duplicate initialization of master local ↵Jeremy Sowden1-1/+1
variable. master was being initialized to a particular value and then having the same value assigned to it immediately afterwards. Removed the initializer. Since the value assigned to master was dynamically allocated, this fixes a memory-leak. Signed-off-by: Jeremy Sowden <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-30staging: kpc2000_spi: eliminated duplicate initialization of drvdata local ↵Jeremy Sowden1-2/+2
variable. drvdata was being initialized to a particular value and then having the same value assigned to it immediately afterwards. Removed the initializer. Since the value assigned, pldev->dev.platform_data, is a pointer-to- void, removed superfluous cast. Signed-off-by: Jeremy Sowden <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-27staging: comedi: comedi_isadma: Use a non-NULL device for DMA APIIan Abbott2-2/+18
The "comedi_isadma" module calls `dma_alloc_coherent()` and `dma_free_coherent()` with a NULL device pointer which is no longer allowed. If the `hw_dev` member of the `struct comedi_device` has been set to a valid device, that can be used instead. Unfortunately, all the current users of the "comedi_isadma" module leave the `hw_dev` member set to NULL. In that case, fall back to using the comedi "class" device pointed to by the `class_dev` member if that is non-NULL. In that case, make it "DMA-capable" with a coherent DMA mask set to the ISA bus limit of 16MB (24 bits). Signed-off-by: Ian Abbott <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25LS1021A: dtsi: add ftm quad decoder entriesPatrick Havelange1-0/+28
Add the 4 Quadrature counters for this board. Reviewed-by: Esben Haabendal <[email protected]> Signed-off-by: Patrick Havelange <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25counter: ftm-quaddec: Documentation: Add specific counter sysfs documentationPatrick Havelange1-0/+16
This adds documentation for the specific prescaler entry. Signed-off-by: Patrick Havelange <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25counter: add FlexTimer Module Quadrature decoder counter driverPatrick Havelange3-0/+366
This driver exposes the counter for the quadrature decoder of the FlexTimer Module, present in the LS1021A soc. Signed-off-by: Patrick Havelange <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25dt-bindings: counter: ftm-quaddecPatrick Havelange1-0/+18
FlexTimer quadrature decoder driver. Reviewed-by: Esben Haabendal <[email protected]> Signed-off-by: Patrick Havelange <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25drivers/clocksource: timer-fsl-ftm: use common header for FlexTimer #definesPatrick Havelange1-13/+2
Common #defines have been moved to "linux/fsl/ftm.h". Thus making use of this file. Also FTM_SC_CLK_SHIFT has been renamed to FTM_SC_CLK_MASK_SHIFT. Reviewed-by: Esben Haabendal <[email protected]> Signed-off-by: Patrick Havelange <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25drivers/pwm: pwm-fsl-ftm: use common header for FlexTimer #definesPatrick Havelange1-43/+1
This also fixes the wrong value for the previously defined FTM_MODE_INIT macro (it was not used). Reviewed-by: Esben Haabendal <[email protected]> Signed-off-by: Patrick Havelange <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25include/fsl: add common FlexTimer #defines in a separate header.Patrick Havelange1-0/+88
Several files are/will be using the same #defines to use the Flextimer module. Regroup them in a common file. Reviewed-by: Esben Haabendal <[email protected]> Signed-off-by: Patrick Havelange <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25iio: counter: Add deprecation markings for IIO Counter attributesWilliam Breathitt Gray2-0/+24
The IIO counter subdirectory is now superceded by the Counter subsystem. This patch adds deprecation warnings to the documentation of the relevant IIO Counter sysfs attributes. Acked-by: Jonathan Cameron <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25dt-bindings: counter: Adjust dt-bindings for STM32 lptimer moveFabrice Gasnier2-1/+1
The STM32 LP Timer counter driver now resides under the Counter subsystem. This patch adjusts dt-bindings to account for the STM32 lptimer driver move. Cc: Mark Rutland <[email protected]> Signed-off-by: Fabrice Gasnier <[email protected]> Acked-by: Rob Herring <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25counter: stm32-lptimer: add counter deviceFabrice Gasnier7-48/+350
Add support for new counter device to stm32-lptimer. Signed-off-by: Fabrice Gasnier <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25dt-bindings: counter: Document stm32 quadrature encoderBenjamin Gaignard2-0/+38
Add bindings for STM32 Timer quadrature encoder. It is a sub-node of STM32 Timer which implement the quadratic encoder part of the hardware. Cc: Mark Rutland <[email protected]> Signed-off-by: Benjamin Gaignard <[email protected]> Acked-by: Rob Herring <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25counter: Add STM32 Timer quadrature encoderBenjamin Gaignard3-0/+401
Implement counter part of the STM32 timer hardware block by using counter API. Hardware only supports X2 and X4 quadrature modes. A ceiling value can be set to define the maximum value reachable by the counter. Signed-off-by: Benjamin Gaignard <[email protected]> Co-authored-by: Fabrice Gasnier <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25counter: 104-quad-8: Documentation: Add Generic Counter sysfs documentationWilliam Breathitt Gray2-0/+37
This patch adds standard documentation for the Generic Counter interface userspace sysfs attributes of the 104-QUAD-8 driver. Acked-by: Jonathan Cameron <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25counter: 104-quad-8: Add Generic Counter interface supportWilliam Breathitt Gray7-643/+1392
This patch adds support for the Generic Counter interface to the 104-QUAD-8 driver. The existing 104-QUAD-8 device interface should not be affected by this patch; all changes are intended as supplemental additions as perceived by the user. Generic Counter Counts are created for the eight quadrature channel counts, as well as their respective quadrature A and B Signals (which are associated via respective Synapse structures) and respective index Signals. The new Generic Counter interface sysfs attributes are intended to expose the same functionality and data available via the existing 104-QUAD-8 IIO device interface; the Generic Counter interface serves to provide the respective functionality and data in a standard way expected of counter devices. Reviewed-by: Jonathan Cameron <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25iio: 104-quad-8: Update license boilerplateWilliam Breathitt Gray1-9/+1
This patch simplifies the boilerplate license text by making use of a SPDX license identifier line. Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25docs: Add Generic Counter interface documentationWilliam Breathitt Gray3-0/+344
This patch adds high-level documentation about the Generic Counter interface. Reviewed-by: Jonathan Cameron <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25counter: Documentation: Add Generic Counter sysfs documentationWilliam Breathitt Gray2-0/+231
This patch adds standard documentation for the userspace sysfs attributes of the Generic Counter interface. Reviewed-by: Jonathan Cameron <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25counter: Introduce the Generic Counter interfaceWilliam Breathitt Gray8-0/+2148
This patch introduces the Generic Counter interface for supporting counter devices. In the context of the Generic Counter interface, a counter is defined as a device that reports one or more "counts" based on the state changes of one or more "signals" as evaluated by a defined "count function." Driver callbacks should be provided to communicate with the device: to read and write various Signals and Counts, and to set and get the "action mode" and "count function" for various Synapses and Counts respectively. To support a counter device, a driver must first allocate the available Counter Signals via counter_signal structures. These Signals should be stored as an array and set to the signals array member of an allocated counter_device structure before the Counter is registered to the system. Counter Counts may be allocated via counter_count structures, and respective Counter Signal associations (Synapses) made via counter_synapse structures. Associated counter_synapse structures are stored as an array and set to the the synapses array member of the respective counter_count structure. These counter_count structures are set to the counts array member of an allocated counter_device structure before the Counter is registered to the system. A counter device is registered to the system by passing the respective initialized counter_device structure to the counter_register function; similarly, the counter_unregister function unregisters the respective Counter. The devm_counter_register and devm_counter_unregister functions serve as device memory-managed versions of the counter_register and counter_unregister functions respectively. Reviewed-by: Jonathan Cameron <[email protected]> Signed-off-by: William Breathitt Gray <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25staging: kpc2000: Add DMA driverMatt Sickler8-0/+1181
Add Daktronics DMA driver. I've added the SPDX license identifiers, Kconfig entry, and cleaned up as many of the warnings as I could. The AIO support code will be removed in a future patch. Signed-off-by: Matt Sickler <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25Staging: vc04_services: Cleanup in ctrl_set_bitrate()Madhumitha Prabakaran1-6/+3
Remove unnecessary variable from the function and make a corresponding change w.r.t the variable. In addition to that align the parameters in the parentheses to maintain Linux kernel coding style Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25staging: rtl8188eu: remove unnecessary parenthesesMichael Straube2-4/+4
Remove unnecessary parentheses to improve readability. Signed-off-by: Michael Straube <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25staging: rtl8188eu: add spaces around '-' in rtw_cmd.cMichael Straube1-2/+2
Add spaces around '-' to follow kernel coding style. Reported by checkpatch. Signed-off-by: Michael Straube <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-04-25staging: rtl8188eu: replace subtraction with resultMichael Straube1-2/+2
Replace subtraction with the result to improve readability and clear missing spaces around '-' checkpatch issues. Signed-off-by: Michael Straube <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.