diff options
Diffstat (limited to 'sound/soc/amd')
| -rw-r--r-- | sound/soc/amd/acp-da7219-max98357a.c | 90 | ||||
| -rw-r--r-- | sound/soc/amd/acp-pcm-dma.c | 623 | ||||
| -rw-r--r-- | sound/soc/amd/acp.h | 97 | 
3 files changed, 500 insertions, 310 deletions
| diff --git a/sound/soc/amd/acp-da7219-max98357a.c b/sound/soc/amd/acp-da7219-max98357a.c index f41560ecbcd1..ccddc6650b9c 100644 --- a/sound/soc/amd/acp-da7219-max98357a.c +++ b/sound/soc/amd/acp-da7219-max98357a.c @@ -33,17 +33,19 @@  #include <linux/gpio.h>  #include <linux/module.h>  #include <linux/i2c.h> +#include <linux/input.h>  #include <linux/acpi.h> +#include "acp.h"  #include "../codecs/da7219.h"  #include "../codecs/da7219-aad.h" -#define CZ_PLAT_CLK 24000000 -#define MCLK_RATE 24576000 +#define CZ_PLAT_CLK 25000000  #define DUAL_CHANNEL		2  static struct snd_soc_jack cz_jack;  static struct clk *da7219_dai_clk; +extern int bt_uart_enable;  static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)  { @@ -62,7 +64,7 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)  	}  	ret = snd_soc_dai_set_pll(codec_dai, 0, DA7219_SYSCLK_PLL, -				  CZ_PLAT_CLK, MCLK_RATE); +				  CZ_PLAT_CLK, DA7219_PLL_FREQ_OUT_98304);  	if (ret < 0) {  		dev_err(rtd->dev, "can't set codec pll: %d\n", ret);  		return ret; @@ -80,13 +82,17 @@ static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)  		return ret;  	} +	snd_jack_set_key(cz_jack.jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); +	snd_jack_set_key(cz_jack.jack, SND_JACK_BTN_1, KEY_VOLUMEUP); +	snd_jack_set_key(cz_jack.jack, SND_JACK_BTN_2, KEY_VOLUMEDOWN); +	snd_jack_set_key(cz_jack.jack, SND_JACK_BTN_3, KEY_VOICECOMMAND); +  	da7219_aad_jack_det(component, &cz_jack);  	return 0;  } -static int cz_da7219_hw_params(struct snd_pcm_substream *substream, -			     struct snd_pcm_hw_params *params) +static int da7219_clk_enable(struct snd_pcm_substream *substream)  {  	int ret = 0;  	struct snd_soc_pcm_runtime *rtd = substream->private_data; @@ -100,11 +106,9 @@ static int cz_da7219_hw_params(struct snd_pcm_substream *substream,  	return ret;  } -static int cz_da7219_hw_free(struct snd_pcm_substream *substream) +static void da7219_clk_disable(void)  {  	clk_disable_unprepare(da7219_dai_clk); - -	return 0;  }  static const unsigned int channels[] = { @@ -127,9 +131,12 @@ static const struct snd_pcm_hw_constraint_list constraints_channels = {  	.mask = 0,  }; -static int cz_fe_startup(struct snd_pcm_substream *substream) +static int cz_da7219_startup(struct snd_pcm_substream *substream)  {  	struct snd_pcm_runtime *runtime = substream->runtime; +	struct snd_soc_pcm_runtime *rtd = substream->private_data; +	struct snd_soc_card *card = rtd->card; +	struct acp_platform_info *machine = snd_soc_card_get_drvdata(card);  	/*  	 * On this platform for PCM device we support stereo @@ -141,23 +148,58 @@ static int cz_fe_startup(struct snd_pcm_substream *substream)  	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,  				   &constraints_rates); -	return 0; +	machine->i2s_instance = I2S_BT_INSTANCE; +	return da7219_clk_enable(substream); +} + +static void cz_da7219_shutdown(struct snd_pcm_substream *substream) +{ +	da7219_clk_disable(); +} + +static int cz_max_startup(struct snd_pcm_substream *substream) +{ +	struct snd_soc_pcm_runtime *rtd = substream->private_data; +	struct snd_soc_card *card = rtd->card; +	struct acp_platform_info *machine = snd_soc_card_get_drvdata(card); + +	machine->i2s_instance = I2S_SP_INSTANCE; +	return da7219_clk_enable(substream); +} + +static void cz_max_shutdown(struct snd_pcm_substream *substream) +{ +	da7219_clk_disable(); +} + +static int cz_dmic_startup(struct snd_pcm_substream *substream) +{ +	struct snd_soc_pcm_runtime *rtd = substream->private_data; +	struct snd_soc_card *card = rtd->card; +	struct acp_platform_info *machine = snd_soc_card_get_drvdata(card); + +	machine->i2s_instance = I2S_SP_INSTANCE; +	return da7219_clk_enable(substream); +} + +static void cz_dmic_shutdown(struct snd_pcm_substream *substream) +{ +	da7219_clk_disable();  } -static struct snd_soc_ops cz_da7219_cap_ops = { -	.hw_params = cz_da7219_hw_params, -	.hw_free = cz_da7219_hw_free, -	.startup = cz_fe_startup, +static const struct snd_soc_ops cz_da7219_cap_ops = { +	.startup = cz_da7219_startup, +	.shutdown = cz_da7219_shutdown,  }; -static struct snd_soc_ops cz_max_play_ops = { -	.hw_params = cz_da7219_hw_params, -	.hw_free = cz_da7219_hw_free, +static const struct snd_soc_ops cz_max_play_ops = { +	.startup = cz_max_startup, +	.shutdown = cz_max_shutdown,  }; -static struct snd_soc_ops cz_dmic_cap_ops = { -	.hw_params = cz_da7219_hw_params, -	.hw_free = cz_da7219_hw_free, +static const struct snd_soc_ops cz_dmic_cap_ops = { +	.startup = cz_dmic_startup, +	.shutdown = cz_dmic_shutdown,  };  static struct snd_soc_dai_link cz_dai_7219_98357[] = { @@ -240,10 +282,16 @@ static int cz_probe(struct platform_device *pdev)  {  	int ret;  	struct snd_soc_card *card; +	struct acp_platform_info *machine; +	machine = devm_kzalloc(&pdev->dev, sizeof(struct acp_platform_info), +			       GFP_KERNEL); +	if (!machine) +		return -ENOMEM;  	card = &cz_card;  	cz_card.dev = &pdev->dev;  	platform_set_drvdata(pdev, card); +	snd_soc_card_set_drvdata(card, machine);  	ret = devm_snd_soc_register_card(&pdev->dev, &cz_card);  	if (ret) {  		dev_err(&pdev->dev, @@ -251,6 +299,8 @@ static int cz_probe(struct platform_device *pdev)  				cz_card.name, ret);  		return ret;  	} +	bt_uart_enable = !device_property_read_bool(&pdev->dev, +						    "bt-pad-enable");  	return 0;  } diff --git a/sound/soc/amd/acp-pcm-dma.c b/sound/soc/amd/acp-pcm-dma.c index 540088d317f2..77203841c535 100644 --- a/sound/soc/amd/acp-pcm-dma.c +++ b/sound/soc/amd/acp-pcm-dma.c @@ -37,12 +37,14 @@  #define MAX_BUFFER (PLAYBACK_MAX_PERIOD_SIZE * PLAYBACK_MAX_NUM_PERIODS)  #define MIN_BUFFER MAX_BUFFER -#define ST_PLAYBACK_MAX_PERIOD_SIZE 8192 +#define ST_PLAYBACK_MAX_PERIOD_SIZE 4096  #define ST_CAPTURE_MAX_PERIOD_SIZE  ST_PLAYBACK_MAX_PERIOD_SIZE  #define ST_MAX_BUFFER (ST_PLAYBACK_MAX_PERIOD_SIZE * PLAYBACK_MAX_NUM_PERIODS)  #define ST_MIN_BUFFER ST_MAX_BUFFER  #define DRV_NAME "acp_audio_dma" +bool bt_uart_enable = true; +EXPORT_SYMBOL(bt_uart_enable);  static const struct snd_pcm_hardware acp_pcm_hardware_playback = {  	.info = SNDRV_PCM_INFO_INTERLEAVED | @@ -130,7 +132,8 @@ static void acp_reg_write(u32 val, void __iomem *acp_mmio, u32 reg)  	writel(val, acp_mmio + (reg * 4));  } -/* Configure a given dma channel parameters - enable/disable, +/* + * Configure a given dma channel parameters - enable/disable,   * number of descriptors, priority   */  static void config_acp_dma_channel(void __iomem *acp_mmio, u8 ch_num, @@ -149,11 +152,12 @@ static void config_acp_dma_channel(void __iomem *acp_mmio, u8 ch_num,  			& dscr_strt_idx),  			acp_mmio, mmACP_DMA_DSCR_STRT_IDX_0 + ch_num); -	/* program a DMA channel with the number of descriptors to be +	/* +	 * program a DMA channel with the number of descriptors to be  	 * processed in the transfer -	*/ +	 */  	acp_reg_write(ACP_DMA_DSCR_CNT_0__DMAChDscrCnt_MASK & num_dscrs, -		acp_mmio, mmACP_DMA_DSCR_CNT_0 + ch_num); +		      acp_mmio, mmACP_DMA_DSCR_CNT_0 + ch_num);  	/* set DMA channel priority */  	acp_reg_write(priority_level, acp_mmio, mmACP_DMA_PRIO_0 + ch_num); @@ -180,13 +184,15 @@ static void config_dma_descriptor_in_sram(void __iomem *acp_mmio,  	acp_reg_write(descr_info->xfer_val, acp_mmio, mmACP_SRBM_Targ_Idx_Data);  } -/* Initialize the DMA descriptor information for transfer between +/* + * Initialize the DMA descriptor information for transfer between   * system memory <-> ACP SRAM   */  static void set_acp_sysmem_dma_descriptors(void __iomem *acp_mmio, -					u32 size, int direction, u32 pte_offset, -					u16 ch, u32 sram_bank, -					u16 dma_dscr_idx, u32 asic_type) +					   u32 size, int direction, +					   u32 pte_offset, u16 ch, +					   u32 sram_bank, u16 dma_dscr_idx, +					   u32 asic_type)  {  	u16 i;  	acp_dma_dscr_transfer_t dmadscr[NUM_DSCRS_PER_CHANNEL]; @@ -195,58 +201,58 @@ static void set_acp_sysmem_dma_descriptors(void __iomem *acp_mmio,  		dmadscr[i].xfer_val = 0;  		if (direction == SNDRV_PCM_STREAM_PLAYBACK) {  			dma_dscr_idx = dma_dscr_idx + i; -			dmadscr[i].dest = sram_bank + (i * (size/2)); +			dmadscr[i].dest = sram_bank + (i * (size / 2));  			dmadscr[i].src = ACP_INTERNAL_APERTURE_WINDOW_0_ADDRESS -				+ (pte_offset * SZ_4K) + (i * (size/2)); +				+ (pte_offset * SZ_4K) + (i * (size / 2));  			switch (asic_type) {  			case CHIP_STONEY:  				dmadscr[i].xfer_val |= -				(ACP_DMA_ATTRIBUTES_DAGB_GARLIC_TO_SHAREDMEM  << 16) | +				(ACP_DMA_ATTR_DAGB_GARLIC_TO_SHAREDMEM  << 16) |  				(size / 2);  				break;  			default:  				dmadscr[i].xfer_val |= -				(ACP_DMA_ATTRIBUTES_DAGB_ONION_TO_SHAREDMEM  << 16) | +				(ACP_DMA_ATTR_DAGB_ONION_TO_SHAREDMEM  << 16) |  				(size / 2);  			}  		} else {  			dma_dscr_idx = dma_dscr_idx + i; -			dmadscr[i].src = sram_bank + (i * (size/2)); +			dmadscr[i].src = sram_bank + (i * (size / 2));  			dmadscr[i].dest =  			ACP_INTERNAL_APERTURE_WINDOW_0_ADDRESS + -			(pte_offset * SZ_4K) + (i * (size/2)); +			(pte_offset * SZ_4K) + (i * (size / 2));  			switch (asic_type) {  			case CHIP_STONEY:  				dmadscr[i].xfer_val |=  				BIT(22) | -				(ACP_DMA_ATTRIBUTES_SHARED_MEM_TO_DAGB_GARLIC << 16) | +				(ACP_DMA_ATTR_SHARED_MEM_TO_DAGB_GARLIC << 16) |  				(size / 2);  				break;  			default:  				dmadscr[i].xfer_val |=  				BIT(22) | -				(ACP_DMA_ATTRIBUTES_SHAREDMEM_TO_DAGB_ONION << 16) | +				(ACP_DMA_ATTR_SHAREDMEM_TO_DAGB_ONION << 16) |  				(size / 2);  			}  		}  		config_dma_descriptor_in_sram(acp_mmio, dma_dscr_idx, -						&dmadscr[i]); +					      &dmadscr[i]);  	}  	config_acp_dma_channel(acp_mmio, ch, -				dma_dscr_idx - 1, -				NUM_DSCRS_PER_CHANNEL, -				ACP_DMA_PRIORITY_LEVEL_NORMAL); +			       dma_dscr_idx - 1, +			       NUM_DSCRS_PER_CHANNEL, +			       ACP_DMA_PRIORITY_LEVEL_NORMAL);  } -/* Initialize the DMA descriptor information for transfer between +/* + * Initialize the DMA descriptor information for transfer between   * ACP SRAM <-> I2S   */  static void set_acp_to_i2s_dma_descriptors(void __iomem *acp_mmio, u32 size, -						int direction, u32 sram_bank, -						u16 destination, u16 ch, -						u16 dma_dscr_idx, u32 asic_type) +					   int direction, u32 sram_bank, +					   u16 destination, u16 ch, +					   u16 dma_dscr_idx, u32 asic_type)  { -  	u16 i;  	acp_dma_dscr_transfer_t dmadscr[NUM_DSCRS_PER_CHANNEL]; @@ -254,7 +260,7 @@ static void set_acp_to_i2s_dma_descriptors(void __iomem *acp_mmio, u32 size,  		dmadscr[i].xfer_val = 0;  		if (direction == SNDRV_PCM_STREAM_PLAYBACK) {  			dma_dscr_idx = dma_dscr_idx + i; -			dmadscr[i].src = sram_bank  + (i * (size/2)); +			dmadscr[i].src = sram_bank  + (i * (size / 2));  			/* dmadscr[i].dest is unused by hardware. */  			dmadscr[i].dest = 0;  			dmadscr[i].xfer_val |= BIT(22) | (destination << 16) | @@ -269,12 +275,12 @@ static void set_acp_to_i2s_dma_descriptors(void __iomem *acp_mmio, u32 size,  				(destination << 16) | (size / 2);  		}  		config_dma_descriptor_in_sram(acp_mmio, dma_dscr_idx, -						&dmadscr[i]); +					      &dmadscr[i]);  	}  	/* Configure the DMA channel with the above descriptore */  	config_acp_dma_channel(acp_mmio, ch, dma_dscr_idx - 1, -				NUM_DSCRS_PER_CHANNEL, -				ACP_DMA_PRIORITY_LEVEL_NORMAL); +			       NUM_DSCRS_PER_CHANNEL, +			       ACP_DMA_PRIORITY_LEVEL_NORMAL);  }  /* Create page table entries in ACP SRAM for the allocated memory */ @@ -291,7 +297,7 @@ static void acp_pte_config(void __iomem *acp_mmio, struct page *pg,  	for (page_idx = 0; page_idx < (num_of_pages); page_idx++) {  		/* Load the low address of page int ACP SRAM through SRBM */  		acp_reg_write((offset + (page_idx * 8)), -			acp_mmio, mmACP_SRBM_Targ_Idx_Addr); +			      acp_mmio, mmACP_SRBM_Targ_Idx_Addr);  		addr = page_to_phys(pg);  		low = lower_32_bits(addr); @@ -301,7 +307,7 @@ static void acp_pte_config(void __iomem *acp_mmio, struct page *pg,  		/* Load the High address of page int ACP SRAM through SRBM */  		acp_reg_write((offset + (page_idx * 8) + 4), -			acp_mmio, mmACP_SRBM_Targ_Idx_Addr); +			      acp_mmio, mmACP_SRBM_Targ_Idx_Addr);  		/* page enable in ACP */  		high |= BIT(31); @@ -313,59 +319,25 @@ static void acp_pte_config(void __iomem *acp_mmio, struct page *pg,  }  static void config_acp_dma(void __iomem *acp_mmio, -			struct audio_substream_data *audio_config, -			u32 asic_type) +			   struct audio_substream_data *rtd, +			   u32 asic_type)  { -	u32 pte_offset, sram_bank; -	u16 ch1, ch2, destination, dma_dscr_idx; - -	if (audio_config->direction == SNDRV_PCM_STREAM_PLAYBACK) { -		pte_offset = ACP_PLAYBACK_PTE_OFFSET; -		ch1 = SYSRAM_TO_ACP_CH_NUM; -		ch2 = ACP_TO_I2S_DMA_CH_NUM; -		sram_bank = ACP_SHARED_RAM_BANK_1_ADDRESS; -		destination = TO_ACP_I2S_1; - -	} else { -		pte_offset = ACP_CAPTURE_PTE_OFFSET; -		ch1 = SYSRAM_TO_ACP_CH_NUM; -		ch2 = ACP_TO_I2S_DMA_CH_NUM; -		switch (asic_type) { -		case CHIP_STONEY: -			sram_bank = ACP_SHARED_RAM_BANK_3_ADDRESS; -			break; -		default: -			sram_bank = ACP_SHARED_RAM_BANK_5_ADDRESS; -		} -		destination = FROM_ACP_I2S_1; -	} - -	acp_pte_config(acp_mmio, audio_config->pg, audio_config->num_of_pages, -			pte_offset); -	if (audio_config->direction == SNDRV_PCM_STREAM_PLAYBACK) -		dma_dscr_idx = PLAYBACK_START_DMA_DESCR_CH12; -	else -		dma_dscr_idx = CAPTURE_START_DMA_DESCR_CH14; - +	acp_pte_config(acp_mmio, rtd->pg, rtd->num_of_pages, +		       rtd->pte_offset);  	/* Configure System memory <-> ACP SRAM DMA descriptors */ -	set_acp_sysmem_dma_descriptors(acp_mmio, audio_config->size, -				       audio_config->direction, pte_offset, -					ch1, sram_bank, dma_dscr_idx, asic_type); - -	if (audio_config->direction == SNDRV_PCM_STREAM_PLAYBACK) -		dma_dscr_idx = PLAYBACK_START_DMA_DESCR_CH13; -	else -		dma_dscr_idx = CAPTURE_START_DMA_DESCR_CH15; +	set_acp_sysmem_dma_descriptors(acp_mmio, rtd->size, +				       rtd->direction, rtd->pte_offset, +				       rtd->ch1, rtd->sram_bank, +				       rtd->dma_dscr_idx_1, asic_type);  	/* Configure ACP SRAM <-> I2S DMA descriptors */ -	set_acp_to_i2s_dma_descriptors(acp_mmio, audio_config->size, -					audio_config->direction, sram_bank, -					destination, ch2, dma_dscr_idx, -					asic_type); +	set_acp_to_i2s_dma_descriptors(acp_mmio, rtd->size, +				       rtd->direction, rtd->sram_bank, +				       rtd->destination, rtd->ch2, +				       rtd->dma_dscr_idx_2, asic_type);  }  /* Start a given DMA channel transfer */ -static void acp_dma_start(void __iomem *acp_mmio, -			 u16 ch_num, bool is_circular) +static void acp_dma_start(void __iomem *acp_mmio, u16 ch_num)  {  	u32 dma_ctrl; @@ -375,7 +347,8 @@ static void acp_dma_start(void __iomem *acp_mmio,  	/* Invalidating the DAGB cache */  	acp_reg_write(1, acp_mmio, mmACP_DAGB_ATU_CTRL); -	/* configure the DMA channel and start the DMA transfer +	/* +	 * configure the DMA channel and start the DMA transfer  	 * set dmachrun bit to start the transfer and enable the  	 * interrupt on completion of the dma transfer  	 */ @@ -385,6 +358,9 @@ static void acp_dma_start(void __iomem *acp_mmio,  	case ACP_TO_I2S_DMA_CH_NUM:  	case ACP_TO_SYSRAM_CH_NUM:  	case I2S_TO_ACP_DMA_CH_NUM: +	case ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM: +	case ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM: +	case I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM:  		dma_ctrl |= ACP_DMA_CNTL_0__DMAChIOCEn_MASK;  		break;  	default: @@ -392,11 +368,8 @@ static void acp_dma_start(void __iomem *acp_mmio,  		break;  	} -	/* enable  for ACP SRAM to/from I2S DMA channel */ -	if (is_circular == true) -		dma_ctrl |= ACP_DMA_CNTL_0__Circular_DMA_En_MASK; -	else -		dma_ctrl &= ~ACP_DMA_CNTL_0__Circular_DMA_En_MASK; +	/* circular for both DMA channel */ +	dma_ctrl |= ACP_DMA_CNTL_0__Circular_DMA_En_MASK;  	acp_reg_write(dma_ctrl, acp_mmio, mmACP_DMA_CNTL_0 + ch_num);  } @@ -410,9 +383,10 @@ static int acp_dma_stop(void __iomem *acp_mmio, u8 ch_num)  	dma_ctrl = acp_reg_read(acp_mmio, mmACP_DMA_CNTL_0 + ch_num); -	/* clear the dma control register fields before writing zero +	/* +	 * clear the dma control register fields before writing zero  	 * in reset bit -	*/ +	 */  	dma_ctrl &= ~ACP_DMA_CNTL_0__DMAChRun_MASK;  	dma_ctrl &= ~ACP_DMA_CNTL_0__DMAChIOCEn_MASK; @@ -420,9 +394,10 @@ static int acp_dma_stop(void __iomem *acp_mmio, u8 ch_num)  	dma_ch_sts = acp_reg_read(acp_mmio, mmACP_DMA_CH_STS);  	if (dma_ch_sts & BIT(ch_num)) { -		/* set the reset bit for this channel to stop the dma -		*  transfer -		*/ +		/* +		 * set the reset bit for this channel to stop the dma +		 *  transfer +		 */  		dma_ctrl |= ACP_DMA_CNTL_0__DMAChRst_MASK;  		acp_reg_write(dma_ctrl, acp_mmio, mmACP_DMA_CNTL_0 + ch_num);  	} @@ -431,13 +406,14 @@ static int acp_dma_stop(void __iomem *acp_mmio, u8 ch_num)  	while (true) {  		dma_ch_sts = acp_reg_read(acp_mmio, mmACP_DMA_CH_STS);  		if (!(dma_ch_sts & BIT(ch_num))) { -			/* clear the reset flag after successfully stopping -			* the dma transfer and break from the loop -			*/ +			/* +			 * clear the reset flag after successfully stopping +			 * the dma transfer and break from the loop +			 */  			dma_ctrl &= ~ACP_DMA_CNTL_0__DMAChRst_MASK;  			acp_reg_write(dma_ctrl, acp_mmio, mmACP_DMA_CNTL_0 -								+ ch_num); +				      + ch_num);  			break;  		}  		if (--count == 0) { @@ -450,7 +426,7 @@ static int acp_dma_stop(void __iomem *acp_mmio, u8 ch_num)  }  static void acp_set_sram_bank_state(void __iomem *acp_mmio, u16 bank, -					bool power_on) +				    bool power_on)  {  	u32 val, req_reg, sts_reg, sts_reg_mask;  	u32 loops = 1000; @@ -530,7 +506,7 @@ static int acp_init(void __iomem *acp_mmio, u32 asic_type)  	while (true) {  		val = acp_reg_read(acp_mmio, mmACP_STATUS); -		if (val & (u32) 0x1) +		if (val & (u32)0x1)  			break;  		if (--count == 0) {  			pr_err("Failed to reset ACP\n"); @@ -544,13 +520,20 @@ static int acp_init(void __iomem *acp_mmio, u32 asic_type)  	val &= ~ACP_SOFT_RESET__SoftResetAud_MASK;  	acp_reg_write(val, acp_mmio, mmACP_SOFT_RESET); +	/* For BT instance change pins from UART to BT */ +	if (!bt_uart_enable) { +		val = acp_reg_read(acp_mmio, mmACP_BT_UART_PAD_SEL); +		val |= ACP_BT_UART_PAD_SELECT_MASK; +		acp_reg_write(val, acp_mmio, mmACP_BT_UART_PAD_SEL); +	} +  	/* initiailize Onion control DAGB register */  	acp_reg_write(ACP_ONION_CNTL_DEFAULT, acp_mmio, -			mmACP_AXI2DAGB_ONION_CNTL); +		      mmACP_AXI2DAGB_ONION_CNTL);  	/* initiailize Garlic control DAGB registers */  	acp_reg_write(ACP_GARLIC_CNTL_DEFAULT, acp_mmio, -			mmACP_AXI2DAGB_GARLIC_CNTL); +		      mmACP_AXI2DAGB_GARLIC_CNTL);  	sram_pte_offset = ACP_DAGB_GRP_SRAM_BASE_ADDRESS |  			ACP_DAGB_BASE_ADDR_GRP_1__AXI2DAGBSnoopSel_MASK | @@ -558,17 +541,18 @@ static int acp_init(void __iomem *acp_mmio, u32 asic_type)  			ACP_DAGB_BASE_ADDR_GRP_1__AXI2DAGBGrpEnable_MASK;  	acp_reg_write(sram_pte_offset,  acp_mmio, mmACP_DAGB_BASE_ADDR_GRP_1);  	acp_reg_write(ACP_PAGE_SIZE_4K_ENABLE, acp_mmio, -			mmACP_DAGB_PAGE_SIZE_GRP_1); +		      mmACP_DAGB_PAGE_SIZE_GRP_1);  	acp_reg_write(ACP_SRAM_BASE_ADDRESS, acp_mmio, -			mmACP_DMA_DESC_BASE_ADDR); +		      mmACP_DMA_DESC_BASE_ADDR);  	/* Num of descriptiors in SRAM 0x4, means 256 descriptors;(64 * 4) */  	acp_reg_write(0x4, acp_mmio, mmACP_DMA_DESC_MAX_NUM_DSCR);  	acp_reg_write(ACP_EXTERNAL_INTR_CNTL__DMAIOCMask_MASK, -		acp_mmio, mmACP_EXTERNAL_INTR_CNTL); +		      acp_mmio, mmACP_EXTERNAL_INTR_CNTL); -       /* When ACP_TILE_P1 is turned on, all SRAM banks get turned on. +       /* +	* When ACP_TILE_P1 is turned on, all SRAM banks get turned on.  	* Now, turn off all of them. This can't be done in 'poweron' of  	* ACP pm domain, as this requires ACP to be initialized.  	* For Stoney, Memory gating is disabled,i.e SRAM Banks @@ -606,7 +590,7 @@ static int acp_deinit(void __iomem *acp_mmio)  		}  		udelay(100);  	} -	/** Disable ACP clock */ +	/* Disable ACP clock */  	val = acp_reg_read(acp_mmio, mmACP_CONTROL);  	val &= ~ACP_CONTROL__ClkEn_MASK;  	acp_reg_write(val, acp_mmio, mmACP_CONTROL); @@ -615,7 +599,7 @@ static int acp_deinit(void __iomem *acp_mmio)  	while (true) {  		val = acp_reg_read(acp_mmio, mmACP_STATUS); -		if (!(val & (u32) 0x1)) +		if (!(val & (u32)0x1))  			break;  		if (--count == 0) {  			pr_err("Failed to reset ACP\n"); @@ -629,7 +613,6 @@ static int acp_deinit(void __iomem *acp_mmio)  /* ACP DMA irq handler routine for playback, capture usecases */  static irqreturn_t dma_irq_handler(int irq, void *arg)  { -	u16 dscr_idx;  	u32 intr_flag, ext_intr_status;  	struct audio_drv_data *irq_data;  	void __iomem *acp_mmio; @@ -646,41 +629,45 @@ static irqreturn_t dma_irq_handler(int irq, void *arg)  	if ((intr_flag & BIT(ACP_TO_I2S_DMA_CH_NUM)) != 0) {  		valid_irq = true; -		if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_13) == -				PLAYBACK_START_DMA_DESCR_CH13) -			dscr_idx = PLAYBACK_END_DMA_DESCR_CH12; -		else -			dscr_idx = PLAYBACK_START_DMA_DESCR_CH12; -		config_acp_dma_channel(acp_mmio, SYSRAM_TO_ACP_CH_NUM, dscr_idx, -				       1, 0); -		acp_dma_start(acp_mmio, SYSRAM_TO_ACP_CH_NUM, false); -  		snd_pcm_period_elapsed(irq_data->play_i2ssp_stream); -  		acp_reg_write((intr_flag & BIT(ACP_TO_I2S_DMA_CH_NUM)) << 16, -				acp_mmio, mmACP_EXTERNAL_INTR_STAT); +			      acp_mmio, mmACP_EXTERNAL_INTR_STAT);  	} -	if ((intr_flag & BIT(I2S_TO_ACP_DMA_CH_NUM)) != 0) { +	if ((intr_flag & BIT(ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM)) != 0) {  		valid_irq = true; -		if (acp_reg_read(acp_mmio, mmACP_DMA_CUR_DSCR_15) == -				CAPTURE_START_DMA_DESCR_CH15) -			dscr_idx = CAPTURE_END_DMA_DESCR_CH14; -		else -			dscr_idx = CAPTURE_START_DMA_DESCR_CH14; -		config_acp_dma_channel(acp_mmio, ACP_TO_SYSRAM_CH_NUM, dscr_idx, -				       1, 0); -		acp_dma_start(acp_mmio, ACP_TO_SYSRAM_CH_NUM, false); +		snd_pcm_period_elapsed(irq_data->play_i2sbt_stream); +		acp_reg_write((intr_flag & +			      BIT(ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM)) << 16, +			      acp_mmio, mmACP_EXTERNAL_INTR_STAT); +	} +	if ((intr_flag & BIT(I2S_TO_ACP_DMA_CH_NUM)) != 0) { +		valid_irq = true; +		snd_pcm_period_elapsed(irq_data->capture_i2ssp_stream);  		acp_reg_write((intr_flag & BIT(I2S_TO_ACP_DMA_CH_NUM)) << 16, -				acp_mmio, mmACP_EXTERNAL_INTR_STAT); +			      acp_mmio, mmACP_EXTERNAL_INTR_STAT);  	}  	if ((intr_flag & BIT(ACP_TO_SYSRAM_CH_NUM)) != 0) {  		valid_irq = true; -		snd_pcm_period_elapsed(irq_data->capture_i2ssp_stream);  		acp_reg_write((intr_flag & BIT(ACP_TO_SYSRAM_CH_NUM)) << 16, -				acp_mmio, mmACP_EXTERNAL_INTR_STAT); +			      acp_mmio, mmACP_EXTERNAL_INTR_STAT); +	} + +	if ((intr_flag & BIT(I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM)) != 0) { +		valid_irq = true; +		snd_pcm_period_elapsed(irq_data->capture_i2sbt_stream); +		acp_reg_write((intr_flag & +			      BIT(I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM)) << 16, +			      acp_mmio, mmACP_EXTERNAL_INTR_STAT); +	} + +	if ((intr_flag & BIT(ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM)) != 0) { +		valid_irq = true; +		acp_reg_write((intr_flag & +			      BIT(ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM)) << 16, +			      acp_mmio, mmACP_EXTERNAL_INTR_STAT);  	}  	if (valid_irq) @@ -695,11 +682,12 @@ static int acp_dma_open(struct snd_pcm_substream *substream)  	int ret = 0;  	struct snd_pcm_runtime *runtime = substream->runtime;  	struct snd_soc_pcm_runtime *prtd = substream->private_data; -	struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd, DRV_NAME); +	struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd, +								    DRV_NAME);  	struct audio_drv_data *intr_data = dev_get_drvdata(component->dev);  	struct audio_substream_data *adata =  		kzalloc(sizeof(struct audio_substream_data), GFP_KERNEL); -	if (adata == NULL) +	if (!adata)  		return -ENOMEM;  	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { @@ -731,17 +719,19 @@ static int acp_dma_open(struct snd_pcm_substream *substream)  	adata->acp_mmio = intr_data->acp_mmio;  	runtime->private_data = adata; -	/* Enable ACP irq, when neither playback or capture streams are +	/* +	 * Enable ACP irq, when neither playback or capture streams are  	 * active by the time when a new stream is being opened.  	 * This enablement is not required for another stream, if current  	 * stream is not closed -	*/ -	if (!intr_data->play_i2ssp_stream && !intr_data->capture_i2ssp_stream) +	 */ +	if (!intr_data->play_i2ssp_stream && !intr_data->capture_i2ssp_stream && +	    !intr_data->play_i2sbt_stream && !intr_data->capture_i2sbt_stream)  		acp_reg_write(1, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB);  	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { -		intr_data->play_i2ssp_stream = substream; -		/* For Stoney, Memory gating is disabled,i.e SRAM Banks +		/* +		 * For Stoney, Memory gating is disabled,i.e SRAM Banks  		 * won't be turned off. The default state for SRAM banks is ON.  		 * Setting SRAM bank state code skipped for STONEY platform.  		 */ @@ -751,7 +741,6 @@ static int acp_dma_open(struct snd_pcm_substream *substream)  							bank, true);  		}  	} else { -		intr_data->capture_i2ssp_stream = substream;  		if (intr_data->asic_type != CHIP_STONEY) {  			for (bank = 5; bank <= 8; bank++)  				acp_set_sram_bank_state(intr_data->acp_mmio, @@ -772,8 +761,11 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,  	struct snd_pcm_runtime *runtime;  	struct audio_substream_data *rtd;  	struct snd_soc_pcm_runtime *prtd = substream->private_data; -	struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd, DRV_NAME); +	struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd, +								    DRV_NAME);  	struct audio_drv_data *adata = dev_get_drvdata(component->dev); +	struct snd_soc_card *card = prtd->card; +	struct acp_platform_info *pinfo = snd_soc_card_get_drvdata(card);  	runtime = substream->runtime;  	rtd = runtime->private_data; @@ -781,14 +773,111 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,  	if (WARN_ON(!rtd))  		return -EINVAL; +	rtd->i2s_instance = pinfo->i2s_instance;  	if (adata->asic_type == CHIP_STONEY) { -		val = acp_reg_read(adata->acp_mmio, mmACP_I2S_16BIT_RESOLUTION_EN); -		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) -			val |= ACP_I2S_SP_16BIT_RESOLUTION_EN; -		else -			val |= ACP_I2S_MIC_16BIT_RESOLUTION_EN; -		acp_reg_write(val, adata->acp_mmio, mmACP_I2S_16BIT_RESOLUTION_EN); +		val = acp_reg_read(adata->acp_mmio, +				   mmACP_I2S_16BIT_RESOLUTION_EN); +		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { +			switch (rtd->i2s_instance) { +			case I2S_BT_INSTANCE: +				val |= ACP_I2S_BT_16BIT_RESOLUTION_EN; +				break; +			case I2S_SP_INSTANCE: +			default: +				val |= ACP_I2S_SP_16BIT_RESOLUTION_EN; +			} +		} else { +			switch (rtd->i2s_instance) { +			case I2S_BT_INSTANCE: +				val |= ACP_I2S_BT_16BIT_RESOLUTION_EN; +				break; +			case I2S_SP_INSTANCE: +			default: +				val |= ACP_I2S_MIC_16BIT_RESOLUTION_EN; +			} +		} +		acp_reg_write(val, adata->acp_mmio, +			      mmACP_I2S_16BIT_RESOLUTION_EN); +	} + +	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { +		switch (rtd->i2s_instance) { +		case I2S_BT_INSTANCE: +			rtd->pte_offset = ACP_ST_BT_PLAYBACK_PTE_OFFSET; +			rtd->ch1 = SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM; +			rtd->ch2 = ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM; +			rtd->sram_bank = ACP_SRAM_BANK_3_ADDRESS; +			rtd->destination = TO_BLUETOOTH; +			rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH8; +			rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH9; +			rtd->byte_cnt_high_reg_offset = +					mmACP_I2S_BT_TRANSMIT_BYTE_CNT_HIGH; +			rtd->byte_cnt_low_reg_offset = +					mmACP_I2S_BT_TRANSMIT_BYTE_CNT_LOW; +			adata->play_i2sbt_stream = substream; +			break; +		case I2S_SP_INSTANCE: +		default: +			switch (adata->asic_type) { +			case CHIP_STONEY: +				rtd->pte_offset = ACP_ST_PLAYBACK_PTE_OFFSET; +				break; +			default: +				rtd->pte_offset = ACP_PLAYBACK_PTE_OFFSET; +			} +			rtd->ch1 = SYSRAM_TO_ACP_CH_NUM; +			rtd->ch2 = ACP_TO_I2S_DMA_CH_NUM; +			rtd->sram_bank = ACP_SRAM_BANK_1_ADDRESS; +			rtd->destination = TO_ACP_I2S_1; +			rtd->dma_dscr_idx_1 = PLAYBACK_START_DMA_DESCR_CH12; +			rtd->dma_dscr_idx_2 = PLAYBACK_START_DMA_DESCR_CH13; +			rtd->byte_cnt_high_reg_offset = +					mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH; +			rtd->byte_cnt_low_reg_offset = +					mmACP_I2S_TRANSMIT_BYTE_CNT_LOW; +			adata->play_i2ssp_stream = substream; +		} +	} else { +		switch (rtd->i2s_instance) { +		case I2S_BT_INSTANCE: +			rtd->pte_offset = ACP_ST_BT_CAPTURE_PTE_OFFSET; +			rtd->ch1 = ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM; +			rtd->ch2 = I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM; +			rtd->sram_bank = ACP_SRAM_BANK_4_ADDRESS; +			rtd->destination = FROM_BLUETOOTH; +			rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH10; +			rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH11; +			rtd->byte_cnt_high_reg_offset = +					mmACP_I2S_BT_RECEIVE_BYTE_CNT_HIGH; +			rtd->byte_cnt_low_reg_offset = +					mmACP_I2S_BT_RECEIVE_BYTE_CNT_LOW; +			adata->capture_i2sbt_stream = substream; +			break; +		case I2S_SP_INSTANCE: +		default: +			rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET; +			rtd->ch1 = ACP_TO_SYSRAM_CH_NUM; +			rtd->ch2 = I2S_TO_ACP_DMA_CH_NUM; +			switch (adata->asic_type) { +			case CHIP_STONEY: +				rtd->pte_offset = ACP_ST_CAPTURE_PTE_OFFSET; +				rtd->sram_bank = ACP_SRAM_BANK_2_ADDRESS; +				break; +			default: +				rtd->pte_offset = ACP_CAPTURE_PTE_OFFSET; +				rtd->sram_bank = ACP_SRAM_BANK_5_ADDRESS; +			} +			rtd->destination = FROM_ACP_I2S_1; +			rtd->dma_dscr_idx_1 = CAPTURE_START_DMA_DESCR_CH14; +			rtd->dma_dscr_idx_2 = CAPTURE_START_DMA_DESCR_CH15; +			rtd->byte_cnt_high_reg_offset = +					mmACP_I2S_RECEIVED_BYTE_CNT_HIGH; +			rtd->byte_cnt_low_reg_offset = +					mmACP_I2S_RECEIVED_BYTE_CNT_LOW; +			adata->capture_i2ssp_stream = substream; +		}  	} +  	size = params_buffer_bytes(params);  	status = snd_pcm_lib_malloc_pages(substream, size);  	if (status < 0) @@ -797,7 +886,7 @@ static int acp_dma_hw_params(struct snd_pcm_substream *substream,  	memset(substream->runtime->dma_area, 0, params_buffer_bytes(params));  	pg = virt_to_page(substream->dma_buffer.area); -	if (pg != NULL) { +	if (pg) {  		acp_set_sram_bank_state(rtd->acp_mmio, 0, true);  		/* Save for runtime private data */  		rtd->pg = pg; @@ -822,26 +911,15 @@ static int acp_dma_hw_free(struct snd_pcm_substream *substream)  	return snd_pcm_lib_free_pages(substream);  } -static u64 acp_get_byte_count(void __iomem *acp_mmio, int stream) +static u64 acp_get_byte_count(struct audio_substream_data *rtd)  { -	union acp_dma_count playback_dma_count; -	union acp_dma_count capture_dma_count; -	u64 bytescount = 0; +	union acp_dma_count byte_count; -	if (stream == SNDRV_PCM_STREAM_PLAYBACK) { -		playback_dma_count.bcount.high = acp_reg_read(acp_mmio, -					mmACP_I2S_TRANSMIT_BYTE_CNT_HIGH); -		playback_dma_count.bcount.low  = acp_reg_read(acp_mmio, -					mmACP_I2S_TRANSMIT_BYTE_CNT_LOW); -		bytescount = playback_dma_count.bytescount; -	} else { -		capture_dma_count.bcount.high = acp_reg_read(acp_mmio, -					mmACP_I2S_RECEIVED_BYTE_CNT_HIGH); -		capture_dma_count.bcount.low  = acp_reg_read(acp_mmio, -					mmACP_I2S_RECEIVED_BYTE_CNT_LOW); -		bytescount = capture_dma_count.bytescount; -	} -	return bytescount; +	byte_count.bcount.high = acp_reg_read(rtd->acp_mmio, +					      rtd->byte_cnt_high_reg_offset); +	byte_count.bcount.low  = acp_reg_read(rtd->acp_mmio, +					      rtd->byte_cnt_low_reg_offset); +	return byte_count.bytescount;  }  static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream) @@ -857,15 +935,10 @@ static snd_pcm_uframes_t acp_dma_pointer(struct snd_pcm_substream *substream)  		return -EINVAL;  	buffersize = frames_to_bytes(runtime, runtime->buffer_size); -	bytescount = acp_get_byte_count(rtd->acp_mmio, substream->stream); +	bytescount = acp_get_byte_count(rtd); -	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { -		if (bytescount > rtd->i2ssp_renderbytescount) -			bytescount = bytescount - rtd->i2ssp_renderbytescount; -	} else { -		if (bytescount > rtd->i2ssp_capturebytescount) -			bytescount = bytescount - rtd->i2ssp_capturebytescount; -	} +	if (bytescount > rtd->bytescount) +		bytescount -= rtd->bytescount;  	pos = do_div(bytescount, buffersize);  	return bytes_to_frames(runtime, pos);  } @@ -883,34 +956,25 @@ static int acp_dma_prepare(struct snd_pcm_substream *substream)  	if (!rtd)  		return -EINVAL; -	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { -		config_acp_dma_channel(rtd->acp_mmio, SYSRAM_TO_ACP_CH_NUM, -					PLAYBACK_START_DMA_DESCR_CH12, -					NUM_DSCRS_PER_CHANNEL, 0); -		config_acp_dma_channel(rtd->acp_mmio, ACP_TO_I2S_DMA_CH_NUM, -					PLAYBACK_START_DMA_DESCR_CH13, -					NUM_DSCRS_PER_CHANNEL, 0); -	} else { -		config_acp_dma_channel(rtd->acp_mmio, ACP_TO_SYSRAM_CH_NUM, -					CAPTURE_START_DMA_DESCR_CH14, -					NUM_DSCRS_PER_CHANNEL, 0); -		config_acp_dma_channel(rtd->acp_mmio, I2S_TO_ACP_DMA_CH_NUM, -					CAPTURE_START_DMA_DESCR_CH15, -					NUM_DSCRS_PER_CHANNEL, 0); -	} + +	config_acp_dma_channel(rtd->acp_mmio, +			       rtd->ch1, +			       rtd->dma_dscr_idx_1, +			       NUM_DSCRS_PER_CHANNEL, 0); +	config_acp_dma_channel(rtd->acp_mmio, +			       rtd->ch2, +			       rtd->dma_dscr_idx_2, +			       NUM_DSCRS_PER_CHANNEL, 0);  	return 0;  }  static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)  {  	int ret; -	u32 loops = 4000;  	u64 bytescount = 0;  	struct snd_pcm_runtime *runtime = substream->runtime; -	struct snd_soc_pcm_runtime *prtd = substream->private_data;  	struct audio_substream_data *rtd = runtime->private_data; -	struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd, DRV_NAME);  	if (!rtd)  		return -EINVAL; @@ -918,59 +982,40 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)  	case SNDRV_PCM_TRIGGER_START:  	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:  	case SNDRV_PCM_TRIGGER_RESUME: -		bytescount = acp_get_byte_count(rtd->acp_mmio, -						substream->stream); +		bytescount = acp_get_byte_count(rtd); +		if (rtd->bytescount == 0) +			rtd->bytescount = bytescount;  		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { -			if (rtd->i2ssp_renderbytescount == 0) -				rtd->i2ssp_renderbytescount = bytescount; -			acp_dma_start(rtd->acp_mmio, -						SYSRAM_TO_ACP_CH_NUM, false); -			while (acp_reg_read(rtd->acp_mmio, mmACP_DMA_CH_STS) & -						BIT(SYSRAM_TO_ACP_CH_NUM)) { -				if (!loops--) { -					dev_err(component->dev, -						"acp dma start timeout\n"); -					return -ETIMEDOUT; -				} -				cpu_relax(); -			} - -			acp_dma_start(rtd->acp_mmio, -					ACP_TO_I2S_DMA_CH_NUM, true); - +			acp_dma_start(rtd->acp_mmio, rtd->ch1); +			acp_dma_start(rtd->acp_mmio, rtd->ch2);  		} else { -			if (rtd->i2ssp_capturebytescount == 0) -				rtd->i2ssp_capturebytescount = bytescount; -			acp_dma_start(rtd->acp_mmio, -					    I2S_TO_ACP_DMA_CH_NUM, true); +			acp_dma_start(rtd->acp_mmio, rtd->ch2); +			acp_dma_start(rtd->acp_mmio, rtd->ch1);  		}  		ret = 0;  		break;  	case SNDRV_PCM_TRIGGER_STOP:  	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:  	case SNDRV_PCM_TRIGGER_SUSPEND: -		/* Need to stop only circular DMA channels : -		 * ACP_TO_I2S_DMA_CH_NUM / I2S_TO_ACP_DMA_CH_NUM. Non-circular -		 * channels will stopped automatically after its transfer -		 * completes : SYSRAM_TO_ACP_CH_NUM / ACP_TO_SYSRAM_CH_NUM +		/* For playback, non circular dma should be stopped first +		 * i.e Sysram to acp dma transfer channel(rtd->ch1) should be +		 * stopped before stopping cirular dma which is acp sram to i2s +		 * fifo dma transfer channel(rtd->ch2). Where as in Capture +		 * scenario, i2s fifo to acp sram dma channel(rtd->ch2) stopped +		 * first before stopping acp sram to sysram which is circular +		 * dma(rtd->ch1).  		 */  		if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { -			ret = acp_dma_stop(rtd->acp_mmio, -						SYSRAM_TO_ACP_CH_NUM); -			ret = acp_dma_stop(rtd->acp_mmio, -					ACP_TO_I2S_DMA_CH_NUM); -			rtd->i2ssp_renderbytescount = 0; +			acp_dma_stop(rtd->acp_mmio, rtd->ch1); +			ret =  acp_dma_stop(rtd->acp_mmio, rtd->ch2);  		} else { -			ret = acp_dma_stop(rtd->acp_mmio, -					I2S_TO_ACP_DMA_CH_NUM); -			ret = acp_dma_stop(rtd->acp_mmio, -						ACP_TO_SYSRAM_CH_NUM); -			rtd->i2ssp_capturebytescount = 0; +			acp_dma_stop(rtd->acp_mmio, rtd->ch2); +			ret = acp_dma_stop(rtd->acp_mmio, rtd->ch1);  		} +		rtd->bytescount = 0;  		break;  	default:  		ret = -EINVAL; -  	}  	return ret;  } @@ -978,26 +1023,27 @@ static int acp_dma_trigger(struct snd_pcm_substream *substream, int cmd)  static int acp_dma_new(struct snd_soc_pcm_runtime *rtd)  {  	int ret; -	struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd, DRV_NAME); +	struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd, +								    DRV_NAME);  	struct audio_drv_data *adata = dev_get_drvdata(component->dev);  	switch (adata->asic_type) {  	case CHIP_STONEY:  		ret = snd_pcm_lib_preallocate_pages_for_all(rtd->pcm, -							SNDRV_DMA_TYPE_DEV, -							NULL, ST_MIN_BUFFER, -							ST_MAX_BUFFER); +							    SNDRV_DMA_TYPE_DEV, +							    NULL, ST_MIN_BUFFER, +							    ST_MAX_BUFFER);  		break;  	default:  		ret = snd_pcm_lib_preallocate_pages_for_all(rtd->pcm, -							SNDRV_DMA_TYPE_DEV, -							NULL, MIN_BUFFER, -							MAX_BUFFER); +							    SNDRV_DMA_TYPE_DEV, +							    NULL, MIN_BUFFER, +							    MAX_BUFFER);  		break;  	}  	if (ret < 0)  		dev_err(component->dev, -				"buffer preallocation failer error:%d\n", ret); +			"buffer preallocation failure error:%d\n", ret);  	return ret;  } @@ -1007,38 +1053,55 @@ static int acp_dma_close(struct snd_pcm_substream *substream)  	struct snd_pcm_runtime *runtime = substream->runtime;  	struct audio_substream_data *rtd = runtime->private_data;  	struct snd_soc_pcm_runtime *prtd = substream->private_data; -	struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd, DRV_NAME); +	struct snd_soc_component *component = snd_soc_rtdcom_lookup(prtd, +								    DRV_NAME);  	struct audio_drv_data *adata = dev_get_drvdata(component->dev); -	kfree(rtd); -  	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) { -		adata->play_i2ssp_stream = NULL; -		/* For Stoney, Memory gating is disabled,i.e SRAM Banks -		 * won't be turned off. The default state for SRAM banks is ON. -		 * Setting SRAM bank state code skipped for STONEY platform. -		 * added condition checks for Carrizo platform only -		 */ -		if (adata->asic_type != CHIP_STONEY) { -			for (bank = 1; bank <= 4; bank++) -				acp_set_sram_bank_state(adata->acp_mmio, bank, -				false); +		switch (rtd->i2s_instance) { +		case I2S_BT_INSTANCE: +			adata->play_i2sbt_stream = NULL; +			break; +		case I2S_SP_INSTANCE: +		default: +			adata->play_i2ssp_stream = NULL; +			/* +			 * For Stoney, Memory gating is disabled,i.e SRAM Banks +			 * won't be turned off. The default state for SRAM banks +			 * is ON.Setting SRAM bank state code skipped for STONEY +			 * platform. Added condition checks for Carrizo platform +			 * only. +			 */ +			if (adata->asic_type != CHIP_STONEY) { +				for (bank = 1; bank <= 4; bank++) +					acp_set_sram_bank_state(adata->acp_mmio, +								bank, false); +			}  		}  	} else  { -		adata->capture_i2ssp_stream = NULL; -		if (adata->asic_type != CHIP_STONEY) { -			for (bank = 5; bank <= 8; bank++) -				acp_set_sram_bank_state(adata->acp_mmio, bank, -						     false); +		switch (rtd->i2s_instance) { +		case I2S_BT_INSTANCE: +			adata->capture_i2sbt_stream = NULL; +			break; +		case I2S_SP_INSTANCE: +		default: +			adata->capture_i2ssp_stream = NULL; +			if (adata->asic_type != CHIP_STONEY) { +				for (bank = 5; bank <= 8; bank++) +					acp_set_sram_bank_state(adata->acp_mmio, +								bank, false); +			}  		}  	} -	/* Disable ACP irq, when the current stream is being closed and +	/* +	 * Disable ACP irq, when the current stream is being closed and  	 * another stream is also not active. -	*/ -	if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream) +	 */ +	if (!adata->play_i2ssp_stream && !adata->capture_i2ssp_stream && +	    !adata->play_i2sbt_stream && !adata->capture_i2sbt_stream)  		acp_reg_write(0, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB); - +	kfree(rtd);  	return 0;  } @@ -1054,7 +1117,7 @@ static const struct snd_pcm_ops acp_dma_ops = {  	.prepare = acp_dma_prepare,  }; -static struct snd_soc_component_driver acp_asoc_platform = { +static const struct snd_soc_component_driver acp_asoc_platform = {  	.name = DRV_NAME,  	.ops = &acp_dma_ops,  	.pcm_new = acp_dma_new, @@ -1073,8 +1136,8 @@ static int acp_audio_probe(struct platform_device *pdev)  	}  	audio_drv_data = devm_kzalloc(&pdev->dev, sizeof(struct audio_drv_data), -					GFP_KERNEL); -	if (audio_drv_data == NULL) +				      GFP_KERNEL); +	if (!audio_drv_data)  		return -ENOMEM;  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0); @@ -1082,13 +1145,16 @@ static int acp_audio_probe(struct platform_device *pdev)  	if (IS_ERR(audio_drv_data->acp_mmio))  		return PTR_ERR(audio_drv_data->acp_mmio); -	/* The following members gets populated in device 'open' +	/* +	 * The following members gets populated in device 'open'  	 * function. Till then interrupts are disabled in 'acp_init'  	 * and device doesn't generate any interrupts.  	 */  	audio_drv_data->play_i2ssp_stream = NULL;  	audio_drv_data->capture_i2ssp_stream = NULL; +	audio_drv_data->play_i2sbt_stream = NULL; +	audio_drv_data->capture_i2sbt_stream = NULL;  	audio_drv_data->asic_type =  *pdata; @@ -1099,7 +1165,7 @@ static int acp_audio_probe(struct platform_device *pdev)  	}  	status = devm_request_irq(&pdev->dev, res->start, dma_irq_handler, -					0, "ACP_IRQ", &pdev->dev); +				  0, "ACP_IRQ", &pdev->dev);  	if (status) {  		dev_err(&pdev->dev, "ACP IRQ request failed\n");  		return status; @@ -1115,7 +1181,7 @@ static int acp_audio_probe(struct platform_device *pdev)  	}  	status = devm_snd_soc_register_component(&pdev->dev, -						&acp_asoc_platform, NULL, 0); +						 &acp_asoc_platform, NULL, 0);  	if (status != 0) {  		dev_err(&pdev->dev, "Fail to register ALSA platform device\n");  		return status; @@ -1145,6 +1211,7 @@ static int acp_pcm_resume(struct device *dev)  {  	u16 bank;  	int status; +	struct audio_substream_data *rtd;  	struct audio_drv_data *adata = dev_get_drvdata(dev);  	status = acp_init(adata->acp_mmio, adata->asic_type); @@ -1154,28 +1221,40 @@ static int acp_pcm_resume(struct device *dev)  	}  	if (adata->play_i2ssp_stream && adata->play_i2ssp_stream->runtime) { -		/* For Stoney, Memory gating is disabled,i.e SRAM Banks +		/* +		 * For Stoney, Memory gating is disabled,i.e SRAM Banks  		 * won't be turned off. The default state for SRAM banks is ON.  		 * Setting SRAM bank state code skipped for STONEY platform.  		 */  		if (adata->asic_type != CHIP_STONEY) {  			for (bank = 1; bank <= 4; bank++)  				acp_set_sram_bank_state(adata->acp_mmio, bank, -						true); +							true);  		} -		config_acp_dma(adata->acp_mmio, -			adata->play_i2ssp_stream->runtime->private_data, -			adata->asic_type); +		rtd = adata->play_i2ssp_stream->runtime->private_data; +		config_acp_dma(adata->acp_mmio, rtd, adata->asic_type);  	} -	if (adata->capture_i2ssp_stream && adata->capture_i2ssp_stream->runtime) { +	if (adata->capture_i2ssp_stream && +	    adata->capture_i2ssp_stream->runtime) {  		if (adata->asic_type != CHIP_STONEY) {  			for (bank = 5; bank <= 8; bank++)  				acp_set_sram_bank_state(adata->acp_mmio, bank, -						true); +							true); +		} +		rtd =  adata->capture_i2ssp_stream->runtime->private_data; +		config_acp_dma(adata->acp_mmio, rtd, adata->asic_type); +	} +	if (adata->asic_type != CHIP_CARRIZO) { +		if (adata->play_i2sbt_stream && +		    adata->play_i2sbt_stream->runtime) { +			rtd = adata->play_i2sbt_stream->runtime->private_data; +			config_acp_dma(adata->acp_mmio, rtd, adata->asic_type); +		} +		if (adata->capture_i2sbt_stream && +		    adata->capture_i2sbt_stream->runtime) { +			rtd = adata->capture_i2sbt_stream->runtime->private_data; +			config_acp_dma(adata->acp_mmio, rtd, adata->asic_type);  		} -		config_acp_dma(adata->acp_mmio, -			adata->capture_i2ssp_stream->runtime->private_data, -			adata->asic_type);  	}  	acp_reg_write(1, adata->acp_mmio, mmACP_EXTERNAL_INTR_ENB);  	return 0; diff --git a/sound/soc/amd/acp.h b/sound/soc/amd/acp.h index ba01510eb818..9cd3e96c84d4 100644 --- a/sound/soc/amd/acp.h +++ b/sound/soc/amd/acp.h @@ -10,17 +10,30 @@  #define ACP_PLAYBACK_PTE_OFFSET			10  #define ACP_CAPTURE_PTE_OFFSET			0 +/* Playback and Capture Offset for Stoney */ +#define ACP_ST_PLAYBACK_PTE_OFFSET	0x04 +#define ACP_ST_CAPTURE_PTE_OFFSET	0x00 +#define ACP_ST_BT_PLAYBACK_PTE_OFFSET	0x08 +#define ACP_ST_BT_CAPTURE_PTE_OFFSET	0x0c +  #define ACP_GARLIC_CNTL_DEFAULT			0x00000FB4  #define ACP_ONION_CNTL_DEFAULT			0x00000FB4  #define ACP_PHYSICAL_BASE			0x14000 -/* Playback SRAM address (as a destination in dma descriptor) */ -#define ACP_SHARED_RAM_BANK_1_ADDRESS		0x4002000 - -/* Capture SRAM address (as a source in dma descriptor) */ -#define ACP_SHARED_RAM_BANK_5_ADDRESS		0x400A000 -#define ACP_SHARED_RAM_BANK_3_ADDRESS		0x4006000 +/* + * In case of I2S SP controller instance, Stoney uses SRAM bank 1 for + * playback and SRAM Bank 2 for capture where as in case of BT I2S + * Instance, Stoney uses SRAM Bank 3 for playback & SRAM Bank 4 will + * be used for capture. Carrizo uses I2S SP controller instance. SRAM Banks + * 1, 2, 3, 4 will be used for playback & SRAM Banks 5, 6, 7, 8 will be used + * for capture scenario. + */ +#define ACP_SRAM_BANK_1_ADDRESS		0x4002000 +#define ACP_SRAM_BANK_2_ADDRESS		0x4004000 +#define ACP_SRAM_BANK_3_ADDRESS		0x4006000 +#define ACP_SRAM_BANK_4_ADDRESS		0x4008000 +#define ACP_SRAM_BANK_5_ADDRESS		0x400A000  #define ACP_DMA_RESET_TIME			10000  #define ACP_CLOCK_EN_TIME_OUT_VALUE		0x000000FF @@ -35,8 +48,13 @@  #define TO_ACP_I2S_1   0x2  #define TO_ACP_I2S_2   0x4 +#define TO_BLUETOOTH   0x3  #define FROM_ACP_I2S_1 0xa  #define FROM_ACP_I2S_2 0xb +#define FROM_BLUETOOTH 0xb + +#define I2S_SP_INSTANCE                 0x01 +#define I2S_BT_INSTANCE                 0x02  #define ACP_TILE_ON_MASK                0x03  #define ACP_TILE_OFF_MASK               0x02 @@ -57,6 +75,14 @@  #define ACP_TO_SYSRAM_CH_NUM 14  #define I2S_TO_ACP_DMA_CH_NUM 15 +/* Playback DMA Channels for I2S BT instance */ +#define SYSRAM_TO_ACP_BT_INSTANCE_CH_NUM  8 +#define ACP_TO_I2S_DMA_BT_INSTANCE_CH_NUM 9 + +/* Capture DMA Channels for I2S BT Instance */ +#define ACP_TO_SYSRAM_BT_INSTANCE_CH_NUM 10 +#define I2S_TO_ACP_DMA_BT_INSTANCE_CH_NUM 11 +  #define NUM_DSCRS_PER_CHANNEL 2  #define PLAYBACK_START_DMA_DESCR_CH12 0 @@ -69,9 +95,23 @@  #define CAPTURE_START_DMA_DESCR_CH15 6  #define CAPTURE_END_DMA_DESCR_CH15 7 +/* I2S BT Instance DMA Descriptors */ +#define PLAYBACK_START_DMA_DESCR_CH8 8 +#define PLAYBACK_END_DMA_DESCR_CH8 9 +#define PLAYBACK_START_DMA_DESCR_CH9 10 +#define PLAYBACK_END_DMA_DESCR_CH9 11 + +#define CAPTURE_START_DMA_DESCR_CH10 12 +#define CAPTURE_END_DMA_DESCR_CH10 13 +#define CAPTURE_START_DMA_DESCR_CH11 14 +#define CAPTURE_END_DMA_DESCR_CH11 15 +  #define mmACP_I2S_16BIT_RESOLUTION_EN       0x5209  #define ACP_I2S_MIC_16BIT_RESOLUTION_EN 0x01  #define ACP_I2S_SP_16BIT_RESOLUTION_EN	0x02 +#define ACP_I2S_BT_16BIT_RESOLUTION_EN	0x04 +#define ACP_BT_UART_PAD_SELECT_MASK	0x1 +  enum acp_dma_priority_level {  	/* 0x0 Specifies the DMA channel is given normal priority */  	ACP_DMA_PRIORITY_LEVEL_NORMAL = 0x0, @@ -84,20 +124,39 @@ struct audio_substream_data {  	struct page *pg;  	unsigned int order;  	u16 num_of_pages; +	u16 i2s_instance;  	u16 direction; +	u16 ch1; +	u16 ch2; +	u16 destination; +	u16 dma_dscr_idx_1; +	u16 dma_dscr_idx_2; +	u32 pte_offset; +	u32 sram_bank; +	u32 byte_cnt_high_reg_offset; +	u32 byte_cnt_low_reg_offset;  	uint64_t size; -	u64 i2ssp_renderbytescount; -	u64 i2ssp_capturebytescount; +	u64 bytescount;  	void __iomem *acp_mmio;  };  struct audio_drv_data {  	struct snd_pcm_substream *play_i2ssp_stream;  	struct snd_pcm_substream *capture_i2ssp_stream; +	struct snd_pcm_substream *play_i2sbt_stream; +	struct snd_pcm_substream *capture_i2sbt_stream;  	void __iomem *acp_mmio;  	u32 asic_type;  }; +/* + * this structure used for platform data transfer between machine driver + * and dma driver + */ +struct acp_platform_info { +	u16 i2s_instance; +}; +  union acp_dma_count {  	struct {  	u32 low; @@ -115,23 +174,25 @@ enum {  };  enum { -	ACP_DMA_ATTRIBUTES_SHAREDMEM_TO_DAGB_ONION = 0x0, -	ACP_DMA_ATTRIBUTES_SHARED_MEM_TO_DAGB_GARLIC = 0x1, -	ACP_DMA_ATTRIBUTES_DAGB_ONION_TO_SHAREDMEM = 0x8, -	ACP_DMA_ATTRIBUTES_DAGB_GARLIC_TO_SHAREDMEM = 0x9, -	ACP_DMA_ATTRIBUTES_FORCE_SIZE = 0xF +	ACP_DMA_ATTR_SHAREDMEM_TO_DAGB_ONION = 0x0, +	ACP_DMA_ATTR_SHARED_MEM_TO_DAGB_GARLIC = 0x1, +	ACP_DMA_ATTR_DAGB_ONION_TO_SHAREDMEM = 0x8, +	ACP_DMA_ATTR_DAGB_GARLIC_TO_SHAREDMEM = 0x9, +	ACP_DMA_ATTR_FORCE_SIZE = 0xF  };  typedef struct acp_dma_dscr_transfer {  	/* Specifies the source memory location for the DMA data transfer. */  	u32 src; -	/* Specifies the destination memory location to where the data will +	/* +	 * Specifies the destination memory location to where the data will  	 * be transferred. -	*/ +	 */  	u32 dest; -	/* Specifies the number of bytes need to be transferred -	* from source to destination memory.Transfer direction & IOC enable -	*/ +	/* +	 * Specifies the number of bytes need to be transferred +	 * from source to destination memory.Transfer direction & IOC enable +	 */  	u32 xfer_val;  	/* Reserved for future use */  	u32 reserved; |