diff options
Diffstat (limited to 'net/packet/af_packet.c')
| -rw-r--r-- | net/packet/af_packet.c | 15 | 
1 files changed, 11 insertions, 4 deletions
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 82a50e850245..118cd66b7516 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -544,7 +544,8 @@ static int prb_calc_retire_blk_tmo(struct packet_sock *po,  			msec = 1;  			div = ecmd.base.speed / 1000;  		} -	} +	} else +		return DEFAULT_PRB_RETIRE_TOV;  	mbits = (blk_size_in_bytes * 8) / (1024 * 1024); @@ -1295,15 +1296,21 @@ static void packet_sock_destruct(struct sock *sk)  static bool fanout_flow_is_huge(struct packet_sock *po, struct sk_buff *skb)  { -	u32 rxhash; +	u32 *history = po->rollover->history; +	u32 victim, rxhash;  	int i, count = 0;  	rxhash = skb_get_hash(skb);  	for (i = 0; i < ROLLOVER_HLEN; i++) -		if (po->rollover->history[i] == rxhash) +		if (READ_ONCE(history[i]) == rxhash)  			count++; -	po->rollover->history[prandom_u32() % ROLLOVER_HLEN] = rxhash; +	victim = prandom_u32() % ROLLOVER_HLEN; + +	/* Avoid dirtying the cache line if possible */ +	if (READ_ONCE(history[victim]) != rxhash) +		WRITE_ONCE(history[victim], rxhash); +  	return count > (ROLLOVER_HLEN >> 1);  }  |