diff options
Diffstat (limited to 'drivers/hwmon')
| -rw-r--r-- | drivers/hwmon/aspeed-pwm-tacho.c | 2 | ||||
| -rw-r--r-- | drivers/hwmon/asus_atk0110.c | 4 | ||||
| -rw-r--r-- | drivers/hwmon/hwmon.c | 28 | ||||
| -rw-r--r-- | drivers/hwmon/ibmaem.c | 2 | ||||
| -rw-r--r-- | drivers/hwmon/ibmpex.c | 2 | ||||
| -rw-r--r-- | drivers/hwmon/ibmpowernv.c | 10 | ||||
| -rw-r--r-- | drivers/hwmon/iio_hwmon.c | 16 | ||||
| -rw-r--r-- | drivers/hwmon/ina3221.c | 592 | ||||
| -rw-r--r-- | drivers/hwmon/k10temp.c | 5 | ||||
| -rw-r--r-- | drivers/hwmon/lm75.c | 21 | ||||
| -rw-r--r-- | drivers/hwmon/lm92.c | 14 | ||||
| -rw-r--r-- | drivers/hwmon/lm95245.c | 3 | ||||
| -rw-r--r-- | drivers/hwmon/mc13783-adc.c | 14 | ||||
| -rw-r--r-- | drivers/hwmon/nct6775.c | 302 | ||||
| -rw-r--r-- | drivers/hwmon/npcm750-pwm-fan.c | 4 | ||||
| -rw-r--r-- | drivers/hwmon/pmbus/Kconfig | 18 | ||||
| -rw-r--r-- | drivers/hwmon/pmbus/ltc2978.c | 9 | ||||
| -rw-r--r-- | drivers/hwmon/pmbus/pmbus.c | 2 | ||||
| -rw-r--r-- | drivers/hwmon/pmbus/pmbus_core.c | 5 | ||||
| -rw-r--r-- | drivers/hwmon/pwm-fan.c | 20 | ||||
| -rw-r--r-- | drivers/hwmon/scmi-hwmon.c | 2 | ||||
| -rw-r--r-- | drivers/hwmon/scpi-hwmon.c | 4 | ||||
| -rw-r--r-- | drivers/hwmon/sht15.c | 5 | ||||
| -rw-r--r-- | drivers/hwmon/tmp102.c | 3 | ||||
| -rw-r--r-- | drivers/hwmon/tmp108.c | 3 | ||||
| -rw-r--r-- | drivers/hwmon/tmp421.c | 6 | 
26 files changed, 735 insertions, 361 deletions
| diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c index 5e449eac788a..92de8139d398 100644 --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -852,7 +852,7 @@ static int aspeed_create_pwm_cooling(struct device *dev,  		dev_err(dev, "Property 'cooling-levels' cannot be read.\n");  		return ret;  	} -	snprintf(cdev->name, MAX_CDEV_NAME_LEN, "%s%d", child->name, pwm_port); +	snprintf(cdev->name, MAX_CDEV_NAME_LEN, "%pOFn%d", child, pwm_port);  	cdev->tcdev = thermal_of_cooling_device_register(child,  							 cdev->name, diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c index a6636fe42189..a7cf00885c5d 100644 --- a/drivers/hwmon/asus_atk0110.c +++ b/drivers/hwmon/asus_atk0110.c @@ -1210,10 +1210,8 @@ static int atk_register_hwmon(struct atk_data *data)  	data->hwmon_dev = hwmon_device_register_with_groups(dev, "atk0110",  							    data,  							    data->attr_groups); -	if (IS_ERR(data->hwmon_dev)) -		return PTR_ERR(data->hwmon_dev); -	return 0; +	return PTR_ERR_OR_ZERO(data->hwmon_dev);  }  static int atk_probe_if(struct atk_data *data) diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c index 33d51281272b..975c95169884 100644 --- a/drivers/hwmon/hwmon.c +++ b/drivers/hwmon/hwmon.c @@ -24,6 +24,9 @@  #include <linux/string.h>  #include <linux/thermal.h> +#define CREATE_TRACE_POINTS +#include <trace/events/hwmon.h> +  #define HWMON_ID_PREFIX "hwmon"  #define HWMON_ID_FORMAT HWMON_ID_PREFIX "%d" @@ -171,6 +174,13 @@ static int hwmon_thermal_add_sensor(struct device *dev,  }  #endif /* IS_REACHABLE(CONFIG_THERMAL) && ... */ +static int hwmon_attr_base(enum hwmon_sensor_types type) +{ +	if (type == hwmon_in) +		return 0; +	return 1; +} +  /* sysfs attribute management */  static ssize_t hwmon_attr_show(struct device *dev, @@ -185,6 +195,9 @@ static ssize_t hwmon_attr_show(struct device *dev,  	if (ret < 0)  		return ret; +	trace_hwmon_attr_show(hattr->index + hwmon_attr_base(hattr->type), +			      hattr->name, val); +  	return sprintf(buf, "%ld\n", val);  } @@ -193,6 +206,7 @@ static ssize_t hwmon_attr_show_string(struct device *dev,  				      char *buf)  {  	struct hwmon_device_attribute *hattr = to_hwmon_attr(devattr); +	enum hwmon_sensor_types type = hattr->type;  	const char *s;  	int ret; @@ -201,6 +215,9 @@ static ssize_t hwmon_attr_show_string(struct device *dev,  	if (ret < 0)  		return ret; +	trace_hwmon_attr_show_string(hattr->index + hwmon_attr_base(type), +				     hattr->name, s); +  	return sprintf(buf, "%s\n", s);  } @@ -221,14 +238,10 @@ static ssize_t hwmon_attr_store(struct device *dev,  	if (ret < 0)  		return ret; -	return count; -} +	trace_hwmon_attr_store(hattr->index + hwmon_attr_base(hattr->type), +			       hattr->name, val); -static int hwmon_attr_base(enum hwmon_sensor_types type) -{ -	if (type == hwmon_in) -		return 0; -	return 1; +	return count;  }  static bool is_string_attr(enum hwmon_sensor_types type, u32 attr) @@ -356,6 +369,7 @@ static const char * const hwmon_in_attr_templates[] = {  	[hwmon_in_max_alarm] = "in%d_max_alarm",  	[hwmon_in_lcrit_alarm] = "in%d_lcrit_alarm",  	[hwmon_in_crit_alarm] = "in%d_crit_alarm", +	[hwmon_in_enable] = "in%d_enable",  };  static const char * const hwmon_curr_attr_templates[] = { diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c index 1f643782ce04..9e92673f6913 100644 --- a/drivers/hwmon/ibmaem.c +++ b/drivers/hwmon/ibmaem.c @@ -101,7 +101,7 @@ static struct platform_driver aem_driver = {  struct aem_ipmi_data {  	struct completion	read_complete;  	struct ipmi_addr	address; -	ipmi_user_t		user; +	struct ipmi_user	*user;  	int			interface;  	struct kernel_ipmi_msg	tx_message; diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c index ab72cabf5a95..bb17a29af64c 100644 --- a/drivers/hwmon/ibmpex.c +++ b/drivers/hwmon/ibmpex.c @@ -84,7 +84,7 @@ struct ibmpex_bmc_data {  	struct ipmi_addr	address;  	struct completion	read_complete; -	ipmi_user_t		user; +	struct ipmi_user	*user;  	int			interface;  	struct kernel_ipmi_msg	tx_message; diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c index 83472808c816..0ccca87f5271 100644 --- a/drivers/hwmon/ibmpowernv.c +++ b/drivers/hwmon/ibmpowernv.c @@ -458,9 +458,6 @@ static int populate_attr_groups(struct platform_device *pdev)  	for_each_child_of_node(opal, np) {  		const char *label; -		if (np->name == NULL) -			continue; -  		type = get_sensor_type(np);  		if (type == MAX_SENSOR_TYPE)  			continue; @@ -589,9 +586,6 @@ static int create_device_attrs(struct platform_device *pdev)  		const char *label;  		enum sensors type; -		if (np->name == NULL) -			continue; -  		type = get_sensor_type(np);  		if (type == MAX_SENSOR_TYPE)  			continue; @@ -603,8 +597,8 @@ static int create_device_attrs(struct platform_device *pdev)  		if (of_property_read_u32(np, "sensor-id", &sensor_id) &&  		    of_property_read_u32(np, "sensor-data", &sensor_id)) {  			dev_info(&pdev->dev, -				 "'sensor-id' missing in the node '%s'\n", -				 np->name); +				 "'sensor-id' missing in the node '%pOFn'\n", +				 np);  			continue;  		} diff --git a/drivers/hwmon/iio_hwmon.c b/drivers/hwmon/iio_hwmon.c index 2f3f875c06ac..eed66e533ee2 100644 --- a/drivers/hwmon/iio_hwmon.c +++ b/drivers/hwmon/iio_hwmon.c @@ -65,13 +65,9 @@ static int iio_hwmon_probe(struct platform_device *pdev)  	int in_i = 1, temp_i = 1, curr_i = 1, humidity_i = 1;  	enum iio_chan_type type;  	struct iio_channel *channels; -	const char *name = "iio_hwmon";  	struct device *hwmon_dev;  	char *sname; -	if (dev->of_node && dev->of_node->name) -		name = dev->of_node->name; -  	channels = devm_iio_channel_get_all(dev);  	if (IS_ERR(channels)) {  		if (PTR_ERR(channels) == -ENODEV) @@ -141,11 +137,15 @@ static int iio_hwmon_probe(struct platform_device *pdev)  	st->attr_group.attrs = st->attrs;  	st->groups[0] = &st->attr_group; -	sname = devm_kstrdup(dev, name, GFP_KERNEL); -	if (!sname) -		return -ENOMEM; +	if (dev->of_node) { +		sname = devm_kasprintf(dev, GFP_KERNEL, "%pOFn", dev->of_node); +		if (!sname) +			return -ENOMEM; +		strreplace(sname, '-', '_'); +	} else { +		sname = "iio_hwmon"; +	} -	strreplace(sname, '-', '_');  	hwmon_dev = devm_hwmon_device_register_with_groups(dev, sname, st,  							   st->groups);  	return PTR_ERR_OR_ZERO(hwmon_dev); diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c index e6b49500c52a..d61688f04594 100644 --- a/drivers/hwmon/ina3221.c +++ b/drivers/hwmon/ina3221.c @@ -38,9 +38,12 @@  #define INA3221_WARN3			0x0c  #define INA3221_MASK_ENABLE		0x0f -#define INA3221_CONFIG_MODE_SHUNT	BIT(1) -#define INA3221_CONFIG_MODE_BUS		BIT(2) -#define INA3221_CONFIG_MODE_CONTINUOUS	BIT(3) +#define INA3221_CONFIG_MODE_MASK	GENMASK(2, 0) +#define INA3221_CONFIG_MODE_POWERDOWN	0 +#define INA3221_CONFIG_MODE_SHUNT	BIT(0) +#define INA3221_CONFIG_MODE_BUS		BIT(1) +#define INA3221_CONFIG_MODE_CONTINUOUS	BIT(2) +#define INA3221_CONFIG_CHx_EN(x)	BIT(14 - (x))  #define INA3221_RSHUNT_DEFAULT		10000 @@ -74,30 +77,37 @@ enum ina3221_channels {  	INA3221_NUM_CHANNELS  }; -static const unsigned int register_channel[] = { -	[INA3221_SHUNT1] = INA3221_CHANNEL1, -	[INA3221_SHUNT2] = INA3221_CHANNEL2, -	[INA3221_SHUNT3] = INA3221_CHANNEL3, -	[INA3221_CRIT1] = INA3221_CHANNEL1, -	[INA3221_CRIT2] = INA3221_CHANNEL2, -	[INA3221_CRIT3] = INA3221_CHANNEL3, -	[INA3221_WARN1] = INA3221_CHANNEL1, -	[INA3221_WARN2] = INA3221_CHANNEL2, -	[INA3221_WARN3] = INA3221_CHANNEL3, +/** + * struct ina3221_input - channel input source specific information + * @label: label of channel input source + * @shunt_resistor: shunt resistor value of channel input source + * @disconnected: connection status of channel input source + */ +struct ina3221_input { +	const char *label; +	int shunt_resistor; +	bool disconnected;  };  /**   * struct ina3221_data - device specific information   * @regmap: Register map of the device   * @fields: Register fields of the device - * @shunt_resistors: Array of resistor values per channel + * @inputs: Array of channel input source specific structures + * @reg_config: Register value of INA3221_CONFIG   */  struct ina3221_data {  	struct regmap *regmap;  	struct regmap_field *fields[F_MAX_FIELDS]; -	int shunt_resistors[INA3221_NUM_CHANNELS]; +	struct ina3221_input inputs[INA3221_NUM_CHANNELS]; +	u32 reg_config;  }; +static inline bool ina3221_is_enabled(struct ina3221_data *ina, int channel) +{ +	return ina->reg_config & INA3221_CONFIG_CHx_EN(channel); +} +  static int ina3221_read_value(struct ina3221_data *ina, unsigned int reg,  			      int *val)  { @@ -113,107 +123,284 @@ static int ina3221_read_value(struct ina3221_data *ina, unsigned int reg,  	return 0;  } -static ssize_t ina3221_show_bus_voltage(struct device *dev, -					struct device_attribute *attr, -					char *buf) +static const u8 ina3221_in_reg[] = { +	INA3221_BUS1, +	INA3221_BUS2, +	INA3221_BUS3, +	INA3221_SHUNT1, +	INA3221_SHUNT2, +	INA3221_SHUNT3, +}; + +static int ina3221_read_in(struct device *dev, u32 attr, int channel, long *val)  { -	struct sensor_device_attribute *sd_attr = to_sensor_dev_attr(attr); +	const bool is_shunt = channel > INA3221_CHANNEL3;  	struct ina3221_data *ina = dev_get_drvdata(dev); -	unsigned int reg = sd_attr->index; -	int val, voltage_mv, ret; - -	ret = ina3221_read_value(ina, reg, &val); -	if (ret) -		return ret; +	u8 reg = ina3221_in_reg[channel]; +	int regval, ret; + +	/* Translate shunt channel index to sensor channel index */ +	channel %= INA3221_NUM_CHANNELS; + +	switch (attr) { +	case hwmon_in_input: +		if (!ina3221_is_enabled(ina, channel)) +			return -ENODATA; + +		ret = ina3221_read_value(ina, reg, ®val); +		if (ret) +			return ret; + +		/* +		 * Scale of shunt voltage (uV): LSB is 40uV +		 * Scale of bus voltage (mV): LSB is 8mV +		 */ +		*val = regval * (is_shunt ? 40 : 8); +		return 0; +	case hwmon_in_enable: +		*val = ina3221_is_enabled(ina, channel); +		return 0; +	default: +		return -EOPNOTSUPP; +	} +} -	voltage_mv = val * 8; +static const u8 ina3221_curr_reg[][INA3221_NUM_CHANNELS] = { +	[hwmon_curr_input] = { INA3221_SHUNT1, INA3221_SHUNT2, INA3221_SHUNT3 }, +	[hwmon_curr_max] = { INA3221_WARN1, INA3221_WARN2, INA3221_WARN3 }, +	[hwmon_curr_crit] = { INA3221_CRIT1, INA3221_CRIT2, INA3221_CRIT3 }, +	[hwmon_curr_max_alarm] = { F_WF1, F_WF2, F_WF3 }, +	[hwmon_curr_crit_alarm] = { F_CF1, F_CF2, F_CF3 }, +}; -	return snprintf(buf, PAGE_SIZE, "%d\n", voltage_mv); +static int ina3221_read_curr(struct device *dev, u32 attr, +			     int channel, long *val) +{ +	struct ina3221_data *ina = dev_get_drvdata(dev); +	struct ina3221_input *input = &ina->inputs[channel]; +	int resistance_uo = input->shunt_resistor; +	u8 reg = ina3221_curr_reg[attr][channel]; +	int regval, voltage_nv, ret; + +	switch (attr) { +	case hwmon_curr_input: +		if (!ina3221_is_enabled(ina, channel)) +			return -ENODATA; +		/* fall through */ +	case hwmon_curr_crit: +	case hwmon_curr_max: +		ret = ina3221_read_value(ina, reg, ®val); +		if (ret) +			return ret; + +		/* Scale of shunt voltage: LSB is 40uV (40000nV) */ +		voltage_nv = regval * 40000; +		/* Return current in mA */ +		*val = DIV_ROUND_CLOSEST(voltage_nv, resistance_uo); +		return 0; +	case hwmon_curr_crit_alarm: +	case hwmon_curr_max_alarm: +		ret = regmap_field_read(ina->fields[reg], ®val); +		if (ret) +			return ret; +		*val = regval; +		return 0; +	default: +		return -EOPNOTSUPP; +	}  } -static ssize_t ina3221_show_shunt_voltage(struct device *dev, -					  struct device_attribute *attr, -					  char *buf) +static int ina3221_write_curr(struct device *dev, u32 attr, +			      int channel, long val)  { -	struct sensor_device_attribute *sd_attr = to_sensor_dev_attr(attr);  	struct ina3221_data *ina = dev_get_drvdata(dev); -	unsigned int reg = sd_attr->index; -	int val, voltage_uv, ret; +	struct ina3221_input *input = &ina->inputs[channel]; +	int resistance_uo = input->shunt_resistor; +	u8 reg = ina3221_curr_reg[attr][channel]; +	int regval, current_ma, voltage_uv; -	ret = ina3221_read_value(ina, reg, &val); -	if (ret) -		return ret; -	voltage_uv = val * 40; +	/* clamp current */ +	current_ma = clamp_val(val, +			       INT_MIN / resistance_uo, +			       INT_MAX / resistance_uo); + +	voltage_uv = DIV_ROUND_CLOSEST(current_ma * resistance_uo, 1000); -	return snprintf(buf, PAGE_SIZE, "%d\n", voltage_uv); +	/* clamp voltage */ +	voltage_uv = clamp_val(voltage_uv, -163800, 163800); + +	/* 1 / 40uV(scale) << 3(register shift) = 5 */ +	regval = DIV_ROUND_CLOSEST(voltage_uv, 5) & 0xfff8; + +	return regmap_write(ina->regmap, reg, regval);  } -static ssize_t ina3221_show_current(struct device *dev, -				    struct device_attribute *attr, char *buf) +static int ina3221_write_enable(struct device *dev, int channel, bool enable)  { -	struct sensor_device_attribute *sd_attr = to_sensor_dev_attr(attr);  	struct ina3221_data *ina = dev_get_drvdata(dev); -	unsigned int reg = sd_attr->index; -	unsigned int channel = register_channel[reg]; -	int resistance_uo = ina->shunt_resistors[channel]; -	int val, current_ma, voltage_nv, ret; +	u16 config, mask = INA3221_CONFIG_CHx_EN(channel); +	int ret; -	ret = ina3221_read_value(ina, reg, &val); +	config = enable ? mask : 0; + +	/* Enable or disable the channel */ +	ret = regmap_update_bits(ina->regmap, INA3221_CONFIG, mask, config);  	if (ret)  		return ret; -	voltage_nv = val * 40000; -	current_ma = DIV_ROUND_CLOSEST(voltage_nv, resistance_uo); +	/* Cache the latest config register value */ +	ret = regmap_read(ina->regmap, INA3221_CONFIG, &ina->reg_config); +	if (ret) +		return ret; -	return snprintf(buf, PAGE_SIZE, "%d\n", current_ma); +	return 0;  } -static ssize_t ina3221_set_current(struct device *dev, -				   struct device_attribute *attr, -				   const char *buf, size_t count) +static int ina3221_read(struct device *dev, enum hwmon_sensor_types type, +			u32 attr, int channel, long *val) +{ +	switch (type) { +	case hwmon_in: +		/* 0-align channel ID */ +		return ina3221_read_in(dev, attr, channel - 1, val); +	case hwmon_curr: +		return ina3221_read_curr(dev, attr, channel, val); +	default: +		return -EOPNOTSUPP; +	} +} + +static int ina3221_write(struct device *dev, enum hwmon_sensor_types type, +			 u32 attr, int channel, long val) +{ +	switch (type) { +	case hwmon_in: +		/* 0-align channel ID */ +		return ina3221_write_enable(dev, channel - 1, val); +	case hwmon_curr: +		return ina3221_write_curr(dev, attr, channel, val); +	default: +		return -EOPNOTSUPP; +	} +} + +static int ina3221_read_string(struct device *dev, enum hwmon_sensor_types type, +			       u32 attr, int channel, const char **str)  { -	struct sensor_device_attribute *sd_attr = to_sensor_dev_attr(attr);  	struct ina3221_data *ina = dev_get_drvdata(dev); -	unsigned int reg = sd_attr->index; -	unsigned int channel = register_channel[reg]; -	int resistance_uo = ina->shunt_resistors[channel]; -	int val, current_ma, voltage_uv, ret; +	int index = channel - 1; -	ret = kstrtoint(buf, 0, ¤t_ma); -	if (ret) -		return ret; +	*str = ina->inputs[index].label; -	/* clamp current */ -	current_ma = clamp_val(current_ma, -			       INT_MIN / resistance_uo, -			       INT_MAX / resistance_uo); +	return 0; +} -	voltage_uv = DIV_ROUND_CLOSEST(current_ma * resistance_uo, 1000); +static umode_t ina3221_is_visible(const void *drvdata, +				  enum hwmon_sensor_types type, +				  u32 attr, int channel) +{ +	const struct ina3221_data *ina = drvdata; +	const struct ina3221_input *input = NULL; + +	switch (type) { +	case hwmon_in: +		/* Ignore in0_ */ +		if (channel == 0) +			return 0; + +		switch (attr) { +		case hwmon_in_label: +			if (channel - 1 <= INA3221_CHANNEL3) +				input = &ina->inputs[channel - 1]; +			/* Hide label node if label is not provided */ +			return (input && input->label) ? 0444 : 0; +		case hwmon_in_input: +			return 0444; +		case hwmon_in_enable: +			return 0644; +		default: +			return 0; +		} +	case hwmon_curr: +		switch (attr) { +		case hwmon_curr_input: +		case hwmon_curr_crit_alarm: +		case hwmon_curr_max_alarm: +			return 0444; +		case hwmon_curr_crit: +		case hwmon_curr_max: +			return 0644; +		default: +			return 0; +		} +	default: +		return 0; +	} +} -	/* clamp voltage */ -	voltage_uv = clamp_val(voltage_uv, -163800, 163800); +static const u32 ina3221_in_config[] = { +	/* 0: dummy, skipped in is_visible */ +	HWMON_I_INPUT, +	/* 1-3: input voltage Channels */ +	HWMON_I_INPUT | HWMON_I_ENABLE | HWMON_I_LABEL, +	HWMON_I_INPUT | HWMON_I_ENABLE | HWMON_I_LABEL, +	HWMON_I_INPUT | HWMON_I_ENABLE | HWMON_I_LABEL, +	/* 4-6: shunt voltage Channels */ +	HWMON_I_INPUT, +	HWMON_I_INPUT, +	HWMON_I_INPUT, +	0 +}; -	/* 1 / 40uV(scale) << 3(register shift) = 5 */ -	val = DIV_ROUND_CLOSEST(voltage_uv, 5) & 0xfff8; +static const struct hwmon_channel_info ina3221_in = { +	.type = hwmon_in, +	.config = ina3221_in_config, +}; -	ret = regmap_write(ina->regmap, reg, val); -	if (ret) -		return ret; +#define INA3221_HWMON_CURR_CONFIG (HWMON_C_INPUT | \ +				   HWMON_C_CRIT | HWMON_C_CRIT_ALARM | \ +				   HWMON_C_MAX | HWMON_C_MAX_ALARM) -	return count; -} +static const u32 ina3221_curr_config[] = { +	INA3221_HWMON_CURR_CONFIG, +	INA3221_HWMON_CURR_CONFIG, +	INA3221_HWMON_CURR_CONFIG, +	0 +}; + +static const struct hwmon_channel_info ina3221_curr = { +	.type = hwmon_curr, +	.config = ina3221_curr_config, +}; + +static const struct hwmon_channel_info *ina3221_info[] = { +	&ina3221_in, +	&ina3221_curr, +	NULL +}; + +static const struct hwmon_ops ina3221_hwmon_ops = { +	.is_visible = ina3221_is_visible, +	.read_string = ina3221_read_string, +	.read = ina3221_read, +	.write = ina3221_write, +}; +static const struct hwmon_chip_info ina3221_chip_info = { +	.ops = &ina3221_hwmon_ops, +	.info = ina3221_info, +}; + +/* Extra attribute groups */  static ssize_t ina3221_show_shunt(struct device *dev,  				  struct device_attribute *attr, char *buf)  {  	struct sensor_device_attribute *sd_attr = to_sensor_dev_attr(attr);  	struct ina3221_data *ina = dev_get_drvdata(dev);  	unsigned int channel = sd_attr->index; -	unsigned int resistance_uo; - -	resistance_uo = ina->shunt_resistors[channel]; +	struct ina3221_input *input = &ina->inputs[channel]; -	return snprintf(buf, PAGE_SIZE, "%d\n", resistance_uo); +	return snprintf(buf, PAGE_SIZE, "%d\n", input->shunt_resistor);  }  static ssize_t ina3221_set_shunt(struct device *dev, @@ -223,6 +410,7 @@ static ssize_t ina3221_set_shunt(struct device *dev,  	struct sensor_device_attribute *sd_attr = to_sensor_dev_attr(attr);  	struct ina3221_data *ina = dev_get_drvdata(dev);  	unsigned int channel = sd_attr->index; +	struct ina3221_input *input = &ina->inputs[channel];  	int val;  	int ret; @@ -232,43 +420,11 @@ static ssize_t ina3221_set_shunt(struct device *dev,  	val = clamp_val(val, 1, INT_MAX); -	ina->shunt_resistors[channel] = val; +	input->shunt_resistor = val;  	return count;  } -static ssize_t ina3221_show_alert(struct device *dev, -				  struct device_attribute *attr, char *buf) -{ -	struct sensor_device_attribute *sd_attr = to_sensor_dev_attr(attr); -	struct ina3221_data *ina = dev_get_drvdata(dev); -	unsigned int field = sd_attr->index; -	unsigned int regval; -	int ret; - -	ret = regmap_field_read(ina->fields[field], ®val); -	if (ret) -		return ret; - -	return snprintf(buf, PAGE_SIZE, "%d\n", regval); -} - -/* bus voltage */ -static SENSOR_DEVICE_ATTR(in1_input, S_IRUGO, -		ina3221_show_bus_voltage, NULL, INA3221_BUS1); -static SENSOR_DEVICE_ATTR(in2_input, S_IRUGO, -		ina3221_show_bus_voltage, NULL, INA3221_BUS2); -static SENSOR_DEVICE_ATTR(in3_input, S_IRUGO, -		ina3221_show_bus_voltage, NULL, INA3221_BUS3); - -/* calculated current */ -static SENSOR_DEVICE_ATTR(curr1_input, S_IRUGO, -		ina3221_show_current, NULL, INA3221_SHUNT1); -static SENSOR_DEVICE_ATTR(curr2_input, S_IRUGO, -		ina3221_show_current, NULL, INA3221_SHUNT2); -static SENSOR_DEVICE_ATTR(curr3_input, S_IRUGO, -		ina3221_show_current, NULL, INA3221_SHUNT3); -  /* shunt resistance */  static SENSOR_DEVICE_ATTR(shunt1_resistor, S_IRUGO | S_IWUSR,  		ina3221_show_shunt, ina3221_set_shunt, INA3221_CHANNEL1); @@ -277,83 +433,16 @@ static SENSOR_DEVICE_ATTR(shunt2_resistor, S_IRUGO | S_IWUSR,  static SENSOR_DEVICE_ATTR(shunt3_resistor, S_IRUGO | S_IWUSR,  		ina3221_show_shunt, ina3221_set_shunt, INA3221_CHANNEL3); -/* critical current */ -static SENSOR_DEVICE_ATTR(curr1_crit, S_IRUGO | S_IWUSR, -		ina3221_show_current, ina3221_set_current, INA3221_CRIT1); -static SENSOR_DEVICE_ATTR(curr2_crit, S_IRUGO | S_IWUSR, -		ina3221_show_current, ina3221_set_current, INA3221_CRIT2); -static SENSOR_DEVICE_ATTR(curr3_crit, S_IRUGO | S_IWUSR, -		ina3221_show_current, ina3221_set_current, INA3221_CRIT3); - -/* critical current alert */ -static SENSOR_DEVICE_ATTR(curr1_crit_alarm, S_IRUGO, -		ina3221_show_alert, NULL, F_CF1); -static SENSOR_DEVICE_ATTR(curr2_crit_alarm, S_IRUGO, -		ina3221_show_alert, NULL, F_CF2); -static SENSOR_DEVICE_ATTR(curr3_crit_alarm, S_IRUGO, -		ina3221_show_alert, NULL, F_CF3); - -/* warning current */ -static SENSOR_DEVICE_ATTR(curr1_max, S_IRUGO | S_IWUSR, -		ina3221_show_current, ina3221_set_current, INA3221_WARN1); -static SENSOR_DEVICE_ATTR(curr2_max, S_IRUGO | S_IWUSR, -		ina3221_show_current, ina3221_set_current, INA3221_WARN2); -static SENSOR_DEVICE_ATTR(curr3_max, S_IRUGO | S_IWUSR, -		ina3221_show_current, ina3221_set_current, INA3221_WARN3); - -/* warning current alert */ -static SENSOR_DEVICE_ATTR(curr1_max_alarm, S_IRUGO, -		ina3221_show_alert, NULL, F_WF1); -static SENSOR_DEVICE_ATTR(curr2_max_alarm, S_IRUGO, -		ina3221_show_alert, NULL, F_WF2); -static SENSOR_DEVICE_ATTR(curr3_max_alarm, S_IRUGO, -		ina3221_show_alert, NULL, F_WF3); - -/* shunt voltage */ -static SENSOR_DEVICE_ATTR(in4_input, S_IRUGO, -		ina3221_show_shunt_voltage, NULL, INA3221_SHUNT1); -static SENSOR_DEVICE_ATTR(in5_input, S_IRUGO, -		ina3221_show_shunt_voltage, NULL, INA3221_SHUNT2); -static SENSOR_DEVICE_ATTR(in6_input, S_IRUGO, -		ina3221_show_shunt_voltage, NULL, INA3221_SHUNT3); -  static struct attribute *ina3221_attrs[] = { -	/* channel 1 */ -	&sensor_dev_attr_in1_input.dev_attr.attr, -	&sensor_dev_attr_curr1_input.dev_attr.attr,  	&sensor_dev_attr_shunt1_resistor.dev_attr.attr, -	&sensor_dev_attr_curr1_crit.dev_attr.attr, -	&sensor_dev_attr_curr1_crit_alarm.dev_attr.attr, -	&sensor_dev_attr_curr1_max.dev_attr.attr, -	&sensor_dev_attr_curr1_max_alarm.dev_attr.attr, -	&sensor_dev_attr_in4_input.dev_attr.attr, - -	/* channel 2 */ -	&sensor_dev_attr_in2_input.dev_attr.attr, -	&sensor_dev_attr_curr2_input.dev_attr.attr,  	&sensor_dev_attr_shunt2_resistor.dev_attr.attr, -	&sensor_dev_attr_curr2_crit.dev_attr.attr, -	&sensor_dev_attr_curr2_crit_alarm.dev_attr.attr, -	&sensor_dev_attr_curr2_max.dev_attr.attr, -	&sensor_dev_attr_curr2_max_alarm.dev_attr.attr, -	&sensor_dev_attr_in5_input.dev_attr.attr, - -	/* channel 3 */ -	&sensor_dev_attr_in3_input.dev_attr.attr, -	&sensor_dev_attr_curr3_input.dev_attr.attr,  	&sensor_dev_attr_shunt3_resistor.dev_attr.attr, -	&sensor_dev_attr_curr3_crit.dev_attr.attr, -	&sensor_dev_attr_curr3_crit_alarm.dev_attr.attr, -	&sensor_dev_attr_curr3_max.dev_attr.attr, -	&sensor_dev_attr_curr3_max_alarm.dev_attr.attr, -	&sensor_dev_attr_in6_input.dev_attr.attr, -  	NULL,  };  ATTRIBUTE_GROUPS(ina3221);  static const struct regmap_range ina3221_yes_ranges[] = { -	regmap_reg_range(INA3221_SHUNT1, INA3221_BUS3), +	regmap_reg_range(INA3221_CONFIG, INA3221_BUS3),  	regmap_reg_range(INA3221_MASK_ENABLE, INA3221_MASK_ENABLE),  }; @@ -370,6 +459,66 @@ static const struct regmap_config ina3221_regmap_config = {  	.volatile_table = &ina3221_volatile_table,  }; +static int ina3221_probe_child_from_dt(struct device *dev, +				       struct device_node *child, +				       struct ina3221_data *ina) +{ +	struct ina3221_input *input; +	u32 val; +	int ret; + +	ret = of_property_read_u32(child, "reg", &val); +	if (ret) { +		dev_err(dev, "missing reg property of %s\n", child->name); +		return ret; +	} else if (val > INA3221_CHANNEL3) { +		dev_err(dev, "invalid reg %d of %s\n", val, child->name); +		return ret; +	} + +	input = &ina->inputs[val]; + +	/* Log the disconnected channel input */ +	if (!of_device_is_available(child)) { +		input->disconnected = true; +		return 0; +	} + +	/* Save the connected input label if available */ +	of_property_read_string(child, "label", &input->label); + +	/* Overwrite default shunt resistor value optionally */ +	if (!of_property_read_u32(child, "shunt-resistor-micro-ohms", &val)) { +		if (val < 1 || val > INT_MAX) { +			dev_err(dev, "invalid shunt resistor value %u of %s\n", +				val, child->name); +			return -EINVAL; +		} +		input->shunt_resistor = val; +	} + +	return 0; +} + +static int ina3221_probe_from_dt(struct device *dev, struct ina3221_data *ina) +{ +	const struct device_node *np = dev->of_node; +	struct device_node *child; +	int ret; + +	/* Compatible with non-DT platforms */ +	if (!np) +		return 0; + +	for_each_child_of_node(np, child) { +		ret = ina3221_probe_child_from_dt(dev, child, ina); +		if (ret) +			return ret; +	} + +	return 0; +} +  static int ina3221_probe(struct i2c_client *client,  			 const struct i2c_device_id *id)  { @@ -399,7 +548,13 @@ static int ina3221_probe(struct i2c_client *client,  	}  	for (i = 0; i < INA3221_NUM_CHANNELS; i++) -		ina->shunt_resistors[i] = INA3221_RSHUNT_DEFAULT; +		ina->inputs[i].shunt_resistor = INA3221_RSHUNT_DEFAULT; + +	ret = ina3221_probe_from_dt(dev, ina); +	if (ret) { +		dev_err(dev, "Unable to probe from device tree\n"); +		return ret; +	}  	ret = regmap_field_write(ina->fields[F_RST], true);  	if (ret) { @@ -407,9 +562,25 @@ static int ina3221_probe(struct i2c_client *client,  		return ret;  	} -	hwmon_dev = devm_hwmon_device_register_with_groups(dev, -							   client->name, -							   ina, ina3221_groups); +	/* Sync config register after reset */ +	ret = regmap_read(ina->regmap, INA3221_CONFIG, &ina->reg_config); +	if (ret) +		return ret; + +	/* Disable channels if their inputs are disconnected */ +	for (i = 0; i < INA3221_NUM_CHANNELS; i++) { +		if (ina->inputs[i].disconnected) +			ina->reg_config &= ~INA3221_CONFIG_CHx_EN(i); +	} +	ret = regmap_write(ina->regmap, INA3221_CONFIG, ina->reg_config); +	if (ret) +		return ret; + +	dev_set_drvdata(dev, ina); + +	hwmon_dev = devm_hwmon_device_register_with_info(dev, client->name, ina, +							 &ina3221_chip_info, +							 ina3221_groups);  	if (IS_ERR(hwmon_dev)) {  		dev_err(dev, "Unable to register hwmon device\n");  		return PTR_ERR(hwmon_dev); @@ -418,6 +589,60 @@ static int ina3221_probe(struct i2c_client *client,  	return 0;  } +static int __maybe_unused ina3221_suspend(struct device *dev) +{ +	struct ina3221_data *ina = dev_get_drvdata(dev); +	int ret; + +	/* Save config register value and enable cache-only */ +	ret = regmap_read(ina->regmap, INA3221_CONFIG, &ina->reg_config); +	if (ret) +		return ret; + +	/* Set to power-down mode for power saving */ +	ret = regmap_update_bits(ina->regmap, INA3221_CONFIG, +				 INA3221_CONFIG_MODE_MASK, +				 INA3221_CONFIG_MODE_POWERDOWN); +	if (ret) +		return ret; + +	regcache_cache_only(ina->regmap, true); +	regcache_mark_dirty(ina->regmap); + +	return 0; +} + +static int __maybe_unused ina3221_resume(struct device *dev) +{ +	struct ina3221_data *ina = dev_get_drvdata(dev); +	int ret; + +	regcache_cache_only(ina->regmap, false); + +	/* Software reset the chip */ +	ret = regmap_field_write(ina->fields[F_RST], true); +	if (ret) { +		dev_err(dev, "Unable to reset device\n"); +		return ret; +	} + +	/* Restore cached register values to hardware */ +	ret = regcache_sync(ina->regmap); +	if (ret) +		return ret; + +	/* Restore config register value to hardware */ +	ret = regmap_write(ina->regmap, INA3221_CONFIG, ina->reg_config); +	if (ret) +		return ret; + +	return 0; +} + +static const struct dev_pm_ops ina3221_pm = { +	SET_SYSTEM_SLEEP_PM_OPS(ina3221_suspend, ina3221_resume) +}; +  static const struct of_device_id ina3221_of_match_table[] = {  	{ .compatible = "ti,ina3221", },  	{ /* sentinel */ } @@ -435,6 +660,7 @@ static struct i2c_driver ina3221_i2c_driver = {  	.driver = {  		.name = INA3221_DRIVER_NAME,  		.of_match_table = ina3221_of_match_table, +		.pm = &ina3221_pm,  	},  	.id_table = ina3221_ids,  }; diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c index bb15d7816a29..2cef0c37ff6f 100644 --- a/drivers/hwmon/k10temp.c +++ b/drivers/hwmon/k10temp.c @@ -325,8 +325,9 @@ static int k10temp_probe(struct pci_dev *pdev,  	data->pdev = pdev; -	if (boot_cpu_data.x86 == 0x15 && (boot_cpu_data.x86_model == 0x60 || -					  boot_cpu_data.x86_model == 0x70)) { +	if (boot_cpu_data.x86 == 0x15 && +	    ((boot_cpu_data.x86_model & 0xf0) == 0x60 || +	     (boot_cpu_data.x86_model & 0xf0) == 0x70)) {  		data->read_htcreg = read_htcreg_nb_f15;  		data->read_tempreg = read_tempreg_nb_f15;  	} else if (boot_cpu_data.x86 == 0x17) { diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c index 49f4b33a5685..c7f20543b2bf 100644 --- a/drivers/hwmon/lm75.c +++ b/drivers/hwmon/lm75.c @@ -47,6 +47,7 @@ enum lm75_type {		/* keep sorted in alphabetical order */  	lm75b,  	max6625,  	max6626, +	max31725,  	mcp980x,  	stds75,  	tcn75, @@ -64,7 +65,6 @@ enum lm75_type {		/* keep sorted in alphabetical order */  static const unsigned short normal_i2c[] = { 0x48, 0x49, 0x4a, 0x4b, 0x4c,  					0x4d, 0x4e, 0x4f, I2C_CLIENT_END }; -  /* The LM75 registers */  #define LM75_REG_TEMP		0x00  #define LM75_REG_CONF		0x01 @@ -76,7 +76,7 @@ struct lm75_data {  	struct i2c_client	*client;  	struct regmap		*regmap;  	u8			orig_conf; -	u8			resolution;	/* In bits, between 9 and 12 */ +	u8			resolution;	/* In bits, between 9 and 16 */  	u8			resolution_limits;  	unsigned int		sample_time;	/* In ms */  }; @@ -254,7 +254,8 @@ static const struct regmap_config lm75_regmap_config = {  	.volatile_reg = lm75_is_volatile_reg,  	.val_format_endian = REGMAP_ENDIAN_BIG,  	.cache_type = REGCACHE_RBTREE, -	.use_single_rw = true, +	.use_single_read = true, +	.use_single_write = true,  };  static void lm75_remove(void *data) @@ -339,6 +340,10 @@ lm75_probe(struct i2c_client *client, const struct i2c_device_id *id)  		data->resolution_limits = 9;  		data->sample_time = MSEC_PER_SEC / 4;  		break; +	case max31725: +		data->resolution = 16; +		data->sample_time = MSEC_PER_SEC / 8; +		break;  	case tcn75:  		data->resolution = 9;  		data->sample_time = MSEC_PER_SEC / 8; @@ -415,6 +420,8 @@ static const struct i2c_device_id lm75_ids[] = {  	{ "lm75b", lm75b, },  	{ "max6625", max6625, },  	{ "max6626", max6626, }, +	{ "max31725", max31725, }, +	{ "max31726", max31725, },  	{ "mcp980x", mcp980x, },  	{ "stds75", stds75, },  	{ "tcn75", tcn75, }, @@ -472,6 +479,14 @@ static const struct of_device_id lm75_of_match[] = {  		.data = (void *)max6626  	},  	{ +		.compatible = "maxim,max31725", +		.data = (void *)max31725 +	}, +	{ +		.compatible = "maxim,max31726", +		.data = (void *)max31725 +	}, +	{  		.compatible = "maxim,mcp980x",  		.data = (void *)mcp980x  	}, diff --git a/drivers/hwmon/lm92.c b/drivers/hwmon/lm92.c index d40fe5122e94..e7333f8e185c 100644 --- a/drivers/hwmon/lm92.c +++ b/drivers/hwmon/lm92.c @@ -127,8 +127,8 @@ static struct lm92_data *lm92_update_device(struct device *dev)  	mutex_lock(&data->update_lock); -	if (time_after(jiffies, data->last_updated + HZ) -	 || !data->valid) { +	if (time_after(jiffies, data->last_updated + HZ) || +	    !data->valid) {  		dev_dbg(&client->dev, "Updating lm92 data\n");  		for (i = 0; i < t_num_regs; i++) {  			data->temp[i] = @@ -153,7 +153,7 @@ static ssize_t show_temp(struct device *dev, struct device_attribute *devattr,  }  static ssize_t set_temp(struct device *dev, struct device_attribute *devattr, -			   const char *buf, size_t count) +			const char *buf, size_t count)  {  	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);  	struct lm92_data *data = dev_get_drvdata(dev); @@ -161,7 +161,7 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *devattr,  	int nr = attr->index;  	long val;  	int err; -	 +  	err = kstrtol(buf, 10, &val);  	if (err)  		return err; @@ -178,6 +178,7 @@ static ssize_t show_temp_hyst(struct device *dev,  {  	struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);  	struct lm92_data *data = lm92_update_device(dev); +  	return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[attr->index])  		       - TEMP_FROM_REG(data->temp[t_hyst]));  } @@ -186,6 +187,7 @@ static ssize_t temp1_min_hyst_show(struct device *dev,  				   struct device_attribute *attr, char *buf)  {  	struct lm92_data *data = lm92_update_device(dev); +  	return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[t_min])  		       + TEMP_FROM_REG(data->temp[t_hyst]));  } @@ -206,7 +208,7 @@ static ssize_t set_temp_hyst(struct device *dev,  	val = clamp_val(val, -120000, 220000);  	mutex_lock(&data->update_lock); -	 data->temp[t_hyst] = +	data->temp[t_hyst] =  		TEMP_TO_REG(TEMP_FROM_REG(data->temp[attr->index]) - val);  	i2c_smbus_write_word_swapped(client, LM92_REG_TEMP_HYST,  				     data->temp[t_hyst]); @@ -218,6 +220,7 @@ static ssize_t alarms_show(struct device *dev, struct device_attribute *attr,  			   char *buf)  {  	struct lm92_data *data = lm92_update_device(dev); +  	return sprintf(buf, "%d\n", ALARMS_FROM_REG(data->temp[t_input]));  } @@ -324,7 +327,6 @@ static int lm92_probe(struct i2c_client *new_client,  	return PTR_ERR_OR_ZERO(hwmon_dev);  } -  /*   * Module and driver stuff   */ diff --git a/drivers/hwmon/lm95245.c b/drivers/hwmon/lm95245.c index 27cb06d65594..996b50246175 100644 --- a/drivers/hwmon/lm95245.c +++ b/drivers/hwmon/lm95245.c @@ -541,7 +541,8 @@ static const struct regmap_config lm95245_regmap_config = {  	.writeable_reg = lm95245_is_writeable_reg,  	.volatile_reg = lm95245_is_volatile_reg,  	.cache_type = REGCACHE_RBTREE, -	.use_single_rw = true, +	.use_single_read = true, +	.use_single_write = true,  };  static const u32 lm95245_chip_config[] = { diff --git a/drivers/hwmon/mc13783-adc.c b/drivers/hwmon/mc13783-adc.c index 78fe8759d2a9..825b922a3f92 100644 --- a/drivers/hwmon/mc13783-adc.c +++ b/drivers/hwmon/mc13783-adc.c @@ -1,21 +1,9 @@ +// SPDX-License-Identifier: GPL-2.0+  /*   * Driver for the ADC on Freescale Semiconductor MC13783 and MC13892 PMICs.   *   * Copyright 2004-2007 Freescale Semiconductor, Inc. All Rights Reserved.   * Copyright (C) 2009 Sascha Hauer, Pengutronix - * - * This program is free software; you can redistribute it and/or - * modify it under the terms of the GNU General Public License - * as published by the Free Software Foundation; either version 2 - * of the License, or (at your option) any later version. - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License along with - * this program; if not, write to the Free Software Foundation, Inc., 51 - * Franklin St, Fifth Floor, Boston, MA 02110-1301 USA   */  #include <linux/mfd/mc13xxx.h> diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c index 78603b78cf41..c3040079b1cb 100644 --- a/drivers/hwmon/nct6775.c +++ b/drivers/hwmon/nct6775.c @@ -42,6 +42,10 @@   * nct6793d    15      6       6       2+6    0xd120 0xc1    0x5ca3   * nct6795d    14      6       6       2+6    0xd350 0xc1    0x5ca3   * nct6796d    14      7       7       2+6    0xd420 0xc1    0x5ca3 + * nct6797d    14      7       7       2+6    0xd450 0xc1    0x5ca3 + *                                           (0xd451) + * nct6798d    14      7       7       2+6    0xd458 0xc1    0x5ca3 + *                                           (0xd459)   *   * #temp lists the number of monitored temperature sources (first value) plus   * the number of directly connectable temperature sensors (second value). @@ -69,7 +73,7 @@  #define USE_ALTERNATE  enum kinds { nct6106, nct6775, nct6776, nct6779, nct6791, nct6792, nct6793, -	     nct6795, nct6796 }; +	     nct6795, nct6796, nct6797, nct6798 };  /* used to set data->name = nct6775_device_names[data->sio_kind] */  static const char * const nct6775_device_names[] = { @@ -82,6 +86,8 @@ static const char * const nct6775_device_names[] = {  	"nct6793",  	"nct6795",  	"nct6796", +	"nct6797", +	"nct6798",  };  static const char * const nct6775_sio_names[] __initconst = { @@ -94,6 +100,8 @@ static const char * const nct6775_sio_names[] __initconst = {  	"NCT6793D",  	"NCT6795D",  	"NCT6796D", +	"NCT6797D", +	"NCT6798D",  };  static unsigned short force_id; @@ -129,7 +137,9 @@ MODULE_PARM_DESC(fan_debounce, "Enable debouncing for fan RPM signal");  #define SIO_NCT6793_ID		0xd120  #define SIO_NCT6795_ID		0xd350  #define SIO_NCT6796_ID		0xd420 -#define SIO_ID_MASK		0xFFF0 +#define SIO_NCT6797_ID		0xd450 +#define SIO_NCT6798_ID		0xd458 +#define SIO_ID_MASK		0xFFF8  enum pwm_enable { off, manual, thermal_cruise, speed_cruise, sf3, sf4 }; @@ -504,7 +514,7 @@ static const s8 NCT6779_BEEP_BITS[] = {  static const u16 NCT6779_REG_FAN[] = {  	0x4c0, 0x4c2, 0x4c4, 0x4c6, 0x4c8, 0x4ca, 0x4ce };  static const u16 NCT6779_REG_FAN_PULSES[NUM_FAN] = { -	0x644, 0x645, 0x646, 0x647, 0x648, 0x649 }; +	0x644, 0x645, 0x646, 0x647, 0x648, 0x649, 0x64f };  static const u16 NCT6779_REG_CRITICAL_PWM_ENABLE[] = {  	0x136, 0x236, 0x336, 0x836, 0x936, 0xa36, 0xb36 }; @@ -704,10 +714,10 @@ static const char *const nct6795_temp_label[] = {  	"PCH_CHIP_TEMP",  	"PCH_CPU_TEMP",  	"PCH_MCH_TEMP", -	"PCH_DIM0_TEMP", -	"PCH_DIM1_TEMP", -	"PCH_DIM2_TEMP", -	"PCH_DIM3_TEMP", +	"Agent0 Dimm0", +	"Agent0 Dimm1", +	"Agent1 Dimm0", +	"Agent1 Dimm1",  	"BYTE_TEMP0",  	"BYTE_TEMP1",  	"PECI Agent 0 Calibration", @@ -742,10 +752,10 @@ static const char *const nct6796_temp_label[] = {  	"PCH_CHIP_TEMP",  	"PCH_CPU_TEMP",  	"PCH_MCH_TEMP", -	"PCH_DIM0_TEMP", -	"PCH_DIM1_TEMP", -	"PCH_DIM2_TEMP", -	"PCH_DIM3_TEMP", +	"Agent0 Dimm0", +	"Agent0 Dimm1", +	"Agent1 Dimm0", +	"Agent1 Dimm1",  	"BYTE_TEMP0",  	"BYTE_TEMP1",  	"PECI Agent 0 Calibration", @@ -757,6 +767,44 @@ static const char *const nct6796_temp_label[] = {  #define NCT6796_TEMP_MASK	0xbfff0ffe  #define NCT6796_VIRT_TEMP_MASK	0x80000c00 +static const char *const nct6798_temp_label[] = { +	"", +	"SYSTIN", +	"CPUTIN", +	"AUXTIN0", +	"AUXTIN1", +	"AUXTIN2", +	"AUXTIN3", +	"AUXTIN4", +	"SMBUSMASTER 0", +	"SMBUSMASTER 1", +	"Virtual_TEMP", +	"Virtual_TEMP", +	"", +	"", +	"", +	"", +	"PECI Agent 0", +	"PECI Agent 1", +	"PCH_CHIP_CPU_MAX_TEMP", +	"PCH_CHIP_TEMP", +	"PCH_CPU_TEMP", +	"PCH_MCH_TEMP", +	"Agent0 Dimm0", +	"Agent0 Dimm1", +	"Agent1 Dimm0", +	"Agent1 Dimm1", +	"BYTE_TEMP0", +	"BYTE_TEMP1", +	"", +	"", +	"", +	"Virtual_TEMP" +}; + +#define NCT6798_TEMP_MASK	0x8fff0ffe +#define NCT6798_VIRT_TEMP_MASK	0x80000c00 +  /* NCT6102D/NCT6106D specific data */  #define NCT6106_REG_VBAT	0x318 @@ -1288,6 +1336,8 @@ static bool is_word_sized(struct nct6775_data *data, u16 reg)  	case nct6793:  	case nct6795:  	case nct6796: +	case nct6797: +	case nct6798:  		return reg == 0x150 || reg == 0x153 || reg == 0x155 ||  		  (reg & 0xfff0) == 0x4c0 ||  		  reg == 0x402 || @@ -1643,6 +1693,8 @@ static void nct6775_update_pwm_limits(struct device *dev)  		case nct6793:  		case nct6795:  		case nct6796: +		case nct6797: +		case nct6798:  			reg = nct6775_read_value(data,  					data->REG_CRITICAL_PWM_ENABLE[i]);  			if (reg & data->CRITICAL_PWM_ENABLE_MASK) @@ -2847,6 +2899,8 @@ store_temp_tolerance(struct device *dev, struct device_attribute *attr,   * Fan speed tolerance is a tricky beast, since the associated register is   * a tick counter, but the value is reported and configured as rpm.   * Compute resulting low and high rpm values and report the difference. + * A fan speed tolerance only makes sense if a fan target speed has been + * configured, so only display values other than 0 if that is the case.   */  static ssize_t  show_speed_tolerance(struct device *dev, struct device_attribute *attr, @@ -2855,19 +2909,23 @@ show_speed_tolerance(struct device *dev, struct device_attribute *attr,  	struct nct6775_data *data = nct6775_update_device(dev);  	struct sensor_device_attribute *sattr = to_sensor_dev_attr(attr);  	int nr = sattr->index; -	int low = data->target_speed[nr] - data->target_speed_tolerance[nr]; -	int high = data->target_speed[nr] + data->target_speed_tolerance[nr]; -	int tolerance; - -	if (low <= 0) -		low = 1; -	if (high > 0xffff) -		high = 0xffff; -	if (high < low) -		high = low; - -	tolerance = (fan_from_reg16(low, data->fan_div[nr]) -		     - fan_from_reg16(high, data->fan_div[nr])) / 2; +	int target = data->target_speed[nr]; +	int tolerance = 0; + +	if (target) { +		int low = target - data->target_speed_tolerance[nr]; +		int high = target + data->target_speed_tolerance[nr]; + +		if (low <= 0) +			low = 1; +		if (high > 0xffff) +			high = 0xffff; +		if (high < low) +			high = low; + +		tolerance = (fan_from_reg16(low, data->fan_div[nr]) +			     - fan_from_reg16(high, data->fan_div[nr])) / 2; +	}  	return sprintf(buf, "%d\n", tolerance);  } @@ -3071,6 +3129,8 @@ store_auto_pwm(struct device *dev, struct device_attribute *attr,  		case nct6793:  		case nct6795:  		case nct6796: +		case nct6797: +		case nct6798:  			nct6775_write_value(data, data->REG_CRITICAL_PWM[nr],  					    val);  			reg = nct6775_read_value(data, @@ -3430,7 +3490,6 @@ nct6775_check_fan_inputs(struct nct6775_data *data)  	bool pwm3pin = false, pwm4pin = false, pwm5pin = false;  	bool pwm6pin = false, pwm7pin = false;  	int sioreg = data->sioreg; -	int regval;  	/* Store SIO_REG_ENABLE for use during resume */  	superio_select(sioreg, NCT6775_LD_HWM); @@ -3438,10 +3497,10 @@ nct6775_check_fan_inputs(struct nct6775_data *data)  	/* fan4 and fan5 share some pins with the GPIO and serial flash */  	if (data->kind == nct6775) { -		regval = superio_inb(sioreg, 0x2c); +		int cr2c = superio_inb(sioreg, 0x2c); -		fan3pin = regval & BIT(6); -		pwm3pin = regval & BIT(7); +		fan3pin = cr2c & BIT(6); +		pwm3pin = cr2c & BIT(7);  		/* On NCT6775, fan4 shares pins with the fdc interface */  		fan4pin = !(superio_inb(sioreg, 0x2A) & 0x80); @@ -3486,85 +3545,130 @@ nct6775_check_fan_inputs(struct nct6775_data *data)  		fan4min = fan4pin;  		pwm3pin = fan3pin;  	} else if (data->kind == nct6106) { -		regval = superio_inb(sioreg, 0x24); -		fan3pin = !(regval & 0x80); -		pwm3pin = regval & 0x08; -	} else { -		/* NCT6779D, NCT6791D, NCT6792D, NCT6793D, NCT6795D, NCT6796D */ -		int regval_1b, regval_2a, regval_2f; -		bool dsw_en; - -		regval = superio_inb(sioreg, 0x1c); +		int cr24 = superio_inb(sioreg, 0x24); -		fan3pin = !(regval & BIT(5)); -		fan4pin = !(regval & BIT(6)); -		fan5pin = !(regval & BIT(7)); - -		pwm3pin = !(regval & BIT(0)); -		pwm4pin = !(regval & BIT(1)); -		pwm5pin = !(regval & BIT(2)); +		fan3pin = !(cr24 & 0x80); +		pwm3pin = cr24 & 0x08; +	} else { +		/* +		 * NCT6779D, NCT6791D, NCT6792D, NCT6793D, NCT6795D, NCT6796D, +		 * NCT6797D, NCT6798D +		 */ +		int cr1a = superio_inb(sioreg, 0x1a); +		int cr1b = superio_inb(sioreg, 0x1b); +		int cr1c = superio_inb(sioreg, 0x1c); +		int cr1d = superio_inb(sioreg, 0x1d); +		int cr2a = superio_inb(sioreg, 0x2a); +		int cr2b = superio_inb(sioreg, 0x2b); +		int cr2d = superio_inb(sioreg, 0x2d); +		int cr2f = superio_inb(sioreg, 0x2f); +		bool dsw_en = cr2f & BIT(3); +		bool ddr4_en = cr2f & BIT(4); +		int cre0; +		int creb; +		int cred; + +		superio_select(sioreg, NCT6775_LD_12); +		cre0 = superio_inb(sioreg, 0xe0); +		creb = superio_inb(sioreg, 0xeb); +		cred = superio_inb(sioreg, 0xed); + +		fan3pin = !(cr1c & BIT(5)); +		fan4pin = !(cr1c & BIT(6)); +		fan5pin = !(cr1c & BIT(7)); + +		pwm3pin = !(cr1c & BIT(0)); +		pwm4pin = !(cr1c & BIT(1)); +		pwm5pin = !(cr1c & BIT(2)); -		regval = superio_inb(sioreg, 0x2d);  		switch (data->kind) {  		case nct6791: +			fan6pin = cr2d & BIT(1); +			pwm6pin = cr2d & BIT(0); +			break;  		case nct6792: -			fan6pin = regval & BIT(1); -			pwm6pin = regval & BIT(0); +			fan6pin = !dsw_en && (cr2d & BIT(1)); +			pwm6pin = !dsw_en && (cr2d & BIT(0));  			break;  		case nct6793: +			fan5pin |= cr1b & BIT(5); +			fan5pin |= creb & BIT(5); + +			fan6pin = creb & BIT(3); + +			pwm5pin |= cr2d & BIT(7); +			pwm5pin |= (creb & BIT(4)) && !(cr2a & BIT(0)); + +			pwm6pin = !dsw_en && (cr2d & BIT(0)); +			pwm6pin |= creb & BIT(2); +			break;  		case nct6795: +			fan5pin |= cr1b & BIT(5); +			fan5pin |= creb & BIT(5); + +			fan6pin = (cr2a & BIT(4)) && +					(!dsw_en || (cred & BIT(4))); +			fan6pin |= creb & BIT(3); + +			pwm5pin |= cr2d & BIT(7); +			pwm5pin |= (creb & BIT(4)) && !(cr2a & BIT(0)); + +			pwm6pin = (cr2a & BIT(3)) && (cred & BIT(2)); +			pwm6pin |= creb & BIT(2); +			break;  		case nct6796: -			regval_1b = superio_inb(sioreg, 0x1b); -			regval_2a = superio_inb(sioreg, 0x2a); -			regval_2f = superio_inb(sioreg, 0x2f); -			dsw_en = regval_2f & BIT(3); +			fan5pin |= cr1b & BIT(5); +			fan5pin |= (cre0 & BIT(3)) && !(cr1b & BIT(0)); +			fan5pin |= creb & BIT(5); -			if (!pwm5pin) -				pwm5pin = regval & BIT(7); +			fan6pin = (cr2a & BIT(4)) && +					(!dsw_en || (cred & BIT(4))); +			fan6pin |= creb & BIT(3); -			if (!fan5pin) -				fan5pin = regval_1b & BIT(5); +			fan7pin = !(cr2b & BIT(2)); -			superio_select(sioreg, NCT6775_LD_12); -			if (data->kind != nct6796) { -				int regval_eb = superio_inb(sioreg, 0xeb); +			pwm5pin |= cr2d & BIT(7); +			pwm5pin |= (cre0 & BIT(4)) && !(cr1b & BIT(0)); +			pwm5pin |= (creb & BIT(4)) && !(cr2a & BIT(0)); -				if (!dsw_en) { -					fan6pin = regval & BIT(1); -					pwm6pin = regval & BIT(0); -				} +			pwm6pin = (cr2a & BIT(3)) && (cred & BIT(2)); +			pwm6pin |= creb & BIT(2); -				if (!fan5pin) -					fan5pin = regval_eb & BIT(5); -				if (!pwm5pin) -					pwm5pin = (regval_eb & BIT(4)) && -						!(regval_2a & BIT(0)); -				if (!fan6pin) -					fan6pin = regval_eb & BIT(3); -				if (!pwm6pin) -					pwm6pin = regval_eb & BIT(2); -			} +			pwm7pin = !(cr1d & (BIT(2) | BIT(3))); +			break; +		case nct6797: +			fan5pin |= !ddr4_en && (cr1b & BIT(5)); +			fan5pin |= creb & BIT(5); -			if (data->kind == nct6795 || data->kind == nct6796) { -				int regval_ed = superio_inb(sioreg, 0xed); +			fan6pin = cr2a & BIT(4); +			fan6pin |= creb & BIT(3); -				if (!fan6pin) -					fan6pin = (regval_2a & BIT(4)) && -					  (!dsw_en || -					   (dsw_en && (regval_ed & BIT(4)))); -				if (!pwm6pin) -					pwm6pin = (regval_2a & BIT(3)) && -					  (regval_ed & BIT(2)); -			} +			fan7pin = cr1a & BIT(1); -			if (data->kind == nct6796) { -				int regval_1d = superio_inb(sioreg, 0x1d); -				int regval_2b = superio_inb(sioreg, 0x2b); +			pwm5pin |= (creb & BIT(4)) && !(cr2a & BIT(0)); +			pwm5pin |= !ddr4_en && (cr2d & BIT(7)); -				fan7pin = !(regval_2b & BIT(2)); -				pwm7pin = !(regval_1d & (BIT(2) | BIT(3))); -			} +			pwm6pin = creb & BIT(2); +			pwm6pin |= cred & BIT(2); +			pwm7pin = cr1d & BIT(4); +			break; +		case nct6798: +			fan6pin = !(cr1b & BIT(0)) && (cre0 & BIT(3)); +			fan6pin |= cr2a & BIT(4); +			fan6pin |= creb & BIT(5); + +			fan7pin = cr1b & BIT(5); +			fan7pin |= !(cr2b & BIT(2)); +			fan7pin |= creb & BIT(3); + +			pwm6pin = !(cr1b & BIT(0)) && (cre0 & BIT(4)); +			pwm6pin |= !(cred & BIT(2)) && (cr2a & BIT(3)); +			pwm6pin |= (creb & BIT(4)) && !(cr2a & BIT(0)); + +			pwm7pin = !(cr1d & (BIT(2) | BIT(3))); +			pwm7pin |= cr2d & BIT(7); +			pwm7pin |= creb & BIT(2);  			break;  		default:	/* NCT6779D */  			break; @@ -3943,8 +4047,12 @@ static int nct6775_probe(struct platform_device *pdev)  	case nct6793:  	case nct6795:  	case nct6796: +	case nct6797: +	case nct6798:  		data->in_num = 15; -		data->pwm_num = (data->kind == nct6796) ? 7 : 6; +		data->pwm_num = (data->kind == nct6796 || +				 data->kind == nct6797 || +				 data->kind == nct6798) ? 7 : 6;  		data->auto_pwm_num = 4;  		data->has_fan_div = false;  		data->temp_fixed_num = 6; @@ -3978,6 +4086,7 @@ static int nct6775_probe(struct platform_device *pdev)  			data->virt_temp_mask = NCT6793_VIRT_TEMP_MASK;  			break;  		case nct6795: +		case nct6797:  			data->temp_label = nct6795_temp_label;  			data->temp_mask = NCT6795_TEMP_MASK;  			data->virt_temp_mask = NCT6795_VIRT_TEMP_MASK; @@ -3987,6 +4096,11 @@ static int nct6775_probe(struct platform_device *pdev)  			data->temp_mask = NCT6796_TEMP_MASK;  			data->virt_temp_mask = NCT6796_VIRT_TEMP_MASK;  			break; +		case nct6798: +			data->temp_label = nct6798_temp_label; +			data->temp_mask = NCT6798_TEMP_MASK; +			data->virt_temp_mask = NCT6798_VIRT_TEMP_MASK; +			break;  		}  		data->REG_CONFIG = NCT6775_REG_CONFIG; @@ -4256,6 +4370,8 @@ static int nct6775_probe(struct platform_device *pdev)  	case nct6793:  	case nct6795:  	case nct6796: +	case nct6797: +	case nct6798:  		break;  	} @@ -4291,6 +4407,8 @@ static int nct6775_probe(struct platform_device *pdev)  		case nct6793:  		case nct6795:  		case nct6796: +		case nct6797: +		case nct6798:  			tmp |= 0x7e;  			break;  		} @@ -4493,6 +4611,12 @@ static int __init nct6775_find(int sioaddr, struct nct6775_sio_data *sio_data)  	case SIO_NCT6796_ID:  		sio_data->kind = nct6796;  		break; +	case SIO_NCT6797_ID: +		sio_data->kind = nct6797; +		break; +	case SIO_NCT6798_ID: +		sio_data->kind = nct6798; +		break;  	default:  		if (val != 0xffff)  			pr_debug("unsupported chip ID: 0x%04x\n", val); diff --git a/drivers/hwmon/npcm750-pwm-fan.c b/drivers/hwmon/npcm750-pwm-fan.c index b998f9fbed41..b3b907bdfb63 100644 --- a/drivers/hwmon/npcm750-pwm-fan.c +++ b/drivers/hwmon/npcm750-pwm-fan.c @@ -52,7 +52,7 @@  /* Define the Counter Register, value = 100 for match 100% */  #define NPCM7XX_PWM_COUNTER_DEFAULT_NUM		255 -#define NPCM7XX_PWM_CMR_DEFAULT_NUM		127 +#define NPCM7XX_PWM_CMR_DEFAULT_NUM		255  #define NPCM7XX_PWM_CMR_MAX			255  /* default all PWM channels PRESCALE2 = 1 */ @@ -861,7 +861,7 @@ static int npcm7xx_create_pwm_cooling(struct device *dev,  		dev_err(dev, "Property 'cooling-levels' cannot be read.\n");  		return ret;  	} -	snprintf(cdev->name, THERMAL_NAME_LENGTH, "%s%d", child->name, +	snprintf(cdev->name, THERMAL_NAME_LENGTH, "%pOFn%d", child,  		 pwm_port);  	cdev->tcdev = thermal_of_cooling_device_register(child, diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig index a82018aaf473..629cb45f8557 100644 --- a/drivers/hwmon/pmbus/Kconfig +++ b/drivers/hwmon/pmbus/Kconfig @@ -5,7 +5,6 @@  menuconfig PMBUS  	tristate "PMBus support"  	depends on I2C -	default n  	help  	  Say yes here if you want to enable PMBus support. @@ -28,7 +27,6 @@ config SENSORS_PMBUS  config SENSORS_ADM1275  	tristate "Analog Devices ADM1275 and compatibles" -	default n  	help  	  If you say yes here you get hardware monitoring support for Analog  	  Devices ADM1075, ADM1272, ADM1275, ADM1276, ADM1278, ADM1293, @@ -49,7 +47,6 @@ config SENSORS_IBM_CFFPS  config SENSORS_IR35221  	tristate "Infineon IR35221" -	default n  	help  	  If you say yes here you get hardware monitoring support for the  	  Infineon IR35221 controller. @@ -59,7 +56,6 @@ config SENSORS_IR35221  config SENSORS_LM25066  	tristate "National Semiconductor LM25066 and compatibles" -	default n  	help  	  If you say yes here you get hardware monitoring support for National  	  Semiconductor LM25056, LM25066, LM5064, and LM5066. @@ -69,7 +65,6 @@ config SENSORS_LM25066  config SENSORS_LTC2978  	tristate "Linear Technologies LTC2978 and compatibles" -	default n  	help  	  If you say yes here you get hardware monitoring support for Linear  	  Technology LTC2974, LTC2975, LTC2977, LTC2978, LTC2980, LTC3880, @@ -83,11 +78,11 @@ config SENSORS_LTC2978_REGULATOR  	depends on SENSORS_LTC2978 && REGULATOR  	help  	  If you say yes here you get regulator support for Linear -	  Technology LTC2974, LTC2977, LTC2978, LTC3880, LTC3883, and LTM4676. +	  Technology LTC2974, LTC2977, LTC2978, LTC3880, LTC3883, LTM4676 +	  and LTM4686.  config SENSORS_LTC3815  	tristate "Linear Technologies LTC3815" -	default n  	help  	  If you say yes here you get hardware monitoring support for Linear  	  Technology LTC3815. @@ -97,7 +92,6 @@ config SENSORS_LTC3815  config SENSORS_MAX16064  	tristate "Maxim MAX16064" -	default n  	help  	  If you say yes here you get hardware monitoring support for Maxim  	  MAX16064. @@ -107,7 +101,6 @@ config SENSORS_MAX16064  config SENSORS_MAX20751  	tristate "Maxim MAX20751" -	default n  	help  	  If you say yes here you get hardware monitoring support for Maxim  	  MAX20751. @@ -117,7 +110,6 @@ config SENSORS_MAX20751  config SENSORS_MAX31785  	tristate "Maxim MAX31785 and compatibles" -	default n  	help  	  If you say yes here you get hardware monitoring support for Maxim  	  MAX31785. @@ -127,7 +119,6 @@ config SENSORS_MAX31785  config SENSORS_MAX34440  	tristate "Maxim MAX34440 and compatibles" -	default n  	help  	  If you say yes here you get hardware monitoring support for Maxim  	  MAX34440, MAX34441, MAX34446, MAX34451, MAX34460, and MAX34461. @@ -137,7 +128,6 @@ config SENSORS_MAX34440  config SENSORS_MAX8688  	tristate "Maxim MAX8688" -	default n  	help  	  If you say yes here you get hardware monitoring support for Maxim  	  MAX8688. @@ -147,7 +137,6 @@ config SENSORS_MAX8688  config SENSORS_TPS40422  	tristate "TI TPS40422" -	default n  	help  	  If you say yes here you get hardware monitoring support for TI  	  TPS40422. @@ -166,7 +155,6 @@ config SENSORS_TPS53679  config SENSORS_UCD9000  	tristate "TI UCD90120, UCD90124, UCD90160, UCD9090, UCD90910" -	default n  	help  	  If you say yes here you get hardware monitoring support for TI  	  UCD90120, UCD90124, UCD90160, UCD9090, UCD90910, Sequencer and System @@ -177,7 +165,6 @@ config SENSORS_UCD9000  config SENSORS_UCD9200  	tristate "TI UCD9220, UCD9222, UCD9224, UCD9240, UCD9244, UCD9246, UCD9248" -	default n  	help  	  If you say yes here you get hardware monitoring support for TI  	  UCD9220, UCD9222, UCD9224, UCD9240, UCD9244, UCD9246, and UCD9248 @@ -188,7 +175,6 @@ config SENSORS_UCD9200  config SENSORS_ZL6100  	tristate "Intersil ZL6100 and compatibles" -	default n  	help  	  If you say yes here you get hardware monitoring support for Intersil  	  ZL2004, ZL2005, ZL2006, ZL2008, ZL2105, ZL2106, ZL6100, ZL6105, diff --git a/drivers/hwmon/pmbus/ltc2978.c b/drivers/hwmon/pmbus/ltc2978.c index 58b789c28b48..07afb92bb36b 100644 --- a/drivers/hwmon/pmbus/ltc2978.c +++ b/drivers/hwmon/pmbus/ltc2978.c @@ -4,6 +4,7 @@   * Copyright (c) 2011 Ericsson AB.   * Copyright (c) 2013, 2014, 2015 Guenter Roeck   * Copyright (c) 2015 Linear Technology + * Copyright (c) 2018 Analog Devices Inc.   *   * This program is free software; you can redistribute it and/or modify   * it under the terms of the GNU General Public License as published by @@ -28,7 +29,7 @@  #include "pmbus.h"  enum chips { ltc2974, ltc2975, ltc2977, ltc2978, ltc2980, ltc3880, ltc3882, -	ltc3883, ltc3886, ltc3887, ltm2987, ltm4675, ltm4676 }; +	ltc3883, ltc3886, ltc3887, ltm2987, ltm4675, ltm4676, ltm4686 };  /* Common for all chips */  #define LTC2978_MFR_VOUT_PEAK		0xdd @@ -81,6 +82,7 @@ enum chips { ltc2974, ltc2975, ltc2977, ltc2978, ltc2980, ltc3880, ltc3882,  #define LTM4676_ID_REV1			0x4400  #define LTM4676_ID_REV2			0x4480  #define LTM4676A_ID			0x47e0 +#define LTM4686_ID			0x4770  #define LTC2974_NUM_PAGES		4  #define LTC2978_NUM_PAGES		8 @@ -512,6 +514,7 @@ static const struct i2c_device_id ltc2978_id[] = {  	{"ltm2987", ltm2987},  	{"ltm4675", ltm4675},  	{"ltm4676", ltm4676}, +	{"ltm4686", ltm4686},  	{}  };  MODULE_DEVICE_TABLE(i2c, ltc2978_id); @@ -588,6 +591,8 @@ static int ltc2978_get_id(struct i2c_client *client)  	else if (chip_id == LTM4676_ID_REV1 || chip_id == LTM4676_ID_REV2 ||  		 chip_id == LTM4676A_ID)  		return ltm4676; +	else if (chip_id == LTM4686_ID) +		return ltm4686;  	dev_err(&client->dev, "Unsupported chip ID 0x%x\n", chip_id);  	return -ENODEV; @@ -684,6 +689,7 @@ static int ltc2978_probe(struct i2c_client *client,  	case ltc3887:  	case ltm4675:  	case ltm4676: +	case ltm4686:  		data->features |= FEAT_CLEAR_PEAKS | FEAT_NEEDS_POLLING;  		info->read_word_data = ltc3880_read_word_data;  		info->pages = LTC3880_NUM_PAGES; @@ -770,6 +776,7 @@ static const struct of_device_id ltc2978_of_match[] = {  	{ .compatible = "lltc,ltm2987" },  	{ .compatible = "lltc,ltm4675" },  	{ .compatible = "lltc,ltm4676" }, +	{ .compatible = "lltc,ltm4686" },  	{ }  };  MODULE_DEVICE_TABLE(of, ltc2978_of_match); diff --git a/drivers/hwmon/pmbus/pmbus.c b/drivers/hwmon/pmbus/pmbus.c index 7718e58dbda5..7688dab32f6e 100644 --- a/drivers/hwmon/pmbus/pmbus.c +++ b/drivers/hwmon/pmbus/pmbus.c @@ -118,6 +118,8 @@ static int pmbus_identify(struct i2c_client *client,  		} else {  			info->pages = 1;  		} + +		pmbus_clear_faults(client);  	}  	if (pmbus_check_byte_register(client, 0, PMBUS_VOUT_MODE)) { diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c index 82c3754e21e3..2e2b5851139c 100644 --- a/drivers/hwmon/pmbus/pmbus_core.c +++ b/drivers/hwmon/pmbus/pmbus_core.c @@ -2015,7 +2015,10 @@ static int pmbus_init_common(struct i2c_client *client, struct pmbus_data *data,  	if (ret >= 0 && (ret & PB_CAPABILITY_ERROR_CHECK))  		client->flags |= I2C_CLIENT_PEC; -	pmbus_clear_faults(client); +	if (data->info->pages) +		pmbus_clear_faults(client); +	else +		pmbus_clear_fault_page(client, -1);  	if (info->identify) {  		ret = (*info->identify)(client, info); diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c index 7838af58f92d..7da6a160d45a 100644 --- a/drivers/hwmon/pwm-fan.c +++ b/drivers/hwmon/pwm-fan.c @@ -221,8 +221,12 @@ static int pwm_fan_probe(struct platform_device *pdev)  	ctx->pwm = devm_of_pwm_get(&pdev->dev, pdev->dev.of_node, NULL);  	if (IS_ERR(ctx->pwm)) { -		dev_err(&pdev->dev, "Could not get PWM\n"); -		return PTR_ERR(ctx->pwm); +		ret = PTR_ERR(ctx->pwm); + +		if (ret != -EPROBE_DEFER) +			dev_err(&pdev->dev, "Could not get PWM: %d\n", ret); + +		return ret;  	}  	platform_set_drvdata(pdev, ctx); @@ -290,9 +294,19 @@ static int pwm_fan_remove(struct platform_device *pdev)  static int pwm_fan_suspend(struct device *dev)  {  	struct pwm_fan_ctx *ctx = dev_get_drvdata(dev); +	struct pwm_args args; +	int ret; + +	pwm_get_args(ctx->pwm, &args); + +	if (ctx->pwm_value) { +		ret = pwm_config(ctx->pwm, 0, args.period); +		if (ret < 0) +			return ret; -	if (ctx->pwm_value)  		pwm_disable(ctx->pwm); +	} +  	return 0;  } diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c index 91976b6ca300..2e005edee0c9 100644 --- a/drivers/hwmon/scmi-hwmon.c +++ b/drivers/hwmon/scmi-hwmon.c @@ -56,7 +56,7 @@ scmi_hwmon_is_visible(const void *drvdata, enum hwmon_sensor_types type,  	const struct scmi_sensors *scmi_sensors = drvdata;  	sensor = *(scmi_sensors->info[type] + channel); -	if (sensor && sensor->name) +	if (sensor)  		return S_IRUGO;  	return 0; diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c index 7e49da50bc69..111d521e2189 100644 --- a/drivers/hwmon/scpi-hwmon.c +++ b/drivers/hwmon/scpi-hwmon.c @@ -286,10 +286,8 @@ static int scpi_hwmon_probe(struct platform_device *pdev)  		 * any thermal zones or if the thermal subsystem is  		 * not configured.  		 */ -		if (IS_ERR(z)) { +		if (IS_ERR(z))  			devm_kfree(dev, zone); -			continue; -		}  	}  	return 0; diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c index 2be77752cd56..c878242f3486 100644 --- a/drivers/hwmon/sht15.c +++ b/drivers/hwmon/sht15.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0  /*   * sht15.c - support for the SHT15 Temperature and Humidity Sensor   * @@ -9,10 +10,6 @@   *   * Copyright (c) 2007 Wouter Horre   * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. - *   * For further information, see the Documentation/hwmon/sht15 file.   */ diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c index dfc40c740d07..6778283e36f9 100644 --- a/drivers/hwmon/tmp102.c +++ b/drivers/hwmon/tmp102.c @@ -212,7 +212,8 @@ static const struct regmap_config tmp102_regmap_config = {  	.volatile_reg = tmp102_is_volatile_reg,  	.val_format_endian = REGMAP_ENDIAN_BIG,  	.cache_type = REGCACHE_RBTREE, -	.use_single_rw = true, +	.use_single_read = true, +	.use_single_write = true,  };  static int tmp102_probe(struct i2c_client *client, diff --git a/drivers/hwmon/tmp108.c b/drivers/hwmon/tmp108.c index 91bb94639286..429bfeae4ca8 100644 --- a/drivers/hwmon/tmp108.c +++ b/drivers/hwmon/tmp108.c @@ -345,7 +345,8 @@ static const struct regmap_config tmp108_regmap_config = {  	.volatile_reg = tmp108_is_volatile_reg,  	.val_format_endian = REGMAP_ENDIAN_BIG,  	.cache_type = REGCACHE_RBTREE, -	.use_single_rw = true, +	.use_single_read = true, +	.use_single_write = true,  };  static int tmp108_probe(struct i2c_client *client, diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c index e36399213324..8844c9565d2a 100644 --- a/drivers/hwmon/tmp421.c +++ b/drivers/hwmon/tmp421.c @@ -226,8 +226,10 @@ static int tmp421_detect(struct i2c_client *client,  {  	enum chips kind;  	struct i2c_adapter *adapter = client->adapter; -	const char * const names[] = { "TMP421", "TMP422", "TMP423", -				       "TMP441", "TMP442" }; +	static const char * const names[] = { +		"TMP421", "TMP422", "TMP423", +		"TMP441", "TMP442" +	};  	int addr = client->addr;  	u8 reg; |