aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/util/scripting-engines/trace-event-python.c
diff options
context:
space:
mode:
authorSrivatsa S. Bhat <[email protected]>2014-03-11 02:06:31 +0530
committerRafael J. Wysocki <[email protected]>2014-03-20 13:43:42 +0100
commitd1a5511390b0eb242c70ab977abff28644f66a5a (patch)
treeca3582cec9483dad7df5a49848715c141e0ffab9 /tools/perf/util/scripting-engines/trace-event-python.c
parent1e0b0c4c6b9241b66c6032e14962a149f852f23a (diff)
powerpc, sysfs: Fix CPU hotplug callback registration
Subsystems that want to register CPU hotplug callbacks, as well as perform initialization for the CPUs that are already online, often do it as shown below: get_online_cpus(); for_each_online_cpu(cpu) init_cpu(cpu); register_cpu_notifier(&foobar_cpu_notifier); put_online_cpus(); This is wrong, since it is prone to ABBA deadlocks involving the cpu_add_remove_lock and the cpu_hotplug.lock (when running concurrently with CPU hotplug operations). Instead, the correct and race-free way of performing the callback registration is: cpu_notifier_register_begin(); for_each_online_cpu(cpu) init_cpu(cpu); /* Note the use of the double underscored version of the API */ __register_cpu_notifier(&foobar_cpu_notifier); cpu_notifier_register_done(); Fix the sysfs code in powerpc by using this latter form of callback registration. Cc: Benjamin Herrenschmidt <[email protected]> Cc: Paul Mackerras <[email protected]> Cc: Olof Johansson <[email protected]> Cc: Wang Dongsheng <[email protected]> Cc: Ingo Molnar <[email protected]> Acked-by: Madhavan Srinivasan <[email protected]> Signed-off-by: Srivatsa S. Bhat <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
Diffstat (limited to 'tools/perf/util/scripting-engines/trace-event-python.c')
0 files changed, 0 insertions, 0 deletions