diff options
author | Arnd Bergmann <[email protected]> | 2024-04-08 21:48:10 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <[email protected]> | 2024-04-09 17:53:50 +0200 |
commit | c3a8f7dfc7c3d5fa71f9038971e2081f0e3ee279 (patch) | |
tree | a2e3282d9718dcc8b72a06c18ea2d71010e7d026 /tools/perf/scripts/python/task-analyzer.py | |
parent | 1b61680cfe3e4dce1e4dcf41d47d92b85c3fcceb (diff) |
staging: rtl8723bs: convert strncpy to strscpy
gcc-9 complains about a possibly unterminated string in the strncpy() destination:
In function 'rtw_cfg80211_add_monitor_if',
inlined from 'cfg80211_rtw_add_virtual_intf' at drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2209:9:
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:2146:2: error: 'strncpy' specified bound 16 equals destination size [-Werror=stringop-truncation]
2146 | strncpy(mon_ndev->name, name, IFNAMSIZ);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This one is a false-positive because of the explicit termination in the following
line, and recent versions of clang and gcc no longer warn about this.
Interestingly, the other strncpy() in this file is missing a termination but
does not produce a warning, possibly because of the type confusion and the
cast between u8 and char.
Change both strncpy() instances to strscpy(), which avoids the warning as well
as the possibly missing termination. No additional padding is needed here.
Signed-off-by: Arnd Bergmann <[email protected]>
Link: https://github.com/KSPP/linux/issues/90
Reviewed-by: Justin Stitt <[email protected]>
Reviewed-by: Dan Carpenter <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/task-analyzer.py')
0 files changed, 0 insertions, 0 deletions