diff options
author | Mike Marciniszyn <[email protected]> | 2020-05-04 09:09:17 -0400 |
---|---|---|
committer | Jason Gunthorpe <[email protected]> | 2020-05-12 11:47:48 -0300 |
commit | fa8dac3968635dec8518a13ac78d662f2aa88e4d (patch) | |
tree | cfeed50711b4c4dd5bc64dc755fa0ea73b308a94 /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | 856ec7f64688387b100b7083cdf480ce3ac41227 (diff) |
IB/hfi1: Fix another case where pq is left on waitlist
The commit noted below fixed a case where a pq is left on the sdma wait
list.
It however missed another case.
user_sdma_send_pkts() has two calls from hfi1_user_sdma_process_request().
If the first one fails as indicated by -EBUSY, the pq will be placed on
the waitlist as by design.
If the second call then succeeds, the pq is still on the waitlist setting
up a race with the interrupt handler if a subsequent request uses a
different SDMA engine
Fix by deleting the first call.
The use of pcount and the intent to send a short burst of packets followed
by the larger balance of packets was never correctly implemented, because
the two calls always send pcount packets no matter what. A subsequent
patch will correct that issue.
Fixes: 9a293d1e21a6 ("IB/hfi1: Ensure pq is not left on waitlist")
Link: https://lore.kernel.org/r/[email protected]
Cc: <[email protected]>
Reviewed-by: Kaike Wan <[email protected]>
Signed-off-by: Mike Marciniszyn <[email protected]>
Signed-off-by: Jason Gunthorpe <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions