diff options
author | Hao Li <[email protected]> | 2020-12-08 10:08:43 +0800 |
---|---|---|
committer | Al Viro <[email protected]> | 2020-12-10 17:33:17 -0500 |
commit | 88149082bb8ef31b289673669e080ec6a00c2e59 (patch) | |
tree | 27b73fca304245cc58b3baff803a68b21c6afa27 /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | edf7ddbf1c5eb98b720b063b73e20e8a4a1ce673 (diff) |
fs: Handle I_DONTCACHE in iput_final() instead of generic_drop_inode()
If generic_drop_inode() returns true, it means iput_final() can evict
this inode regardless of whether it is dirty or not. If we check
I_DONTCACHE in generic_drop_inode(), any inode with this bit set will be
evicted unconditionally. This is not the desired behavior because
I_DONTCACHE only means the inode shouldn't be cached on the LRU list.
As for whether we need to evict this inode, this is what
generic_drop_inode() should do. This patch corrects the usage of
I_DONTCACHE.
This patch was proposed in [1].
[1]: https://lore.kernel.org/linux-fsdevel/[email protected]/
Fixes: dae2f8ed7992 ("fs: Lift XFS_IDONTCACHE to the VFS layer")
Signed-off-by: Hao Li <[email protected]>
Reviewed-by: Dave Chinner <[email protected]>
Reviewed-by: Ira Weiny <[email protected]>
Signed-off-by: Al Viro <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions