diff options
author | Jan Kara <[email protected]> | 2021-01-07 16:40:34 +0100 |
---|---|---|
committer | Jens Axboe <[email protected]> | 2021-01-26 10:22:18 -0700 |
commit | 767630c63bb23acf022adb265574996ca39a4645 (patch) | |
tree | c65326eca59d2752a65c59ca79ee95cd5cbdf2c8 /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | 46bbf653a67a36989a55dbb894c8b94c5ecb2858 (diff) |
bdev: Do not return EBUSY if bdev discard races with write
blkdev_fallocate() tries to detect whether a discard raced with an
overlapping write by calling invalidate_inode_pages2_range(). However
this check can give both false negatives (when writing using direct IO
or when writeback already writes out the written pagecache range) and
false positives (when write is not actually overlapping but ends in the
same page when blocksize < pagesize). This actually causes issues for
qemu which is getting confused by EBUSY errors.
Fix the problem by removing this conflicting write detection since it is
inherently racy and thus of little use anyway.
Reported-by: Maxim Levitsky <[email protected]>
CC: "Darrick J. Wong" <[email protected]>
Link: https://lore.kernel.org/qemu-devel/[email protected]
Signed-off-by: Jan Kara <[email protected]>
Reviewed-by: Maxim Levitsky <[email protected]>
Reviewed-by: Darrick J. Wong <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions