diff options
author | Peter Zijlstra <[email protected]> | 2019-02-14 10:30:52 +0100 |
---|---|---|
committer | Ingo Molnar <[email protected]> | 2019-04-03 09:36:27 +0200 |
commit | 6690e86be83ac75832e461c141055b5d601c0a6d (patch) | |
tree | ac9835c1ef68ed66a41977c0f7f9f788a0b6a6a4 /tools/perf/scripts/python/exported-sql-viewer.py | |
parent | 5e7a8ca319268a70a6c7c3c1fde5bea38e1e5539 (diff) |
sched/x86: Save [ER]FLAGS on context switch
Effectively reverts commit:
2c7577a75837 ("sched/x86_64: Don't save flags on context switch")
Specifically because SMAP uses FLAGS.AC which invalidates the claim
that the kernel has clean flags.
In particular; while preemption from interrupt return is fine (the
IRET frame on the exception stack contains FLAGS) it breaks any code
that does synchonous scheduling, including preempt_enable().
This has become a significant issue ever since commit:
5b24a7a2aa20 ("Add 'unsafe' user access functions for batched accesses")
provided for means of having 'normal' C code between STAC / CLAC,
exposing the FLAGS.AC state. So far this hasn't led to trouble,
however fix it before it comes apart.
Reported-by: Julien Thierry <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Acked-by: Andy Lutomirski <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: Josh Poimboeuf <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: [email protected]
Fixes: 5b24a7a2aa20 ("Add 'unsafe' user access functions for batched accesses")
Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions