aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/exported-sql-viewer.py
diff options
context:
space:
mode:
authorJin Yao <[email protected]>2020-02-02 22:16:52 +0800
committerArnaldo Carvalho de Melo <[email protected]>2020-03-09 21:43:25 -0300
commit3e152aa984ff4f639f7d2daf1ad10d408c0a3332 (patch)
tree34262d1b1c44ce49cd2cb46423ba6cd2a917ddbf /tools/perf/scripts/python/exported-sql-viewer.py
parentd942815a76463fa53b81d3d1c064f76bb3f80ead (diff)
perf block-info: Fix wrong block address comparison in block_info__cmp()
Commit 6041441870ab ("perf block: Cleanup and refactor block info functions") introduces block_info__cmp(), which compares two blocks. But the issues are: 1. It should return the strcmp cmp value only if it's not 0. 2. When symbol names are matched, we need to compare the addresses of blocks further. But it wrongly uses the symbol addresses for comparison. 3. If the syms are both NULL, we can't consider these two blocks are matched. This patch fixes above 3 issues. Fixes: 6041441870ab ("perf block: Cleanup and refactor block info functions") Signed-off-by: Jin Yao <[email protected]> Cc: Alexander Shishkin <[email protected]> Cc: Andi Kleen <[email protected]> Cc: Jin Yao <[email protected]> Cc: Jiri Olsa <[email protected]> Cc: Kan Liang <[email protected]> Cc: Peter Zijlstra <[email protected]> Link: http://lore.kernel.org/lkml/[email protected] Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/exported-sql-viewer.py')
0 files changed, 0 insertions, 0 deletions