diff options
author | Zhike Wang <[email protected]> | 2019-03-11 03:15:54 -0700 |
---|---|---|
committer | David S. Miller <[email protected]> | 2019-03-13 13:48:27 -0700 |
commit | 5b5f99b186906d198f4455b3add911c87ab361fc (patch) | |
tree | 7d68f218de2af85d7273d4092e75016551c0ebcd /tools/perf/scripts/python/export-to-sqlite.py | |
parent | deb6bfabdbb634e91f36a4e9cb00a7137d72d886 (diff) |
net_sched: return correct value for *notify* functions
It is confusing to directly use return value of netlink_send()/
netlink_unicast() as the return value of *notify*, as it may be not
error at all.
Example: in tc_del_tfilter(), after calling tfilter_del_notify(), it will
goto errout if (err). However, the netlink_send()/netlink_unicast() will
return positive value even for successful case. So it may not call
tcf_chain_tp_remove() and so on to clean up the resource, as a result,
resource is leaked.
It may be easier to only check the return value of tfilter_del_nofiy(),
but it is more clean to correct all related functions.
Co-developed-by: Zengmo Gao <[email protected]>
Signed-off-by: Zhike Wang <[email protected]>
Acked-by: Cong Wang <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-sqlite.py')
0 files changed, 0 insertions, 0 deletions