aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python/export-to-postgresql.py
diff options
context:
space:
mode:
authorJohannes Weiner <[email protected]>2018-02-21 14:45:24 -0800
committerLinus Torvalds <[email protected]>2018-02-21 15:35:42 -0800
commitc3cc39118c3610eb6ab4711bc624af7fc48a35fe (patch)
tree326e2c9da7bedf15bf0fd2505f8421c11b99f6bc /tools/perf/scripts/python/export-to-postgresql.py
parent101110f6271ce956a049250c907bc960030577f8 (diff)
mm: memcontrol: fix NR_WRITEBACK leak in memcg and system stats
After commit a983b5ebee57 ("mm: memcontrol: fix excessive complexity in memory.stat reporting"), we observed slowly upward creeping NR_WRITEBACK counts over the course of several days, both the per-memcg stats as well as the system counter in e.g. /proc/meminfo. The conversion from full per-cpu stat counts to per-cpu cached atomic stat counts introduced an irq-unsafe RMW operation into the updates. Most stat updates come from process context, but one notable exception is the NR_WRITEBACK counter. While writebacks are issued from process context, they are retired from (soft)irq context. When writeback completions interrupt the RMW counter updates of new writebacks being issued, the decs from the completions are lost. Since the global updates are routed through the joint lruvec API, both the memcg counters as well as the system counters are affected. This patch makes the joint stat and event API irq safe. Link: http://lkml.kernel.org/r/[email protected] Fixes: a983b5ebee57 ("mm: memcontrol: fix excessive complexity in memory.stat reporting") Signed-off-by: Johannes Weiner <[email protected]> Debugged-by: Tejun Heo <[email protected]> Reviewed-by: Rik van Riel <[email protected]> Reviewed-by: Andrew Morton <[email protected]> Cc: Vladimir Davydov <[email protected]> Cc: Michal Hocko <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions