diff options
author | Linus Torvalds <[email protected]> | 2024-01-31 23:32:27 -0500 |
---|---|---|
committer | Steven Rostedt (Google) <[email protected]> | 2024-02-01 10:30:33 -0500 |
commit | 49304c2b93e4f7468b51ef717cbe637981397115 (patch) | |
tree | c41949ae9d5da49c9731260736d28f6dbfbd5fb4 /tools/perf/scripts/python/export-to-postgresql.py | |
parent | 99c001cb617df409dac275a059d6c3f187a2da7a (diff) |
tracefs: dentry lookup crapectomy
The dentry lookup for eventfs files was very broken, and had lots of
signs of the old situation where the filesystem names were all created
statically in the dentry tree, rather than being looked up dynamically
based on the eventfs data structures.
You could see it in the naming - how it claimed to "create" dentries
rather than just look up the dentries that were given it.
You could see it in various nonsensical and very incorrect operations,
like using "simple_lookup()" on the dentries that were passed in, which
only results in those dentries becoming negative dentries. Which meant
that any other lookup would possibly return ENOENT if it saw that
negative dentry before the data was then later filled in.
You could see it in the immense amount of nonsensical code that didn't
actually just do lookups.
Link: https://lore.kernel.org/linux-trace-kernel/[email protected]/
Link: https://lore.kernel.org/linux-trace-kernel/[email protected]
Cc: [email protected]
Cc: Al Viro <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Mathieu Desnoyers <[email protected]>
Cc: Christian Brauner <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Ajay Kaher <[email protected]>
Cc: Mark Rutland <[email protected]>
Fixes: c1504e510238 ("eventfs: Implement eventfs dir creation functions")
Signed-off-by: Linus Torvalds <[email protected]>
Signed-off-by: Steven Rostedt (Google) <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python/export-to-postgresql.py')
0 files changed, 0 insertions, 0 deletions